Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests

2012-03-27 Thread Stefan Hajnoczi
On Tue, Mar 27, 2012 at 12:29:09PM +0800, Zhi Yong Wu wrote: > On Mon, Mar 26, 2012 at 10:21 PM, Stefan Hajnoczi wrote: > > On Tue, Mar 20, 2012 at 11:44 AM, Stefan Hajnoczi > > wrote: > >> On Tue, Mar 20, 2012 at 10:58:10AM +0100, Kevin Wolf wrote: > >>> Am 20.03.2012 10:47, schrieb Paolo Bonzin

Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests

2012-03-26 Thread Zhi Yong Wu
On Mon, Mar 26, 2012 at 10:21 PM, Stefan Hajnoczi wrote: > On Tue, Mar 20, 2012 at 11:44 AM, Stefan Hajnoczi > wrote: >> On Tue, Mar 20, 2012 at 10:58:10AM +0100, Kevin Wolf wrote: >>> Am 20.03.2012 10:47, schrieb Paolo Bonzini: >>> > Il 20/03/2012 10:40, Zhi Yong Wu ha scritto: >>> >> HI, Kevin,

Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests

2012-03-26 Thread Kevin Wolf
Am 26.03.2012 16:21, schrieb Stefan Hajnoczi: > On Tue, Mar 20, 2012 at 11:44 AM, Stefan Hajnoczi > wrote: >> On Tue, Mar 20, 2012 at 10:58:10AM +0100, Kevin Wolf wrote: >>> Am 20.03.2012 10:47, schrieb Paolo Bonzini: Il 20/03/2012 10:40, Zhi Yong Wu ha scritto: > HI, Kevin, > > W

Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests

2012-03-26 Thread Stefan Hajnoczi
On Tue, Mar 20, 2012 at 11:44 AM, Stefan Hajnoczi wrote: > On Tue, Mar 20, 2012 at 10:58:10AM +0100, Kevin Wolf wrote: >> Am 20.03.2012 10:47, schrieb Paolo Bonzini: >> > Il 20/03/2012 10:40, Zhi Yong Wu ha scritto: >> >> HI, Kevin, >> >> >> >> We hope that I/O throttling can be shipped without kn

Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests

2012-03-23 Thread Richard Davies
Stefan Hajnoczi wrote: > > Hi. We were producing the IDE assert()s and deadlocks with linux kernels. > > Although I believe the same symptoms exist on windows, I haven't actually > > tested it myself. Typically they would show up in the 16-bit bootloader > > code, even before the 32-bit OS has star

Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests

2012-03-23 Thread Stefan Hajnoczi
On Fri, Mar 23, 2012 at 11:32 AM, Stefan Hajnoczi wrote: > On Fri, Mar 23, 2012 at 11:02 AM, Richard Davies wrote: >> Stefan Hajnoczi wrote: >>> > Hi. We were producing the IDE assert()s and deadlocks with linux kernels. >>> > Although I believe the same symptoms exist on windows, I haven't actua

Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests

2012-03-23 Thread Stefan Hajnoczi
On Fri, Mar 23, 2012 at 11:02 AM, Richard Davies wrote: > Stefan Hajnoczi wrote: >> > Hi. We were producing the IDE assert()s and deadlocks with linux kernels. >> > Although I believe the same symptoms exist on windows, I haven't actually >> > tested it myself. Typically they would show up in the

Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests

2012-03-23 Thread Stefan Hajnoczi
On Fri, Mar 23, 2012 at 10:43 AM, Chris Webb wrote: > Stefan Hajnoczi writes: > >> On Thu, Mar 22, 2012 at 07:07:52PM +, Chris Webb wrote: >> > Stefan Hajnoczi writes: >> > >> > > Yesterday I only posted an analysis of the bug but here are some >> > > thoughts on how to move forward.  Thrott

Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests

2012-03-23 Thread Chris Webb
Stefan Hajnoczi writes: > On Thu, Mar 22, 2012 at 07:07:52PM +, Chris Webb wrote: > > Stefan Hajnoczi writes: > > > > > Yesterday I only posted an analysis of the bug but here are some > > > thoughts on how to move forward. Throttling itself is not the problem. > > > We've known that synch

Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests

2012-03-23 Thread Stefan Hajnoczi
On Thu, Mar 22, 2012 at 07:07:52PM +, Chris Webb wrote: > Stefan Hajnoczi writes: > > > Yesterday I only posted an analysis of the bug but here are some > > thoughts on how to move forward. Throttling itself is not the problem. > > We've known that synchronous operations in the vcpu thread a

Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests

2012-03-22 Thread Chris Webb
Stefan Hajnoczi writes: > Yesterday I only posted an analysis of the bug but here are some > thoughts on how to move forward. Throttling itself is not the problem. > We've known that synchronous operations in the vcpu thread are a problem > long before throttling. This is just another reason to

Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests

2012-03-20 Thread Stefan Hajnoczi
On Tue, Mar 20, 2012 at 10:58:10AM +0100, Kevin Wolf wrote: > Am 20.03.2012 10:47, schrieb Paolo Bonzini: > > Il 20/03/2012 10:40, Zhi Yong Wu ha scritto: > >> HI, Kevin, > >> > >> We hope that I/O throttling can be shipped without known issue in QEMU > >> 1.1, so if you are available, can you give

Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests

2012-03-20 Thread Kevin Wolf
Am 20.03.2012 10:47, schrieb Paolo Bonzini: > Il 20/03/2012 10:40, Zhi Yong Wu ha scritto: >> HI, Kevin, >> >> We hope that I/O throttling can be shipped without known issue in QEMU >> 1.1, so if you are available, can you give this patch some love? > > I'm sorry to say this, but I think I/O throt

Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests

2012-03-20 Thread Kevin Wolf
Am 20.03.2012 10:40, schrieb Zhi Yong Wu: > HI, Kevin, > > We hope that I/O throttling can be shipped without known issue in QEMU > 1.1, so if you are available, can you give this patch some love? Sorry, haven't had the time to follow the discussion closely. Are all review comments addressed now?

Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests

2012-03-20 Thread Paolo Bonzini
Il 20/03/2012 10:40, Zhi Yong Wu ha scritto: > HI, Kevin, > > We hope that I/O throttling can be shipped without known issue in QEMU > 1.1, so if you are available, can you give this patch some love? I'm sorry to say this, but I think I/O throttling is impossible to save. As it is implemented no

Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests

2012-03-20 Thread Zhi Yong Wu
HI, Kevin, We hope that I/O throttling can be shipped without known issue in QEMU 1.1, so if you are available, can you give this patch some love? On Tue, Mar 13, 2012 at 9:53 AM, wrote: > From: Zhi Yong Wu > > Signed-off-by: Zhi Yong Wu > [ Iterate until all block devices have processed all