Re: [Qemu-devel] [PATCH] block: do not use get_clock()

2014-12-01 Thread Stefan Hajnoczi
On Fri, Nov 28, 2014 at 02:41:54PM +0100, Markus Armbruster wrote: Stefan Hajnoczi stefa...@gmail.com writes: On Wed, Nov 26, 2014 at 03:01:02PM +0100, Paolo Bonzini wrote: Use the external qemu-timer API instead. Cc: kw...@redhat.com Cc: stefa...@redhat.com Signed-off-by: Paolo

Re: [Qemu-devel] [PATCH] block: do not use get_clock()

2014-12-01 Thread Markus Armbruster
Stefan Hajnoczi stefa...@redhat.com writes: On Fri, Nov 28, 2014 at 02:41:54PM +0100, Markus Armbruster wrote: Stefan Hajnoczi stefa...@gmail.com writes: On Wed, Nov 26, 2014 at 03:01:02PM +0100, Paolo Bonzini wrote: Use the external qemu-timer API instead. Cc: kw...@redhat.com Cc:

Re: [Qemu-devel] [PATCH] block: do not use get_clock()

2014-11-28 Thread Stefan Hajnoczi
On Wed, Nov 26, 2014 at 03:01:02PM +0100, Paolo Bonzini wrote: Use the external qemu-timer API instead. Cc: kw...@redhat.com Cc: stefa...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/accounting.c | 6 -- block/raw-posix.c | 8 2 files changed, 8

Re: [Qemu-devel] [PATCH] block: do not use get_clock()

2014-11-28 Thread Markus Armbruster
Stefan Hajnoczi stefa...@gmail.com writes: On Wed, Nov 26, 2014 at 03:01:02PM +0100, Paolo Bonzini wrote: Use the external qemu-timer API instead. Cc: kw...@redhat.com Cc: stefa...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/accounting.c | 6 --

Re: [Qemu-devel] [PATCH] block: do not use get_clock()

2014-11-27 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Use the external qemu-timer API instead. Ignorant question: why?

Re: [Qemu-devel] [PATCH] block: do not use get_clock()

2014-11-27 Thread Paolo Bonzini
On 27/11/2014 10:19, Markus Armbruster wrote: Paolo Bonzini pbonz...@redhat.com writes: Use the external qemu-timer API instead. Ignorant question: why? Because no one else calls it directly, it is an internal function. I want to keep it confined to qemu-timer.c (and possibly cpus.c in

Re: [Qemu-devel] [PATCH] block: do not use get_clock()

2014-11-27 Thread Stefan Hajnoczi
On Thu, Nov 27, 2014 at 10:19:45AM +0100, Markus Armbruster wrote: Paolo Bonzini pbonz...@redhat.com writes: Use the external qemu-timer API instead. Ignorant question: why? Patch seems fine but I concur with Markus. Let's add the rationale to the commit description. pgpj67g1P8W4L.pgp

Re: [Qemu-devel] [PATCH] block: do not use get_clock()

2014-11-27 Thread Paolo Bonzini
On 27/11/2014 17:44, Stefan Hajnoczi wrote: On Thu, Nov 27, 2014 at 10:19:45AM +0100, Markus Armbruster wrote: Paolo Bonzini pbonz...@redhat.com writes: Use the external qemu-timer API instead. Ignorant question: why? Patch seems fine but I concur with Markus. Let's add the rationale

Re: [Qemu-devel] [PATCH] block: do not use get_clock()

2014-11-27 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: On 27/11/2014 10:19, Markus Armbruster wrote: Paolo Bonzini pbonz...@redhat.com writes: Use the external qemu-timer API instead. Ignorant question: why? Because no one else calls it directly, it is an internal function. I want to keep it

Re: [Qemu-devel] [PATCH] block: do not use get_clock()

2014-11-27 Thread Paolo Bonzini
On 27/11/2014 18:45, Markus Armbruster wrote: Because no one else calls it directly, it is an internal function. I want to keep it confined to qemu-timer.c (and possibly cpus.c in the icount implementation, but maybe not even that is necessary). That's a perfectly sensible reason.