Re: [Qemu-devel] [PATCH] dmg: fix binary search

2019-01-17 Thread John Snow
On 1/17/19 2:29 PM, John Snow wrote: > > > On 12/21/18 8:58 AM, yuchenlin wrote: >> There is a possible hang in original binary searsh implemtation. That is >> if chunk1 = 4, chunk2 = 5, chunk3 = 4, and we go else case. >> >> The chunk1 will be still 4, and so on. >> >> Signed-off-by: yuchenli

Re: [Qemu-devel] [PATCH] dmg: fix binary search

2019-01-17 Thread John Snow
On 12/21/18 8:58 AM, yuchenlin wrote: > There is a possible hang in original binary searsh implemtation. That is > if chunk1 = 4, chunk2 = 5, chunk3 = 4, and we go else case. > > The chunk1 will be still 4, and so on. > > Signed-off-by: yuchenlin Generally we ask that people use their full n

Re: [Qemu-devel] [PATCH] dmg: fix binary search

2019-01-02 Thread Stefan Hajnoczi
On Fri, Dec 21, 2018 at 09:58:03PM +0800, yuchenlin wrote: > There is a possible hang in original binary searsh implemtation. That is > if chunk1 = 4, chunk2 = 5, chunk3 = 4, and we go else case. > > The chunk1 will be still 4, and so on. > > Signed-off-by: yuchenlin > --- > block/dmg.c | 6 +++