Re: [Qemu-devel] [PATCH] hw/pci: do not update the PCI mappings while Decode (I/O or memory) bit is not set in the Command register

2016-01-14 Thread Marcel Apfelbaum
On 01/14/2016 04:49 PM, Michael S. Tsirkin wrote: On Thu, Jan 14, 2016 at 03:30:41PM +0100, Laszlo Ersek wrote: 2. The same as with pxb, disable Integrated End points for pxb-pcie. My vote, without a doubt. Yea, me too. On a related note: I wonder whether enough resources will be

Re: [Qemu-devel] [PATCH] hw/pci: do not update the PCI mappings while Decode (I/O or memory) bit is not set in the Command register

2016-01-14 Thread Michael S. Tsirkin
On Thu, Jan 14, 2016 at 05:23:27PM +0200, Marcel Apfelbaum wrote: > On 01/14/2016 04:49 PM, Michael S. Tsirkin wrote: > >On Thu, Jan 14, 2016 at 03:30:41PM +0100, Laszlo Ersek wrote: > >>>2. The same as with pxb, disable Integrated End points for pxb-pcie. > >> > >>My vote, without a doubt. > > >

Re: [Qemu-devel] [PATCH] hw/pci: do not update the PCI mappings while Decode (I/O or memory) bit is not set in the Command register

2016-01-14 Thread Marcel Apfelbaum
On 01/14/2016 05:37 PM, Michael S. Tsirkin wrote: On Thu, Jan 14, 2016 at 05:23:27PM +0200, Marcel Apfelbaum wrote: On 01/14/2016 04:49 PM, Michael S. Tsirkin wrote: On Thu, Jan 14, 2016 at 03:30:41PM +0100, Laszlo Ersek wrote: 2. The same as with pxb, disable Integrated End points for

Re: [Qemu-devel] [PATCH] hw/pci: do not update the PCI mappings while Decode (I/O or memory) bit is not set in the Command register

2016-01-14 Thread Michael S. Tsirkin
On Thu, Jan 14, 2016 at 07:20:32PM +0200, Marcel Apfelbaum wrote: > On 01/14/2016 05:37 PM, Michael S. Tsirkin wrote: > >On Thu, Jan 14, 2016 at 05:23:27PM +0200, Marcel Apfelbaum wrote: > >>On 01/14/2016 04:49 PM, Michael S. Tsirkin wrote: > >>>On Thu, Jan 14, 2016 at 03:30:41PM +0100, Laszlo

Re: [Qemu-devel] [PATCH] hw/pci: do not update the PCI mappings while Decode (I/O or memory) bit is not set in the Command register

2016-01-14 Thread Marcel Apfelbaum
On 01/11/2016 08:57 PM, Marcel Apfelbaum wrote: On 01/11/2016 08:44 PM, Laszlo Ersek wrote: On 01/11/16 19:01, Marcel Apfelbaum wrote: On 01/11/2016 07:15 PM, Laszlo Ersek wrote: On 01/11/16 17:34, Marcel Apfelbaum wrote: On 01/11/2016 06:11 PM, Laszlo Ersek wrote: On 01/11/16 13:24, Marcel

Re: [Qemu-devel] [PATCH] hw/pci: do not update the PCI mappings while Decode (I/O or memory) bit is not set in the Command register

2016-01-14 Thread Laszlo Ersek
On 01/14/16 13:24, Marcel Apfelbaum wrote: > On 01/11/2016 08:57 PM, Marcel Apfelbaum wrote: >> On 01/11/2016 08:44 PM, Laszlo Ersek wrote: >>> On 01/11/16 19:01, Marcel Apfelbaum wrote: On 01/11/2016 07:15 PM, Laszlo Ersek wrote: > On 01/11/16 17:34, Marcel Apfelbaum wrote: >> On

Re: [Qemu-devel] [PATCH] hw/pci: do not update the PCI mappings while Decode (I/O or memory) bit is not set in the Command register

2016-01-14 Thread Marcel Apfelbaum
On 01/14/2016 07:28 PM, Michael S. Tsirkin wrote: On Thu, Jan 14, 2016 at 07:20:32PM +0200, Marcel Apfelbaum wrote: On 01/14/2016 05:37 PM, Michael S. Tsirkin wrote: On Thu, Jan 14, 2016 at 05:23:27PM +0200, Marcel Apfelbaum wrote: On 01/14/2016 04:49 PM, Michael S. Tsirkin wrote: On Thu,

Re: [Qemu-devel] [PATCH] hw/pci: do not update the PCI mappings while Decode (I/O or memory) bit is not set in the Command register

2016-01-14 Thread Michael S. Tsirkin
On Thu, Jan 14, 2016 at 03:30:41PM +0100, Laszlo Ersek wrote: > > 2. The same as with pxb, disable Integrated End points for pxb-pcie. > > My vote, without a doubt. Yea, me too. On a related note: I wonder whether enough resources will be allocated to the bridge to actually make it possible to

Re: [Qemu-devel] [PATCH] hw/pci: do not update the PCI mappings while Decode (I/O or memory) bit is not set in the Command register

2016-01-14 Thread Marcel Apfelbaum
On 01/14/2016 04:30 PM, Laszlo Ersek wrote: On 01/14/16 13:24, Marcel Apfelbaum wrote: On 01/11/2016 08:57 PM, Marcel Apfelbaum wrote: On 01/11/2016 08:44 PM, Laszlo Ersek wrote: On 01/11/16 19:01, Marcel Apfelbaum wrote: On 01/11/2016 07:15 PM, Laszlo Ersek wrote: On 01/11/16 17:34, Marcel

Re: [Qemu-devel] [PATCH] hw/pci: do not update the PCI mappings while Decode (I/O or memory) bit is not set in the Command register

2016-01-11 Thread Igor Mammedov
On Mon, 11 Jan 2016 14:24:23 +0200 Marcel Apfelbaum wrote: > Two reasons: > - PCI Spec indicates that while the bit is not set >the memory sizing is not finished. > - pci_bar_address will return PCI_BAR_UNMAPPED >and a previous value can be accidentally overridden >

Re: [Qemu-devel] [PATCH] hw/pci: do not update the PCI mappings while Decode (I/O or memory) bit is not set in the Command register

2016-01-11 Thread Laszlo Ersek
On 01/11/16 17:34, Marcel Apfelbaum wrote: > On 01/11/2016 06:11 PM, Laszlo Ersek wrote: >> On 01/11/16 13:24, Marcel Apfelbaum wrote: >>> Two reasons: >>> - PCI Spec indicates that while the bit is not set >>> the memory sizing is not finished. >>> - pci_bar_address will return

Re: [Qemu-devel] [PATCH] hw/pci: do not update the PCI mappings while Decode (I/O or memory) bit is not set in the Command register

2016-01-11 Thread Marcel Apfelbaum
On 01/11/2016 06:11 PM, Laszlo Ersek wrote: On 01/11/16 13:24, Marcel Apfelbaum wrote: Two reasons: - PCI Spec indicates that while the bit is not set the memory sizing is not finished. - pci_bar_address will return PCI_BAR_UNMAPPED and a previous value can be accidentally

Re: [Qemu-devel] [PATCH] hw/pci: do not update the PCI mappings while Decode (I/O or memory) bit is not set in the Command register

2016-01-11 Thread Laszlo Ersek
On 01/11/16 13:24, Marcel Apfelbaum wrote: > Two reasons: > - PCI Spec indicates that while the bit is not set >the memory sizing is not finished. > - pci_bar_address will return PCI_BAR_UNMAPPED >and a previous value can be accidentally overridden >if the command register is

Re: [Qemu-devel] [PATCH] hw/pci: do not update the PCI mappings while Decode (I/O or memory) bit is not set in the Command register

2016-01-11 Thread Marcel Apfelbaum
On 01/11/2016 04:07 PM, Igor Mammedov wrote: On Mon, 11 Jan 2016 14:24:23 +0200 Marcel Apfelbaum wrote: Two reasons: - PCI Spec indicates that while the bit is not set the memory sizing is not finished. - pci_bar_address will return PCI_BAR_UNMAPPED and a

Re: [Qemu-devel] [PATCH] hw/pci: do not update the PCI mappings while Decode (I/O or memory) bit is not set in the Command register

2016-01-11 Thread Marcel Apfelbaum
On 01/11/2016 08:44 PM, Laszlo Ersek wrote: On 01/11/16 19:01, Marcel Apfelbaum wrote: On 01/11/2016 07:15 PM, Laszlo Ersek wrote: On 01/11/16 17:34, Marcel Apfelbaum wrote: On 01/11/2016 06:11 PM, Laszlo Ersek wrote: On 01/11/16 13:24, Marcel Apfelbaum wrote: Two reasons: - PCI Spec

Re: [Qemu-devel] [PATCH] hw/pci: do not update the PCI mappings while Decode (I/O or memory) bit is not set in the Command register

2016-01-11 Thread Marcel Apfelbaum
On 01/11/2016 07:15 PM, Laszlo Ersek wrote: On 01/11/16 17:34, Marcel Apfelbaum wrote: On 01/11/2016 06:11 PM, Laszlo Ersek wrote: On 01/11/16 13:24, Marcel Apfelbaum wrote: Two reasons: - PCI Spec indicates that while the bit is not set the memory sizing is not finished. -

Re: [Qemu-devel] [PATCH] hw/pci: do not update the PCI mappings while Decode (I/O or memory) bit is not set in the Command register

2016-01-11 Thread Laszlo Ersek
On 01/11/16 19:01, Marcel Apfelbaum wrote: > On 01/11/2016 07:15 PM, Laszlo Ersek wrote: >> On 01/11/16 17:34, Marcel Apfelbaum wrote: >>> On 01/11/2016 06:11 PM, Laszlo Ersek wrote: On 01/11/16 13:24, Marcel Apfelbaum wrote: > Two reasons: >- PCI Spec indicates that while the bit