Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

2017-08-21 Thread Markus Armbruster
David Michael writes: > This allows building with "./configure --python=python3", where > the python3 program is at least version 3.6. It preserves > compatibility with Python 2. The changes include: > > - Avoiding "print" usage > - Using bytes with files opened in binary mode > - Switchi

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

2017-08-30 Thread Stefan Hajnoczi
On Mon, Aug 21, 2017 at 04:29:44PM +0200, Markus Armbruster wrote: > What is our Python 2 -> 3 migration strategy? > > Don't support Python 3 until a flag day, then flip and don't support > Python 2? Add support for Python 3 so that both Python 2.6+ and Python 3 are supported. When Python 2 is E

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

2017-08-30 Thread Stefan Hajnoczi
On Sat, Aug 19, 2017 at 10:58:44PM -0700, David Michael wrote: > This allows building with "./configure --python=python3", where > the python3 program is at least version 3.6. It preserves > compatibility with Python 2. The changes include: > > - Avoiding "print" usage > - Using bytes with f

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

2017-08-30 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Mon, Aug 21, 2017 at 04:29:44PM +0200, Markus Armbruster wrote: >> What is our Python 2 -> 3 migration strategy? >> >> Don't support Python 3 until a flag day, then flip and don't support >> Python 2? > > Add support for Python 3 so that both Python 2.6+ and Python 3

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

2017-08-31 Thread Peter Maydell
On 31 August 2017 at 07:35, Markus Armbruster wrote: > So, first we'll invest in work-arounds to make both 2 and 3 work. Once > 2 is gone, we can invest some more to clean them up. Which probably > won't happen, so we'll continue to carry work-arounds that no longer > make sense. > > I maintain

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

2017-08-31 Thread Daniel P. Berrange
On Thu, Aug 31, 2017 at 11:27:15AM +0100, Peter Maydell wrote: > On 31 August 2017 at 07:35, Markus Armbruster wrote: > > So, first we'll invest in work-arounds to make both 2 and 3 work. Once > > 2 is gone, we can invest some more to clean them up. Which probably > > won't happen, so we'll cont

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

2017-08-31 Thread Daniel P. Berrange
On Thu, Aug 31, 2017 at 11:55:18AM +0100, Peter Maydell wrote: > On 31 August 2017 at 11:47, Daniel P. Berrange wrote: > > If we can update to python 2.7 as our minimum, then supporting py2 > > and py3 gets simpler, avoiding some of the nastier hacks, even > > without that though it isn't too hard

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

2017-08-31 Thread Peter Maydell
On 31 August 2017 at 11:47, Daniel P. Berrange wrote: > If we can update to python 2.7 as our minimum, then supporting py2 > and py3 gets simpler, avoiding some of the nastier hacks, even > without that though it isn't too hard. Unfortunately RHEL6 is what's holding us to retaining 2.6 support, a

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

2017-08-31 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Thu, Aug 31, 2017 at 11:55:18AM +0100, Peter Maydell wrote: >> On 31 August 2017 at 11:47, Daniel P. Berrange wrote: >> > If we can update to python 2.7 as our minimum, then supporting py2 >> > and py3 gets simpler, avoiding some of the nastier hacks, even >> >

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

2017-08-31 Thread Peter Maydell
On 31 August 2017 at 12:02, Daniel P. Berrange wrote: > On Thu, Aug 31, 2017 at 11:55:18AM +0100, Peter Maydell wrote: >> On 31 August 2017 at 11:47, Daniel P. Berrange wrote: >> > If we can update to python 2.7 as our minimum, then supporting py2 >> > and py3 gets simpler, avoiding some of the n

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

2017-08-31 Thread Markus Armbruster
Peter Maydell writes: > On 31 August 2017 at 07:35, Markus Armbruster wrote: >> So, first we'll invest in work-arounds to make both 2 and 3 work. Once >> 2 is gone, we can invest some more to clean them up. Which probably >> won't happen, so we'll continue to carry work-arounds that no longer

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

2017-08-31 Thread Daniel P. Berrange
On Thu, Aug 31, 2017 at 02:58:24PM +0200, Markus Armbruster wrote: > Peter Maydell writes: > > > On 31 August 2017 at 07:35, Markus Armbruster wrote: > >> So, first we'll invest in work-arounds to make both 2 and 3 work. Once > >> 2 is gone, we can invest some more to clean them up. Which prob

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

2017-08-31 Thread Peter Maydell
On 31 August 2017 at 14:14, Daniel P. Berrange wrote: > NB, some distros have already changed /usr/bin/python to point to py3 > so all the files with #!/usr/bin/python in QEMU are already broken on > those distros. This is a bug in those distros and they should fix it. Python 3 is not Python 2 an

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

2017-08-31 Thread Kashyap Chamarthy
On Thu, Aug 31, 2017 at 02:44:58PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Thu, Aug 31, 2017 at 11:55:18AM +0100, Peter Maydell wrote: > >> On 31 August 2017 at 11:47, Daniel P. Berrange wrote: > >> > If we can update to python 2.7 as our minimum, then supporting

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

2017-08-31 Thread Daniel P. Berrange
On Thu, Aug 31, 2017 at 02:19:05PM +0100, Peter Maydell wrote: > On 31 August 2017 at 14:14, Daniel P. Berrange wrote: > > NB, some distros have already changed /usr/bin/python to point to py3 > > so all the files with #!/usr/bin/python in QEMU are already broken on > > those distros. > > This is

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

2017-08-31 Thread Peter Maydell
On 31 August 2017 at 13:58, Markus Armbruster wrote: > Peter Maydell writes: > >> On 31 August 2017 at 07:35, Markus Armbruster wrote: >>> So, first we'll invest in work-arounds to make both 2 and 3 work. Once >>> 2 is gone, we can invest some more to clean them up. Which probably >>> won't ha

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

2017-08-31 Thread Peter Maydell
On 31 August 2017 at 14:25, Daniel P. Berrange wrote: > On Thu, Aug 31, 2017 at 02:19:05PM +0100, Peter Maydell wrote: >> On 31 August 2017 at 14:14, Daniel P. Berrange wrote: >> > NB, some distros have already changed /usr/bin/python to point to py3 >> > so all the files with #!/usr/bin/python i

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

2017-09-01 Thread Max Reitz
On 2017-08-31 15:14, Daniel P. Berrange wrote: [...] > NB, some distros have already changed /usr/bin/python to point to py3 > so all the files with #!/usr/bin/python in QEMU are already broken on > those distros. For what it's worth, I (at least used to) build qemu regularly on Arch Linux and t

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

2017-09-18 Thread Stefan Hajnoczi
On Sat, Aug 19, 2017 at 10:58:44PM -0700, David Michael wrote: > This allows building with "./configure --python=python3", where > the python3 program is at least version 3.6. It preserves > compatibility with Python 2. The changes include: > > - Avoiding "print" usage > - Using bytes with f