Re: [Qemu-devel] [PATCH 2/2] LAPIC: make lapic support cpu hotplug

2011-10-07 Thread liu ping fan
On 10/6/11, Jan Kiszka wrote: > On 2011-10-06 03:13, liu ping fan wrote: >> On Wed, Oct 5, 2011 at 7:01 PM, Jan Kiszka wrote: >>> On 2011-10-05 12:26, liu ping fan wrote: > > And make the creation of apic as part of cpu initialization, so >> apic's state has been ready, before setting kv

Re: [Qemu-devel] [PATCH 2/2] LAPIC: make lapic support cpu hotplug

2011-10-05 Thread Jan Kiszka
On 2011-10-06 03:13, liu ping fan wrote: > On Wed, Oct 5, 2011 at 7:01 PM, Jan Kiszka wrote: >> On 2011-10-05 12:26, liu ping fan wrote: > And make the creation of apic as part of cpu initialization, so > apic's state has been ready, before setting kvm_apic. There is no kvm-api

Re: [Qemu-devel] [PATCH 2/2] LAPIC: make lapic support cpu hotplug

2011-10-05 Thread Anthony Liguori
On 10/05/2011 08:13 PM, liu ping fan wrote: On Wed, Oct 5, 2011 at 7:01 PM, Jan Kiszka wrote: On 2011-10-05 12:26, liu ping fan wrote: > And make the creation of apic as part of cpu initialization, so apic's state has been ready, before setting kvm_apic. There is no kvm-apic upstream yet

Re: [Qemu-devel] [PATCH 2/2] LAPIC: make lapic support cpu hotplug

2011-10-05 Thread liu ping fan
On Wed, Oct 5, 2011 at 7:01 PM, Jan Kiszka wrote: > On 2011-10-05 12:26, liu ping fan wrote: >>>  > And make the creation of apic as part of cpu initialization, so apic's state has been ready, before setting kvm_apic. >>> >>> There is no kvm-apic upstream yet, so it's hard to judge why we nee

Re: [Qemu-devel] [PATCH 2/2] LAPIC: make lapic support cpu hotplug

2011-10-05 Thread Jan Kiszka
On 2011-10-05 12:26, liu ping fan wrote: >> > And make the creation of apic as part of cpu initialization, so >>> apic's state has been ready, before setting kvm_apic. >> >> There is no kvm-apic upstream yet, so it's hard to judge why we need >> this here. If we do, this has to be a separate patch

Re: [Qemu-devel] [PATCH 2/2] LAPIC: make lapic support cpu hotplug

2011-10-05 Thread liu ping fan
On Wed, Oct 5, 2011 at 12:43 AM, Jan Kiszka wrote: > On 2011-10-04 13:13, pingf...@linux.vnet.com wrote: > > From: Liu Ping Fan > > > > Separate apic from qbus to icc bus which supports hotplug feature. > > Modeling the ICC bus looks like a step in the right direction. The > IOAPIC could be atta

Re: [Qemu-devel] [PATCH 2/2] LAPIC: make lapic support cpu hotplug

2011-10-05 Thread liu ping fan
On Tue, Oct 4, 2011 at 8:58 PM, Anthony Liguori wrote: > On 10/04/2011 06:13 AM, pingf...@linux.vnet.com wrote: > >> From: Liu Ping Fan >> > >> >> Separate apic from qbus to icc bus which supports hotplug feature. >> And make the creation of apic as part of cpu initialization, so >> apic's state h

Re: [Qemu-devel] [PATCH 2/2] LAPIC: make lapic support cpu hotplug

2011-10-04 Thread Jan Kiszka
On 2011-10-04 13:13, pingf...@linux.vnet.com wrote: > From: Liu Ping Fan > > Separate apic from qbus to icc bus which supports hotplug feature. Modeling the ICC bus looks like a step in the right direction. The IOAPIC could be attached to it as well to get rid of "ioapics[MAX_IOAPICS]". > And m

Re: [Qemu-devel] [PATCH 2/2] LAPIC: make lapic support cpu hotplug

2011-10-04 Thread Anthony Liguori
On 10/04/2011 06:13 AM, pingf...@linux.vnet.com wrote: From: Liu Ping Fan Separate apic from qbus to icc bus which supports hotplug feature. And make the creation of apic as part of cpu initialization, so apic's state has been ready, before setting kvm_apic. Signed-off-by: Liu Ping Fan --- Ma