Re: [Qemu-devel] [PATCH 2/6] util: introduce glib-helper.c

2017-04-25 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 21 April 2017 at 16:10, Alexey wrote: > > Hello, thank you for so detailed comment, > > > > On Fri, Apr 21, 2017 at 11:27:55AM +0100, Peter Maydell wrote: > > >> Can we have a proper doc comment format comment, please, > >> since this is now

Re: [Qemu-devel] [PATCH 2/6] util: introduce glib-helper.c

2017-04-21 Thread Peter Maydell
On 21 April 2017 at 16:10, Alexey wrote: > Hello, thank you for so detailed comment, > > On Fri, Apr 21, 2017 at 11:27:55AM +0100, Peter Maydell wrote: >> Can we have a proper doc comment format comment, please, >> since this is now a function available to all of QEMU? >> >> > +gint g_int_cmp64(

Re: [Qemu-devel] [PATCH 2/6] util: introduce glib-helper.c

2017-04-21 Thread Alexey
Hello, thank you for so detailed comment, On Fri, Apr 21, 2017 at 11:27:55AM +0100, Peter Maydell wrote: > On 14 April 2017 at 14:17, Alexey Perevalov wrote: > > There is a lack of g_int_cmp which compares pointers value in glib, > > xen_disk.c introduced its own, so the same function now requir

Re: [Qemu-devel] [PATCH 2/6] util: introduce glib-helper.c

2017-04-21 Thread Peter Maydell
On 14 April 2017 at 14:17, Alexey Perevalov wrote: > There is a lack of g_int_cmp which compares pointers value in glib, > xen_disk.c introduced its own, so the same function now requires > in migration.c. So logically to move it into common place. > Futher: maybe extend glib. > > Also this commit

Re: [Qemu-devel] [PATCH 2/6] util: introduce glib-helper.c

2017-04-21 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (f4...@amsat.org) wrote: > Hi Alexey, > > On 04/14/2017 10:17 AM, Alexey Perevalov wrote: > > There is a lack of g_int_cmp which compares pointers value in glib, > > xen_disk.c introduced its own, so the same function now requires > > in migration.c. So logically to move i

Re: [Qemu-devel] [PATCH 2/6] util: introduce glib-helper.c

2017-04-17 Thread Alexey
Hi Philippe, On Fri, Apr 14, 2017 at 01:05:52PM -0300, Philippe Mathieu-Daudé wrote: > Hi Alexey, > > On 04/14/2017 10:17 AM, Alexey Perevalov wrote: > >There is a lack of g_int_cmp which compares pointers value in glib, > >xen_disk.c introduced its own, so the same function now requires > >in m

Re: [Qemu-devel] [PATCH 2/6] util: introduce glib-helper.c

2017-04-14 Thread Philippe Mathieu-Daudé
Hi Alexey, On 04/14/2017 10:17 AM, Alexey Perevalov wrote: There is a lack of g_int_cmp which compares pointers value in glib, xen_disk.c introduced its own, so the same function now requires in migration.c. So logically to move it into common place. Futher: maybe extend glib. Also this commit