Re: [Qemu-devel] [PATCH 24/26] acpi, acpi_piix: factor out GPE logic

2011-04-18 Thread Isaku Yamahata
On Sun, Apr 17, 2011 at 06:53:12PM +0300, Avi Kivity wrote: On 04/17/2011 04:50 PM, Isaku Yamahata wrote: On Sun, Apr 17, 2011 at 04:17:51PM +0300, Avi Kivity wrote: On 03/16/2011 11:29 AM, Isaku Yamahata wrote: factor out ACPI GPE logic. Later it will be used by ICH9 ACPI. I think

Re: [Qemu-devel] [PATCH 24/26] acpi, acpi_piix: factor out GPE logic

2011-04-18 Thread Avi Kivity
On 04/18/2011 10:47 AM, Isaku Yamahata wrote: Hmm but it seems that there is another issue. With the previous patch, I confirmed sts and en are saved as expected. The related VMStateDescription are defined in acpi_piix.c in the following order. vmstate_acpi calls vmstate_gpe. andvmstate_gpe

Re: [Qemu-devel] [PATCH 24/26] acpi, acpi_piix: factor out GPE logic

2011-04-18 Thread Isaku Yamahata
On Mon, Apr 18, 2011 at 11:22:40AM +0300, Avi Kivity wrote: Are you using qemu-kvm.git or qemu.git? I think there are indeed two issues, your patch fixes the first and there is another that is specific to qemu-kvm. I'm using qemu.git. I've start to have a look at qemu-kvm.git, --

Re: [Qemu-devel] [PATCH 24/26] acpi, acpi_piix: factor out GPE logic

2011-04-17 Thread Avi Kivity
On 03/16/2011 11:29 AM, Isaku Yamahata wrote: factor out ACPI GPE logic. Later it will be used by ICH9 ACPI. I think this patch is causing qemu-kvm failures on migration: (gdb) bt #0 0x0049aff4 in qemu_put_be16s (f=0x1a74490, pv=0x2c02580, size=2) at hw/hw.h:108 #1 put_uint16

Re: [Qemu-devel] [PATCH 24/26] acpi, acpi_piix: factor out GPE logic

2011-04-17 Thread Isaku Yamahata
On Sun, Apr 17, 2011 at 04:17:51PM +0300, Avi Kivity wrote: On 03/16/2011 11:29 AM, Isaku Yamahata wrote: factor out ACPI GPE logic. Later it will be used by ICH9 ACPI. I think this patch is causing qemu-kvm failures on migration: (gdb) bt #0 0x0049aff4 in qemu_put_be16s

Re: [Qemu-devel] [PATCH 24/26] acpi, acpi_piix: factor out GPE logic

2011-04-17 Thread Avi Kivity
On 04/17/2011 04:50 PM, Isaku Yamahata wrote: On Sun, Apr 17, 2011 at 04:17:51PM +0300, Avi Kivity wrote: On 03/16/2011 11:29 AM, Isaku Yamahata wrote: factor out ACPI GPE logic. Later it will be used by ICH9 ACPI. I think this patch is causing qemu-kvm failures on migration: (gdb) bt