Re: [Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support

On Mon, 3 Jul 2017 19:34:07 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jul 03, 2017 at 02:27:11PM +0200, Igor Mammedov wrote: > > On Fri, 30 Jun 2017 10:25:05 +0300 > > Marcel Apfelbaum wrote: > > > > [...] > > > > > > So for the modern systems not

Re: [Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support

On 04/07/2017 4:00, Alexander Bezzubikov wrote: That is why I think we can consider a possibility of forgetting about ACPI hot plug in pcie-pci bridge and use only SHPC (with some correcting work). Especially since q35 is used only for 'modern' Windows guests and there're no big problems with

Re: [Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support

That is why I think we can consider a possibility of forgetting about ACPI hot plug in pcie-pci bridge and use only SHPC (with some correcting work). Especially since q35 is used only for 'modern' Windows guests and there're no big problems with SHPC on Linux guests. вт, 4 июля 2017 г. в 1:06,

Re: [Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support

Tried it on Win7 Enterprise SP1 - SHPC works well, _OSC patches aren't necessary (since pci-bridge has its own controller, I suppose). On Linux guests it works when adding device from CLI with -device, but OS seems to fail detecting the device when I add it with device_add from monitor. Also

Re: [Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support

On Mon, Jul 03, 2017 at 09:26:33PM +0300, Marcel Apfelbaum wrote: > On 03/07/2017 19:34, Michael S. Tsirkin wrote: > > On Mon, Jul 03, 2017 at 02:27:11PM +0200, Igor Mammedov wrote: > > > On Fri, 30 Jun 2017 10:25:05 +0300 > > > Marcel Apfelbaum wrote: > > > > > > [...] > > >

Re: [Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support

On 03/07/2017 19:34, Michael S. Tsirkin wrote: On Mon, Jul 03, 2017 at 02:27:11PM +0200, Igor Mammedov wrote: On Fri, 30 Jun 2017 10:25:05 +0300 Marcel Apfelbaum wrote: [...] So for the modern systems not supporting PCI ACPI hotplug we don't need pci-bridges anyway, but

Re: [Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support

SHPC did work for linux. As ACPI is enabled by default, you need to expose it in _OSC and maybe jump through more hoops to avoid ACPI from trying to take over. Source is available so if it doesn't work you should be able to find out why. On Mon, Jul 03, 2017 at 05:41:12PM +0300, Alexander

Re: [Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support

On Mon, Jul 03, 2017 at 02:27:11PM +0200, Igor Mammedov wrote: > On Fri, 30 Jun 2017 10:25:05 +0300 > Marcel Apfelbaum wrote: > > [...] > > > > So for the modern systems not supporting PCI ACPI hotplug > > we don't need pci-bridges anyway, but for the older ones > > the ACPI

Re: [Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support

Do we have any surely working scenario of pci-bridge's SHPC usage? Because first of all I've tried to use SHPC to avoi involving any ACPI code, but it didn't look functioning even for ordinary pci-bridge, that's why after talking to Marcel I left SHPC idea. 2017-07-03 16:58 GMT+03:00 Alexander

Re: [Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support

Hmm, I've failed to make SHPC (from current master) work on any modern Linux guests. 2017-07-03 15:27 GMT+03:00 Igor Mammedov : > On Fri, 30 Jun 2017 10:25:05 +0300 > Marcel Apfelbaum wrote: > > [...] > > > > So for the modern systems not supporting PCI

Re: [Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support

On Fri, 30 Jun 2017 10:25:05 +0300 Marcel Apfelbaum wrote: [...] > > So for the modern systems not supporting PCI ACPI hotplug > we don't need pci-bridges anyway, but for the older ones > the ACPI code of the pci-bridge will be loaded into the > ACPI namespace only if a

Re: [Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support

On Fri, Jun 30, 2017 at 10:25:05AM +0300, Marcel Apfelbaum wrote: > On 30/06/2017 2:17, Michael S. Tsirkin wrote: > > On Fri, Jun 30, 2017 at 12:55:56AM +0300, Aleksandr Bezzubikov wrote: > > > The series adds hotplug support to legacy PCI buses for Q35 machines. > > > The ACPI hotplug code is

Re: [Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support

On 30/06/2017 2:17, Michael S. Tsirkin wrote: On Fri, Jun 30, 2017 at 12:55:56AM +0300, Aleksandr Bezzubikov wrote: The series adds hotplug support to legacy PCI buses for Q35 machines. The ACPI hotplug code is emitted if at least one legacy pci-bridge is present. This series is mostly based

Re: [Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support

On Fri, Jun 30, 2017 at 12:55:56AM +0300, Aleksandr Bezzubikov wrote: > The series adds hotplug support to legacy PCI buses for Q35 machines. > The ACPI hotplug code is emitted if at least one legacy pci-bridge is present. > > This series is mostly based on past Marcel's series >