Re: [Qemu-devel] [PATCH v2] qxl: add primary_created state, change mode lifetimes

2011-06-29 Thread Alon Levy
On Wed, Jun 29, 2011 at 10:41:43AM +0200, Gerd Hoffmann wrote: > Hi, > > >>Shouldn't the mode change to QXL_MODE_UNDEFINED on DESTROY_SURFACES? > >>(I can see it currently doesn't, but it seems like a mistake) > > > >No, that is the point - this patch makes the lifetime of QXL_MODE_NATIVE be > >

Re: [Qemu-devel] [PATCH v2] qxl: add primary_created state, change mode lifetimes

2011-06-29 Thread Gerd Hoffmann
Hi, Shouldn't the mode change to QXL_MODE_UNDEFINED on DESTROY_SURFACES? (I can see it currently doesn't, but it seems like a mistake) No, that is the point - this patch makes the lifetime of QXL_MODE_NATIVE be the lifetime of the driver in the guest, kinda. we never unload the driver in the

Re: [Qemu-devel] [PATCH v2] qxl: add primary_created state, change mode lifetimes

2011-06-27 Thread Alon Levy
On Mon, Jun 27, 2011 at 10:42:46AM +0300, yhalperi wrote: > On 06/24/2011 04:02 PM, Alon Levy wrote: > >Currently we define the following relation between modes and primary surface > >existance: > > > > QXL_MODE_COMPAT > > QXL_MODE_NATIVE primary exists > > QXL_MODE_UNDEFINED > > QXL_MODE_VGA

Re: [Qemu-devel] [PATCH v2] qxl: add primary_created state, change mode lifetimes

2011-06-27 Thread yhalperi
On 06/24/2011 04:02 PM, Alon Levy wrote: Currently we define the following relation between modes and primary surface existance: QXL_MODE_COMPAT QXL_MODE_NATIVE primary exists QXL_MODE_UNDEFINED QXL_MODE_VGA primary doesn't exist This, coupled with disallowing various IO's when not