Re: [Qemu-devel] [PATCH v5 02/36] ppc/xive: add support for the LSI interrupt sources

2018-11-26 Thread Cédric Le Goater
On 11/27/18 12:48 AM, David Gibson wrote: > On Mon, Nov 26, 2018 at 12:20:19PM +0100, Cédric Le Goater wrote: >> On 11/26/18 6:39 AM, David Gibson wrote: >>> On Fri, Nov 23, 2018 at 02:28:35PM +0100, Cédric Le Goater wrote: +/* + * Returns whether the event notification shoul

Re: [Qemu-devel] [PATCH v5 02/36] ppc/xive: add support for the LSI interrupt sources

2018-11-26 Thread David Gibson
On Mon, Nov 26, 2018 at 12:20:19PM +0100, Cédric Le Goater wrote: > On 11/26/18 6:39 AM, David Gibson wrote: > > On Fri, Nov 23, 2018 at 02:28:35PM +0100, Cédric Le Goater wrote: > >> > >> +/* > >> + * Returns whether the event notification should be forwarded. > >> + */ > >> +stati

Re: [Qemu-devel] [PATCH v5 02/36] ppc/xive: add support for the LSI interrupt sources

2018-11-26 Thread Cédric Le Goater
On 11/26/18 6:39 AM, David Gibson wrote: > On Fri, Nov 23, 2018 at 02:28:35PM +0100, Cédric Le Goater wrote: >> >> +/* >> + * Returns whether the event notification should be forwarded. >> + */ >> +static bool xive_source_lsi_trigger(XiveSource *xsrc, uint32_t >> srcno) > >>

Re: [Qemu-devel] [PATCH v5 02/36] ppc/xive: add support for the LSI interrupt sources

2018-11-25 Thread David Gibson
On Fri, Nov 23, 2018 at 02:28:35PM +0100, Cédric Le Goater wrote: > > +/* > + * Returns whether the event notification should be forwarded. > + */ > +static bool xive_source_lsi_trigger(XiveSource *xsrc, uint32_t > srcno) > >>> > >>> What exactly "trigger" means isn't enti

Re: [Qemu-devel] [PATCH v5 02/36] ppc/xive: add support for the LSI interrupt sources

2018-11-23 Thread Cédric Le Goater
+/* + * Returns whether the event notification should be forwarded. + */ +static bool xive_source_lsi_trigger(XiveSource *xsrc, uint32_t srcno) >>> >>> What exactly "trigger" means isn't entirely obvious for an LSI. Might >>> be clearer to have "lsi_assert" and "lsi_deas

Re: [Qemu-devel] [PATCH v5 02/36] ppc/xive: add support for the LSI interrupt sources

2018-11-22 Thread David Gibson
On Thu, Nov 22, 2018 at 08:39:41AM +0100, Cédric Le Goater wrote: > On 11/22/18 4:19 AM, David Gibson wrote: > > On Fri, Nov 16, 2018 at 11:56:55AM +0100, Cédric Le Goater wrote: > >> The 'sent' status of the LSI interrupt source is modeled with the 'P' > >> bit of the ESB and the assertion status

Re: [Qemu-devel] [PATCH v5 02/36] ppc/xive: add support for the LSI interrupt sources

2018-11-21 Thread Cédric Le Goater
On 11/22/18 4:19 AM, David Gibson wrote: > On Fri, Nov 16, 2018 at 11:56:55AM +0100, Cédric Le Goater wrote: >> The 'sent' status of the LSI interrupt source is modeled with the 'P' >> bit of the ESB and the assertion status of the source is maintained in >> an array under the main sPAPRXive object

Re: [Qemu-devel] [PATCH v5 02/36] ppc/xive: add support for the LSI interrupt sources

2018-11-21 Thread David Gibson
On Fri, Nov 16, 2018 at 11:56:55AM +0100, Cédric Le Goater wrote: > The 'sent' status of the LSI interrupt source is modeled with the 'P' > bit of the ESB and the assertion status of the source is maintained in > an array under the main sPAPRXive object. The type of the source is > stored in the sa