Re: [Qemu-devel] [PATCH v6 5/5] qobject: modify qobject_ref() to assert on NULL

2018-04-19 Thread Marc-André Lureau
Hi On Thu, Apr 19, 2018 at 5:39 PM, Eric Blake wrote: > On 04/19/2018 10:01 AM, Marc-André Lureau wrote: >> While it may be convenient to accept NULL value in >> qobject_unref() (for similar reasons as free() accepts NULL), it is >> not such a good idea for qobject_ref(): now assert() on NULL. >>

Re: [Qemu-devel] [PATCH v6 5/5] qobject: modify qobject_ref() to assert on NULL

2018-04-19 Thread Eric Blake
On 04/19/2018 10:01 AM, Marc-André Lureau wrote: > While it may be convenient to accept NULL value in > qobject_unref() (for similar reasons as free() accepts NULL), it is > not such a good idea for qobject_ref(): now assert() on NULL. > > Some places relied on that behaviour (the monitor request