Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

2017-07-14 Thread Michael S. Tsirkin
On Fri, Jul 14, 2017 at 02:11:27PM +0100, Peter Maydell wrote: > On 13 July 2017 at 17:38, Michael S. Tsirkin wrote: > > It's already a library, I don't think you need changes or refactoring. > > You can just link boot_sector.c and call boot_sector_test like the pxe > > test

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

2017-07-14 Thread Peter Maydell
On 13 July 2017 at 17:38, Michael S. Tsirkin wrote: > It's already a library, I don't think you need changes or refactoring. > You can just link boot_sector.c and call boot_sector_test like the pxe > test does. If this passes you know all acpi tables are in memory. > > I'll post

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

2017-07-13 Thread Michael S. Tsirkin
On Thu, Jul 13, 2017 at 06:34:33AM -0700, Ben Warren wrote: > Hi, > > On Jul 13, 2017, at 4:51 AM, Marc-André Lureau > > wrote: > > Hi > > On Thu, Jul 13, 2017 at 1:32 PM Laszlo Ersek wrote: > > On 07/13/17 12:47, Peter

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

2017-07-13 Thread Ben Warren via Qemu-devel
Hi, > On Jul 13, 2017, at 4:51 AM, Marc-André Lureau > wrote: > > Hi > > On Thu, Jul 13, 2017 at 1:32 PM Laszlo Ersek > wrote: > On 07/13/17 12:47, Peter Maydell wrote: > > On 12 July 2017 at 00:43, Ben Warren

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

2017-07-13 Thread Marc-André Lureau
Hi On Thu, Jul 13, 2017 at 1:32 PM Laszlo Ersek wrote: > On 07/13/17 12:47, Peter Maydell wrote: > > On 12 July 2017 at 00:43, Ben Warren wrote: > >> Yes, it’s definitely a setup time problem. With the values that are > checked > >> in, I can’t get

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

2017-07-13 Thread Laszlo Ersek
On 07/13/17 12:47, Peter Maydell wrote: > On 12 July 2017 at 00:43, Ben Warren wrote: >> Yes, it’s definitely a setup time problem. With the values that are checked >> in, I can’t get it to fail on my setup, but if I wind the numbers down I see >> the same failure as

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

2017-07-13 Thread Peter Maydell
On 12 July 2017 at 00:43, Ben Warren wrote: > Yes, it’s definitely a setup time problem. With the values that are checked > in, I can’t get it to fail on my setup, but if I wind the numbers down I see > the same failure as Peter. So now we have the ages-old problem of

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

2017-07-11 Thread Michael S. Tsirkin
On Tue, Jul 11, 2017 at 04:43:50PM -0700, Ben Warren wrote: > Hi Laszlo, > > > On Jul 11, 2017, at 3:13 PM, Laszlo Ersek wrote: > > On 07/11/17 22:42, Peter Maydell wrote: > > On 11 July 2017 at 20:10, Michael S. Tsirkin wrote: > >

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

2017-07-11 Thread Ben Warren via Qemu-devel
Hi Laszlo, > On Jul 11, 2017, at 3:13 PM, Laszlo Ersek wrote: > > On 07/11/17 22:42, Peter Maydell wrote: >> On 11 July 2017 at 20:10, Michael S. Tsirkin wrote: >>> On Tue, Jul 11, 2017 at 05:49:07PM +0100, Peter Maydell wrote: The good news is it's not

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

2017-07-11 Thread Laszlo Ersek
On 07/11/17 22:42, Peter Maydell wrote: > On 11 July 2017 at 20:10, Michael S. Tsirkin wrote: >> On Tue, Jul 11, 2017 at 05:49:07PM +0100, Peter Maydell wrote: >>> The good news is it's not aarch64-specific. I just hit this on >>> a build on x86_64 host, gcc, debug build: >>> >>>

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

2017-07-11 Thread Peter Maydell
On 11 July 2017 at 20:10, Michael S. Tsirkin wrote: > On Tue, Jul 11, 2017 at 05:49:07PM +0100, Peter Maydell wrote: >> The good news is it's not aarch64-specific. I just hit this on >> a build on x86_64 host, gcc, debug build: >> >> GTESTER check-qtest-x86_64 >> ** >>

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

2017-07-11 Thread Michael S. Tsirkin
On Tue, Jul 11, 2017 at 05:49:07PM +0100, Peter Maydell wrote: > On 11 July 2017 at 16:22, Peter Maydell wrote: > > On 11 July 2017 at 16:07, Ben Warren wrote: > >> Hi Peter, > >>> On Jul 11, 2017, at 6:32 AM, Peter Maydell

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

2017-07-11 Thread Peter Maydell
On 11 July 2017 at 16:22, Peter Maydell wrote: > On 11 July 2017 at 16:07, Ben Warren wrote: >> Hi Peter, >>> On Jul 11, 2017, at 6:32 AM, Peter Maydell wrote: >>> Hi -- this test seems to intermittently fail: >>> >>>

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

2017-07-11 Thread Peter Maydell
On 11 July 2017 at 16:07, Ben Warren wrote: > Hi Peter, >> On Jul 11, 2017, at 6:32 AM, Peter Maydell wrote: >> >> On 3 July 2017 at 20:45, Michael S. Tsirkin wrote: >>> From: Ben Warren >>> >>> The

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

2017-07-11 Thread Ben Warren via Qemu-devel
Hi Peter, > On Jul 11, 2017, at 6:32 AM, Peter Maydell wrote: > > On 3 July 2017 at 20:45, Michael S. Tsirkin wrote: >> From: Ben Warren >> >> The following tests are implemented: >> * test that a GUID passed in by command

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

2017-07-11 Thread Peter Maydell
On 3 July 2017 at 20:45, Michael S. Tsirkin wrote: > From: Ben Warren > > The following tests are implemented: > * test that a GUID passed in by command line is propagated to the guest. > Read the GUID from guest memory > * test that the "auto"