Re: [Qemu-devel] [RFC 2/3] intc/arm_gic: Support PPI injection for more than 256 vpus

2019-09-06 Thread Peter Maydell
On Tue, 3 Sep 2019 at 09:40, Auger Eric wrote: > I guess arm_cpu_kvm_set_irq attempting to inject IRQ/FIQ into KVM is > used with userspace GIC emulation, which is not supported along with > GICv3. But anyway, I guess it does not hurt to set vcpu_index2 in > arm_cpu_kvm_set_irq? Having now got up

Re: [Qemu-devel] [RFC 2/3] intc/arm_gic: Support PPI injection for more than 256 vpus

2019-09-03 Thread Auger Eric
Hi Peter, On 9/3/19 10:29 AM, Peter Maydell wrote: > On Thu, 29 Aug 2019 at 08:58, Auger Eric wrote: >> >> Hi Zenghui, >> >> On 8/29/19 4:53 AM, Zenghui Yu wrote: >>> For confirmation, should we also adjust the vcpu_index in >>> arm_cpu_kvm_set_irq(), just like above? >> >> I am not familiar with

Re: [Qemu-devel] [RFC 2/3] intc/arm_gic: Support PPI injection for more than 256 vpus

2019-09-03 Thread Peter Maydell
On Thu, 29 Aug 2019 at 08:58, Auger Eric wrote: > > Hi Zenghui, > > On 8/29/19 4:53 AM, Zenghui Yu wrote: > > For confirmation, should we also adjust the vcpu_index in > > arm_cpu_kvm_set_irq(), just like above? > > I am not familiar with this path. in arm_cpu_initfn(), there is a > comment saying

Re: [Qemu-devel] [RFC 2/3] intc/arm_gic: Support PPI injection for more than 256 vpus

2019-08-29 Thread Auger Eric
Hi, On 8/29/19 9:58 AM, Auger Eric wrote: > Hi Zenghui, > > On 8/29/19 4:53 AM, Zenghui Yu wrote: >> Hi Eric, >> >> On 2019/8/28 0:05, Eric Auger wrote: >>> Host kernels that expose the KVM_CAP_ARM_IRQ_LINE_LAYOUT_2 capability >>> allow injection of PPIs along with vcpu ids larger than 255. Let's

Re: [Qemu-devel] [RFC 2/3] intc/arm_gic: Support PPI injection for more than 256 vpus

2019-08-29 Thread Auger Eric
Hi Zenghui, On 8/29/19 4:53 AM, Zenghui Yu wrote: > Hi Eric, > > On 2019/8/28 0:05, Eric Auger wrote: >> Host kernels that expose the KVM_CAP_ARM_IRQ_LINE_LAYOUT_2 capability >> allow injection of PPIs along with vcpu ids larger than 255. Let's >> encode the vpcu id on 12 bits according to the up

Re: [Qemu-devel] [RFC 2/3] intc/arm_gic: Support PPI injection for more than 256 vpus

2019-08-28 Thread Zenghui Yu
Hi Eric, On 2019/8/28 0:05, Eric Auger wrote: Host kernels that expose the KVM_CAP_ARM_IRQ_LINE_LAYOUT_2 capability allow injection of PPIs along with vcpu ids larger than 255. Let's encode the vpcu id on 12 bits according to the upgraded KVM_IRQ_LINE ABI when needed. Without that patch qemu ex