Re: [Qemu-devel] [RFC PATCH 5/6] hw/ppc/pnv_xscom: retrieve homer/occ base address from PBA BARs

2019-08-08 Thread David Gibson
On Wed, Aug 07, 2019 at 12:44:44PM +0530, Balamuruhan S wrote: > During PowerNV boot skiboot populates the device tree by retrieving > base address of homer/occ common area from PBA BARs and prd ipoll > mask by accessing xscom read/write accesses. > > Signed-off-by: Balamuruhan S Again seems

Re: [Qemu-devel] [RFC PATCH 5/6] hw/ppc/pnv_xscom: retrieve homer/occ base address from PBA BARs

2019-08-07 Thread Balamuruhan S
On Wed, Aug 07, 2019 at 10:01:58AM +0200, Cédric Le Goater wrote: > On 07/08/2019 09:14, Balamuruhan S wrote: > > During PowerNV boot skiboot populates the device tree by retrieving > > base address of homer/occ common area from PBA BARs and prd ipoll > > mask by accessing xscom read/write

Re: [Qemu-devel] [RFC PATCH 5/6] hw/ppc/pnv_xscom: retrieve homer/occ base address from PBA BARs

2019-08-07 Thread Cédric Le Goater
On 07/08/2019 09:14, Balamuruhan S wrote: > During PowerNV boot skiboot populates the device tree by retrieving > base address of homer/occ common area from PBA BARs and prd ipoll > mask by accessing xscom read/write accesses. This looks good. If you could add defines it would be better. Our