Re: [Qemu-devel] Patch: dyngen-exec.h for OpenBSD

2007-04-06 Thread Anthony Liguori
Paul Brook wrote: On Thursday 05 April 2007 23:12, Todd T. Fries wrote: Penned by Thiemo Seufer on 20070402 10:54.53, we have: | > /* NOTE: standard headers should be used with special care at this | > point because host CPU registers are used as global variables. Some | > host heade

Re: [Qemu-devel] Patch: dyngen-exec.h for OpenBSD

2007-04-06 Thread Paul Brook
On Thursday 05 April 2007 23:12, Todd T. Fries wrote: > Penned by Thiemo Seufer on 20070402 10:54.53, we have: > | > /* NOTE: standard headers should be used with special care at this > | > point because host CPU registers are used as global variables. Some > | > host headers do not allow

Re: [Qemu-devel] Patch: dyngen-exec.h for OpenBSD

2007-04-06 Thread Thiemo Seufer
Todd T. Fries wrote: > > Penned by Thiemo Seufer on 20070402 10:54.53, we have: > | > /* NOTE: standard headers should be used with special care at this > | > point because host CPU registers are used as global variables. Some > | > host headers do not allow that. */ > | > #include > |

Re: [Qemu-devel] Patch: dyngen-exec.h for OpenBSD

2007-04-06 Thread Todd T. Fries
Penned by Thiemo Seufer on 20070402 10:54.53, we have: | > /* NOTE: standard headers should be used with special care at this | > point because host CPU registers are used as global variables. Some | > host headers do not allow that. */ | > #include | > - | > +#ifdef __OpenBSD__ | > +#i

Re: [Qemu-devel] Patch: dyngen-exec.h for OpenBSD

2007-04-02 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Thiemo Seufer <[EMAIL PROTECTED]> writes: : M. Warner Losh wrote: : > In message: <[EMAIL PROTECTED]> : > Thiemo Seufer <[EMAIL PROTECTED]> writes: : > : I made that "#ifdef _BSD" based on the assumption it is ok for all : > : BSD variants, in

Re: [Qemu-devel] Patch: dyngen-exec.h for OpenBSD

2007-04-02 Thread Thiemo Seufer
M. Warner Losh wrote: > In message: <[EMAIL PROTECTED]> > Thiemo Seufer <[EMAIL PROTECTED]> writes: > : I made that "#ifdef _BSD" based on the assumption it is ok for all > : BSD variants, including Darwin. > > _BSD isn't defined on all variants of BSD. sys/param.h defines BSD to > be

Re: [Qemu-devel] Patch: dyngen-exec.h for OpenBSD

2007-04-02 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Thiemo Seufer <[EMAIL PROTECTED]> writes: : I made that "#ifdef _BSD" based on the assumption it is ok for all : BSD variants, including Darwin. _BSD isn't defined on all variants of BSD. sys/param.h defines BSD to be 199506 on all BSD systems (at least

Re: [Qemu-devel] Patch: dyngen-exec.h for OpenBSD

2007-04-02 Thread Thiemo Seufer
Juergen Keil wrote: > > > From: Thiemo Seufer <[EMAIL PROTECTED]> > > Todd T. Fries wrote: > > > This is relative to the 20070319 snapshot. > > > > > > > > > --- dyngen-exec.h.origMon Feb 5 17:01:54 2007 > > > +++ dyngen-exec.h Sat Mar 10 16:39:39 2007 > ... > > > /* XXX: This may be wrong

Re: [Qemu-devel] Patch: dyngen-exec.h for OpenBSD

2007-04-02 Thread Juergen Keil
> From: Thiemo Seufer <[EMAIL PROTECTED]> > Todd T. Fries wrote: > > This is relative to the 20070319 snapshot. > > > > > > --- dyngen-exec.h.orig Mon Feb 5 17:01:54 2007 > > +++ dyngen-exec.h Sat Mar 10 16:39:39 2007 ... > > /* XXX: This may be wrong for 64-bit ILP32 hosts. */ > > ty

Re: [Qemu-devel] Patch: dyngen-exec.h for OpenBSD

2007-04-02 Thread Thiemo Seufer
Todd T. Fries wrote: > This is relative to the 20070319 snapshot. > > > --- dyngen-exec.h.origMon Feb 5 17:01:54 2007 > +++ dyngen-exec.h Sat Mar 10 16:39:39 2007 > @@ -27,11 +27,15 @@ > #define _FILEDEFED > #endif > > +#include "config.h" > + Doesn't seem to be necessary in the