Re: [Qemu-devel] build errors on s390 tcg

2011-10-04 Thread Stefan Weil
Am 04.10.2011 14:44, schrieb Peter Maydell: On 4 October 2011 13:23, Alexander Graf wrote: The problem is that tcg.c defines the functions with int arguments for TCG register indexes, while s390/tcg-target.c takes TCGReg parameters. I'm not sure which way is better, but using TCGReg feels mor

Re: [Qemu-devel] build errors on s390 tcg

2011-10-04 Thread Peter Maydell
On 4 October 2011 13:23, Alexander Graf wrote: > The problem is that tcg.c defines the functions with int arguments for TCG > register indexes, while s390/tcg-target.c takes TCGReg parameters. I'm not > sure which way is better, but using TCGReg feels more type safe to me. You're not consistent,

Re: [Qemu-devel] build errors on s390 tcg

2011-10-04 Thread Alexander Graf
On 10/04/2011 01:54 PM, Christian Borntraeger wrote: With todays qemu git I get the following error when compiling for s390: In file included from /home/cborntra/REPOS/qemu/tcg/tcg.c:175:0: /home/cborntra/REPOS/qemu/tcg/s390/tcg-target.c:677:13: error: conflicting types for ‘tcg_out_mov’ /home/