On 5/14/21 7:29 AM, Paolo Bonzini wrote:
> On 14/05/21 01:35, David Gibson wrote:
>>> "FDT" is set by meson.build if the library is available, LIBFDT is
>>> set by
>>> the board to link with the library. In other words CONFIG_FDT is
>>> per-build,
>>> while CONFIG_LIBFDT is per-target.
>> Oof... t
On 14/05/21 01:35, David Gibson wrote:
"FDT" is set by meson.build if the library is available, LIBFDT is set by
the board to link with the library. In other words CONFIG_FDT is per-build,
while CONFIG_LIBFDT is per-target.
Oof... that's highly non-obvious. Could we call it HAVE_LIBFDT and
USE
On Thu, May 13, 2021 at 05:26:37PM +0200, Paolo Bonzini wrote:
> On 13/05/21 05:46, David Gibson wrote:
> > > The patch makes sense in general. The file is only needed for pseries and
> > > powernv, not for e.g. e500 which does need fdt.
> >
> > Yes, agreed.
> >
> > > I would get rid of FDT_PPC
On 13/05/21 05:46, David Gibson wrote:
The patch makes sense in general. The file is only needed for pseries and
powernv, not for e.g. e500 which does need fdt.
Yes, agreed.
I would get rid of FDT_PPC completely. First, before patch 3, you can move
fdt.c to PSERIES and POWERNV (it's too sma
On Wed, May 12, 2021 at 09:59:00AM +0200, Paolo Bonzini wrote:
> On 12/05/21 04:30, David Gibson wrote:
> > On Tue, May 11, 2021 at 05:53:53PM +0200, Philippe Mathieu-Daudé wrote:
> > > hw/ppc/fdt.c defines the ppc_create_page_sizes_prop() function,
> > > which is unrelated to the libfdt. Remove th
On 12/05/21 04:30, David Gibson wrote:
On Tue, May 11, 2021 at 05:53:53PM +0200, Philippe Mathieu-Daudé wrote:
hw/ppc/fdt.c defines the ppc_create_page_sizes_prop() function,
which is unrelated to the libfdt. Remove the incorrect library
dependency on the file.
Signed-off-by: Philippe Mathieu-D
On Tue, May 11, 2021 at 05:53:53PM +0200, Philippe Mathieu-Daudé wrote:
> hw/ppc/fdt.c defines the ppc_create_page_sizes_prop() function,
> which is unrelated to the libfdt. Remove the incorrect library
> dependency on the file.
>
> Signed-off-by: Philippe Mathieu-Daudé
This is definitely wrong
