Re: Realize methods realizing "sideways" in the composition tree

2021-01-19 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 15 Jan 2021 at 15:45, Markus Armbruster wrote: >> >> The .realize() method realizes the child at (1). It should use >> qdev_realize() like we do everywhere else, since commit ce189ab230 >> "qdev: Convert bus-less devices to qdev_realize() with Coccinelle". >> >>

Re: Realize methods realizing "sideways" in the composition tree

2021-01-15 Thread Peter Maydell
On Fri, 15 Jan 2021 at 15:45, Markus Armbruster wrote: > > The .realize() method realizes the child at (1). It should use > qdev_realize() like we do everywhere else, since commit ce189ab230 > "qdev: Convert bus-less devices to qdev_realize() with Coccinelle". > > It sets a link property from

Realize methods realizing "sideways" in the composition tree

2021-01-15 Thread Markus Armbruster
Perhaps I'm slow on the uptake today... We have typedef struct XHCIPciState { /*< private >*/ PCIDevice parent_obj; /*< public >*/ (1) XHCIState xhci; OnOffAuto msi; OnOffAuto msix; } XHCIPciState; This is a PCI device that contains a