Re: Replace GSource with AioContext for chardev

2020-04-15 Thread Daniel P . Berrangé
On Tue, Apr 14, 2020 at 02:13:45PM +0200, Kevin Wolf wrote: > Am 14.04.2020 um 12:54 hat Paolo Bonzini geschrieben: > > On 14/04/20 12:27, Daniel P. Berrangé wrote: > > > Ignoring back compat, what would be our ideal CLI syntax ? > > > > > > Current syntax is > > > > > > -chardev socket,id=char

Re: Replace GSource with AioContext for chardev

2020-04-14 Thread Kevin Wolf
Am 14.04.2020 um 12:54 hat Paolo Bonzini geschrieben: > On 14/04/20 12:27, Daniel P. Berrangé wrote: > > Ignoring back compat, what would be our ideal CLI syntax ? > > > > Current syntax is > > > > -chardev socket,id=charnet1,path=/tmp/vhost1.sock > > -netdev vhost-user,chardev=charnet1,id=ho

Re: Replace GSource with AioContext for chardev

2020-04-14 Thread Paolo Bonzini
On 14/04/20 12:27, Daniel P. Berrangé wrote: > Ignoring back compat, what would be our ideal CLI syntax ? > > Current syntax is > > -chardev socket,id=charnet1,path=/tmp/vhost1.sock > -netdev vhost-user,chardev=charnet1,id=hostnet1 > > Should we have an option that expresses a "SocketAddres

Re: Replace GSource with AioContext for chardev

2020-04-14 Thread Daniel P . Berrangé
On Tue, Apr 14, 2020 at 09:25:58AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Thu, Apr 09, 2020 at 03:16:01PM +0200, Marc-André Lureau wrote: > >> Hi > >> > >> On Thu, Apr 9, 2020 at 2:46 PM Coiby Xu wrote: > >> > > >> > > >> > Hi, > >> > > >> > I'm now implementing v

Re: Replace GSource with AioContext for chardev

2020-04-14 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Apr 09, 2020 at 03:16:01PM +0200, Marc-André Lureau wrote: >> Hi >> >> On Thu, Apr 9, 2020 at 2:46 PM Coiby Xu wrote: >> > >> > >> > Hi, >> > >> > I'm now implementing vhost-user block device backend >> > https://patchew.org/QEMU/20200309100342.14921-1-coiby

Re: Replace GSource with AioContext for chardev

2020-04-09 Thread Daniel P . Berrangé
On Thu, Apr 09, 2020 at 03:16:01PM +0200, Marc-André Lureau wrote: > Hi > > On Thu, Apr 9, 2020 at 2:46 PM Coiby Xu wrote: > > > > > > Hi, > > > > I'm now implementing vhost-user block device backend > > https://patchew.org/QEMU/20200309100342.14921-1-coiby...@gmail.com/ > > and want to use chard

Re: Replace GSource with AioContext for chardev

2020-04-09 Thread Marc-André Lureau
Hi On Thu, Apr 9, 2020 at 2:46 PM Coiby Xu wrote: > > > Hi, > > I'm now implementing vhost-user block device backend > https://patchew.org/QEMU/20200309100342.14921-1-coiby...@gmail.com/ > and want to use chardev to help manage vhost-user client connections > and read socket message. However ther

Replace GSource with AioContext for chardev

2020-04-09 Thread Coiby Xu
Hi, I'm now implementing vhost-user block device backend https://patchew.org/QEMU/20200309100342.14921-1-coiby...@gmail.com/ and want to use chardev to help manage vhost-user client connections and read socket message. However there are two issues that need to be addressed. Firstly, chardev is