Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

2022-03-18 Thread Peter Xu
On Wed, Mar 16, 2022 at 11:00:53AM +, Daniel P. Berrangé wrote: > On Wed, Mar 16, 2022 at 06:40:08PM +0800, Peter Xu wrote: > > On Wed, Mar 16, 2022 at 09:59:28AM +, Daniel P. Berrangé wrote: > > > On Wed, Mar 16, 2022 at 11:30:59AM +0800, Peter Xu wrote: > > > > On Tue, Mar 15, 2022 at 11:

Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

2022-03-16 Thread Daniel P . Berrangé
On Wed, Mar 16, 2022 at 06:40:08PM +0800, Peter Xu wrote: > On Wed, Mar 16, 2022 at 09:59:28AM +, Daniel P. Berrangé wrote: > > On Wed, Mar 16, 2022 at 11:30:59AM +0800, Peter Xu wrote: > > > On Tue, Mar 15, 2022 at 11:15:41AM +, Daniel P. Berrangé wrote: > > > > > I still remember you ment

Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

2022-03-16 Thread Peter Xu
On Wed, Mar 16, 2022 at 09:59:28AM +, Daniel P. Berrangé wrote: > On Wed, Mar 16, 2022 at 11:30:59AM +0800, Peter Xu wrote: > > On Tue, Mar 15, 2022 at 11:15:41AM +, Daniel P. Berrangé wrote: > > > > I still remember you mentioned the upper layer softwares can have > > > > assumption on usi

Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

2022-03-16 Thread Daniel P . Berrangé
On Wed, Mar 16, 2022 at 11:30:59AM +0800, Peter Xu wrote: > On Tue, Mar 15, 2022 at 11:15:41AM +, Daniel P. Berrangé wrote: > > > I still remember you mentioned the upper layer softwares can have > > > assumption on using only 1 pair of socket for migration, I think that > > > makes > > > post

Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

2022-03-15 Thread Peter Xu
On Tue, Mar 15, 2022 at 11:15:41AM +, Daniel P. Berrangé wrote: > > I still remember you mentioned the upper layer softwares can have > > assumption on using only 1 pair of socket for migration, I think that makes > > postcopy-preempt by default impossible. > > > > Why multifd is different her

Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

2022-03-15 Thread Daniel P . Berrangé
On Tue, Mar 15, 2022 at 02:13:43PM +0800, Peter Xu wrote: > On Mon, Mar 14, 2022 at 06:49:25PM +, Daniel P. Berrangé wrote: > > Taking a step back here and looking at the bigger picture of > > migration protocol configuration > > > > Almost every time we add a new feature to migration, we

Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

2022-03-15 Thread Daniel P . Berrangé
On Tue, Mar 15, 2022 at 10:43:45AM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > Almost every time we add a new feature to migration, we end up > > having to define at least one new migration parameter, then wire > > it up in libvirt, and then the mgmt

Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

2022-03-15 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Tue, Mar 01, 2022 at 04:51:09PM +, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > On Tue, Mar 01, 2022 at 10:27:10AM +, Daniel P. Berrangé wrote: > > > > > I also didn't know whether there's other limitati

Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

2022-03-14 Thread Peter Xu
On Mon, Mar 14, 2022 at 06:49:25PM +, Daniel P. Berrangé wrote: > Taking a step back here and looking at the bigger picture of > migration protocol configuration > > Almost every time we add a new feature to migration, we end up > having to define at least one new migration parameter, then

Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

2022-03-14 Thread Daniel P . Berrangé
On Tue, Mar 01, 2022 at 04:51:09PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Tue, Mar 01, 2022 at 10:27:10AM +, Daniel P. Berrangé wrote: > > > > I also didn't know whether there's other limitations of it. For > > > > example, > > > > will a new socke