Re: aio-context question

2020-03-23 Thread Dietmar Maurer
> If it doesn't have any effect because it just does what will be done > later anyway, it can be removed, but that doesn't buy us much. I think that code is simply unnecessary (no effect). But it is quite hard to read and understand, so I think removing that code helps to simplify things. > If it

Re: aio-context question

2020-03-23 Thread Kevin Wolf
Am 19.03.2020 um 09:13 hat Dietmar Maurer geschrieben: > I just saw commit 30dd65f307b647eef8156c4a33bd007823ef85cb, and noticed that > a similar pattern in drive_backup_prepare() and blockdev_backup_prepare(). > > The calls to bdrv_try_set_aio_context() seems useless, because we already do > tha

aio-context question

2020-03-19 Thread Dietmar Maurer
I just saw commit 30dd65f307b647eef8156c4a33bd007823ef85cb, and noticed that a similar pattern in drive_backup_prepare() and blockdev_backup_prepare(). The calls to bdrv_try_set_aio_context() seems useless, because we already do that later in backup_job_create/brdv_attach. But I am not 100%& sur