Re: compile warning in i8259.c

2021-03-15 Thread Paolo Bonzini
On 15/03/21 16:55, Philippe Mathieu-Daudé wrote: Since you ask, I'd love to have things solved differently... One PIC has 8 IRQs, so we should model 2 cascaded PICs as 2 cascaded QOM PICs. But this code is so old and heavily used that my desire is unlikely to be realized. And your patch is

Re: compile warning in i8259.c

2021-03-15 Thread Christian Borntraeger
On 15.03.21 17:20, Thomas Huth wrote: On 15/03/2021 16.44, Christian Borntraeger wrote: On 15.03.21 16:14, Christian Borntraeger wrote: For some time now I do see the following, when I compile x86-softmmu on s390: FAILED: libcommon.fa.p/hw_intc_i8259.c.o cc -Ilibcommon.fa.p -I. -I.. -Iqapi

Re: compile warning in i8259.c

2021-03-15 Thread Richard Henderson
On 3/15/21 10:20 AM, Thomas Huth wrote: +    if (irq == 2) { +    irq2 = pic_get_irq(slave_pic); This looks better. You should also be able to pull in the declaration to int irq2 = pic_get_irq(slave_pic); here. r~

Re: compile warning in i8259.c

2021-03-15 Thread Thomas Huth
On 15/03/2021 16.44, Christian Borntraeger wrote: On 15.03.21 16:14, Christian Borntraeger wrote: For some time now I do see the following, when I compile x86-softmmu on s390: FAILED: libcommon.fa.p/hw_intc_i8259.c.o cc -Ilibcommon.fa.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shader

Re: compile warning in i8259.c

2021-03-15 Thread Christian Borntraeger
On 15.03.21 16:58, Thomas Huth wrote: On 15/03/2021 16.50, Philippe Mathieu-Daudé wrote: On 3/15/21 4:42 PM, Thomas Huth wrote: On 15/03/2021 16.14, Christian Borntraeger wrote: For some time now I do see the following, when I compile x86-softmmu on s390: FAILED:

Re: compile warning in i8259.c

2021-03-15 Thread Thomas Huth
On 15/03/2021 16.50, Philippe Mathieu-Daudé wrote: On 3/15/21 4:42 PM, Thomas Huth wrote: On 15/03/2021 16.14, Christian Borntraeger wrote: For some time now I do see the following, when I compile x86-softmmu on s390: FAILED: libcommon.fa.p/hw_intc_i8259.c.o cc -Ilibcommon.fa.p -I. -I..

Re: compile warning in i8259.c

2021-03-15 Thread Philippe Mathieu-Daudé
On 3/15/21 4:44 PM, Christian Borntraeger wrote: > On 15.03.21 16:14, Christian Borntraeger wrote: >> For some time now I do see the following, when I compile x86-softmmu >> on s390: >> >> FAILED: libcommon.fa.p/hw_intc_i8259.c.o >> cc -Ilibcommon.fa.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shader >>

Re: compile warning in i8259.c

2021-03-15 Thread Philippe Mathieu-Daudé
On 3/15/21 4:42 PM, Thomas Huth wrote: > On 15/03/2021 16.14, Christian Borntraeger wrote: >> For some time now I do see the following, when I compile x86-softmmu >> on s390: >> >> FAILED: libcommon.fa.p/hw_intc_i8259.c.o >> cc -Ilibcommon.fa.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shader >>

Re: compile warning in i8259.c

2021-03-15 Thread Christian Borntraeger
On 15.03.21 16:14, Christian Borntraeger wrote: For some time now I do see the following, when I compile x86-softmmu on s390: FAILED: libcommon.fa.p/hw_intc_i8259.c.o cc -Ilibcommon.fa.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/capstone -I/usr/include/glib-2.0

Re: compile warning in i8259.c

2021-03-15 Thread Christian Borntraeger
On 15.03.21 16:42, Thomas Huth wrote: On 15/03/2021 16.14, Christian Borntraeger wrote: For some time now I do see the following, when I compile x86-softmmu on s390: FAILED: libcommon.fa.p/hw_intc_i8259.c.o cc -Ilibcommon.fa.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/capstone

Re: compile warning in i8259.c

2021-03-15 Thread Thomas Huth
On 15/03/2021 16.14, Christian Borntraeger wrote: For some time now I do see the following, when I compile x86-softmmu on s390: FAILED: libcommon.fa.p/hw_intc_i8259.c.o cc -Ilibcommon.fa.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/capstone -I/usr/include/glib-2.0

compile warning in i8259.c

2021-03-15 Thread Christian Borntraeger
For some time now I do see the following, when I compile x86-softmmu on s390: FAILED: libcommon.fa.p/hw_intc_i8259.c.o cc -Ilibcommon.fa.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/capstone -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libmount