Re: gmake in Solaris 11.4: TFR missing

2020-07-04 Thread Peter Maydell
On Sat, 4 Jul 2020 at 20:15, Michele Denber wrote: > > On 07/04/20 11:57, Philippe Mathieu-Daudé wrote: > > Odd... > > Assuming you are using gcc, have you tried 'configure --host-cc=gcc'? > > OK, so I changed it from > > # /opt/csw/bin/bash ./configure --cc=gcc --extra-cflags="-m32" > > to > > #

Re: gmake in Solaris 11.4: TFR missing

2020-07-04 Thread Michele Denber
Update: actually, after using it for a bit, it appears that XP runs at about the same speed in 5.0 as it did in 2.12. It's just the initial boot that's very slow. Does this message (which I discovered hiding under the QEMU window) have anything to do with it? (qemu:27712): Gtk-WARNING **: Co

Re: gmake in Solaris 11.4: TFR missing

2020-07-04 Thread Michele Denber
On 07/04/20 11:57, Philippe Mathieu-Daudé wrote: Odd... Assuming you are using gcc, have you tried 'configure --host-cc=gcc'? OK, so I changed it from # /opt/csw/bin/bash ./configure --cc=gcc --extra-cflags="-m32" to # /opt/csw/bin/bash ./configure --cc=gcc --extra-cflags="-m32" --host-cc

Re: gmake in Solaris 11.4: TFR missing

2020-07-04 Thread Philippe Mathieu-Daudé
On 7/4/20 5:36 PM, Michele Denber wrote: > On 07/04/20 08:02, Thomas Huth wrote: >> TFR is a macro that is defined in our qemu-common.h header ... does it >> work if you add a #include "qemu-common.h" somewhere at the beginning of >> net/tap-solaris.c ? > Yes, thank you, that fixed it: > > root@he

Re: gmake in Solaris 11.4: TFR missing

2020-07-04 Thread Michele Denber
On 07/04/20 08:02, Thomas Huth wrote: TFR is a macro that is defined in our qemu-common.h header ... does it work if you add a #include "qemu-common.h" somewhere at the beginning of net/tap-solaris.c ? Yes, thank you, that fixed it: root@hemlock:~/qemu-5.0.0# gmake -j16 gmake[1]: Entering direc

Re: gmake in Solaris 11.4: TFR missing

2020-07-04 Thread Michele Denber
On 07/03/20 17:55, Philippe Mathieu-Daudé wrote: TFR() is defined in include/qemu-common.h: #define TFR(expr) do { if ((expr) != -1) break; } while (errno == EINTR) Ah ha, thank you. It figures, the one place I didn't look. I assumed that QEMU would know how to find its own things so TFR m

Re: gmake in Solaris 11.4: TFR missing

2020-07-04 Thread Peter Maydell
On Sat, 4 Jul 2020 at 12:30, Philippe Mathieu-Daudé wrote: > Any idea what means TFR? I understand it keeps retrying while > interrupted, but can't find the origin of that abbreviation. Probably it stands for "temporary failure retry" -- glibc provides essentially the same primitive in unistd.h a

Re: gmake in Solaris 11.4: TFR missing

2020-07-04 Thread Thomas Huth
On 03/07/2020 23.35, Michele Denber wrote: > >> >> It appears that _IOR & friends are defined in >> /usr/include/sys/ioccom.h, but I can't figure out how to point gmake >> to that.  Do I need some sort of "-I" in the Makefile? >> >> >> When I built QEMU 2.12, I ran into this too and ended up just

Re: gmake in Solaris 11.4: TFR missing

2020-07-04 Thread Philippe Mathieu-Daudé
+Eric for macros & errno handling On 7/4/20 11:11 AM, Peter Maydell wrote: > On Fri, 3 Jul 2020 at 22:55, Philippe Mathieu-Daudé wrote: >> >> On 7/3/20 11:35 PM, Michele Denber wrote: >>> What is TFR? >> >> TFR() is defined in include/qemu-common.h: > > Yep; adding #include "qemu-common.h" to

Re: gmake in Solaris 11.4: TFR missing

2020-07-04 Thread Peter Maydell
On Fri, 3 Jul 2020 at 22:55, Philippe Mathieu-Daudé wrote: > > On 7/3/20 11:35 PM, Michele Denber wrote: > > What is TFR? > > TFR() is defined in include/qemu-common.h: Yep; adding #include "qemu-common.h" to tap-solaris.c should fix this (I think we missed tap-solaris.c in the header cleanup o

Re: gmake in Solaris 11.4: TFR missing

2020-07-03 Thread Philippe Mathieu-Daudé
On 7/3/20 11:35 PM, Michele Denber wrote: > >> >> It appears that _IOR & friends are defined in >> /usr/include/sys/ioccom.h, but I can't figure out how to point gmake >> to that.  Do I need some sort of "-I" in the Makefile? >> >> >> When I built QEMU 2.12, I ran into this too and ended up just >

gmake in Solaris 11.4: TFR missing

2020-07-03 Thread Michele Denber
It appears that _IOR & friends are defined in /usr/include/sys/ioccom.h, but I can't figure out how to point gmake to that. Do I need some sort of "-I" in the Makefile? When I built QEMU 2.12, I ran into this too and ended up just commenting out all the references to _IOR, etc. in hw/tpm