Re: nbd: bitmap_to_extents() calls nbd_extent_array_add() without checking return value: coverity false positive?

2020-11-09 Thread Vladimir Sementsov-Ogievskiy
09.11.2020 18:22, Eric Blake wrote: On 11/9/20 1:17 AM, Vladimir Sementsov-Ogievskiy wrote: 07.11.2020 01:53, Peter Maydell wrote: On Fri, 6 Nov 2020 at 20:36, Eric Blake wrote: On 11/6/20 11:22 AM, Peter Maydell wrote: Hi; Coverity's "you usually check the return value of this function

Re: nbd: bitmap_to_extents() calls nbd_extent_array_add() without checking return value: coverity false positive?

2020-11-09 Thread Eric Blake
On 11/9/20 1:17 AM, Vladimir Sementsov-Ogievskiy wrote: > 07.11.2020 01:53, Peter Maydell wrote: >> On Fri, 6 Nov 2020 at 20:36, Eric Blake wrote: >>> >>> On 11/6/20 11:22 AM, Peter Maydell wrote: Hi; Coverity's "you usually check the return value of this function but you didn't do that

Re: nbd: bitmap_to_extents() calls nbd_extent_array_add() without checking return value: coverity false positive?

2020-11-08 Thread Vladimir Sementsov-Ogievskiy
07.11.2020 01:53, Peter Maydell wrote: On Fri, 6 Nov 2020 at 20:36, Eric Blake wrote: On 11/6/20 11:22 AM, Peter Maydell wrote: Hi; Coverity's "you usually check the return value of this function but you didn't do that here" heuristic has fired on the code in nbd/server.c:bitmap_to_extents()

Re: nbd: bitmap_to_extents() calls nbd_extent_array_add() without checking return value: coverity false positive?

2020-11-06 Thread Peter Maydell
On Fri, 6 Nov 2020 at 20:36, Eric Blake wrote: > > On 11/6/20 11:22 AM, Peter Maydell wrote: > > Hi; Coverity's "you usually check the return value of this function > > but you didn't do that here" heuristic has fired on the code in > > nbd/server.c:bitmap_to_extents() -- the function

Re: nbd: bitmap_to_extents() calls nbd_extent_array_add() without checking return value: coverity false positive?

2020-11-06 Thread Eric Blake
On 11/6/20 11:22 AM, Peter Maydell wrote: > Hi; Coverity's "you usually check the return value of this function > but you didn't do that here" heuristic has fired on the code in > nbd/server.c:bitmap_to_extents() -- the function nbd_extent_array_add() > is called five times in server.c, and the

nbd: bitmap_to_extents() calls nbd_extent_array_add() without checking return value: coverity false positive?

2020-11-06 Thread Peter Maydell
Hi; Coverity's "you usually check the return value of this function but you didn't do that here" heuristic has fired on the code in nbd/server.c:bitmap_to_extents() -- the function nbd_extent_array_add() is called five times in server.c, and the return value is checked in four of those, but not in