Re: of AVR target page size

2021-03-18 Thread Peter Maydell
On Thu, 18 Mar 2021 at 20:05, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > On Thu, 18 Mar 2021 at 10:45, Dr. David Alan Gilbert > > wrote: > > > > > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > > > Also, what does the > > > > /* 0x80 is reser

Re: of AVR target page size

2021-03-18 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Thu, 18 Mar 2021 at 10:45, Dr. David Alan Gilbert > wrote: > > > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > > Also, what does the > > > /* 0x80 is reserved in migration.h start with 0x100 next */ > > > comment refer to? migration

Re: of AVR target page size

2021-03-18 Thread Dr. David Alan Gilbert
* Michael Rolnik (mrol...@gmail.com) wrote: > how do I test my fix? Is there a procedure? As long as your TARGET_PAGE_SIZE is now 512 or bigger you should be OK as long as your AVR stuff still works. If you want you can try and do a live migrate between two copies of qemu, but that does assume yo

Re: of AVR target page size

2021-03-18 Thread Peter Maydell
On Thu, 18 Mar 2021 at 10:45, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > Also, what does the > > /* 0x80 is reserved in migration.h start with 0x100 next */ > > comment refer to? migration.h has no instances of "RAM_SAVE" > > or 0x80 or 1 << 7... > > I

Re: of AVR target page size

2021-03-18 Thread Michael Rolnik
how do I test my fix? Is there a procedure? Thanks, Michael Rolnik On Thu, Mar 18, 2021 at 12:45 PM Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > On Thu, 18 Mar 2021 at 10:25, Dr. David Alan Gilbert > > wrote: > > > Oh yes, just: > > > > > > diff --git a

Re: of AVR target page size

2021-03-18 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Thu, 18 Mar 2021 at 10:25, Dr. David Alan Gilbert > wrote: > > Oh yes, just: > > > > diff --git a/migration/ram.c b/migration/ram.c > > index 52537f14ac..a7269955b5 100644 > > --- a/migration/ram.c > > +++ b/migration/ram.c > > @@ -81,6 +81,8

Re: of AVR target page size

2021-03-18 Thread Peter Maydell
On Thu, 18 Mar 2021 at 10:25, Dr. David Alan Gilbert wrote: > Oh yes, just: > > diff --git a/migration/ram.c b/migration/ram.c > index 52537f14ac..a7269955b5 100644 > --- a/migration/ram.c > +++ b/migration/ram.c > @@ -81,6 +81,8 @@ > /* 0x80 is reserved in migration.h start with 0x100 next */ >

Re: of AVR target page size

2021-03-18 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Thu, 18 Mar 2021 at 10:18, Dr. David Alan Gilbert > wrote: > > diff --git a/migration/ram.c b/migration/ram.c > > index 1ee7ff9c6d..f053d45f3c 100644 > > --- a/migration/ram.c > > +++ b/migration/ram.c > > @@ -81,6 +81,8 @@ > > /* 0x80 is res

Re: of AVR target page size

2021-03-18 Thread Peter Maydell
On Thu, 18 Mar 2021 at 10:18, Dr. David Alan Gilbert wrote: > diff --git a/migration/ram.c b/migration/ram.c > index 1ee7ff9c6d..f053d45f3c 100644 > --- a/migration/ram.c > +++ b/migration/ram.c > @@ -81,6 +81,8 @@ > /* 0x80 is reserved in migration.h start with 0x100 next */ > #define RAM_SAVE_

Re: of AVR target page size

2021-03-18 Thread Dr. David Alan Gilbert
* Michael Rolnik (mrol...@gmail.com) wrote: > ok. I will try to fix it. Thanks, if you can that would be great. Dave > Regards, > Michael Rolnik > > On Thu, Mar 18, 2021 at 11:55 AM Dr. David Alan Gilbert > wrote: > > > * Michael Rolnik (mrol...@gmail.com) wrote: > > > Hi Dave. > > > > > > Wh

Re: of AVR target page size

2021-03-18 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Wed, 17 Mar 2021 at 20:17, Dr. David Alan Gilbert > wrote: > > > > Hi Michael, > > I noticed your AVR code defines: > > > > #define TARGET_PAGE_BITS 8 > > > > and has an explanation of why. > > > > Note however that's not going to work wit

Re: of AVR target page size

2021-03-18 Thread Michael Rolnik
ok. I will try to fix it. Regards, Michael Rolnik On Thu, Mar 18, 2021 at 11:55 AM Dr. David Alan Gilbert wrote: > * Michael Rolnik (mrol...@gmail.com) wrote: > > Hi Dave. > > > > What is the smallest supported page size? > > Currently 512 I think; in migration/ram.c we have: > > #define RAM_SA

Re: of AVR target page size

2021-03-18 Thread Dr. David Alan Gilbert
* Michael Rolnik (mrol...@gmail.com) wrote: > Hi Dave. > > What is the smallest supported page size? Currently 512 I think; in migration/ram.c we have: #define RAM_SAVE_FLAG_FULL 0x01 /* Obsolete, not used anymore */ #define RAM_SAVE_FLAG_ZERO 0x02 #define RAM_SAVE_FLAG_MEM_SIZE 0x04 #de

Re: of AVR target page size

2021-03-18 Thread Michael Rolnik
I guess we can add some bits TARGET_PAGE_BITS, this will make us to push some portion of SRAM into the CPU. Michael Rolnik On Thu, Mar 18, 2021 at 12:33 AM Peter Maydell wrote: > On Wed, 17 Mar 2021 at 20:17, Dr. David Alan Gilbert > wrote: > > > > Hi Michael, > > I noticed your AVR code def

Re: of AVR target page size

2021-03-17 Thread Peter Maydell
On Wed, 17 Mar 2021 at 20:17, Dr. David Alan Gilbert wrote: > > Hi Michael, > I noticed your AVR code defines: > > #define TARGET_PAGE_BITS 8 > > and has an explanation of why. > > Note however that's not going to work with the current live > migration/snapshotting code, since you're a couple

Re: of AVR target page size

2021-03-17 Thread Michael Rolnik
Hi Dave. What is the smallest supported page size? On Wed, Mar 17, 2021 at 10:14 PM Dr. David Alan Gilbert wrote: > Hi Michael, > I noticed your AVR code defines: > > #define TARGET_PAGE_BITS 8 > > and has an explanation of why. > > Note however that's not going to work with the current li

of AVR target page size

2021-03-17 Thread Dr. David Alan Gilbert
Hi Michael, I noticed your AVR code defines: #define TARGET_PAGE_BITS 8 and has an explanation of why. Note however that's not going to work with the current live migration/snapshotting code, since you're a couple of bits smaller than the smallest page size we had so far, and for many years