Re: of remote_iohub_finalize

2024-09-19 Thread Jag Raman
Hi Dave, Thanks for checking! remote_iohub_finalize() is a relic from when remote iohub was a separate type. We aren't calling it anywhere; we can remove it. Cheers, Jag > On Sep 18, 2024, at 1:00 PM, Dr. David Alan Gilbert wrote: > > Hi Jag, > One of my scripts noticed that 'remote_iohub_f

Re: of remote_iohub_finalize

2024-09-19 Thread Dr. David Alan Gilbert
* Jag Raman (jag.ra...@oracle.com) wrote: > Hi Dave, > > Thanks for checking! > > remote_iohub_finalize() is a relic from when remote iohub was a separate > type. We aren't calling it anywhere; we can remove it. OK, I'll send a patch later. Dave > Cheers, > Jag > > > On Sep 18, 2024, at 1:00

of remote_iohub_finalize

2024-09-18 Thread Dr. David Alan Gilbert
Hi Jag, One of my scripts noticed that 'remote_iohub_finalize' in hw/remote/iohub.c is unused; before I go and delete it as deadcode, is that actually just a missing call somewhere? Dave -- -Open up your eyes, open up your mind, open up your code --- / Dr. David Alan Gilbert|