re:Re: [PATCH] target/riscv/cpu.c: Fix elen check

[503386372]

sorry for that, i will try again with git.sr.th.


------------------ 原始邮件 ------------------
发件人: "Alistair Francis";
发件时间: 2022-12-28 13:46
收件人: "Elta"<503386...@qq.com&gt;;
收件人: 
"qemu-devel";"palmer";"alistair.francis";"bin.meng";"qemu-riscv";
主题: Re: [PATCH] target/riscv/cpu.c: Fix elen check



On Fri, Dec 16, 2022 at 1:10 AM Elta <503386...@qq.com&gt; wrote:
&gt;
&gt; Should be cpu-&gt;cfg.elen in range [8, 64].
&gt;
&gt; Signed-off-by: Dongxue Zhang 

Thanks for the patch!

I'm seeing weird formatting issues though, it looks like the encoding
is incorrect.

Did you use `git send-email` to send the patch? If not can you try
sending it again following the instructions here
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#submitting-your-patches

Alistair

&gt; ---
&gt;  target/riscv/cpu.c | 2 +-
&gt;  1 file changed, 1 insertion(+), 1 deletion(-)
&gt;
&gt; diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
&gt; index d14e95c9dc..1e8032c969 100644
&gt; --- a/target/riscv/cpu.c
&gt; +++ b/target/riscv/cpu.c
&gt; @@ -870,7 +870,7 @@ static void riscv_cpu_realize(DeviceState *dev, Error 
**errp)
&gt;                          "Vector extension ELEN must be power of 2");
&gt;                  return;
&gt;              }
&gt; -            if (cpu-&gt;cfg.elen &gt; 64 || cpu-&gt;cfg.vlen < 8) {
&gt; +            if (cpu-&gt;cfg.elen &gt; 64 || cpu-&gt;cfg.elen < 8) {
&gt;                  error_setg(errp,
&gt;                          "Vector extension implementation only supports 
ELEN "
&gt;                          "in the range [8, 64]");
&gt; --
&gt; 2.17.1
&gt;