Re: util/async-teardown.c: is it really needed for --disable-system build?

2023-08-14 Thread Michael Tokarev
14.08.2023 10:27, Claudio Imbrenda wrote: On Mon, 14 Aug 2023 10:12:35 +0300 Michael Tokarev wrote: 14.08.2023 10:01, Claudio Imbrenda wrote: I think we could guard the offending item with CONFIG_SOFTMMU for now, to immediately fix the issues you raised, and do the refactoring you proposed l

Re: util/async-teardown.c: is it really needed for --disable-system build?

2023-08-14 Thread Claudio Imbrenda
On Mon, 14 Aug 2023 10:12:35 +0300 Michael Tokarev wrote: > 14.08.2023 10:01, Claudio Imbrenda wrote: > > > I think we could guard the offending item with CONFIG_SOFTMMU for now, > > to immediately fix the issues you raised, and do the refactoring you > > proposed later (e.g. next cycle). > >

Re: util/async-teardown.c: is it really needed for --disable-system build?

2023-08-14 Thread Claudio Imbrenda
On Sat, 12 Aug 2023 12:48:14 +0300 Michael Tokarev wrote: > 12.08.2023 12:38, Michael Tokarev wrote: > ... > > It smells like, at the very least, os-posix.c should be split. We shouldn't > > include > > a ton of qemu-system functionality (like very specific option parsing) into > > qemu-nbd > >

Re: util/async-teardown.c: is it really needed for --disable-system build?

2023-08-14 Thread Michael Tokarev
14.08.2023 10:01, Claudio Imbrenda wrote: I think we could guard the offending item with CONFIG_SOFTMMU for now, to immediately fix the issues you raised, and do the refactoring you proposed later (e.g. next cycle). I don't think rushing for the last-minute fix is necessary in this case. It ha

Re: util/async-teardown.c: is it really needed for --disable-system build?

2023-08-12 Thread Michael Tokarev
12.08.2023 12:38, Michael Tokarev wrote: ... It smells like, at the very least, os-posix.c should be split. We shouldn't include a ton of qemu-system functionality (like very specific option parsing) into qemu-nbd for example. How about splitting os-posix.c into a few files in util/ (not in th

util/async-teardown.c: is it really needed for --disable-system build?

2023-08-12 Thread Michael Tokarev
Hi! On Debian we're building qemu tools (eg qemu-img &Co) on systems which don't support qemu-system. And after commit c891c24b1a "os-posix: asynchronous teardown for shutdown on Linux", this fails on certain architectures too, notable on ia64. This is because ia64 does not have the "traditiona