[Qemu-devel] [PATCH v2 04/16] highbank: Convert conditional compilation of debug printfs to regular ifs

Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/net/xgmac.c | 10 ++ 1 fi

[Qemu-devel] [PATCH v2 07/16] stellaris: Convert conditional compilation of debug printfs to regular ifs

Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/net/stellaris_enet.c | 21 +++

[Qemu-devel] [PATCH v2 15/16] pci-host: Convert conditional compilation of debug printfs to regular ifs

Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/pci-host/bonito.c | 10 ++---

[Qemu-devel] [PATCH v2 08/16] tpm: Convert conditional compilation of debug printfs to regular ifs

Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/tpm/tpm_passthrough.c |8 --

[Qemu-devel] [PATCH v2 06/16] spapr: Convert conditional compilation of debug printfs to regular ifs

Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/net/spapr_llan.c |6 -- 1 f

[Qemu-devel] [PATCH v2 10/16] i8257: Convert conditional compilation of debug printfs to regular ifs

Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/dma/i8257.c | 13 +++-- 1

[Qemu-devel] [PATCH v2 13/16] isa: Convert conditional compilation of debug printfs to regular ifs

Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/isa/vt82c686.c | 10 ++ 1

[Qemu-devel] [PATCH 0/4] Support more than 255 cpus

From: "Li, ZhenHua" These series patches are trying to make Qemu support more than 255 CPUs. The max cpu number changed to 4096. Support more than 255 cpus: ACPI and APIC defines Support more than 255 cpus: max_cpus to 4096 Support more than 255 cpus: max cpumask bit to 4096 Support more th

Re: [Qemu-devel] [PATCH] virtio-blk: Allow config-wce in dataplane

On Tue, 05/13 09:07, Paolo Bonzini wrote: > Il 13/05/2014 04:24, Fam Zheng ha scritto: > >Dataplane now uses block layer. Protect bdrv_set_enable_write_cache with > >aio_context_acquire and aio_context_release, so we can enable config-wce > >to allow guest to modify the write cache online. > > > >S

Re: [Qemu-devel] [PATCH v2 2/3] PPC: Allow little-endian user mode.

On 10.05.14 11:16, Doug Kwan wrote: This allow running PPC64 little-endian in user mode if target is configured that way. In PPC64 LE user mode we set MSR.LE during initialization. Overhaul handling of byteswapping in code generation and mem helpers. Signed-off-by: Doug Kwan --- target-ppc/

[Qemu-devel] [PATCH 3/4] Support more than 255 cpus: max cpumask bit to 4096

From: "Li, ZhenHua" Change MAX_CPUMASK_BITS from 255 to 4096. Signed-off-by: Li, ZhenHua --- include/sysemu/sysemu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index ba5c7f8..97961a6 100644 --- a/include/sysemu/sysemu.h

Re: [Qemu-devel] [PATCH] virtio-blk: Allow config-wce in dataplane

Il 13/05/2014 04:24, Fam Zheng ha scritto: Dataplane now uses block layer. Protect bdrv_set_enable_write_cache with aio_context_acquire and aio_context_release, so we can enable config-wce to allow guest to modify the write cache online. Signed-off-by: Fam Zheng --- This applies on top of Stef

[Qemu-devel] [PATCH v2 16/16] common: Convert conditional compilation of debug printfs to regular ifs

Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- include/qemu-common.h |7 +++

[Qemu-devel] [PATCH v2 01/16] x86: Convert conditional compilation of debug printfs to regular ifs

Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/i386/kvm/pci-assign.c |9 --

[Qemu-devel] [PATCH v2 11/16] rc4030: Convert conditional compilation of debug printfs to regular ifs

Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/dma/rc4030.c | 11 +-- 1

[Qemu-devel] [PATCH v2 09/16] i82374: Convert conditional compilation of debug printfs to regular ifs

Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/dma/i82374.c | 11 +-- 1

Re: [Qemu-devel] [RFC PATCH 09/11] target-arm: move arm_*_code to a separate file

Am 08.05.2014 18:09, schrieb Paolo Bonzini: > These will soon require cpu_ldst.h, so move them out of cpu.h. > > Signed-off-by: Paolo Bonzini > --- > target-arm/arm_ldst.h | 47 > ++ > target-arm/cpu.h | 22 -- > tar

Re: [Qemu-devel] [RFC] vhost: Can we change synchronize_rcu to call_rcu in vhost_set_memory() in vhost kernel module?

Hi, > -Original Message- > From: Paolo Bonzini [mailto:[email protected]] > Sent: Monday, May 12, 2014 5:58 PM > Perhaps we can check for cases where only the address is changing, and > poke at an existing struct kvm_kernel_irq_routing_entry without doing > any RCU synchronization? > >

[Qemu-devel] [PATCH v2 14/16] lan9118: Convert conditional compilation of debug printfs to regular ifs

Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/net/lan9118.c | 26 ++

Re: [Qemu-devel] [RFC PATCH 08/11] softmmu: make do_unaligned_access extern

Il 13/05/2014 08:53, Andreas Färber ha scritto: > +void do_unaligned_access(CPUAlphaState *env, target_ulong addr, > + int is_write, int is_user, uintptr_t retaddr); > + > #include "exec/exec-all.h" > > #endif /* !defined (__CPU_ALPHA_H__) */ [snip] Have you considered

Re: [Qemu-devel] [RFC] vhost: Can we change synchronize_rcu to call_rcu in vhost_set_memory() in vhost kernel module?

Hi, > -Original Message- > From: Michael S. Tsirkin [mailto:[email protected]] > Sent: Monday, May 12, 2014 6:31 PM > > vhost does everything under a VQ lock. > I think RCU for VHOST_SET_MEM_TABLE can be replaced with > taking and freeing the VQ lock. > > Does the below solve the problem f

[Qemu-devel] [PATCH v2 12/16] sd: Convert conditional compilation of debug printfs to regular ifs

Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/sd/sd.c |7 --- hw/sd/s

[Qemu-devel] [PATCH 1/4] Support more than 255 cpus: ACPI and APIC defines

From: "Li, ZhenHua" Change ACPI_CPU_HOTPLUG_ID_LIMIT from 256 to 4096; Change MAX_APICS from 256 to 4096; Signed-off-by: Li, ZhenHua --- include/hw/acpi/cpu_hotplug_defs.h | 4 ++-- include/hw/i386/apic_internal.h| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/includ

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 06/16] spapr: Convert conditional compilation of debug printfs to regular ifs

On 13.05.14 09:02, Marc Marí wrote: Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí I

[Qemu-devel] [PATCH 2/4] Support more than 255 cpus: max_cpus to 4096

From: "Li, ZhenHua" max_cpus from 255 to 4096. So the machine types can support up to 4096 cpus. Signed-off-by: Li, ZhenHua --- include/hw/i386/pc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 9010246..8183141 100644 ---

Re: [Qemu-devel] [PATCH] xhci: child detach fix

> -Original Message- > From: Gerd Hoffmann [mailto:[email protected]] > Sent: Tuesday, May 13, 2014 2:56 PM > > > BTW, in usb_release_port(), the detached port should be insert > > the head of bus->free list table. Because of the save/restore will > > cause qemu crash, after hot plug/hot u

Re: [Qemu-devel] [RFC PATCH 11/11] softmmu: move all load/store functions to cpu_ldst.h

Am 08.05.2014 18:09, schrieb Paolo Bonzini: > Unify pieces of cpu-all.h, exec-all.h, softmmu_exec.h and tcg/tcg.h > into a single new header file with all helpers. > > Signed-off-by: Paolo Bonzini > --- > include/exec/cpu-all.h | 119 --- > include/exec/cpu_ldst.h

Re: [Qemu-devel] [PATCH v2 2/3] PPC: Allow little-endian user mode.

On 13.05.14 09:30, Doug Kwan (關振德) wrote: On Tue, May 13, 2014 at 12:05 AM, Alexander Graf > wrote: On 10.05.14 11:16, Doug Kwan wrote: This allow running PPC64 little-endian in user mode if target is configured that way. In PPC64 LE user

Re: [Qemu-devel] [RFC PATCH 11/11] softmmu: move all load/store functions to cpu_ldst.h

Il 13/05/2014 09:13, Andreas Färber ha scritto: Am 08.05.2014 18:09, schrieb Paolo Bonzini: Unify pieces of cpu-all.h, exec-all.h, softmmu_exec.h and tcg/tcg.h into a single new header file with all helpers. Signed-off-by: Paolo Bonzini --- include/exec/cpu-all.h |

[Qemu-devel] [PATCH v2 03/16] scsi: Convert conditional compilation of debug printfs to regular ifs

Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/scsi/lsi53c895a.c | 17

[Qemu-devel] [PATCH 4/4] Support more than 255 cpus: runtime check

From: "Li, ZhenHua" There is some runtime check for max cpu count. Make them support 4096 cpus. Signed-off-by: Li, ZhenHua --- hw/i386/acpi-build.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index c98df88..5c3bf10 100

Re: [Qemu-devel] [PATCH v2 01/16] x86: Convert conditional compilation of debug printfs to regular ifs

Am 13.05.2014 09:02, schrieb Marc Marí: > Modify debug macros to have the same format through the codebase and use > regular > ifs instead of ifdef. > > As the debug printf is always put in code, some casting had to be added to > avoid > warnings treated as errors at compile time. > > Signed-of

[Qemu-devel] [PATCH v2 00/16] Convert conditional compilation of debug printfs

A macro has been added to qemu-common.h to simplify and standarize the debug printfs. Some of those printfs have been changed too. Marc Marí (16): x86: Convert conditional compilation of debug printfs to regular ifs s390: Convert conditional compilation of debug printfs to regular ifs scsi:

[Qemu-devel] [PATCH v2 02/16] s390: Convert conditional compilation of debug printfs to regular ifs

Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/s390x/s390-virtio-bus.c |8

Re: [Qemu-devel] [PATCH] usb: fix up post load checks

Hi, > +(dev->setup_state == SETUP_STATE_DATA && Fails to build, SETUP_STATE_DATA is not defined here. I think we can simply drop that check, index should never ever be larger than len, no matter what the state is. cheers, Gerd

[Qemu-devel] [PATCH] xhci: add endpoint cap on express bus only

Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 6753a42..a203bc6 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -3594,8 +3594,10 @@ static int usb_xhci_initfn(struct

[Qemu-devel] [PATCH v2 05/16] xilinx: Convert conditional compilation of debug printfs to regular ifs

Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/net/cadence_gem.c | 11 ++

Re: [Qemu-devel] [PATCH v2 0/3] Adding new user mode target ppc64le-linux-user

On 10.05.14 11:16, Doug Kwan wrote: Hi I have made changes based on comments to the previous set of pathces. 1. Target name is now ppc64le-linux-user. 2. I used a memop mask to avoid generating redundant byteswap pairs that cancel out each other. This is suggested by Peter Maydell. 3. The

Re: [Qemu-devel] Qemu live migration code

* Bechir Bani ([email protected]) wrote: > Hi , > > There is someone who can explain to me the role of two trace points in the > file* Migration.c * > > The trace points are : > > * migrate_pending* : what are the attributes *pending size *and *max* ? 'pending_size' is an estimate of the

Re: [Qemu-devel] [PATCH 4/4] Support more than 255 cpus: runtime check

On Tue, May 13, 2014 at 11:09 AM, Li, Zhen-Hua wrote: > From: "Li, ZhenHua" > > There is some runtime check for max cpu count. Make them support 4096 cpus. > > Signed-off-by: Li, ZhenHua > --- > hw/i386/acpi-build.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git

Re: [Qemu-devel] segfault while booting from saved snapshot

Hi, Could anyone please give me the command to do live-migration to to a file? I have tried searching on QEMU Wiki but all the articles that I have come across point to snapshotting the disk, and not the entire VM to a file. Appreciate your help. Thanks, Shehbaz On Sat, Apr 19, 2014 at 11:07 PM

Re: [Qemu-devel] [RFC] vhost: Can we change synchronize_rcu to call_rcu in vhost_set_memory() in vhost kernel module?

On Tue, May 13, 2014 at 07:03:20AM +, Gonglei (Arei) wrote: > Hi, > > > -Original Message- > > From: Michael S. Tsirkin [mailto:[email protected]] > > Sent: Monday, May 12, 2014 6:31 PM > > > > vhost does everything under a VQ lock. > > I think RCU for VHOST_SET_MEM_TABLE can be replace

Re: [Qemu-devel] [PATCH] usb: fix up post load checks

On Tue, May 13, 2014 at 09:50:09AM +0200, Gerd Hoffmann wrote: > Hi, > > > +(dev->setup_state == SETUP_STATE_DATA && > > Fails to build, SETUP_STATE_DATA is not defined here. > > I think we can simply drop that check, index should never ever be larger > than len, no matter what the sta

Re: [Qemu-devel] segfault while booting from saved snapshot

Am 13.05.2014 um 10:20 hat Shehbaz Jaffer geschrieben: > Hi, > > Could anyone please give me the command to do live-migration to to a > file? I have tried searching on QEMU Wiki but all the articles that I > have come across point to snapshotting the disk, and not the entire VM > to a file. In th

Re: [Qemu-devel] [PATCH 4/5] qcow1: Validate image size (CVE-2014-0223)

Am 12.05.2014 um 19:04 hat Benoît Canet geschrieben: > The Monday 12 May 2014 à 18:43:33 (+0200), Kevin Wolf wrote : > > Am 12.05.2014 um 17:50 hat Benoît Canet geschrieben: > > > The Monday 12 May 2014 à 15:04:10 (+0200), Kevin Wolf wrote : > > > > A huge image size could cause s->l1_size to overf

Re: [Qemu-devel] [PATCH] usb: fix up post load checks

On Di, 2014-05-13 at 11:32 +0300, Michael S. Tsirkin wrote: > On Tue, May 13, 2014 at 09:50:09AM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > +(dev->setup_state == SETUP_STATE_DATA && > > > > Fails to build, SETUP_STATE_DATA is not defined here. > > > > I think we can simply drop that

[Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

The shell script attempts to suppress core dumps like this: old_ulimit=$(ulimit -c) ulimit -c 0 $QEMU_IO arg... ulimit -c "$old_ulimit" This breaks the test hard unless the limit was zero to begin with! ulimit sets both hard and soft limit by default, and (re-)raising the hard lim

Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help.

Am 12.05.2014 um 19:02 hat Eric Blake geschrieben: > On 05/12/2014 10:36 AM, Kevin Wolf wrote: > > >>> rebase [-q] [-f fmt] [-t cache] [-p] [-u] -b backing_file [-F > >>> backing_fmt] filename > >> > >> 'rebase' lacks -o; so it must continue to document -b. This thread was > >> started in context

Re: [Qemu-devel] [PATCH] virtio: allow mapping up to max queue size

* Michael S. Tsirkin ([email protected]) wrote: > It's a loop from i < num_sg and the array is VIRTQUEUE_MAX_SIZE - so > it's OK if the value read is VIRTQUEUE_MAX_SIZE. > > Not a big problem in practice as people don't use > such big queues, but it's inelegant. > > Reported-by: "Dr. David Alan Gi

[Qemu-devel] usb: usb tablet freeze when save/restore guest os

Hi, For recent Linux guests, the usb tablet will be suspended when it is idle. When Qemu detect the usb tablet event, will call uhci_wakeup(), which according the value of port->ctrl to decide to call uhci_resume() or not. UHCI_PORT_RD bit is set to 1 for UHCI is resuming, and qemu will not call

Re: [Qemu-devel] [PATCH v2 02/16] s390: Convert conditional compilation of debug printfs to regular ifs

On Tue, 13 May 2014 09:02:38 +0200 Marc Marí wrote: I'd replace the subject with "s390: convert debug printfs to QEMU_DPRINTF" which is more descriptive and has the additional virtue of being shorter ;) > Modify debug macros to have the same format through the codebase and use > regular > ifs

Re: [Qemu-devel] [PATCH v2 16/16] common: Convert conditional compilation of debug printfs to regular ifs

On Tue, 13 May 2014 09:02:52 +0200 Marc Marí wrote: > Modify debug macros to have the same format through the codebase and use > regular > ifs instead of ifdef. > > As the debug printf is always put in code, some casting had to be added to > avoid > warnings treated as errors at compile time.

Re: [Qemu-devel] [RFC PATCH 09/11] target-arm: move arm_*_code to a separate file

On 13 May 2014 08:03, Andreas Färber wrote: > I notice that these user-only functions/macros are taking CPUARMState > but never use it today. Should I convert them to CPUState once I tackle > linux-user, or can we just drop that unused argument? I think they mostly take that argument for consiste

Re: [Qemu-devel] [PATCH] usb: fix up post load checks

On Tue, May 13, 2014 at 10:44:45AM +0200, Gerd Hoffmann wrote: > On Di, 2014-05-13 at 11:32 +0300, Michael S. Tsirkin wrote: > > On Tue, May 13, 2014 at 09:50:09AM +0200, Gerd Hoffmann wrote: > > > Hi, > > > > > > > +(dev->setup_state == SETUP_STATE_DATA && > > > > > > Fails to build, S

Re: [Qemu-devel] [PATCH] virtio-blk: Allow config-wce in dataplane

Il 13/05/2014 09:13, Fam Zheng ha scritto: On Tue, 05/13 09:07, Paolo Bonzini wrote: Il 13/05/2014 04:24, Fam Zheng ha scritto: Dataplane now uses block layer. Protect bdrv_set_enable_write_cache with aio_context_acquire and aio_context_release, so we can enable config-wce to allow guest to mod

Re: [Qemu-devel] [PATCH 1/2] nbd: Close socket on negotiation failure.

Il 13/05/2014 01:35, Hani Benhabiles ha scritto: Otherwise, the nbd client may hang waiting for the server response. Signed-off-by: Hani Benhabiles --- Quick method to trigger such behaviour: (qemu) nbd_server_start localhost:10809 (qemu) nbd_server_add sd0 $ nbd-client localhost 10809 -name

Re: [Qemu-devel] [PATCH 02/10] tcg: Invert the inclusion of helper.h

Richard Henderson writes: > Rather than include helper.h with N values of GEN_HELPER, include a > secondary file that sets up the macros to include helper.h. This > minimizes the files that must be rebuilt when changing the macros > for file N. > > Signed-off-by: Richard Henderson > --- > inc

Re: [Qemu-devel] [PATCH 2/2] nbd: Miscellaneous typo fixes.

Il 13/05/2014 01:35, Hani Benhabiles ha scritto: Signed-off-by: Hani Benhabiles --- nbd.c | 2 +- qemu-nbd.c| 2 +- qemu-nbd.texi | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/nbd.c b/nbd.c index e5084b6..e0d032c 100644 --- a/nbd.c +++ b/nbd.c @@ -306,7 +306

Re: [Qemu-devel] [PATCH 0/4] Support more than 255 cpus

Am 13.05.2014 09:09, schrieb Li, Zhen-Hua: > From: "Li, ZhenHua" > > These series patches are trying to make Qemu support more than 255 CPUs. > The max cpu number changed to 4096. This series is not trivial. And it's not a bug fix either, so not stable material. CC'ing Igor and Eduardo for rev

Re: [Qemu-devel] [PATCH v2 15/16] pci-host: Convert conditional compilation of debug printfs to regular ifs

El Tue, 13 May 2014 09:02:51 +0200 Marc Marí escribió: > diff --git a/hw/pci-host/ppce500.c b/hw/pci-host/ppce500.c > index c80b7cb..dfeb19e 100644 > --- a/hw/pci-host/ppce500.c > +++ b/hw/pci-host/ppce500.c > @@ -21,12 +21,16 @@ > #include "qemu/bswap.h" > #include "hw/pci-host/ppce500.h" > >

Re: [Qemu-devel] [PATCH v2 11/16] rc4030: Convert conditional compilation of debug printfs to regular ifs

El Tue, 13 May 2014 09:02:47 +0200 Marc Marí escribió: > hw/dma/rc4030.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/hw/dma/rc4030.c b/hw/dma/rc4030.c > index af26632..84f9f33 100644 > --- a/hw/dma/rc4030.c > +++ b/hw/dma/rc4030.c > @@ -32,17 +32,16 @@

Re: [Qemu-devel] [PATCH 03/10] tcg: Push tcg-runtime routines into exec/helper-*

Richard Henderson writes: > Rather than special casing them, use the standard mechanisms > for tcg helper generation. > > Signed-off-by: Richard Henderson > --- > include/exec/helper-gen.h | 1 + > include/exec/helper-head.h | 12 > include/exec/helper-proto.h | 1 + > includ

Re: [Qemu-devel] uvesafb doesn't work with seabios

Am 2014-05-13 07:52, schrieb Bernhard Walle: Hi, * Kevin O'Connor [2014-05-12 22:07]: On Mon, May 12, 2014 at 08:53:53PM +0200, Bernhard Walle wrote: > Am 2014-05-12 07:29, schrieb Kevin O'Connor: > > > >It does look like the x86emu issue. You can try applying the > >SeaVGABIOS patch below to

Re: [Qemu-devel] [PATCH v2 09/16] i82374: Convert conditional compilation of debug printfs to regular ifs

El Tue, 13 May 2014 09:02:45 +0200 Marc Marí escribió: > hw/dma/i82374.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c > index b8ad2e6..7026f24 100644 > --- a/hw/dma/i82374.c > +++ b/hw/dma/i82374.c > @@ -27,14 +27,13 @@

Re: [Qemu-devel] segfault while booting from saved snapshot

On Tue, May 13, 2014 at 2:08 PM, Kevin Wolf wrote: > Am 13.05.2014 um 10:20 hat Shehbaz Jaffer geschrieben: >> Hi, >> >> Could anyone please give me the command to do live-migration to to a >> file? I have tried searching on QEMU Wiki but all the articles that I >> have come across point to snapsh

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

On Tue, 05/13 10:46, Markus Armbruster wrote: > The shell script attempts to suppress core dumps like this: > > old_ulimit=$(ulimit -c) > ulimit -c 0 > $QEMU_IO arg... > ulimit -c "$old_ulimit" > > This breaks the test hard unless the limit was zero to begin with! > ulimit sets bo

[Qemu-devel] [Bug 1315159] Re: Cannot invoke qemu-kvm with spice paramenter renderer

renderer property in spice parameter of qemu don't exists. http://git.qemu.org/?p=qemu.git;a=blob_plain;f=qemu-options.hx;hb=master Look from line "DEF("spice", HAS_ARG, QEMU_OPTION_spice," for all valid parameters. ** Changed in: qemu Status: New => Invalid -- You received this bug noti

Re: [Qemu-devel] [PATCH 04/10] tcg: Use helper-gen.h in tcg-op.h

Richard Henderson writes: > No need to open-code the setup of the builtin helpers. > > Signed-off-by: Richard Henderson > --- > tcg/tcg-op.h | 175 > +-- > 1 file changed, 25 insertions(+), 150 deletions(-) > > diff --git a/tcg/tcg-op.h

Re: [Qemu-devel] usb: usb tablet freeze when save/restore guest os

Signed-off-by: Gonglei --- hw/usb/hcd-uhci.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index 0820244..fe0ad81 100644 --- a/hw/usb/hcd-uhci.c +++ b/hw/usb/hcd-uhci.c @@ -680,6 +680,12 @@ static void uhci_wakeup(USBPort *port1) { UHC

Re: [Qemu-devel] [PATCH 05/10] tcg: Inline tcg_gen_helperN

Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > include/exec/helper-gen.h | 12 ++-- > tcg/tcg-op.h | 7 --- > 2 files changed, 6 insertions(+), 13 deletions(-) > > diff --git a/include/exec/helper-gen.h b/include/exec/

Re: [Qemu-devel] [PATCH 07/10] tcg: Register the helper info struct rather than the name

Richard Henderson writes: > This will let us find all the info from the hash table. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > tcg/tcg.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/tcg/tcg.c b/tcg/tcg.c > index b64471f..3bbf982 1

[Qemu-devel] [PATCH v2] usb: fix up post load checks

Correct post load checks: 1. dev->setup_len == sizeof(dev->data_buf) seems fine, no need to fail migration 2. When state is DATA, passing index > len will cause memcpy with negative length, resulting in heap overflow First of the issues was reported by dgilbert. Reported-by: "Dr. David

Re: [Qemu-devel] [PATCH 08/10] tcg: Save flags and computed sizemask in TCGHelperInfo

Richard Henderson writes: > Signed-off-by: Richard Henderson > --- > +#define DEF_HELPER_FLAGS_0(NAME, FLAGS, ret) \ > + { .func = HELPER(NAME), .name = #NAME, .flags = FLAGS, \ > +.sizemask = dh_sizemask(ret, 0) }, > + > +#define DEF_HELPER_FLAGS_1(NAME, FLAGS, ret, t1) \ > + { .func =

Re: [Qemu-devel] [PATCH v2 08/16] tpm: Convert conditional compilation of debug printfs to regular ifs

El Tue, 13 May 2014 09:02:44 +0200 Marc Marí escribió: > diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c > index 6f0a4d2..302f2bf 100644 > --- a/hw/tpm/tpm_tis.c > +++ b/hw/tpm/tpm_tis.c > @@ -30,16 +30,16 @@ > #include "qemu-common.h" > #include "qemu/main-loop.h" > > -/*#define DEBUG_TIS */

Re: [Qemu-devel] [PATCH 10/10] tcg: Move size effects out of dh_arg

Richard Henderson writes: > Tidying the initialization of the args arrays at the same time. > > Signed-off-by: Richard Henderson > --- > include/exec/helper-gen.h | 87 > -- > include/exec/helper-head.h | 2 +- > 2 files changed, 39 insertions(+),

Re: [Qemu-devel] [PATCH] usb: fix up post load checks

Hi, > And SETUP_STATE_PARAM? Shortcut for small control transfers on xhci. Doesn't go through the idle -> setup -> data -> ack state engine. security-wise: you can't go from 'param' to 'data' without 'setup' inbetween. beside that index should still be zero at the point where len is modifie

[Qemu-devel] Undefined error for curl_multi_socket_action

After rebasing my code with the master branch, i have started getting error for this method "curl_multi_socket_action". In the file blocl/curl.c I can see function call for this method without NEED_CURL_TIMER_CALLBACK directive check also. Is this is know issue, and what i can do to get rid of it

Re: [Qemu-devel] [PATCH v2 05/16] xilinx: Convert conditional compilation of debug printfs to regular ifs

El Tue, 13 May 2014 09:02:41 +0200 Marc Marí escribió: > Modify debug macros to have the same format through the codebase and > use regular ifs instead of ifdef. > > As the debug printf is always put in code, some casting had to be > added to avoid warnings treated as errors at compile time. > >

Re: [Qemu-devel] [PATCH] kvm: make one_reg helpers available for everyone

On 09.05.14 10:06, Cornelia Huck wrote: s390x introduced helper functions for getting/setting one_regs with commit 860643bc. However, nothing about these is s390-specific. Alexey Kardashevskiy had already posted a general version, so let's merge the two patches and massage the code a bit. CC:

Re: [Qemu-devel] [PATCH v2 04/16] highbank: Convert conditional compilation of debug printfs to regular ifs

El Tue, 13 May 2014 09:02:40 +0200 Marc Marí escribió: > Modify debug macros to have the same format through the codebase and > use regular ifs instead of ifdef. > > As the debug printf is always put in code, some casting had to be > added to avoid warnings treated as errors at compile time. > >

[Qemu-devel] [RFC 1/3] using CPUMASK bitmaps to calculate cpu index

instead of seeking the number of CPUs, using CPUMASK bitmaps to calculate the cpu index, also would be a gread benefit to remove cpu index. Signed-off-by: Chen Fan --- exec.c | 9 - include/qom/cpu.h | 9 + include/sysemu/sysemu.h | 7 --- 3 files chang

[Qemu-devel] [RFC 0/3] cpu: add device_add foo-x86_64-cpu support

this patches tried to make cpu hotplug with device_add, and made -device foo-x86_64-cpu available，also we can set apic-id property with command line, if without setting apic-id property, we added first unoccupied apic id as the default new apic id. and hotplug cpu with device_add, we must make che

[Qemu-devel] [RFC 2/3] cpu: introduce CpuTopoInfo structure for argument simplification

Signed-off-by: Chen Fan Reviewed-by: Eduardo Habkost --- target-i386/topology.h | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/target-i386/topology.h b/target-i386/topology.h index 07a6c5f..e9ff89c 100644 --- a/target-i386/topology.h +++ b

[Qemu-devel] [RFC 3/3] cpu: add device_add foo-x86_64-cpu support

In order to implement adding cpu with device_add, we should make the check of APIC ID after object_init(), so add UserCreatable complete method for checking APIC ID availability, and introduce cpu_physid_mask for saving occupied APIC ID, then we could use -device foo-x86_64-cpu without setting apic

Re: [Qemu-devel] KVM call agenda for 2014-05-13

Am 12.05.2014 13:09, schrieb Peter Maydell: > On 12 May 2014 11:30, Peter Crosthwaite wrote: >> On Mon, May 12, 2014 at 7:44 PM, Peter Maydell >> wrote: >>> On 12 May 2014 10:10, Juan Quintela wrote: Please, send any topic that you are interested in covering. - QOMifying both Mem

Re: [Qemu-devel] [PATCH memory v1 1/1] memory: Simplify mr_add_subregion() if-else

Il 12/05/2014 10:13, Peter Crosthwaite ha scritto: This if else is not needed. The previous call to memory_region_add (whether _overlap or not) will always set priority and may_overlap to desired values. And its not possible to get here without having called memory_region_add_subregion due to the

Re: [Qemu-devel] [PULL 0/8] KVM changes for 2014-05-08

On Sat, 10 May 2014 08:50:44 +0200 Paolo Bonzini wrote: > The following changes since commit 3a87f8b6859e6221b827ab4737779dddb37553ec: > > Merge remote-tracking branch 'remotes/afaerber/tags/ppc-for-2.0' into > staging (2014-03-20 11:45:38 +) > > are available in the git repository at: >

Re: [Qemu-devel] KVM call agenda for 2014-05-13

On Tuesday, May 13, 2014, Andreas Färber wrote: > Am 12.05.2014 13:09, schrieb Peter Maydell: > > On 12 May 2014 11:30, Peter Crosthwaite > > > > wrote: > >> On Mon, May 12, 2014 at 7:44 PM, Peter Maydell < > [email protected] > wrote: > >>> On 12 May 2014 10:10, Juan Quintela > > wrote:

Re: [Qemu-devel] [PULL 00/17] Block patches

On 9 May 2014 20:03, Stefan Hajnoczi wrote: > The following changes since commit 43cbeffb19877c62cbe0aaf08b2f235d98d71340: > > Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' > into staging (2014-05-08 12:38:01 +0100) > > are available in the git repository at: > > >

Re: [Qemu-devel] KVM call agenda for 2014-05-13

On 13 May 2014 00:27, Peter Crosthwaite wrote: > Ok so here's my plan: This generally all sounds good to me. A slight nit: > QOMify address spaces. So they can be instantiated, reffed etc. > completely aside from the hotplug discussion this greatly helps > connecting bus master devices using pro

Re: [Qemu-devel] [PATCH v4] libxl: add basic spice support for pv domUs

Il 13/05/2014 11:50, Ian Campbell ha scritto: On Tue, 2014-05-13 at 10:00 +0200, Fabio Fantoni wrote: But: Does spice already require a VFB? In which case the existing handing of that will suffice. I think I'm probably confused about something: Does this patch enable/expose SPICE to the guest?

Re: [Qemu-devel] [PATCH 0/4] Support more than 255 cpus

On 2014-05-13 09:09, Li, Zhen-Hua wrote: > From: "Li, ZhenHua" > > These series patches are trying to make Qemu support more than 255 CPUs. > The max cpu number changed to 4096. > > Support more than 255 cpus: ACPI and APIC defines > Support more than 255 cpus: max_cpus to 4096 > Support mor

Re: [Qemu-devel] [PATCH v4] libxl: add basic spice support for pv domUs

On Tue, 2014-05-13 at 12:51 +0200, Fabio Fantoni wrote: > Il 13/05/2014 11:50, Ian Campbell ha scritto: > > On Tue, 2014-05-13 at 10:00 +0200, Fabio Fantoni wrote: > >>> But: Does spice already require a VFB? In which case the existing > >>> handing of that will suffice. > >>> > >>> I think I'm pro

Re: [Qemu-devel] KVM call agenda for 2014-05-13

On Tuesday, May 13, 2014, Peter Maydell wrote: > On 13 May 2014 00:27, Peter Crosthwaite > > > wrote: > > Ok so here's my plan: > > This generally all sounds good to me. A slight nit: > > > QOMify address spaces. So they can be instantiated, reffed etc. > > completely aside from the hotplug disc

Re: [Qemu-devel] [PULL 0/8] KVM changes for 2014-05-08

Il 13/05/2014 12:31, Cornelia Huck ha scritto: On Sat, 10 May 2014 08:50:44 +0200 Paolo Bonzini wrote: The following changes since commit 3a87f8b6859e6221b827ab4737779dddb37553ec: Merge remote-tracking branch 'remotes/afaerber/tags/ppc-for-2.0' into staging (2014-03-20 11:45:38 +) are

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

Fam Zheng writes: > On Tue, 05/13 10:46, Markus Armbruster wrote: >> The shell script attempts to suppress core dumps like this: >> >> old_ulimit=$(ulimit -c) >> ulimit -c 0 >> $QEMU_IO arg... >> ulimit -c "$old_ulimit" >> >> This breaks the test hard unless the limit was zero t

Re: [Qemu-devel] KVM call agenda for 2014-05-13

On 13 May 2014 12:07, Peter Crosthwaite wrote: > On Tuesday, May 13, 2014, Peter Maydell wrote: >> I'm not sure that the thing a bus master exposes to be connected >> up should be an AddressSpace -- I think it should be a MemoryRegion >> (more precisely, the code creating the bus-master should cr

Re: [Qemu-devel] [PULL 00/10] Build system changes for 2014-05-09

On 9 May 2014 22:03, Paolo Bonzini wrote: > The following changes since commit 6b342cc9c872e82620fdd32730cd92affa8a19b3: > > Merge remote-tracking branch 'remotes/spice/tags/pull-spice-7' into staging > (2014-05-08 10:57:25 +0100) > > are available in the git repository at: > > > git://github

Re: [Qemu-devel] [PATCH] virtio: allow mapping up to max queue size

On Mon, May 12, 2014 at 12:08:21PM +0300, Michael S. Tsirkin wrote: > It's a loop from i < num_sg and the array is VIRTQUEUE_MAX_SIZE - so > it's OK if the value read is VIRTQUEUE_MAX_SIZE. > > Not a big problem in practice as people don't use > such big queues, but it's inelegant. > > Reported-

Re: [Qemu-devel] [PATCHv4] block: optimize zero writes with bdrv_write_zeroes

On 12.05.2014 22:28, Eric Blake wrote: On 05/08/2014 10:22 AM, Peter Lieven wrote: this patch tries to optimize zero write requests by automatically using bdrv_write_zeroes if it is supported by the format. This significantly speeds up file system initialization and should speed zero write test

  1   2   3   4   >