Re: [Qemu-devel] [PATCH 06/13] target-ppc: implement stxvll instructions

2016-12-05 Thread Nikunj A Dadhania
Richard Henderson writes: > On 12/05/2016 03:25 AM, Nikunj A Dadhania wrote: >> +getVSR(xt_num, , env); >> +if (msr_le) { >> +for (i = 0; i < end; i++) { >> +cpu_stb_data_ra(env, addr, xt.u8[i], GETPC()); >> +addr = addr_add(env, addr,

Re: [Qemu-devel] [Spice-devel] Postcopy+spice crash

2016-12-05 Thread Gerd Hoffmann
Hi, > >> On a quick glance I'd blame the guest for sending corrupted commands. > >> Strange though that it happens on migration only, so there could be > >> a host issue too. Or a timing issue triggered by migration. > >> > >> Which migration phase? > > > > This is the point at which it

Re: [Qemu-devel] [PATCH 03/13] target-ppc: implement lxvl instruction

2016-12-05 Thread Nikunj A Dadhania
Richard Henderson writes: > On 12/05/2016 03:25 AM, Nikunj A Dadhania wrote: >> lxvl: Load VSX Vector with Length >> >> Little/Big-endian Storage: >> +---+---+---+---+---+---+---+---+---+---+---+---+---+---+--+--+ >> |“T”|“h”|“i”|“s”|“ ”|“i”|“s”|“ ”|“a”|“

Re: [Qemu-devel] [PATCH ppc-for-2.9 00/13] POWER9 TCG enablements - part9

2016-12-05 Thread David Gibson
On Mon, Dec 05, 2016 at 04:55:17PM +0530, Nikunj A Dadhania wrote: > This series contains 12 new instructions for POWER9 ISA3.0 > Couple of consolidation patches > VSX Vector Insert/Extract Word > VSX Vector Permute > VSX Load/Store with length > VSX Scalar Quad-Precision

Re: [Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications

2016-12-05 Thread Lan Tianyu
On 2016年12月02日 14:52, Peter Xu wrote: > On Thu, Dec 01, 2016 at 02:44:14PM +0800, Lan Tianyu wrote: > > [...] > >> Hi: >> I think there are still other gaps to enable passthough device with >> vIOMMU's DMA translation support. >> >> 1. Since this patchset is to shadow guest IO page table to >>

Re: [Qemu-devel] [PATCH for-2.9 v2 0/2] cryptodev: support xts(aes) algorithm

2016-12-05 Thread Gonglei
On 2016/12/5 19:39, Longpeng(Mike) wrote: > This patchset firstly fix a bug in cryptodev_builtin_get_aes_algo, and > then add xts(aes) algorithm support. > > --- > Changes since v1: > - change macro's defination. [Arei] > > --- > Longpeng(Mike) (2): > cryptodev: fix the check of aes

Re: [Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications

2016-12-05 Thread Peter Xu
On Tue, Dec 06, 2016 at 03:06:20PM +0800, Lan Tianyu wrote: > On 2016年12月06日 14:51, Peter Xu wrote: > > On Tue, Dec 06, 2016 at 02:30:24PM +0800, Lan Tianyu wrote: > > > > [...] > > > 2. How to restore GPA->HPA mapping when IOVA is disabled by guest. > When guest enables IOVA for

Re: [Qemu-devel] [PATCH 1/1] vfio iommu type1: set size to PAGE_SIZE while looking for iova in dma list

2016-12-05 Thread Kirti Wankhede
On 12/6/2016 4:24 AM, Alex Williamson wrote: > On Tue, 6 Dec 2016 02:38:01 +0530 > Kirti Wankhede wrote: > >> In the functions of pin_pages/unpin_pages from mdev vendor driver, >> vfio_find_dma() should be called with size as PAGE_SIZE instead of 0. >> vfio_find_dma()

Re: [Qemu-devel] [PATCH kernel v5 5/5] virtio-balloon: tell host vm's unused page info

2016-12-05 Thread Li, Liang Z
> >>> + mutex_lock(>balloon_lock); > >>> + > >>> + for (order = MAX_ORDER - 1; order >= 0; order--) { > >> > >> I scratched my head for a bit on this one. Why are you walking over > >> orders, > >> *then* zones. I *think* you're doing it because you can efficiently > >> fill the bitmaps at a

Re: [Qemu-devel] [PATCH 02/13] target-ppc: add mask_u128 routine

2016-12-05 Thread Nikunj A Dadhania
Richard Henderson writes: > On 12/05/2016 03:25 AM, Nikunj A Dadhania wrote: >> +#if defined(CONFIG_INT128) >> +FUNC_MASK(mask_u128, Int128, 128, Int128, ~((__uint128_t)0)); >> +#else >> +static inline Int128 mask_u128(int start, int end) >> +{ >> +Int128 r = {0}; >> +

Re: [Qemu-devel] [PATCH 04/13] target-ppc: implement lxvll instruction

2016-12-05 Thread Nikunj A Dadhania
Richard Henderson writes: > On 12/05/2016 03:25 AM, Nikunj A Dadhania wrote: >> +void helper_lxvll(CPUPPCState *env, target_ulong addr, >> + target_ulong xt_num, target_ulong rb) >> +{ >> +ppc_vsr_t xt; >> + >> +getVSR(xt_num, , env); >> +if

Re: [Qemu-devel] [PATCH 05/13] target-ppc: implement stxvl instruction

2016-12-05 Thread Nikunj A Dadhania
Richard Henderson writes: > On 12/05/2016 03:25 AM, Nikunj A Dadhania wrote: >> +for (i = 15; i > 15 - end; i--) { >> +cpu_stb_data_ra(env, addr, xt.u8[i], GETPC()); >> +addr = addr_add(env, addr, 1); >> +} > > (1) you need to handle nb > 16. Sure will

Re: [Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications

2016-12-05 Thread Peter Xu
On Tue, Dec 06, 2016 at 02:30:24PM +0800, Lan Tianyu wrote: [...] > >> 2. How to restore GPA->HPA mapping when IOVA is disabled by guest. > >> When guest enables IOVA for device, vIOMMU will invalidate all previous > >> GPA->HPA mapping and update IOVA->HPA mapping to pIOMMU via iommu > >>

Re: [Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications

2016-12-05 Thread Lan Tianyu
On 2016年12月06日 14:51, Peter Xu wrote: > On Tue, Dec 06, 2016 at 02:30:24PM +0800, Lan Tianyu wrote: > > [...] > 2. How to restore GPA->HPA mapping when IOVA is disabled by guest. When guest enables IOVA for device, vIOMMU will invalidate all previous GPA->HPA mapping and update

[Qemu-devel] [PULL 3/3] fsl_etsec: Fix various small problems in hexdump code

2016-12-05 Thread Jason Wang
From: Andrey Smirnov Fix various small problems in hexdump code, such as: - Reference to non-existing field etsec->nic->nc.name is replaced with nc->name - Type mismatch warnings Signed-off-by: Andrey Smirnov Signed-off-by: Jason

Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/2] less confusing block file names

2016-12-05 Thread Stefan Hajnoczi
On Fri, Dec 02, 2016 at 01:48:52PM -0600, Eric Blake wrote: > no real change from v2 other than trivial rebasing and R-by: > https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07220.html > > but it's been more than a month since the last activity, and the > start of the release cycle is as

Re: [Qemu-devel] [PULL 0/3] Net patches

2016-12-05 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 0/3] Net patches Type: series Message-id: 1480931523-5769-1-git-send-email-jasow...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

[Qemu-devel] [PATCH] tests: Ignore test-char binary

2016-12-05 Thread Lin Ma
Commit ea3af47d added test for chardev unit tests, but didn't add the name of generated binary in .gitignore. Signed-off-by: Lin Ma --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index c0d7857..99f2aac 100644 ---

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.8] qcow2: Don't strand clusters near 2G intervals during commit

2016-12-05 Thread Stefan Hajnoczi
On Sat, Dec 03, 2016 at 11:34:02AM -0600, Eric Blake wrote: > The qcow2_make_empty() function is reached during 'qemu-img commit', > in order to clear out ALL clusters of an image. However, if the > image cannot use the fast code path (true if the image is format > 0.10, or if the image contains

Re: [Qemu-devel] [PATCH] net: virtio-net: initialise local 'netcfg' variable

2016-12-05 Thread P J P
Hello Jason, +-- On Mon, 5 Dec 2016, Jason Wang wrote --+ | See feature_sizes[] in virtio-net.c, we won't expose mtu to guest until MTU | feature were negotiated. Oh, it updates config size without the 'mtu' field during realise, okay. Still IMO having an initialiser({}) is better. But

[Qemu-devel] [PULL 1/4] qxl: Only emit QXL_INTERRUPT_CLIENT_MONITORS_CONFIG on config changes

2016-12-05 Thread Gerd Hoffmann
From: Christophe Fergeau Currently if the client keeps sending the same monitor config to QEMU/spice-server, QEMU will always raise a QXL_INTERRUPT_CLIENT_MONITORS_CONFIG regardless of whether there was a change or not. Guest-side (with fedora 25), the kernel QXL KMS driver

[Qemu-devel] [PULL for-2.8 0/4] vga fixes

2016-12-05 Thread Gerd Hoffmann
repository at: git://git.kraxel.org/qemu tags/pull-vga-20161205-1 for you to fetch changes up to 4299b90e9ba9ce5ca9024572804ba751aa1a7e70: display: cirrus: check vga bits per pixel(bpp) value (2016-12-05 11:01:55 +0100) qxl: fix

Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support

2016-12-05 Thread Longpeng (Mike)
Hi Daniel, On 2016/12/5 17:18, Daniel P. Berrange wrote: > On Mon, Dec 05, 2016 at 04:59:38PM +0800, Longpeng(Mike) wrote: .. >> diff --git a/qapi/crypto.json b/qapi/crypto.json >> index 5c9d7d4..d403ab9 100644 >> --- a/qapi/crypto.json >> +++ b/qapi/crypto.json >> @@ -75,7 +75,7 @@ >> {

[Qemu-devel] [PATCH 03/13] target-ppc: implement lxvl instruction

2016-12-05 Thread Nikunj A Dadhania
lxvl: Load VSX Vector with Length Little/Big-endian Storage: +---+---+---+---+---+---+---+---+---+---+---+---+---+---+--+--+ |“T”|“h”|“i”|“s”|“ ”|“i”|“s”|“ ”|“a”|“ ”|“T”|“E”|“S”|“T”|FF|FF| +---+---+---+---+---+---+---+---+---+---+---+---+---+---+--+--+ Loading 14 bytes results in: Vector (8-bit

[Qemu-devel] [PATCH 07/13] target-ppc: implement xxextractuw instruction

2016-12-05 Thread Nikunj A Dadhania
xxextractuw: VSX Vector Extract Unsigned Word Signed-off-by: Nikunj A Dadhania --- target-ppc/helper.h | 1 + target-ppc/int_helper.c | 33 + target-ppc/translate/vsx-impl.inc.c | 22 ++

[Qemu-devel] [PATCH 06/13] target-ppc: implement stxvll instructions

2016-12-05 Thread Nikunj A Dadhania
stxvll: Store VSX Vector Left-justified with Length Vector (8-bit elements) in LE/BE: +---+---+---+---+---+---+---+---+---+---+---+---+---+---+--+--+ |“T”|“h”|“i”|“s”|“ ”|“i”|“s”|“ ”|“a”|“ ”|“T”|“E”|“S”|“T”|00|00| +---+---+---+---+---+---+---+---+---+---+---+---+---+---+--+--+ Storing 14 bytes

[Qemu-devel] [PATCH 10/13] target-ppc: implement xsabsqp/xsnabsqp instruction

2016-12-05 Thread Nikunj A Dadhania
xsabsqp: VSX Scalar Absolute Quad-Precision xsnabsqp: VSX Scalar Negative Absolute Quad-Precision Signed-off-by: Nikunj A Dadhania --- target-ppc/translate/vsx-impl.inc.c | 35 +++ target-ppc/translate/vsx-ops.inc.c | 5 + 2

[Qemu-devel] [PATCH for-2.9 v2 2/2] cryptodev: add xts(aes) support

2016-12-05 Thread Longpeng(Mike)
This patch add xts(aes) support. Signed-off-by: Longpeng(Mike) Reviewed-by: Gonglei --- backends/cryptodev-builtin.c | 8 1 file changed, 8 insertions(+) diff --git a/backends/cryptodev-builtin.c b/backends/cryptodev-builtin.c index

[Qemu-devel] [PATCH for-2.9 v2 1/2] cryptodev: fix the check of aes algorithm

2016-12-05 Thread Longpeng(Mike)
As the key length of xts(aes) is different with other mode of aes, so we should check specially in cryptodev_builtin_get_aes_algo, if it is xts mode. Signed-off-by: Longpeng(Mike) --- backends/cryptodev-builtin.c | 47 +++- 1 file

Re: [Qemu-devel] a suggestion to extend the query block stats commands for multi-disk case

2016-12-05 Thread Paolo Bonzini
On 05/12/2016 12:53, Stefan Hajnoczi wrote: > Adding the BlockBackend *query_blk parameter is a reasonable short-term > workaround. I wonder if the polling stats APIs need to be rethought in > the longer term. > > Regarding the low-level details of block statistics inside QEMU, we can >

[Qemu-devel] [PULL 2/3] fsl_etsec: Pad short payloads with zeros

2016-12-05 Thread Jason Wang
From: Andrey Smirnov Depending on QEMU network setup it is possible for us to receive a complete Ethernet packet that is less 64 bytes long. One such example is when QEMU is configured to use a standalone TAP device (not set to be a part of any bridge) receives and ARP

Re: [Qemu-devel] [PATCH v4 04/13] virtio: poll virtqueues for new buffers

2016-12-05 Thread Stefan Hajnoczi
On Mon, Dec 05, 2016 at 08:54:59AM +0800, Fam Zheng wrote: > On Thu, 12/01 19:26, Stefan Hajnoczi wrote: > > Add an AioContext poll handler to detect new virtqueue buffers without > > waiting for a guest->host notification. > > > > Signed-off-by: Stefan Hajnoczi > > --- > >

Re: [Qemu-devel] [PATCH v4 00/13] aio: experimental virtio-blk polling mode

2016-12-05 Thread Fam Zheng
On Thu, 12/01 19:26, Stefan Hajnoczi wrote: > One way to avoid the costly exit is to use polling instead of notification. Testing with fio on virtio-blk backed by NVMe device, I can see significant performance improvement with this series: poll-max-nsiodepth=1iodepth=32

Re: [Qemu-devel] [RFC] target-ppc/fpu_helper.c: Use C99 code to speed up floating point unit

2016-12-05 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC] target-ppc/fpu_helper.c: Use C99 code to speed up floating point unit Type: series Message-id: e8b64b53-09f0-4b1e-9f11-48cc3957c...@gmail.com === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PULL 0/4] target-mips queue

2016-12-05 Thread Stefan Hajnoczi
On Sun, Dec 04, 2016 at 02:00:13AM +, Yongbok Kim wrote: > Hi, > > This is pull-req for target-mips. > > Regards, > Yongbok > > The following changes since commit bd8ef5060dd2124a54578241da9a572faf7658dd: > > Merge remote-tracking branch 'dgibson/tags/ppc-for-2.8-20161201' into >

Re: [Qemu-devel] New wiki page: http://wiki.qemu.org/Hosts

2016-12-05 Thread Paolo Bonzini
- Original Message - > From: "Peter Maydell" > To: "Paolo Bonzini" > Cc: "Programmingkid" , "qemu-devel qemu-devel" > > Sent: Monday, December 5, 2016 11:57:04 AM > Subject: Re:

Re: [Qemu-devel] [PATCH for-2.8] target-arm/translate-a64: fix gen_load_exclusive

2016-12-05 Thread Alex Bennée
Alex Bennée writes: > While testing rth's latest TCG patches with risu I found ldaxp was > broken. Investigating further I found it was broken by 1dd089d0 when > the cmpxchg atomic work was merged. CC'ing Paolo/Richard Do you guys have any final TCG fixes planned for

Re: [Qemu-devel] [PATCH] nbd: Implement NBD_CMD_HAS_ZERO_INIT

2016-12-05 Thread Stefan Hajnoczi
On Sun, Dec 04, 2016 at 11:44:57PM +, Yi Fang wrote: > NBD client has not implemented callback for .bdrv_has_zero_init. So > bdrv_has_zero_init always returns 0 when doing non-shared storage > migration. > This patch implemented NBD_CMD_HAS_ZERO_INIT and will avoid unnecessary > set-dirty.

Re: [Qemu-devel] [PATCH v4 04/13] virtio: poll virtqueues for new buffers

2016-12-05 Thread Christian Borntraeger
On 12/05/2016 11:14 AM, Stefan Hajnoczi wrote: > On Mon, Dec 05, 2016 at 08:54:59AM +0800, Fam Zheng wrote: >> On Thu, 12/01 19:26, Stefan Hajnoczi wrote: >>> Add an AioContext poll handler to detect new virtqueue buffers without >>> waiting for a guest->host notification. >>> >>> Signed-off-by:

[Qemu-devel] [PATCH 09/13] target-ppc: implement stop instruction

2016-12-05 Thread Nikunj A Dadhania
Use the nap code. Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index f68f427..47349e7 100644 --- a/target-ppc/translate.c +++

[Qemu-devel] [PATCH 08/13] target-ppc: implement xxinsertw instruction

2016-12-05 Thread Nikunj A Dadhania
xxinsertw: VSX Vector Insert Word Signed-off-by: Nikunj A Dadhania --- target-ppc/helper.h | 1 + target-ppc/int_helper.c | 30 ++ target-ppc/translate/vsx-impl.inc.c | 5 +++--

[Qemu-devel] [PATCH 13/13] target-ppc: Add xxperm and xxpermr instructions

2016-12-05 Thread Nikunj A Dadhania
From: Bharata B Rao xxperm: VSX Vector Permute xxpermr: VSX Vector Permute Right-indexed Signed-off-by: Bharata B Rao Signed-off-by: Nikunj A Dadhania --- target-ppc/fpu_helper.c | 50

[Qemu-devel] [PATCH for-2.9 v2 0/2] cryptodev: support xts(aes) algorithm

2016-12-05 Thread Longpeng(Mike)
This patchset firstly fix a bug in cryptodev_builtin_get_aes_algo, and then add xts(aes) algorithm support. --- Changes since v1: - change macro's defination. [Arei] --- Longpeng(Mike) (2): cryptodev: fix the check of aes algorithm cryptodev: add xts(aes) support

[Qemu-devel] [PATCH 11/13] target-ppc: implement xsnegqp instruction

2016-12-05 Thread Nikunj A Dadhania
xsnegqp: VSX Scalar Negate Quad-Precision Signed-off-by: Nikunj A Dadhania --- target-ppc/translate/vsx-impl.inc.c | 5 + target-ppc/translate/vsx-ops.inc.c | 1 + 2 files changed, 6 insertions(+) diff --git a/target-ppc/translate/vsx-impl.inc.c

Re: [Qemu-devel] [PATCH v2] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-05 Thread Laszlo Ersek
On 12/04/16 18:33, Michael S. Tsirkin wrote: > On Fri, Dec 02, 2016 at 10:01:52PM +0100, Laszlo Ersek wrote: >> When passed to git-diff (and to every other git command producing diffs >> and/or diffstats) with "-O" or "diff.orderFile", this list of patterns >> will place the more declarative /

Re: [Qemu-devel] [PATCH v5 7/9] block: don't make snapshots for filters

2016-12-05 Thread Kevin Wolf
Am 05.12.2016 um 08:43 hat Pavel Dovgalyuk geschrieben: > Paolo, > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 21.11.2016 um 13:22 hat Pavel Dovgalyuk geschrieben: > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > Am 16.11.2016 um 10:49 hat Pavel Dovgalyuk geschrieben: > > > >

Re: [Qemu-devel] [PATCH v4 04/13] virtio: poll virtqueues for new buffers

2016-12-05 Thread Paolo Bonzini
- Original Message - > From: "Stefan Hajnoczi" > To: "Fam Zheng" > Cc: "Stefan Hajnoczi" , borntrae...@de.ibm.com, "Karl > Rister" , > qemu-devel@nongnu.org, "Paolo Bonzini" > Sent:

Re: [Qemu-devel] New wiki page: http://wiki.qemu.org/Hosts

2016-12-05 Thread Peter Maydell
On 3 December 2016 at 08:41, Paolo Bonzini wrote: > Since this stuff changes rarely, it should be in the source tree > instead. You can link to the source tree from the wiki with something > like this: > > {{src|path=BUILDING|description=the BUILDING file in the source

[Qemu-devel] [PULL 2/4] virtio-gpu: fix information leak in getting capset info dispatch

2016-12-05 Thread Gerd Hoffmann
From: Li Qiang In virgl_cmd_get_capset_info dispatch function, the 'resp' hasn't been full initialized before writing to the guest. This will leak the 'resp.padding' and 'resp.hdr.padding' fieds to the guest. This patch fix this issue. Signed-off-by: Li Qiang

Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support

2016-12-05 Thread Daniel P. Berrange
On Mon, Dec 05, 2016 at 07:11:37PM +0800, Longpeng (Mike) wrote: > Hi Daniel, > > On 2016/12/5 17:18, Daniel P. Berrange wrote: > > > On Mon, Dec 05, 2016 at 04:59:38PM +0800, Longpeng(Mike) wrote: > .. > >> diff --git a/qapi/crypto.json b/qapi/crypto.json > >> index 5c9d7d4..d403ab9 100644

Re: [Qemu-devel] [PATCH v4 00/13] aio: experimental virtio-blk polling mode

2016-12-05 Thread Christian Borntraeger
On 12/01/2016 08:26 PM, Stefan Hajnoczi wrote: > v4: > * Added poll time self-tuning algorithm [Christian and Paolo] > * Try a single iteration of polling to avoid non-blocking > ppoll(2)/epoll_wait(2) [Paolo] > * Reordered patches to make performance analysis easier - see below This looks

[Qemu-devel] [PATCH 02/13] target-ppc: add mask_u128 routine

2016-12-05 Thread Nikunj A Dadhania
Adjust FUNC_MASK define and add function to generate mask_u128 Signed-off-by: Nikunj A Dadhania --- target-ppc/internal.h | 38 +- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git a/target-ppc/internal.h

[Qemu-devel] [PATCH 01/13] target-ppc: move ppc_vsr_t to common header

2016-12-05 Thread Nikunj A Dadhania
The structure and corresponding defines and functions need to be used outside of fpu_helper.c as well. Add u8, u16, u32 and Int128 to the structure. Signed-off-by: Nikunj A Dadhania --- target-ppc/fpu_helper.c | 37 -

[Qemu-devel] [PATCH ppc-for-2.9 00/13] POWER9 TCG enablements - part9

2016-12-05 Thread Nikunj A Dadhania
This series contains 12 new instructions for POWER9 ISA3.0 Couple of consolidation patches VSX Vector Insert/Extract Word VSX Vector Permute VSX Load/Store with length VSX Scalar Quad-Precision Move Instructions Bharata B Rao (1): target-ppc: Add xxperm and xxpermr

[Qemu-devel] [PATCH 04/13] target-ppc: implement lxvll instruction

2016-12-05 Thread Nikunj A Dadhania
lxvll: Load VSX Vector Left-justified with Length Little/Big-endian Storage: +---+---+---+---+---+---+---+---+---+---+---+---+---+---+--+--+ |“T”|“h”|“i”|“s”|“ ”|“i”|“s”|“ ”|“a”|“ ”|“T”|“E”|“S”|“T”|FF|FF| +---+---+---+---+---+---+---+---+---+---+---+---+---+---+--+--+ Loading 14 bytes to vector

Re: [Qemu-devel] [PATCH] tests: Ignore test-char binary

2016-12-05 Thread Marc-André Lureau
Patch already sent by Changlong Xie, can someone pick it? thanks On Mon, Dec 5, 2016 at 1:53 PM Lin Ma wrote: > Commit ea3af47d added test for chardev unit tests, but didn't add > the name of generated binary in .gitignore. > > Signed-off-by: Lin Ma > --- >

Re: [Qemu-devel] a suggestion to extend the query block stats commands for multi-disk case

2016-12-05 Thread Stefan Hajnoczi
On Mon, Dec 05, 2016 at 04:56:38PM +0800, Dou Liyang wrote: > Hi all, > > Currently, in Qemu, we query the block states by using “info blockstats”. > For each disk, the command calls “bdrv_query_stats” function to get the > info of block states in “qmp_query_blockstats” . > Since commit 13344f3a,

Re: [Qemu-devel] [PATCH for-2.9 24/30] aspeed: use first SPI flash as a boot ROM

2016-12-05 Thread Marcin Krzemiński
2016-12-05 10:36 GMT+01:00 Cédric Le Goater : > Hello Marcin, > > On 12/04/2016 06:00 PM, mar.krzeminski wrote: > > Hi Cedric, > > > > it looks like good idea for now to handle boot from flash. > > As I understand you are trying to omit bootrom code in Qemu model? > > I suppose you

[Qemu-devel] [PULL 3/4] virtio-gpu: fix memory leak in update_cursor_data_virgl

2016-12-05 Thread Gerd Hoffmann
From: Li Qiang In update_cursor_data_virgl function, if the 'width'/ 'height' is not equal to current cursor's width/height it will return without free the 'data' allocated previously. This will lead a memory leak issue. This patch fix this issue. Signed-off-by: Li Qiang

[Qemu-devel] [PULL 4/4] display: cirrus: check vga bits per pixel(bpp) value

2016-12-05 Thread Gerd Hoffmann
From: Prasad J Pandit In Cirrus CLGD 54xx VGA Emulator, if cirrus graphics mode is VGA, 'cirrus_get_bpp' returns zero(0), which could lead to a divide by zero error in while copying pixel data. The same could occur via blit pitch values. Add check to avoid it.

Re: [Qemu-devel] Linux kernel polling for QEMU

2016-12-05 Thread Alex Bennée
Paolo Bonzini writes: > On 30/11/2016 10:46, Peter Maydell wrote: >>> > The problem is indeed with the scheduling. The way it currently works >>> > is to depend on the iothread to kick a reschedule once in a while, or >>> > a cpu to issue an instruction that does so

[Qemu-devel] [PATCH 12/13] target-ppc: implement xscpsgnqp instruction

2016-12-05 Thread Nikunj A Dadhania
xscpsgnqp: VSX Scalar Copy Sign Quad-Precision Signed-off-by: Nikunj A Dadhania --- target-ppc/translate/vsx-impl.inc.c | 12 +++- target-ppc/translate/vsx-ops.inc.c | 1 + 2 files changed, 12 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 05/13] target-ppc: implement stxvl instruction

2016-12-05 Thread Nikunj A Dadhania
stxvl: Store VSX Vector with Length Vector (8-bit elements) in BE: +---+---+---+---+---+---+---+---+---+---+---+---+---+---+--+--+ |“T”|“h”|“i”|“s”|“ ”|“i”|“s”|“ ”|“a”|“ ”|“T”|“E”|“S”|“T”|00|00| +---+---+---+---+---+---+---+---+---+---+---+---+---+---+--+--+ Vector (8-bit elements) in LE:

Re: [Qemu-devel] [PATCH v5 7/9] block: don't make snapshots for filters

2016-12-05 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 05.12.2016 um 08:43 hat Pavel Dovgalyuk geschrieben: > > Paolo, > > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 21.11.2016 um 13:22 hat Pavel Dovgalyuk geschrieben: > > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > > Am

Re: [Qemu-devel] [Spice-devel] Postcopy+spice crash

2016-12-05 Thread Uri Lublin
On 12/05/2016 11:46 AM, Dr. David Alan Gilbert wrote: * Gerd Hoffmann (kra...@redhat.com) wrote: On Fr, 2016-12-02 at 17:44 +, Dr. David Alan Gilbert wrote: Hi Gerd, I've got a moderately repeatable crash with spice playing a video + postcopy. Some of the time I just get a warning (that

Re: [Qemu-devel] [PATCH v4 01/64] tcg: Add field extraction primitives

2016-12-05 Thread Alex Bennée
Richard Henderson writes: > Adds tcg_gen_extract_* and tcg_gen_sextract_* for extraction of > fixed position bitfields, much like we already have for deposit. > > Signed-off-by: Richard Henderson > --- > tcg/README | 20 ++- >

Re: [Qemu-devel] [PATCH v5 7/9] block: don't make snapshots for filters

2016-12-05 Thread Kevin Wolf
Am 05.12.2016 um 12:49 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 05.12.2016 um 08:43 hat Pavel Dovgalyuk geschrieben: > > > Paolo, > > > > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > Am 21.11.2016 um 13:22 hat Pavel Dovgalyuk geschrieben: >

[Qemu-devel] Meeting notes on -blockdev, dynamic backend reconfiguration

2016-12-05 Thread Markus Armbruster
I recently met Kevin, and we discussed two block layer topics in some depth. = -blockdev = We want a command line option to mirror QMP blockdev-add for 2.9. QemuOpts has to grow from "list of (key, simple value) plus conventions to support lists of simple values in limited ways" to the

Re: [Qemu-devel] [PATCH v4 02/64] tcg: Minor adjustments to deposit expanders

2016-12-05 Thread Alex Bennée
Richard Henderson writes: > Assert that len is not 0. > > Since we have asserted that ofs + len <= N, a later > check for len == N implies that ofs == 0. > > Signed-off-by: Richard Henderson > --- > tcg/tcg-op.c | 6 -- > 1 file changed, 4

Re: [Qemu-devel] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-12-05 Thread Vladimir Sementsov-Ogievskiy
02.12.2016 23:39, John Snow wrote: On 12/02/2016 01:45 PM, Alex Bligh wrote: John, +Some storage formats and operations over such formats express a +concept of data dirtiness. Whether the operation is block device +mirroring, incremental block device backup or any other operation with +a

[Qemu-devel] [PATCH RFC v2 0/6] COLO block replication supports shared disk case

2016-12-05 Thread zhanghailiang
COLO block replication doesn't support the shared disk case, Here we try to implement it. For the detail of shared-disk scenario, please refer to patch 1. COLO codes with shared-disk block replication can be found from the link:

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/7] target-ppc: Implement unsigned quadword left/right shift and unit tests

2016-12-05 Thread joserz
On Mon, Dec 05, 2016 at 12:56:39PM +1100, David Gibson wrote: > On Sat, Dec 03, 2016 at 05:37:27PM -0800, Richard Henderson wrote: > > On 12/02/2016 09:00 PM, Jose Ricardo Ziviani wrote: > > > +++ b/include/qemu/host-utils.h > > > @@ -29,6 +29,33 @@ > > > #include "qemu/bswap.h" > > > > > >

[Qemu-devel] [PULL 1/3] net: mcf: check receive buffer size register value

2016-12-05 Thread Jason Wang
From: Prasad J Pandit ColdFire Fast Ethernet Controller uses a receive buffer size register(EMRBR) to hold maximum size of all receive buffers. It is set by a user before any operation. If it was set to be zero, ColdFire emulator would go into an infinite loop while

[Qemu-devel] [PULL 0/3] Net patches

2016-12-05 Thread Jason Wang
The following changes since commit bd8ef5060dd2124a54578241da9a572faf7658dd: Merge remote-tracking branch 'dgibson/tags/ppc-for-2.8-20161201' into staging (2016-12-01 13:39:29 +) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you

[Qemu-devel] [PATCH RFC v2 6/6] nbd/replication: implement .bdrv_get_info() for nbd and replication driver

2016-12-05 Thread zhanghailiang
Without this callback, there will be an error reports in the primary side: "qemu-system-x86_64: Couldn't determine the cluster size of the target image, which has no backing file: Operation not supported Aborting, since this may create an unusable destination image" For nbd driver, it doesn't

[Qemu-devel] [PATCH for-2.9 2/3] cryptodev: switch to standard des

2016-12-05 Thread Longpeng(Mike)
The cryptodev use DES-RFB for ecb(des) currently, we should use standard DES for cryptodev instead. Signed-off-by: Longpeng(Mike) --- backends/cryptodev-builtin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backends/cryptodev-builtin.c

[Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support

2016-12-05 Thread Longpeng(Mike)
This patch add standart DES support. Signed-off-by: Longpeng(Mike) --- crypto/cipher-gcrypt.c | 3 +++ crypto/cipher-nettle.c | 13 ++--- crypto/cipher.c| 5 - qapi/crypto.json | 2 +- 4 files changed, 18 insertions(+), 5 deletions(-) diff

[Qemu-devel] [PATCH for-2.9 3/3] tests: crypto: add testcase for standard des(ecb)

2016-12-05 Thread Longpeng(Mike)
As we have added standart DES support when using gcrypt/nettle, so this patch add a testcase for standard ecb(des). Note: the data is copied from linux-kernel's tcrypt module. Signed-off-by: Longpeng(Mike) --- tests/test-crypto-cipher.c | 11 +++ 1 file changed,

Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support

2016-12-05 Thread Daniel P. Berrange
On Mon, Dec 05, 2016 at 04:59:38PM +0800, Longpeng(Mike) wrote: > This patch add standart DES support. > > Signed-off-by: Longpeng(Mike) > --- > crypto/cipher-gcrypt.c | 3 +++ > crypto/cipher-nettle.c | 13 ++--- > crypto/cipher.c| 5 - >

Re: [Qemu-devel] [PATCH for-2.9 2/3] cryptodev: switch to standard des

2016-12-05 Thread Daniel P. Berrange
On Mon, Dec 05, 2016 at 04:59:39PM +0800, Longpeng(Mike) wrote: > The cryptodev use DES-RFB for ecb(des) currently, we should use > standard DES for cryptodev instead. > > Signed-off-by: Longpeng(Mike) > --- > backends/cryptodev-builtin.c | 2 +- > 1 file changed, 1

Re: [Qemu-devel] [PATCH for-2.9 3/3] tests: crypto: add testcase for standard des(ecb)

2016-12-05 Thread Longpeng (Mike)
Hi Daniel, On 2016/12/5 17:24, Daniel P. Berrange wrote: > On Mon, Dec 05, 2016 at 04:59:40PM +0800, Longpeng(Mike) wrote: .. >> { >> +.path = "/crypto/cipher/des-ecb", >> +.alg = QCRYPTO_CIPHER_ALG_DES, >> +.mode = QCRYPTO_CIPHER_MODE_ECB, >> +.key = >>

Re: [Qemu-devel] [RFC PATCH] glusterfs: allow partial reads

2016-12-05 Thread Wolfgang Bumiller
On Fri, Dec 02, 2016 at 01:13:28PM -0600, Eric Blake wrote: > On 12/01/2016 04:59 AM, Wolfgang Bumiller wrote: > > Fixes #1644754. > > > > Signed-off-by: Wolfgang Bumiller > > --- > > I'm not sure what the original rationale was to treat both partial > > reads as well as

[Qemu-devel] [PATCH RFC v2 3/6] replication: Split out backup_do_checkpoint() from secondary_do_checkpoint()

2016-12-05 Thread zhanghailiang
The helper backup_do_checkpoint() will be used for primary related codes. Here we split it out from secondary_do_checkpoint(). Besides, it is unnecessary to call backup_do_checkpoint() in replication starting and normally stop replication path. We only need call it while do real checkpointing.

[Qemu-devel] [PATCH RFC v2 5/6] replication: Implement block replication for shared disk case

2016-12-05 Thread zhanghailiang
Just as the scenario of non-shared disk block replication, we are going to implement block replication from many basic blocks that are already in QEMU. The architecture is: virtio-blk || .-- /

[Qemu-devel] a suggestion to extend the query block stats commands for multi-disk case

2016-12-05 Thread Dou Liyang
Hi all, Currently, in Qemu, we query the block states by using “info blockstats”. For each disk, the command calls “bdrv_query_stats” function to get the info of block states in “qmp_query_blockstats” . Since commit 13344f3a, Stefan added mutex to ensures that the dataplane IOThread and the main

[Qemu-devel] [PATCH for-2.9 0/3] crypto: add standard des support

2016-12-05 Thread Longpeng(Mike)
This patchset add standard DES support when using gcrypt/nettle. Qemu only support DES-RFB which is used by vnc-auth currently, however gcrypt/nettle library support standard DES in actually, what's more, due to the virtio-crypto has been supportted, the guest can use various cipher-algo

Re: [Qemu-devel] New wiki page: http://wiki.qemu.org/Hosts

2016-12-05 Thread Paolo Bonzini
> On Dec 3, 2016, at 3:41 AM, Paolo Bonzini wrote: > > On 02/12/2016 23:59, Programmingkid wrote: > >> I thought we could use a Hosts page to sort all the host documentation we > >> have. It is located here: http://wiki.qemu.org/Hosts > >> > >> Here is what I have so far: > >> > >> AIX > >>

Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support

2016-12-05 Thread Gonglei (Arei)
> > > switch (alg) { > > +case QCRYPTO_CIPHER_ALG_DES: > > case QCRYPTO_CIPHER_ALG_DES_RFB: > > case QCRYPTO_CIPHER_ALG_AES_128: > > case QCRYPTO_CIPHER_ALG_AES_192: > > @@ -256,11 +257,17 @@ QCryptoCipher > *qcrypto_cipher_new(QCryptoCipherAlgorithm alg, > > ctx =

Re: [Qemu-devel] [PATCH for-2.9 2/2] cryptodev: add xts(aes) support

2016-12-05 Thread Gonglei (Arei)
> -Original Message- > From: longpeng > Sent: Monday, December 05, 2016 3:44 PM > To: Gonglei (Arei) > Cc: longpeng; qemu-devel@nongnu.org; Wubin (H); Zhoujian (jay, Euler) > Subject: [PATCH for-2.9 2/2] cryptodev: add xts(aes) support > > This patch add xts(aes) support. > >

Re: [Qemu-devel] [PATCH v5 00/10] tcg mips64 and mips r6 improvements

2016-12-05 Thread Jin Guojie
-- Original -- From: "Richard Henderson";; Send time: Thursday, Dec 1, 2016 11:52 PM To: "Jin Guojie"; "qemu-devel"; Cc: "Aurelien Jarno"; "James Hogan";

Re: [Qemu-devel] [PATCH for-2.9 1/2] cryptodev: fix the check of aes algorithm

2016-12-05 Thread Gonglei (Arei)
> -Original Message- > From: longpeng > Sent: Monday, December 05, 2016 3:44 PM > To: Gonglei (Arei) > Cc: longpeng; qemu-devel@nongnu.org; Wubin (H); Zhoujian (jay, Euler) > Subject: [PATCH for-2.9 1/2] cryptodev: fix the check of aes algorithm > > As the key length of xts(aes) is

Re: [Qemu-devel] Postcopy+spice crash

2016-12-05 Thread Gerd Hoffmann
On Fr, 2016-12-02 at 17:44 +, Dr. David Alan Gilbert wrote: > Hi Gerd, > I've got a moderately repeatable crash with spice playing > a video + postcopy. Some of the time I just get a warning > (that I also get in precopy) but sometimes it turns into > a backtrace; > > This is: > f24

[Qemu-devel] [PATCH RFC v2 1/6] docs/block-replication: Add description for shared-disk case

2016-12-05 Thread zhanghailiang
Introuduce the scenario of shared-disk block replication and how to use it. Signed-off-by: zhanghailiang Signed-off-by: Wen Congyang Signed-off-by: Zhang Chen --- v2: - fix some problems found by Changlong ---

[Qemu-devel] [PATCH RFC v2 4/6] replication: fix code logic with the new shared_disk option

2016-12-05 Thread zhanghailiang
Some code logic only be needed in non-shared disk, here we adjust these codes to prepare for shared disk scenario. Signed-off-by: zhanghailiang --- block/replication.c | 47 --- 1 file changed, 28 insertions(+), 19

Re: [Qemu-devel] [libvirt] [PATCH for-2.9 00/17] target-i386: Implement query-cpu-model-expansion

2016-12-05 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [libvirt] [PATCH for-2.9 00/17] target-i386: Implement query-cpu-model-expansion Type: series Message-id:

Re: [Qemu-devel] [PATCH] net: virtio-net: initialise local 'netcfg' variable

2016-12-05 Thread P J P
Hello Jason, +-- On Mon, 5 Dec 2016, Jason Wang wrote --+ | > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c | > index 01f1351..cb5b3dc 100644 | > --- a/hw/net/virtio-net.c | > +++ b/hw/net/virtio-net.c | > @@ -72,7 +72,7 @@ static int vq2q(int queue_index) | > static void

Re: [Qemu-devel] [PATCH for-2.9 3/3] tests: crypto: add testcase for standard des(ecb)

2016-12-05 Thread Daniel P. Berrange
On Mon, Dec 05, 2016 at 04:59:40PM +0800, Longpeng(Mike) wrote: > As we have added standart DES support when using gcrypt/nettle, > so this patch add a testcase for standard ecb(des). > > Note: the data is copied from linux-kernel's tcrypt module. > > Signed-off-by: Longpeng(Mike)

Re: [Qemu-devel] [PATCH for-2.9 24/30] aspeed: use first SPI flash as a boot ROM

2016-12-05 Thread Cédric Le Goater
Hello Marcin, On 12/04/2016 06:00 PM, mar.krzeminski wrote: > Hi Cedric, > > it looks like good idea for now to handle boot from flash. > As I understand you are trying to omit bootrom code in Qemu model? I suppose you mean handling a romd memory region under the m25p80 object ? > This could

Re: [Qemu-devel] [RISU PATCH 0/9] Record/playback patches

2016-12-05 Thread joserz
On Fri, Dec 02, 2016 at 03:59:26PM +, Alex Bennée wrote: > Hi Peter, > > I've been cleaning things up so I thought I should re-post my current > state. These all apply to the current master. > > I had to regenerate all the risu binaries as I'd used --no-fp for a > bunch of them originally

Re: [Qemu-devel] [PATCH for-2.9 1/2] cryptodev: fix the check of aes algorithm

2016-12-05 Thread Longpeng (Mike)
Hi Gonglei, On 2016/12/5 17:34, Gonglei (Arei) wrote: > .. >> >> +#define AES_KEYSIZE_128 16 >> +#define AES_KEYSIZE_128_XTS 32 >> +#define AES_KEYSIZE_192 24 >> +#define AES_KEYSIZE_256 32 >> +#define AES_KEYSIZE_256_XTS 64 >> + >> static int >> -cryptodev_builtin_get_aes_algo(uint32_t

<    1   2   3   >