[Qemu-devel] [PATCH 08/11] qdev: remove DeviceClass::init

2018-01-16 Thread Philippe Mathieu-Daudé
it has no more users. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/qdev-core.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index 0a71bf83f0..de063b232f 100644 --- a/include/hw/qdev-core.h +++

Re: [Qemu-devel] [PULL 22/33] vhost: Move log_dirty check

2018-01-16 Thread Igor Mammedov
On Tue, 16 Jan 2018 06:48:06 +0200 "Michael S. Tsirkin" wrote: > From: "Dr. David Alan Gilbert" > > Move the log_dirty check into vhost_section. > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 12/24] sdhci: remove dead code

2018-01-16 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180115182436.2066-3-f4...@amsat.org Signed-off-by: Peter Maydell --- include/hw/sd/sdhci.h |

[Qemu-devel] [PULL 06/24] hw/sd/milkymist-memcard: Reset SD card on controller reset

2018-01-16 Thread Peter Maydell
Since milkymist-memcard is still using the legacy SD card API, the SD card created by sd_init() is not plugged into any bus. This means that the controller has to reset it manually. Failing to do this mostly didn't affect the guest since the guest typically does a programmed SD card reset as part

[Qemu-devel] [PULL 04/24] target/arm: Handle page table walk load failures correctly

2018-01-16 Thread Peter Maydell
Instead of ignoring the response from address_space_ld*() (indicating an attempt to read a page table descriptor from an invalid physical address), use it to report the failure correctly. Since this is another couple of locations where we need to decide the value of the ARMMMUFaultInfo ea bit

[Qemu-devel] [PULL 05/24] hw/sd/pl181: Reset SD card on controller reset

2018-01-16 Thread Peter Maydell
Since pl181 is still using the legacy SD card API, the SD card created by sd_init() is not plugged into any bus. This means that the controller has to reset it manually. Failing to do this mostly didn't affect the guest since the guest typically does a programmed SD card reset as part of its SD

[Qemu-devel] [PULL 18/24] sdhci: convert the DPRINT() calls into trace events

2018-01-16 Thread Peter Maydell
From: Philippe Mathieu-Daudé zero-initialize ADMADescr 'dscr' in sdhci_do_adma() to avoid: hw/sd/sdhci.c: In function ‘sdhci_do_adma’: hw/sd/sdhci.c:714:29: error: ‘dscr.addr’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

[Qemu-devel] [PULL 13/24] sdhci: use DEFINE_SDHCI_COMMON_PROPERTIES() for common sysbus/pci properties

2018-01-16 Thread Peter Maydell
From: Philippe Mathieu-Daudé Add common/sysbus/pci/sdbus comments to have clearer code blocks separation. Signed-off-by: Philippe Mathieu-Daudé Message-id: 20180115182436.2066-4-f4...@amsat.org Signed-off-by: Peter Maydell

[Qemu-devel] [PULL 17/24] sdhci: use qemu_log_mask(UNIMP) instead of fprintf()

2018-01-16 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180115182436.2066-8-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/sdhci.c | 7

Re: [Qemu-devel] [PATCH 05/11] virtio-ccw: convert VirtIOCCWDeviceClass::init -> realize

2018-01-16 Thread Farhan Ali
shouldn't the commit message say exit -> unrealize? Thanks Farhan On 01/16/2018 08:15 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- hw/s390x/virtio-ccw.h | 2 +- hw/s390x/virtio-ccw.c | 35 +-- 2 files

[Qemu-devel] [PATCH v5 03/14] qapi: Use OrderedDict from standard library if available

2018-01-16 Thread Daniel P. Berrange
The OrderedDict class appeared in the 'collections' module from python 2.7 onwards, so use that in preference to our local backport if available. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrange --- scripts/qapi.py | 5 - 1 file

[Qemu-devel] [PATCH v5 01/14] qapi: convert to use python print function instead of statement

2018-01-16 Thread Daniel P. Berrange
Python 3 no longer supports the bare "print" statement, it must be called as a normal function with round brackets. It is possible to opt-in to this new syntax with Python 2.6 onwards by importing the "print_function" from the "__future__" module, making it easy to support Python 2 and 3 in

Re: [Qemu-devel] [PULL v3 00/53] Misc changes for 2017-01-12

2018-01-16 Thread Paolo Bonzini
On 16/01/2018 14:47, Peter Maydell wrote: > On 16 January 2018 at 13:41, Paolo Bonzini wrote: >> On 16/01/2018 13:06, Peter Maydell wrote: ASAN is enabled by default if available when --enable-debug. We could add more flags if that helps. >>> Configure switches

[Qemu-devel] [PATCH v3 3/4] cryptodev-vhost-user: add crypto session handler

2018-01-16 Thread Jay Zhou
From: Gonglei Introduce two vhost-user meassges: VHOST_USER_CREATE_CRYPTO_SESSION and VHOST_USER_CLOSE_CRYPTO_SESSION. At this point, the QEMU side support crypto operation in cryptodev host-user backend. Signed-off-by: Gonglei Signed-off-by:

Re: [Qemu-devel] [PULL v1 0/8] Xilinx queue

2018-01-16 Thread Peter Maydell
On 16 January 2018 at 11:50, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > The following changes since commit f5213bd060b460c99e605472b7e03967db43: > > Merge remote-tracking branch

[Qemu-devel] [PATCH v3 4/4] cryptodev-vhost-user: set the key length

2018-01-16 Thread Jay Zhou
From: Gonglei Signed-off-by: Gonglei --- backends/cryptodev-vhost-user.c | 4 include/sysemu/cryptodev-vhost-user.h | 3 +++ 2 files changed, 7 insertions(+) diff --git a/backends/cryptodev-vhost-user.c

Re: [Qemu-devel] [PATCH 1/3] linux-user: introduce functions to detect CPU type

2018-01-16 Thread Laurent Vivier
Le 15/01/2018 à 23:04, Richard Henderson a écrit : > On 01/13/2018 06:48 AM, Laurent Vivier wrote: >> From: YunQiang Su >> >> Move CPU type name selection to a function, >> and add a function to return ELF e_flags. >> >> [lv: splitted the patch and some cleanup in

Re: [Qemu-devel] [PATCH 03/11] hw/i2c: convert I2CSlaveClass::init -> realize

2018-01-16 Thread Philippe Mathieu-Daudé
On 01/16/2018 10:15 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/i2c/i2c.h| 2 +- > include/hw/i2c/smbus.h | 2 +- > hw/audio/wm8750.c | 8 +++- > hw/display/ssd0303.c| 5 ++--- > hw/gpio/max7310.c | 6

Re: [Qemu-devel] [PATCH 4/4] virtio-net: notify backend with number of queue pairs setup

2018-01-16 Thread Maxime Coquelin
On 01/16/2018 04:07 AM, Michael S. Tsirkin wrote: On Fri, Jan 12, 2018 at 03:56:58PM +0100, Maxime Coquelin wrote: Signed-off-by: Maxime Coquelin --- hw/net/virtio-net.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/net/virtio-net.c

[Qemu-devel] [PULL 10/51] build-sys: silence make by default or V=0

2018-01-16 Thread Paolo Bonzini
From: Marc-André Lureau Move generic make flags in MAKEFLAGS (SUBDIR_MAKEFLAGS is more qemu specific). Use --quiet to silence make 'is up to date' message. Signed-off-by: Marc-André Lureau Tested-by: Eric Blake

Re: [Qemu-devel] [PATCH 1/4] vhost-user: fix multiple queue specification

2018-01-16 Thread Maxime Coquelin
On 01/16/2018 04:00 AM, Michael S. Tsirkin wrote: On Fri, Jan 12, 2018 at 03:56:55PM +0100, Maxime Coquelin wrote: The number of queues supported by the slave is queried with message VHOST_USER_GET_QUEUE_NUM, not with message VHOST_USER_GET_PROTOCOL_FEATURES. Also, looking at master and

[Qemu-devel] [PATCH 06/11] sysbus: add realize() and unrealize()

2018-01-16 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sysbus.h | 4 hw/core/sysbus.c| 23 +++ 2 files changed, 27 insertions(+) diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h index e88bb6dae0..c87a6df29e 100644 --- a/include/hw/sysbus.h +++

[Qemu-devel] [PATCH 02/11] smbus_eeprom: replace SMBusDeviceClass::init by DeviceClass::reset

2018-01-16 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/i2c/smbus_eeprom.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c index b13ec0fe7a..7e81ae4fe5 100644 --- a/hw/i2c/smbus_eeprom.c +++ b/hw/i2c/smbus_eeprom.c @@

[Qemu-devel] [PATCH 01/11] smbus: add a NULL check for SMBusDeviceClass::init callbacks

2018-01-16 Thread Philippe Mathieu-Daudé
ensure SMBusDeviceClass::init is set before calling it Signed-off-by: Philippe Mathieu-Daudé --- hw/i2c/smbus.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/i2c/smbus.c b/hw/i2c/smbus.c index 2d1b79a689..a90d65ef37 100644 --- a/hw/i2c/smbus.c +++

[Qemu-devel] [PULL 07/24] hw/sd/ssi-sd: Reset SD card on controller reset

2018-01-16 Thread Peter Maydell
Since ssi-sd is still using the legacy SD card API, the SD card created by sd_init() is not plugged into any bus. This means that the controller has to reset it manually. Failing to do this mostly didn't affect the guest since the guest typically does a programmed SD card reset as part of its SD

[Qemu-devel] [PULL 11/24] sdhci: clean up includes

2018-01-16 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180115182436.2066-2-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/sdhci-internal.h

[Qemu-devel] [PULL 19/24] sdhci: move MASK_TRNMOD with other SDHC_TRN* defines in "sd-internal.h"

2018-01-16 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180115182436.2066-10-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/sdhci-internal.h

[Qemu-devel] [PULL 03/24] hw/arm/virt: Add virt-2.12 machine type

2018-01-16 Thread Peter Maydell
Add virt-2.12 machine type. Signed-off-by: Peter Maydell --- hw/arm/virt.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 151592b..543f9bd 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@

[Qemu-devel] [PATCH v5 07/14] qapi: ensure stable sort ordering when checking QAPI entities

2018-01-16 Thread Daniel P. Berrange
Some early python 3.x versions will have different default ordering when calling the 'values()' method on a dict, compared to python 2.x and later 3.x versions. Explicitly sort the items to get a stable ordering. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P.

[Qemu-devel] [PATCH v5 02/14] qapi: use items()/values() intead of iteritems()/itervalues()

2018-01-16 Thread Daniel P. Berrange
The iteritems()/itervalues() methods are gone in py3, but the items()/values() methods are still around. The latter are less efficient than the former in py2, but this has unmeasurably small impact on QEMU build time, so taking portability over efficiency is a net win. Reviewed-by: Philippe

[Qemu-devel] [PATCH v5 14/14] docker: change Fedora images to run with python3

2018-01-16 Thread Daniel P. Berrange
Fedora has switched to Python 3 by default, so it makes sense to use that for testing QEMU builds, so we get testing of Python 3 compatibility. Signed-off-by: Daniel P. Berrange --- tests/docker/dockerfiles/fedora.docker | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [PATCH V3 0/6] target/ppc: Rework spapr_caps

2018-01-16 Thread David Gibson
On Tue, Jan 16, 2018 at 02:47:13PM +0100, Andrea Bolognani wrote: > On Mon, 2018-01-15 at 17:32 +1100, Suraj Jitindar Singh wrote: > > The following patch series adds 3 new tristate capabilities and their > > associated handling. > > > > A new H-Call is implemented which a guest will use to query

Re: [Qemu-devel] [PATCH 05/11] virtio-ccw: convert VirtIOCCWDeviceClass::init -> realize

2018-01-16 Thread Philippe Mathieu-Daudé
On 01/16/2018 10:41 AM, Farhan Ali wrote: > shouldn't the commit message say exit -> unrealize? Oops, indeed :| Thanks :) Phil. > > > Thanks > Farhan > > On 01/16/2018 08:15 AM, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>  

[Qemu-devel] [PULL v4 00/51] Misc patches for 2018-01-12

2018-01-16 Thread Paolo Bonzini
The following changes since commit 997eba28a3ed5400a80f754bf3a1c8044b75b9ff: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20180111' into staging (2018-01-11 14:34:41 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream

[Qemu-devel] [PULL 03/51] pc: fail memory hot-plug/unplug with -no-acpi and Q35 machine type

2018-01-16 Thread Paolo Bonzini
From: Haozhong Zhang When -no-acpi option is used with Q35 machine type, no guest ACPI is built, but the ACPI device is still created, so only checking the presence of ACPI device before memory plug/unplug is not enough in such cases. Check whether ACPI is disabled

[Qemu-devel] [PULL 02/51] scsi: fix scsi_convert_sense crash when in_buf == NULL && in_len == 0

2018-01-16 Thread Paolo Bonzini
scsi_disk_emulate_command passes in_buf == NULL when sent a REQUEST SENSE command. Check for in_len == 0 before dereferencing in_buf. Fixes: f68d98b21fa74155dc7c1fd212474379ac3c7531 Reported-by: Roman Kagan Tested-by: Roman Kagan Signed-off-by: Paolo

[Qemu-devel] [PULL 11/51] build-sys: add a rule to print a variable

2018-01-16 Thread Paolo Bonzini
From: Marc-André Lureau $ make print-CFLAGS CFLAGS=-fsanitize=address -Og -g Trick from various sources: https://stackoverflow.com/questions/16467718/how-to-print-out-a-variable-in-makefile https://www.cmcrossroads.com/article/printing-value-makefile-variable

[Qemu-devel] [PATCH 4/4] ppc: Deprecate qemu-system-ppcemb

2018-01-16 Thread Thomas Huth
qemu-system-ppcemb has been once split of qemu-system-ppc to support CPU page sizes < 4096 for some of the embedded 4xx PowerPC CPUs. However, there was hardly any OS available in the wild that really used such small page sizes (Linux uses 4096 on PPC), so there is no known recent use case for

[Qemu-devel] [PATCH v2 0/4] Clean up the ppc configs

2018-01-16 Thread Thomas Huth
ppc64-softmmu is a superset of ppc-softmmu which in turn is a superset of ppcemb-softmmu. But since the config files are currently independent from each other, we missed to define some CONFIG switches in the super- sets: CONFIG_SUNGEM is missing from the ppc64-softmmu config, and the

[Qemu-devel] [PATCH 3/4] hw/ppc/Makefile: Add a way to disable the PPC4xx boards

2018-01-16 Thread Thomas Huth
We've got the config switch CONFIG_PPC4XX, so we should use it in the Makefile accordingly and only include the PPC4xx boards if this switch has been enabled. (Note: Unfortunately, the files ppc4xx_devs.c and ppc405_uc.c still have to be included in the build anyway to fulfil some complicated

Re: [Qemu-devel] [PULL 00/33] pc, pci, virtio: features, fixes, cleanups

2018-01-16 Thread Peter Maydell
On 16 January 2018 at 04:46, Michael S. Tsirkin wrote: > A large pull due to patch buildup over the holiday period. > Most notable here is probably the addition of vhost-user-blk. > > The following changes since commit f5213bd060b460c99e605472b7e03967db43: > > Merge

Re: [Qemu-devel] [PATCH v2 3/4] cryptodev-vhost-user: add crypto session handler

2018-01-16 Thread Zhoujian (jay)
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Tuesday, January 16, 2018 12:24 PM > To: Zhoujian (jay) > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; Huangweidong (C) > ; stefa...@redhat.com;

[Qemu-devel] [PATCH v2 1/6] block: maintain persistent disabled bitmaps

2018-01-16 Thread Vladimir Sementsov-Ogievskiy
To maintain load/store disabled bitmap there is new approach: - deprecate @autoload flag of block-dirty-bitmap-add, make it ignored - store enabled bitmaps as "auto" to qcow2 - store disabled bitmaps without "auto" flag to qcow2 - on qcow2 open load "auto" bitmaps as enabled and others as

Re: [Qemu-devel] [PULL 00/33] pc, pci, virtio: features, fixes, cleanups

2018-01-16 Thread Peter Maydell
On 16 January 2018 at 12:24, Peter Maydell wrote: > On 16 January 2018 at 04:46, Michael S. Tsirkin wrote: >> A large pull due to patch buildup over the holiday period. >> Most notable here is probably the addition of vhost-user-blk. >> >> The following

Re: [Qemu-devel] [PATCH x86-next v2] target-i386: add PCID flag to Westmere, Sandy Bridge and Ivy Bridge

2018-01-16 Thread Vincent Bernat
❦ 16 janvier 2018 10:41 -0200, Eduardo Habkost  : >> > Adding Westmere-PCID would require adding a Westmere-PCID-IBRS >> > CPU model too, so this is starting to look a bit ridiculous. >> > Sane VM management systems would know how to use >> > "-cpu Westmere,+pcid" without

[Qemu-devel] [PATCH v6 7/9] qcow2: move is_zero() up

2018-01-16 Thread Anton Nefedov
To be used in the following commit without a forward declaration. Signed-off-by: Anton Nefedov Reviewed-by: Alberto Garcia --- block/qcow2.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git

[Qemu-devel] [PATCH v6 8/9] qcow2: skip writing zero buffers to empty COW areas

2018-01-16 Thread Anton Nefedov
If COW areas of the newly allocated clusters are zeroes on the backing image, efficient bdrv_write_zeroes(flags=BDRV_REQ_ALLOCATE) can be used on the whole cluster instead of writing explicit zero buffers later in perform_cow(). iotest 060: write to the discarded cluster does not trigger COW

[Qemu-devel] [PATCH 11/11] qdev: rename typedef qdev_resetfn() -> DeviceReset()

2018-01-16 Thread Philippe Mathieu-Daudé
following the DeviceRealize and DeviceUnrealize typedefs, this unify a bit the QOM API. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/qdev-core.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index

[Qemu-devel] [PATCH 10/11] qdev: remove empty realize/unrealize stubs

2018-01-16 Thread Philippe Mathieu-Daudé
they are not useful, keep the code clean. Signed-off-by: Philippe Mathieu-Daudé --- hw/core/qdev.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 985f890a74..91ddbfa5f3 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@

[Qemu-devel] [PATCH 05/11] virtio-ccw: convert VirtIOCCWDeviceClass::init -> realize

2018-01-16 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/s390x/virtio-ccw.h | 2 +- hw/s390x/virtio-ccw.c | 35 +-- 2 files changed, 18 insertions(+), 19 deletions(-) diff --git a/hw/s390x/virtio-ccw.h b/hw/s390x/virtio-ccw.h index 3905f3a3d6..2fc513001e

[Qemu-devel] [PULL 15/24] sdhci: refactor common sysbus/pci realize() into sdhci_common_realize()

2018-01-16 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180115182436.2066-6-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/sdhci.c | 30

[Qemu-devel] [PULL 14/24] sdhci: refactor common sysbus/pci class_init() into sdhci_common_class_init()

2018-01-16 Thread Peter Maydell
From: Philippe Mathieu-Daudé Now both inherited classes appear as DEVICE_CATEGORY_STORAGE. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180115182436.2066-5-f4...@amsat.org Signed-off-by: Peter

Re: [Qemu-devel] [PATCHv2 1/2] spapr: Allow some cases where we can't set VSMT mode in the kernel

2018-01-16 Thread David Gibson
On Tue, Jan 16, 2018 at 11:34:52AM +0100, Laurent Vivier wrote: > On 16/01/2018 05:47, David Gibson wrote: > > At present if we require a vsmt mode that's not equal to the kernel's > > default, and the kernel doesn't let us change it (e.g. because it's an old > > kernel without support) then we

[Qemu-devel] [PATCH v5 13/14] travis: improve python version test coverage

2018-01-16 Thread Daniel P. Berrange
Currently travis declares ancient python 2.4 is desired. Update that to 2.6 which is the oldest version any targetted distros still needs. If we just list a python 3 version at the top level this will double the number of travis jobs we run which is unreasonable. So arbitrarily pick the clang

[Qemu-devel] [PATCH v5 00/14] Support building with py2 or py3

2018-01-16 Thread Daniel P. Berrange
This is an update for my previously posted series: v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg06528.html v3: https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg02978.html v4: https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg03150.html This series enables some

[Qemu-devel] [PATCH v5 04/14] qapi: adapt to moved location of StringIO module in py3

2018-01-16 Thread Daniel P. Berrange
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrange --- scripts/qapi.py | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 514b7bb5a4..514cca44bf 100644 --- a/scripts/qapi.py

Re: [Qemu-devel] [PULL v3 00/53] Misc changes for 2017-01-12

2018-01-16 Thread Peter Maydell
On 16 January 2018 at 13:41, Paolo Bonzini wrote: > On 16/01/2018 13:06, Peter Maydell wrote: >>> ASAN is enabled by default if available when --enable-debug. We could >>> add more flags if that helps. >> Configure switches should work like this: >> * default: use feature if

Re: [Qemu-devel] [PULL v3 00/53] Misc changes for 2017-01-12

2018-01-16 Thread Peter Maydell
On 16 January 2018 at 13:50, Marc-André Lureau wrote: > Interesting, looks like a bug in gcc ubsan that doesn't happen with > recent versions (related to > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80550 but probably a > different bug). Adding a cast is enough: > >

[Qemu-devel] [PATCH v5 12/14] ui: update keycodemapdb to get py3 fixes

2018-01-16 Thread Daniel P. Berrange
Signed-off-by: Daniel P. Berrange --- ui/keycodemapdb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/keycodemapdb b/ui/keycodemapdb index 05dad417e9..6b3d716e2b 16 --- a/ui/keycodemapdb +++ b/ui/keycodemapdb @@ -1 +1 @@ -Subproject commit

[Qemu-devel] [PULL 04/51] hpet: recover timer offset correctly

2018-01-16 Thread Paolo Bonzini
From: Pavel Dovgalyuk HPET saves its state by calculating the current time and recovers timer offset using this calculated value. But these calculations include divisions and multiplications. Therefore the timer state cannot be recovered precise enough. This patch

[Qemu-devel] [PULL 01/51] scsi-generic: Add share-rw option

2018-01-16 Thread Paolo Bonzini
From: Fam Zheng Add the property to the device model, then parse it by calling blkconf_apply_backend_options(). In addition to blk_set_perm(), the called function also handles error options and wce. For error options we've already checked that the default values are used, for

[Qemu-devel] [PULL 06/51] chardev: use backend chr context when watch for fe

2018-01-16 Thread Paolo Bonzini
From: Peter Xu In commit 6bbb6c0644 ("chardev: use per-dev context for io_add_watch_poll", 2017-09-22) all the chardev watches are converted to use per-chardev gcontext to support chardev to be run outside default main thread. However that's still missing one call from the

[Qemu-devel] [PULL 08/51] chardev: introduce qemu_chr_timeout_add_ms()

2018-01-16 Thread Paolo Bonzini
From: Peter Xu It's a replacement of g_timeout_add[_seconds]() for chardevs. Chardevs now can have dedicated gcontext, we should always bind chardev tasks onto those gcontext rather than the default main context. Since there are quite a few of g_timeout_add[_seconds]()

[Qemu-devel] [PULL 07/51] chardev: let g_idle_add() be with chardev gcontext

2018-01-16 Thread Paolo Bonzini
From: Peter Xu The idle task will be attached to main gcontext even if the chardev backend is running in another gcontext. Fix the only caller by extending the g_idle_add() logic into the more powerful g_source_attach(). It's basically g_idle_add_full() implementation, but

[Qemu-devel] [PULL 15/51] tests: fix check-qobject leak

2018-01-16 Thread Paolo Bonzini
From: Marc-André Lureau /public/qobject_is_equal_conversion: OK = ==14396==ERROR: LeakSanitizer: detected memory leaks Direct leak of 56 byte(s) in 1 object(s) allocated from: #0 0x7f07682c5850 in

[Qemu-devel] [PULL 14/51] tests/docker: add test-debug

2018-01-16 Thread Paolo Bonzini
From: Marc-André Lureau Add a new test with --enable-debug using clang/asan/ubsan, remove --enable-debug from test-clang & test-mingw. Signed-off-by: Marc-André Lureau Message-Id: <20180104160523.22995-7-marcandre.lur...@redhat.com>

[Qemu-devel] [PATCH v6 3/7] vhost: Merge sections added to temporary list

2018-01-16 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" As sections are reported by the listener to the _nop and _add methods, add them to the temporary section list but now merge them with the previous section if the new one abuts and the backend allows. Signed-off-by: Dr. David Alan Gilbert

[Qemu-devel] [PATCH v6 4/7] vhost: Regenerate region list from changed sections list

2018-01-16 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Compare the sections list that's just been generated, and if it's different from the old one regenerate the region list. Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/trace-events | 1 + hw/virtio/vhost.c |

Re: [Qemu-devel] [PATCH v3 4/8] s390-ccw: interactive boot menu for eckd dasd (menu setup)

2018-01-16 Thread Thomas Huth
On 15.01.2018 17:44, Collin L. Walling wrote: > Reads boot menu flag and timeout values from the iplb and > sets the respective fields for the menu. > > Signed-off-by: Collin L. Walling > --- [...] > diff --git a/pc-bios/s390-ccw/iplb.h b/pc-bios/s390-ccw/iplb.h >

Re: [Qemu-devel] [PATCH 0/4] Implements the Windows Hypervisor Platform accelerator

2018-01-16 Thread Justin Terry (VM) via Qemu-devel
Hey Stefan, Again thanks for the feedback. The short answer is that it will be first available on an Windows 10 Insider Preview release: https://www.microsoft.com/en-us/software-download/windowsinsiderpreviewSDK. I just don’t know which one exactly. When this is released I will for sure update

Re: [Qemu-devel] [RFC PATCH 01/10] block/qapi: Introduce BlockdevCreateOptions

2018-01-16 Thread Eric Blake
On 01/11/2018 01:52 PM, Kevin Wolf wrote: > This creates a BlockdevCreateOptions union type that will contain all of > the options for image creation. We'll start out with an empty struct > type BlockdevCreateDummy for all drivers. > > Signed-off-by: Kevin Wolf > --- >

Re: [Qemu-devel] [PULL v2 0/4] tcg queued patches

2018-01-16 Thread Peter Maydell
'remotes/pmaydell/tags/pull-target-arm-20180116' into staging (2018-01-16 > 14:18:20 +) > > are available in the Git repository at: > > git://github.com/rth7680/qemu.git tags/pull-tcg-20180116 > > for you to fetch changes up to 030ffe39dd4128eb90483af82a5b23b23054a466: > >

Re: [Qemu-devel] [RFC PATCH 02/10] block/qapi: Add qcow2 create options to schema

2018-01-16 Thread Eric Blake
On 01/11/2018 01:52 PM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 33 - > 1 file changed, 32 insertions(+), 1 deletion(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index

Re: [Qemu-devel] [PATCH] hw/pci-bridge: fix QEMU crash because of pcie-root-port

2018-01-16 Thread Laszlo Ersek
On 01/15/18 17:31, Marcel Apfelbaum wrote: > On 15/01/2018 17:54, Laszlo Ersek wrote: >> On 01/10/18 20:09, Marcel Apfelbaum wrote: >>> If we try to use more pcie_root_ports then available slots >>> and an IO hint is passed to the port, QEMU crashes because >>> we try to init the "IO hint"

Re: [Qemu-devel] [PATCH v6 0/3] vhost: two fixes and used_memslots refactoring

2018-01-16 Thread Michael S. Tsirkin
On Tue, Jan 16, 2018 at 08:17:54AM +, Zhoujian (jay) wrote: > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Tuesday, January 16, 2018 12:42 PM > > To: Zhoujian (jay) > > Cc: qemu-devel@nongnu.org; imamm...@redhat.com;

Re: [Qemu-devel] [RFC PATCH 03/10] qcow2: Let qcow2_create() handle protocol layer

2018-01-16 Thread Eric Blake
On 01/11/2018 01:52 PM, Kevin Wolf wrote: > Currently, qcow2_create() only parses the QemuOpts and then calls > qcow2_create2() for the actual image creation, which includes both the > creation of the actual file on the file system and writing a valid empty > qcow2 image into that file. > > The

Re: [Qemu-devel] [RFC PATCH 04/10] qcow2: Pass BlockdevCreateOptions to qcow2_create2()

2018-01-16 Thread Eric Blake
On 01/11/2018 01:52 PM, Kevin Wolf wrote: > All of the simple options are now passed to qcow2_create2() in a > BlockdevCreateOptions object. Still missing: node-name and the > encryption options. > > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 186 >

Re: [Qemu-devel] [PULL 09/27] migration: calculate vCPU blocktime on dst side

2018-01-16 Thread Alexey Perevalov
On 01/16/2018 08:43 PM, Dr. David Alan Gilbert wrote: * Max Reitz (mre...@redhat.com) wrote: On 2018-01-15 12:52, Juan Quintela wrote: From: Alexey Perevalov This patch provides blocktime calculation per vCPU, as a summary and as a overlapped value for all vCPUs.

Re: [Qemu-devel] [PATCH] xilinx_spips: Correct usage of an uninitialized local variable

2018-01-16 Thread francisco iglesias
On Tuesday, 16 January 2018, Peter Maydell wrote: > On 14 January 2018 at 22:55, Francisco Iglesias > wrote: > > Coverity found that the variable tx_rx in the function > > xilinx_spips_flush_txfifo was being used uninitialized (CID 1383841).

Re: [Qemu-devel] [PATCH] LEON3 IRQMP: Fix IRQ software ack

2018-01-16 Thread Mark Cave-Ayland
On 16/01/18 10:21, Fabien Chouteau wrote: On 15/01/2018 19:16, Mark Cave-Ayland wrote: On 11/01/18 11:48, Fabien Chouteau wrote: On 10/01/2018 21:43, Jean-Christophe Dubois wrote: With the LEON3 IRQ controller IRQs can be acknoledged 2 ways: * Explicitely by software writing to the

Re: [Qemu-devel] [RFC PATCH 05/10] qcow2: Use BlockdevRef in qcow2_create2()

2018-01-16 Thread Eric Blake
On 01/11/2018 01:52 PM, Kevin Wolf wrote: > Instead of passing a separate BlockDriverState* into qcow2_create2(), > make use of the BlockdevRef that is included in BlockdevCreateOptions. > > Signed-off-by: Kevin Wolf > --- > include/block/block.h | 1 + > block.c

Re: [Qemu-devel] [RFC PATCH 06/10] qcow2: Use QCryptoBlockCreateOptions in qcow2_create2()

2018-01-16 Thread Eric Blake
On 01/11/2018 01:52 PM, Kevin Wolf wrote: > Instead of passing the encryption format name and the QemuOpts down, use > the QCryptoBlockCreateOptions contained in BlockdevCreateOptions. > > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 62 >

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 4/8] s390-ccw: interactive boot menu for eckd dasd (menu setup)

2018-01-16 Thread Collin L. Walling
On 01/16/2018 01:23 PM, Thomas Huth wrote: On 15.01.2018 17:44, Collin L. Walling wrote: Reads boot menu flag and timeout values from the iplb and sets the respective fields for the menu. Signed-off-by: Collin L. Walling --- [...] diff --git

Re: [Qemu-devel] [RFC PATCH 07/10] qcow2: Handle full/falloc preallocation in qcow2_create2()

2018-01-16 Thread Eric Blake
On 01/11/2018 01:52 PM, Kevin Wolf wrote: > Once qcow2_create2() can be called directly on an already existing node, > we must provide the 'full' and 'falloc' preallocation modes outside of > creating the image on the protocol layer. Fortunately, we have > preallocated truncate now which can

Re: [Qemu-devel] [RFC PATCH 08/10] util: Add qemu_opts_to_qdict_filtered()

2018-01-16 Thread Eric Blake
On 01/11/2018 01:52 PM, Kevin Wolf wrote: > This allows, given a QemuOpts for a QemuOptsList that was merged from > multiple QemuOptsList, to only consider those options that exist in one > specific list. Block drivers need this to separate format-layer create > options from protocol-level

Re: [Qemu-devel] [RFC PATCH 09/10] qcow2: Use visitor for options in qcow2_create()

2018-01-16 Thread Eric Blake
On 01/11/2018 01:52 PM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 227 > ++--- > tests/qemu-iotests/049.out | 10 +- > 2 files changed, 93 insertions(+), 144 deletions(-) > > +/* Only the

Re: [Qemu-devel] [RFC PATCH 01/10] block/qapi: Introduce BlockdevCreateOptions

2018-01-16 Thread Kevin Wolf
Am 16.01.2018 um 19:54 hat Eric Blake geschrieben: > On 01/11/2018 01:52 PM, Kevin Wolf wrote: > > This creates a BlockdevCreateOptions union type that will contain all of > > the options for image creation. We'll start out with an empty struct > > type BlockdevCreateDummy for all drivers. > > >

Re: [Qemu-devel] [PATCH] sun4u: implement power device

2018-01-16 Thread Mark Cave-Ayland
On 16/01/18 00:54, Philippe Mathieu-Daudé wrote: CC'ing PCI maintainers. Hi Mark, On 01/15/2018 05:58 PM, Mark Cave-Ayland wrote: This inbuilt device contains a single 4-byte register, of which bit 24 is used to power down the machine on a real Ultra 5. The power device exists at offset

Re: [Qemu-devel] [PATCH] sun4u: implement power device

2018-01-16 Thread Mark Cave-Ayland
On 16/01/18 14:23, Marcel Apfelbaum wrote: Hi Philippe, On 16/01/2018 2:54, Philippe Mathieu-Daudé wrote: CC'ing PCI maintainers. Hi Mark, On 01/15/2018 05:58 PM, Mark Cave-Ayland wrote: This inbuilt device contains a single 4-byte register, of which bit 24 is used to power down the

Re: [Qemu-devel] [RFC PATCH 10/10] block: x-blockdev-create QMP command

2018-01-16 Thread Eric Blake
On 01/11/2018 01:52 PM, Kevin Wolf wrote: > This adds a synchronous x-blockdev-create QMP command that can create > qcow2 images on a given node name. > > We don't want to block while creating an image, so this is not the final > interface in all aspects, but BlockdevCreateOptionsQcow2 and >

Re: [Qemu-devel] [PATCH v2 5/7] target/m68k: add moves

2018-01-16 Thread Richard Henderson
On 01/16/2018 09:48 AM, Laurent Vivier wrote: > Le 15/01/2018 à 19:37, Richard Henderson a écrit : >> On 01/12/2018 04:43 PM, Laurent Vivier wrote: > ... >>> -dc->user = (env->sr & SR_S) == 0; >>> +#if defined(CONFIG_SOFTMMU) >>> +dc->user = (env->sr & SR_S) == 0 ? M68K_USER_FROM_MSR : 0;

Re: [Qemu-devel] [RFC PATCH 02/10] block/qapi: Add qcow2 create options to schema

2018-01-16 Thread Kevin Wolf
Am 16.01.2018 um 19:59 hat Eric Blake geschrieben: > On 01/11/2018 01:52 PM, Kevin Wolf wrote: > > Signed-off-by: Kevin Wolf > > --- > > qapi/block-core.json | 33 - > > 1 file changed, 32 insertions(+), 1 deletion(-) > > > > diff --git

Re: [Qemu-devel] [PATCH v2 1/4] linux-user: Move CPU type name selection to a function

2018-01-16 Thread Richard Henderson
On 01/16/2018 09:25 AM, Laurent Vivier wrote: > Instead of a sequence of "#if ... #endif" move the > selection to a function in linux-user/*/target_elf.h > > We can't add them in linux-user/*/target_cpu.h > because we will need to include "elf.h" to > use ELF flags with eflags, and including >

Re: [Qemu-devel] [PATCH v2 2/4] linux-user: introduce functions to detect CPU type

2018-01-16 Thread Richard Henderson
On 01/16/2018 09:25 AM, Laurent Vivier wrote: > From: YunQiang Su > > Add a function to return ELF e_flags and use it > to select the CPU model. > > [lv: split the patch and some cleanup in get_elf_eflags()] > Signed-off-by: Laurent Vivier > --- > > Notes:

<    1   2   3   4   5