[Qemu-devel] [PATCH v3 3/4] softfloat: use floatx80_infinity in softfloat

2018-02-23 Thread Laurent Vivier
Since f3218a8 ("softfloat: add floatx80 constants") floatx80_infinity is defined but never used. This patch updates floatx80 functions to use this definition. This allows to define a different default Infinity value on m68k: the m68k FPU defines infinity with all bits set to zero in the mantissa.

[Qemu-devel] [PATCH v3 4/4] target/m68k: add fscale, fgetman and fgetexp

2018-02-23 Thread Laurent Vivier
Using local m68k floatx80_getman(), floatx80_getexp(), floatx80_scale() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 15 + target/m68k/helper.h | 3 + target/m68k/softfloat.c | 14

[Qemu-devel] [PATCH] e1000e : fix PCIe AER error injection

2018-02-23 Thread Thomas Tai
When using qemu pcie_aer_inject_error command to inject an error on e1000e, the error is not sent to the guest. The problem is caused by the e1000e did not initialize the device error control registers mask. Since the default mask is 0, any value written to the registers will be masked off. Follow

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-23 Thread Christian Borntraeger
On 02/23/2018 03:57 PM, Collin L. Walling wrote: > On 02/23/2018 05:11 AM, Christian Borntraeger wrote: >> >> On 02/23/2018 11:07 AM, Thomas Huth wrote: >>> On 22.02.2018 20:40, Collin L. Walling wrote: On 02/22/2018 11:45 AM, Collin L. Walling wrote: > On 02/22/2018 10:44 AM, Christian

Re: [Qemu-devel] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-23 Thread Collin L. Walling
On 02/23/2018 08:33 AM, Thomas Huth wrote: On 23.02.2018 12:50, Viktor Mihajlovski wrote: On 23.02.2018 11:17, Thomas Huth wrote: On 23.02.2018 09:53, Christian Borntraeger wrote: Hmmm, on my ubuntu 16.04 guest, I get the boot menu with no timeout even if I do not specify loadparm or boot men

Re: [Qemu-devel] [PATCH v2 17/36] gluster: Support .bdrv_co_create

2018-02-23 Thread Eric Blake
On 02/21/2018 07:53 AM, Kevin Wolf wrote: This adds the .bdrv_co_create driver callback to gluster, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 18 ++- block/gluster.c | 135 ++- 2 file

Re: [Qemu-devel] [PATCH v3 1/3] s390x/sclp: proper support of larger send and receive masks

2018-02-23 Thread Claudio Imbrenda
On Fri, 23 Feb 2018 15:27:02 +0100 Christian Borntraeger wrote: [...] > > +/* copy up to dst_len bytes and fill the rest of dst with zeroes > > */ > > you just moved this function but shouldnt it be > > src_len bytes and fill will zeroes until dst_len? true, will fix [...]

Re: [Qemu-devel] [PATCH v2 18/36] rbd: Fix use after free in qemu_rbd_set_keypairs() error path

2018-02-23 Thread Eric Blake
On 02/21/2018 07:53 AM, Kevin Wolf wrote: If we want to include the invalid option name in the error message, we can't free the string earlier than that. Signed-off-by: Kevin Wolf --- block/rbd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) D'oh. Should this one be cc'd to qemu

Re: [Qemu-devel] [PATCH v2 28/67] target/arm: Implement SVE Permute - Predicates Group

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 6 + > target/arm/sve_helper.c| 280 > + > target/arm/translate-sve.c | 110 ++ > target/arm/sve.decod

Re: [Qemu-devel] [PATCH v2 19/36] rbd: Factor out qemu_rbd_connect()

2018-02-23 Thread Kevin Wolf
Am 23.02.2018 um 00:10 hat Max Reitz geschrieben: > On 2018-02-21 14:53, Kevin Wolf wrote: > > The code to establish an RBD connection is duplicated between open and > > create. In order to be able to share the code, factor out the code from > > qemu_rbd_open() as a first step. > > > > Signed-off-

Re: [Qemu-devel] [PATCH v2 33/36] file-posix: Fix no-op bdrv_truncate() with falloc preallocation

2018-02-23 Thread Eric Blake
On 02/21/2018 07:54 AM, Kevin Wolf wrote: If bdrv_truncate() is called, but the requested size is the same as before, don't call posix_fallocate(), which returns -EINVAL for length zero and would therefore make bdrv_truncate() fail. The problem can be triggered by creating a zero-sized raw image

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 29/67] target/arm: Implement SVE Permute - Interleaving Group

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 15 ++ > target/arm/sve_helper.c| 72 > ++ > target/arm/translate-sve.c | 69 +++

Re: [Qemu-devel] [PATCH v2 27/36] sheepdog: QAPIfy "redundacy" create option

2018-02-23 Thread Kevin Wolf
Am 21.02.2018 um 14:53 hat Kevin Wolf geschrieben: > The "redundacy" option for Sheepdog image creation is currently a string > that can encode one or two integers depending on its format, which at > the same time implicitly selects a mode. > > This patch turns it into a QAPI union and converts th

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 30/67] target/arm: Implement SVE compress active elements

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 3 +++ > target/arm/sve_helper.c| 34 ++ > target/arm/translate-sve.c | 12 > target/arm/sve.decode | 6 ++ >

[Qemu-devel] [PATCH 3/5] ide: do not set s->end_transfer_func to ide_transfer_cancel

2018-02-23 Thread Paolo Bonzini
There is code checking s->end_transfer_func and it was not taught about ide_transfer_cancel. We can just use ide_transfer_stop because s->end_transfer_func is only ever called in the DRQ phase: after ide_transfer_cancel, the value of s->end_transfer_func is only used as a marker and never used to

[Qemu-devel] [PATCH 2/5] ide: push end_transfer callback to ide_transfer_halt

2018-02-23 Thread Paolo Bonzini
The callback must be invoked once we get out of the DRQ phase; because all end_transfer_funcs end up invoking ide_transfer_stop, call it there. While at it, remove the "notify" argument from ide_transfer_halt; the code can simply be moved to ide_transfer_stop. Old PATA controllers have no end_tran

[Qemu-devel] [PATCH 1/5] ide: push call to end_transfer_func out of start_transfer callback

2018-02-23 Thread Paolo Bonzini
Split the PIO transfer across two callbacks, thus pushing the (possibly recursive) call to end_transfer_func up one level and out of the AHCI-specific code. Signed-off-by: Paolo Bonzini --- hw/ide/ahci.c | 7 ++- hw/ide/core.c | 9 ++--- include/hw/ide/internal.h

[Qemu-devel] [PATCH 4/5] atapi: call ide_set_irq before ide_transfer_start

2018-02-23 Thread Paolo Bonzini
The ATAPI_INT_REASON_IO interrupt is raised when I/O starts, but in the AHCI case ide_set_irq was actually called at the end of a mutual recursion. Move it early, with the side effect that ide_transfer_start becomes a tail call in ide_atapi_cmd_reply_end. Signed-off-by: Paolo Bonzini --- hw/ide/

[Qemu-devel] [RFC PATCH 0/5] atapi: change unlimited recursion to while loop

2018-02-23 Thread Paolo Bonzini
Real hardware doesn't have an unlimited stack, so the unlimited recursion in the ATAPI code smells a bit. In fact, the call to ide_transfer_start easily becomes a tail call with a small change to the code (patch 4). The remaining four patches move code around so as to the turn the call back to id

[Qemu-devel] [PATCH 5/5] ide: introduce ide_transfer_start_norecurse

2018-02-23 Thread Paolo Bonzini
For the case where the end_transfer_func is also the caller of ide_transfer_start, the mutual recursion can lead to unlimited stack usage. Introduce a new version that can be used to change tail recursion into a loop, and use it in trace_ide_atapi_cmd_reply_end. Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PATCH v3 03/31] target/arm/cpu.h: update comment for half-precision values

2018-02-23 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- target/arm/cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 267a9d7e2f..c2bce23fa5 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -168,6 +168,7 @@ typedef struct { * Qn =

[Qemu-devel] [PATCH v3 01/31] include/exec/helper-head.h: support f16 in helper calls

2018-02-23 Thread Alex Bennée
This allows us to explicitly pass float16 to helpers rather than assuming uint32_t and dealing with the result. Of course they will be passed in i32 sized registers by default. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- include/exec/helper-head.h | 3 +++ 1 file changed, 3 in

[Qemu-devel] [PATCH v3 07/31] arm/translate-a64: handle_3same_64 comment fix

2018-02-23 Thread Alex Bennée
We do implement all the opcodes. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- target/arm/translate-a64.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index ebaf4571ac..5dd54b7ac4 100644 --- a/targe

[Qemu-devel] [PATCH v3 04/31] target/arm/cpu.h: add additional float_status flags

2018-02-23 Thread Alex Bennée
Half-precision flush to zero behaviour is controlled by a separate FZ16 bit in the FPCR. To handle this we pass a pointer to fp_status_fp16 when working on half-precision operations. The value of the presented FPCR is calculated from an amalgam of the two when read. Signed-off-by: Alex Bennée --

[Qemu-devel] [PATCH v3 02/31] target/arm/cpu64: introduce ARM_V8_FP16 feature bit

2018-02-23 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- target/arm/cpu.h | 1 + target/arm/cpu64.c | 1 + 2 files changed, 2 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 8c839faa8f..267a9d7e2f 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -1408,6 +1408,

[Qemu-devel] [PATCH v3 06/31] arm/translate-a64: implement half-precision F(MIN|MAX)(V|NMV)

2018-02-23 Thread Alex Bennée
This implements the half-precision variants of the across vector reduction operations. This involves a re-factor of the reduction code which more closely matches the ARM ARM order (and handles 8 element reductions). Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson -- v1 - dropped the

[Qemu-devel] [PATCH v3 00/31] Add ARMv8.2 half-precision functions

2018-02-23 Thread Alex Bennée
Now that the softfloat re-factoring has been merged I re-based this directly from master. Alternatively you can grab the full tree from: https://github.com/stsquad/qemu/tree/arm-fp16-v3 I've tested with the following RISU test binaries: http://people.linaro.org/~alex.bennee/testcases/arm64.

[Qemu-devel] [PATCH v3 30/31] arm/translate-a64: implement simd_scalar_three_reg_same_fp16

2018-02-23 Thread Alex Bennée
This covers the encoding group: Advanced SIMD scalar three same FP16 As all the helpers are already there it is simply a case of calling the existing helpers in the scalar context. Signed-off-by: Alex Bennée --- v2 - checkpatch fixes v3 - check for FP16 feature - remove stray debug -

[Qemu-devel] [PATCH v3 08/31] arm/translate-a64: initial decode for simd_three_reg_same_fp16

2018-02-23 Thread Alex Bennée
This is the initial decode skeleton for the Advanced SIMD three same instruction group. The fprintf is purely to aid debugging as the additional instructions are added. It will be removed once the group is complete. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- target/arm/trans

[Qemu-devel] [PATCH v3 05/31] target/arm/helper: pass explicit fpst to set_rmode

2018-02-23 Thread Alex Bennée
As the rounding mode is now split between FP16 and the rest of floating point we need to be explicit when tweaking it. Instead of passing the CPU env we now pass the appropriate fpst pointer directly. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- target/arm/helper.c| 4

[Qemu-devel] [PATCH v3 10/31] arm/translate-a64: add FP16 F[A]C[EQ/GE/GT] to simd_three_reg_same_fp16

2018-02-23 Thread Alex Bennée
These use the generic float16_compare functionality which in turn uses the common float_compare code from the softfloat re-factor. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- target/arm/helper-a64.c| 49 ++ target/arm/helper-a64.

[Qemu-devel] [PATCH v3 18/31] arm/translate-a64: add FCVTxx to simd_two_reg_misc_fp16

2018-02-23 Thread Alex Bennée
This covers all the floating point convert operations. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- target/arm/helper-a64.c| 32 + target/arm/helper-a64.h| 2 ++ target/arm/translate-a64.c | 85 +- 3 files cha

[Qemu-devel] [PATCH v3 11/31] arm/translate-a64: add FP16 FMULA/X/S to simd_three_reg_same_fp16

2018-02-23 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- target/arm/helper-a64.c| 24 target/arm/helper-a64.h| 2 ++ target/arm/translate-a64.c | 15 +++ 3 files changed, 41 insertions(+) diff --git a/target/arm/helper-a64.c b/target/arm/helper

[Qemu-devel] [PATCH v3 09/31] arm/translate-a64: add FP16 FADD/FABD/FSUB/FMUL/FDIV to simd_three_reg_same_fp16

2018-02-23 Thread Alex Bennée
The fprintf is only there for debugging as the skeleton is added to, it will be removed once the skeleton is complete. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - add absh helper - fix checkpatch violation - make abs a bitwise operation --- target/arm/helper-a64.c|

[Qemu-devel] [PATCH v3 20/31] arm/translate-a64: add FP16 SCVTF/UCVFT to simd_two_reg_misc_fp16

2018-02-23 Thread Alex Bennée
I've re-factored the handle_simd_intfp_conv helper to properly handle half-precision as well as call plain conversion helpers when we are not doing fixed point conversion. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- target/arm/helper.c| 4 ++ target/arm/helper.h

[Qemu-devel] [PATCH v3 29/31] arm/translate-a64: add all FP16 ops in simd_scalar_pairwise

2018-02-23 Thread Alex Bennée
I only needed to do a little light re-factoring to support the half-precision helpers. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- target/arm/translate-a64.c | 80 +++--- 1 file changed, 54 insertions(+), 26 deletions(-) diff --git a/ta

[Qemu-devel] [PATCH v3 17/31] arm/translate-a64: add FP16 FPRINTx to simd_two_reg_misc_fp16

2018-02-23 Thread Alex Bennée
This adds the full range of half-precision floating point to integral instructions. Signed-off-by: Alex Bennée --- v3 - fix re-base conflicts - move comment to previous commit - don't double test is_scalar in unallocated checks --- target/arm/helper-a64.c| 22 target/arm/hel

[Qemu-devel] [PATCH v3 13/31] arm/translate-a64: add FP16 pairwise ops simd_three_reg_same_fp16

2018-02-23 Thread Alex Bennée
This includes FMAXNMP, FADDP, FMAXP, FMINNMP, FMINP. Signed-off-by: Alex Bennée --- v2 - checkpatch fixes --- target/arm/translate-a64.c | 208 + 1 file changed, 133 insertions(+), 75 deletions(-) diff --git a/target/arm/translate-a64.c b/target/ar

[Qemu-devel] [PATCH v3 15/31] arm/translate-a64: add FP16 x2 ops for simd_indexed

2018-02-23 Thread Alex Bennée
A bunch of the vectorised bitwise operations just operate on larger chunks at a time. We can do the same for the new half-precision operations by introducing some TWOHALFOP helpers which work on each half of a pair of half-precision operations at once. Hopefully all this hoop jumping will get simp

[Qemu-devel] [PATCH v3 31/31] arm/translate-a64: add all single op FP16 to handle_fp_1src_half

2018-02-23 Thread Alex Bennée
This includes FMOV, FABS, FNEG, FSQRT and FRINT[NPMZAXI]. We re-use existing helpers to achieve this. Signed-off-by: Alex Bennée --- v3 - make fabs a bitwise operation - use read_vec_element_i32 to read value - properly wire into disas_fp_1rc --- target/arm/translate-a64.c | 71 +

[Qemu-devel] [PATCH v3 16/31] arm/translate-a64: initial decode for simd_two_reg_misc_fp16

2018-02-23 Thread Alex Bennée
This actually covers two different sections of the encoding table: Advanced SIMD scalar two-register miscellaneous FP16 Advanced SIMD two-register miscellaneous (FP16) The difference between the two is covered by a combination of Q (bit 30) and S (bit 28). Notably the FRINTx instructions ar

[Qemu-devel] [PATCH v3 27/31] arm/translate-a64: add FP16 FRSQRTE to simd_two_reg_misc_fp16

2018-02-23 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- target/arm/translate-a64.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index ba3926262e..faec8084fa 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/transl

[Qemu-devel] [PATCH v3 26/31] arm/helper.c: re-factor rsqrte and add rsqrte_f16

2018-02-23 Thread Alex Bennée
Much like recpe the ARM ARM has simplified the pseudo code for the calculation which is done on a fixed point 9 bit integer maths. So while adding f16 we can also clean this up to be a little less heavy on the floating point and just return the fractional part and leave the calle's to do the final

[Qemu-devel] [PATCH v9 02/13] s390-ccw: refactor eckd_block_num to use CHS

2018-02-23 Thread Collin L. Walling
Add new cylinder/head/sector struct. Use it to calculate eckd block numbers instead of a BootMapPointer (which used eckd chs anyway). Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/bootmap.c | 28 ++-- pc-bios/s390-ccw/bootmap.h | 8 +

[Qemu-devel] [PATCH v3 21/31] arm/translate-a64: add FP16 FNEG/FABS to simd_two_reg_misc_fp16

2018-02-23 Thread Alex Bennée
Neither of these operations alter the floating point status registers so we can do a pure bitwise operation, either squashing any sign bit (ABS) or inverting it (NEG). Signed-off-by: Alex Bennée --- v3 - fixup re-base conflicts - make both operations pure bitwise TCG --- target/arm/translat

[Qemu-devel] [PATCH v9 03/13] s390-ccw: refactor IPL structs

2018-02-23 Thread Collin L. Walling
ECKD DASDs have different IPL structures for CDL and LDL formats. The current Ipl1 and Ipl2 structs follow the CDL format, so we prepend "EckdCdl" to them. Boot info for LDL has been moved to a new struct: EckdLdlIpl1. Signed-off-by: Collin L. Walling Acked-by: Janosch Frank Reviewed-by: Thomas

[Qemu-devel] [PATCH v3 14/31] arm/translate-a64: add FP16 FMULX/MLS/FMLA to simd_indexed

2018-02-23 Thread Alex Bennée
The helpers use the new re-factored muladd support in SoftFloat for the float16 work. Signed-off-by: Alex Bennée --- v3 - re-jigged switch statement to fall-through for unalloc - added is_fp16 bool for fpst - fixed up some long lines --- target/arm/translate-a64.c | 83 +++

[Qemu-devel] [PATCH v9 04/13] s390-ccw: update libc

2018-02-23 Thread Collin L. Walling
Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) Added C standard functions: isdigit Added non C-standard function: uitoa atoui Signed-off-by: Collin L. Walling Acked-by: Christian Borntraeger Reviewed-by: Janosch Frank

[Qemu-devel] [PATCH v3 28/31] arm/translate-a64: add FP16 FMOV to simd_mod_imm

2018-02-23 Thread Alex Bennée
Only one half-precision instruction has been added to this group. Signed-off-by: Alex Bennée --- v2 - checkpatch fixes v3 - use vfp_expand_imm --- target/arm/translate-a64.c | 35 +-- 1 file changed, 25 insertions(+), 10 deletions(-) diff --git a/target/arm/

[Qemu-devel] [PATCH v9 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-23 Thread Collin L. Walling
--- [v9] --- - only set boot menu opts if a bootindex was specified on cmd - Menus for guests with an IPL device that chooses to use the SCSI scheme are only enabled explicitly for -boot menu=on options (i.e. it will appropriately and cleanly ignore the zipl flag) --- [Summary] --- Thes

[Qemu-devel] [PATCH v9 05/13] s390-ccw: move auxiliary IPL data to separate location

2018-02-23 Thread Collin L. Walling
The s390-ccw firmware needs some information in support of the boot process which is not available on the native machine. Examples are the netboot firmware load address and now the boot menu parameters. While storing that data in unused fields of the IPL parameter block works, that approach could

[Qemu-devel] [PATCH v9 08/13] s390-ccw: read stage2 boot loader data to find menu

2018-02-23 Thread Collin L. Walling
Read the stage2 boot loader data block-by-block. We scan the current block for the string "zIPL" to detect the start of the boot menu banner. We then load the adjacent blocks (previous block and next block) to account for the possibility of menu data spanning multiple blocks. Signed-off-by: Collin

[Qemu-devel] [PATCH v3 24/31] arm/translate-a64: add FP16 FRCPX to simd_two_reg_misc_fp16

2018-02-23 Thread Alex Bennée
We go with the localised helper. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- target/arm/helper-a64.c| 29 + target/arm/helper-a64.h| 1 + target/arm/translate-a64.c | 4 3 files changed, 34 insertions(+) diff --git a/target/arm/helpe

[Qemu-devel] [PATCH v9 01/13] s390-ccw: refactor boot map table code

2018-02-23 Thread Collin L. Walling
Some ECKD bootmap code was using structs designed for SCSI. Even though this works, it confuses readability. Add a new BootMapTable struct to assist with readability in bootmap entry code. Also: - replace ScsiMbr in ECKD code with appropriate structs - fix read_block messages to reflect BootMapTab

[Qemu-devel] [PATCH v9 11/13] s390-ccw: set cp_receive mask only when needed and consume pending service irqs

2018-02-23 Thread Collin L. Walling
It is possible while waiting for multiple types of external interrupts that we might have pending irqs remaining between irq consumption and irq-type disabling. Those interrupts could potentially propagate to the guest after IPL completes and cause unwanted behavior. As it is today, the SCLP will

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 31/67] target/arm: Implement SVE conditionally broadcast/extract element

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 2 + > target/arm/sve_helper.c| 11 ++ > target/arm/translate-sve.c | 299 > + > target/arm/sve.decode | 20 +++

[Qemu-devel] [PATCH v3 22/31] arm/helper.c: re-factor recpe and add recepe_f16

2018-02-23 Thread Alex Bennée
It looks like the ARM ARM has simplified the pseudo code for the calculation which is done on a fixed point 9 bit integer maths. So while adding f16 we can also clean this up to be a little less heavy on the floating point and just return the fractional part and leave the calle's to do the final pa

[Qemu-devel] [PATCH v9 06/13] s390-ccw: parse and set boot menu options

2018-02-23 Thread Collin L. Walling
Set boot menu options for an s390 guest and store them in the iplb. These options are set via the QEMU command line option: -boot menu=on|off[,splash-time=X] or via the libvirt domain xml: Where X represents some positive integer representing milliseconds. Any value set fo

[Qemu-devel] [PATCH v9 10/13] s390-ccw: read user input for boot index via the SCLP console

2018-02-23 Thread Collin L. Walling
Implements an sclp_read function to capture input from the console and a wrapper function that handles parsing certain characters and adding input to a buffer. The input is checked for any erroneous values and is handled appropriately. A prompt will persist until input is entered or the timeout ex

[Qemu-devel] [PATCH REPOST v1 0/8] Group support and random clean-ups

2018-02-23 Thread Alex Bennée
Hi, This is essentially a re-post but with a wider distribution. There is one extra patch which adds the FP16 1 source data processing. This is for discussion on how best to represent all the different architectural versions by using the second field in the aarch64.risu file. Alex Bennée (8): r

[Qemu-devel] [PATCH v3 23/31] arm/translate-a64: add FP16 FRECPE

2018-02-23 Thread Alex Bennée
Now we have added f16 during the re-factoring we can simply call the helper. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- target/arm/translate-a64.c | 8 1 file changed, 8 insertions(+) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 00b04d3

[Qemu-devel] [PATCH v9 07/13] s390-ccw: set up interactive boot menu parameters

2018-02-23 Thread Collin L. Walling
Reads boot menu flag and timeout values from the iplb and sets the respective fields for the menu. Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/Makefile | 2 +- pc-bios/s390-ccw/main.c | 24 pc-bios/s390-ccw/menu.c | 22 +

[Qemu-devel] [PATCH v9 13/13] s390-ccw: interactive boot menu for scsi

2018-02-23 Thread Collin L. Walling
Interactive boot menu for scsi. This follows a similar procedure as the interactive menu for eckd dasd. An example follows: s390x Enumerated Boot Menu. 3 entries detected. Select from index 0 to 2. Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- hw/s390x/ipl.c

[Qemu-devel] [PATCH v1 1/8] risugen: support @GroupName in risu files

2018-02-23 Thread Alex Bennée
The existing pattern support is useful but it does get a little tedious when faced with large groups of instructions. This introduces the concept of a @GroupName which can be sprinkled in the risu definition and is attached to all instructions following its definition until the next group or an emp

[Qemu-devel] [PATCH v3 19/31] arm/translate-a64: add FP16 FCMxx (zero) to simd_two_reg_misc_fp16

2018-02-23 Thread Alex Bennée
I re-use the existing handle_2misc_fcmp_zero handler and tweak it slightly to deal with the half-precision case. Signed-off-by: Alex Bennée --- v3 - use size directly wuth read/write_vec_element - drop unneeded break - WIP: mess with calculating maxpasses --- target/arm/translate-a64.c |

[Qemu-devel] [PATCH v9 12/13] s390-ccw: use zipl values when no boot menu options are present

2018-02-23 Thread Collin L. Walling
If no boot menu options are present, then flag the boot menu to use the zipl options that were set in the zipl configuration file (and stored on disk by zipl). These options are found at some offset prior to the start of the zipl boot menu banner. The zipl timeout value is limited to a 16-bit unsig

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 32/67] target/arm: Implement SVE copy to vector (predicated)

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/translate-sve.c | 13 + > target/arm/sve.decode | 6 ++ > 2 files changed, 19 insertions(+) > > diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c

[Qemu-devel] [PATCH v1 4/8] new contrib/generate_all.sh: batch risugen script

2018-02-23 Thread Alex Bennée
This is a simple script for generating all instructions in a given RISU file. You can split up the batch size by passing a -n N command line options. For example: ./contrib/generate_all.sh -n 2 hp.risu testcases.armv8.2_hp Signed-off-by: Alex Bennée --- contrib/generate_all.sh | 96 ++

[Qemu-devel] [PATCH v9 09/13] s390-ccw: print zipl boot menu

2018-02-23 Thread Collin L. Walling
When the boot menu options are present and the guest's disk has been configured by the zipl tool, then the user will be presented with an interactive boot menu with labeled entries. An example of what the menu might look like: zIPL v1.37.1-build-20170714 interactive boot menu. 0. default (linux-4

[Qemu-devel] [PATCH v1 3/8] aarch64.risu: add cryptographic extensions for v8.2

2018-02-23 Thread Alex Bennée
Signed-off-by: Alex Bennée --- aarch64.risu | 32 1 file changed, 32 insertions(+) diff --git a/aarch64.risu b/aarch64.risu index 838bded..06a9f3c 100644 --- a/aarch64.risu +++ b/aarch64.risu @@ -2937,3 +2937,35 @@ FCVTZUsi_RES A64_V sf:1 000 1 type:1 1 11 00

[Qemu-devel] [PATCH v1 8/8] aarch64.risu: update Floating-point data-processing (1 source)

2018-02-23 Thread Alex Bennée
This adds the half-precision encoding and shuffles around the RES space to indicate this. Signed-off-by: Alex Bennée --- aarch64.risu | 55 +++ 1 file changed, 27 insertions(+), 28 deletions(-) diff --git a/aarch64.risu b/aarch64.risu index 06

Re: [Qemu-devel] [edk2] [PATCH 0/7] RFC: ovmf: preliminary TPM2 support

2018-02-23 Thread Laszlo Ersek
On 02/23/18 14:23, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > The following series adds basic TPM2 support for OVMF-on-QEMU (I > haven't tested TPM1, for lack of interest). It links with the modules > to initializes the device in PEI phase, and do measurements (both

[Qemu-devel] [PATCH v1 5/8] contrib/run_risu.sh: allow appending of QEMU_FLAGS

2018-02-23 Thread Alex Bennée
Useful if you want to disable a feature for your run. For example: set -x QEMU_FLAGS "-cpu fp16=off" Signed-off-by: Alex Bennée --- contrib/run_risu.sh | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/contrib/run_risu.sh b/contrib/run_risu.sh index 439cd36..63649dd 10

[Qemu-devel] [PATCH v1 7/8] contrib/run_risu.sh: add a visual cue for a clean-run

2018-02-23 Thread Alex Bennée
It saves you from having to check the status code or wonder if the errors just scrolled off your screen. Signed-off-by: Alex Bennée --- contrib/run_risu.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/contrib/run_risu.sh b/contrib/run_risu.sh index 2d1897a..fc69d83 100755 --- a/contrib/

[Qemu-devel] [PATCH v3 25/31] arm/translate-a64: add FP16 FSQRT to simd_two_reg_misc_fp16

2018-02-23 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 remove superfluous helpers --- target/arm/helper-a64.c| 13 + target/arm/helper-a64.h| 1 + target/arm/translate-a64.c | 5 + 3 files changed, 19 insertions(+) diff --git a/target/arm/helper-a64.c b/tar

[Qemu-devel] [PATCH v1 6/8] contrib/run_risu.sh: don't set -e

2018-02-23 Thread Alex Bennée
As the script is meant to summarise the results at the end it doesn't make sense to bail out at the first error. Signed-off-by: Alex Bennée --- contrib/run_risu.sh | 2 -- 1 file changed, 2 deletions(-) diff --git a/contrib/run_risu.sh b/contrib/run_risu.sh index 63649dd..2d1897a 100755 --- a/c

Re: [Qemu-devel] [PATCH v9 13/13] s390-ccw: interactive boot menu for scsi

2018-02-23 Thread Viktor Mihajlovski
On 23.02.2018 16:43, Collin L. Walling wrote: > Interactive boot menu for scsi. This follows a similar procedure > as the interactive menu for eckd dasd. An example follows: > > s390x Enumerated Boot Menu. > > 3 entries detected. Select from index 0 to 2. > > Signed-off-by: Collin L. Wal

Re: [Qemu-devel] [PATCH v2 18/36] rbd: Fix use after free in qemu_rbd_set_keypairs() error path

2018-02-23 Thread Kevin Wolf
Am 23.02.2018 um 16:15 hat Eric Blake geschrieben: > On 02/21/2018 07:53 AM, Kevin Wolf wrote: > > If we want to include the invalid option name in the error message, we > > can't free the string earlier than that. > > > > Signed-off-by: Kevin Wolf > > --- > > block/rbd.c | 3 ++- > > 1 file c

Re: [Qemu-devel] [edk2] [PATCH 1/7] SecurityPkg/Tcg2Pei: drop Tcg2PhysicalPresenceLib dependency

2018-02-23 Thread Laszlo Ersek
On 02/23/18 14:23, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Apparently, unnecessary. Avoids extra build dependency and churn. > > CC: Laszlo Ersek > CC: Stefan Berger > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Marc-André Lureau > --- >

[Qemu-devel] [PATCH v1 2/8] aarch64.risu: clean-up and annotate with groups

2018-02-23 Thread Alex Bennée
Clean-up the risu definitions by: - removing out-dated section numbers - fixing section titles to match ASL encoding groups - add @Section markers Signed-off-by: Alex Bennée --- aarch64.risu | 200 +-- 1 file changed, 141 insertions(+

[Qemu-devel] [PATCH v3 12/31] arm/translate-a64: add FP16 FR[ECP/SQRT]S to simd_three_reg_same_fp16

2018-02-23 Thread Alex Bennée
As some of the constants here will also be needed elsewhere (specifically for the upcoming SVE support) we move them out to softfloat.h. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v3 - move constants used for estimate to softfloat.h --- include/fpu/softfloat.h| 16

[Qemu-devel] [PATCH v2] tcg: Add choose_vector_size

2018-02-23 Thread Richard Henderson
This unifies 5 copies of checks for supported vector size, and in the process fixes a missing check in tcg_gen_gvec_2s. This lead to an assertion failure for 64-bit vector multiply, which is not available in the AVX instruction set. Suggested-by: Peter Maydell Signed-off-by: Richard Henderson -

Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState

2018-02-23 Thread Alex Williamson
On Fri, 23 Feb 2018 09:53:22 +0100 Gerd Hoffmann wrote: > Hi, > > > > What type of device is only sometimes hotpluggable ? > > > The commit message says "display devices" and "consoles", > > > but I would expect those to both be types of device which > > > have a class which is never hotplugga

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 34/67] target/arm: Implement SVE vector splice (predicated)

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 2 ++ > target/arm/sve_helper.c| 37 + > target/arm/translate-sve.c | 10 ++ > target/arm/sve.decode | 3 +++ > 4

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 33/67] target/arm: Implement SVE reverse within elements

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 14 ++ > target/arm/sve_helper.c| 41 ++--- > target/arm/translate-sve.c | 38 ++

Re: [Qemu-devel] [PATCH v9 05/13] s390-ccw: move auxiliary IPL data to separate location

2018-02-23 Thread Collin L. Walling
On 02/23/2018 11:03 AM, Thomas Huth wrote: On 23.02.2018 16:43, Collin L. Walling wrote: The s390-ccw firmware needs some information in support of the boot process which is not available on the native machine. Examples are the netboot firmware load address and now the boot menu parameters. Whi

Re: [Qemu-devel] [PATCH v9 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-23 Thread Viktor Mihajlovski
On 23.02.2018 16:43, Collin L. Walling wrote: > --- [v9] --- > > - only set boot menu opts if a bootindex was specified on cmd > > - Menus for guests with an IPL device that chooses to use the SCSI scheme are >only enabled explicitly for -boot menu=on options (i.e. it will > appropriately

Re: [Qemu-devel] proposed release schedule for QEMU 2.12

2018-02-23 Thread Peter Maydell
On 30 January 2018 at 16:25, Peter Maydell wrote: > It seems like it's about time we settled on the dates for the > 2.12 release. I've sketched in a suggestion at: > https://wiki.qemu.org/Planning/2.12 > > which puts softfreeze on the 13th March, hardfreeze a > week later on the 20th, and final

Re: [Qemu-devel] [PATCH v9 05/13] s390-ccw: move auxiliary IPL data to separate location

2018-02-23 Thread Thomas Huth
On 23.02.2018 16:43, Collin L. Walling wrote: > The s390-ccw firmware needs some information in support of the > boot process which is not available on the native machine. > Examples are the netboot firmware load address and now the > boot menu parameters. > > While storing that data in unused fie

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 35/67] target/arm: Implement SVE Select Vectors Group

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 9 > target/arm/sve_helper.c| 55 > ++ > target/arm/translate-sve.c | 2 ++ > target/arm/sve.decode | 6

Re: [Qemu-devel] [PATCH v1 4/8] new contrib/generate_all.sh: batch risugen script

2018-02-23 Thread Daniel P . Berrangé
On Fri, Feb 23, 2018 at 03:46:09PM +, Alex Bennée wrote: > This is a simple script for generating all instructions in a given > RISU file. You can split up the batch size by passing a -n N command > line options. For example: > > ./contrib/generate_all.sh -n 2 hp.risu testcases.armv8.2_hp >

Re: [Qemu-devel] [PATCH v2 21/36] rbd: Pass BlockdevOptionsRbd to qemu_rbd_connect()

2018-02-23 Thread Kevin Wolf
Am 23.02.2018 um 00:25 hat Max Reitz geschrieben: > On 2018-02-21 14:53, Kevin Wolf wrote: > > With the conversion to a QAPI options object, the function is now > > prepared to be used in a .bdrv_co_create implementation. > > > > Signed-off-by: Kevin Wolf > > -*s_snap = g_strdup(snap); > > -

Re: [Qemu-devel] [PATCH v2 36/67] target/arm: Implement SVE Integer Compare - Vectors Group

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c > index 86cd792cdf..ae433861f8 100644 > --- a/target/arm/sve_helper.c > +++ b/target/arm/sve_helper.c > @@ -46,14 +46,14 @@ > * > *

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 37/67] target/arm: Implement SVE Integer Compare - Immediate Group

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 44 +++ > target/arm/sve_helper.c| 88 > ++ > target/arm/translate-sve.c | 63 ++

Re: [Qemu-devel] [PATCH] log-for-trace.h: Split out parts of log.h used by trace.h

2018-02-23 Thread Stefan Hajnoczi
On Tue, Feb 13, 2018 at 02:00:29PM +, Peter Maydell wrote: > A persistent build problem we see is where a source file > accidentally omits the #include of log.h. This slips through > local developer testing because if you configure with the > default (log) trace backend trace.h will pull in log

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 38/67] target/arm: Implement SVE Partition Break Group

2018-02-23 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 18 > target/arm/sve_helper.c| 247 > + > target/arm/translate-sve.c | 96 ++ > target/arm/sve.de

Re: [Qemu-devel] [PATCH v8 09/21] null: Switch to .bdrv_co_block_status()

2018-02-23 Thread Eric Blake
On 02/14/2018 06:05 AM, Kevin Wolf wrote: +static int coroutine_fn null_co_block_status(BlockDriverState *bs, if (s->read_zeroes) { -return BDRV_BLOCK_OFFSET_VALID | start | BDRV_BLOCK_ZERO; -} else { -return BDRV_BLOCK_OFFSET_VALID | start; +ret |= BDRV_BLOC

Re: [Qemu-devel] [PATCH v1 4/8] new contrib/generate_all.sh: batch risugen script

2018-02-23 Thread Peter Maydell
On 23 February 2018 at 16:17, Daniel P. Berrangé wrote: > On Fri, Feb 23, 2018 at 03:46:09PM +, Alex Bennée wrote: >> This is a simple script for generating all instructions in a given >> RISU file. You can split up the batch size by passing a -n N command >> line options. For example: >> >>

Re: [Qemu-devel] [PATCH v2 21/36] rbd: Pass BlockdevOptionsRbd to qemu_rbd_connect()

2018-02-23 Thread Max Reitz
On 2018-02-23 17:19, Kevin Wolf wrote: > Am 23.02.2018 um 00:25 hat Max Reitz geschrieben: >> On 2018-02-21 14:53, Kevin Wolf wrote: >>> With the conversion to a QAPI options object, the function is now >>> prepared to be used in a .bdrv_co_create implementation. >>> >>> Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v1 4/8] new contrib/generate_all.sh: batch risugen script

2018-02-23 Thread Alex Bennée
Daniel P. Berrangé writes: > On Fri, Feb 23, 2018 at 03:46:09PM +, Alex Bennée wrote: >> This is a simple script for generating all instructions in a given >> RISU file. You can split up the batch size by passing a -n N command >> line options. For example: >> >> ./contrib/generate_all.sh

<    1   2   3   4   >