Re: [PULL 0/1] Usb 20191107 patches

2019-11-07 Thread Peter Maydell
acb28c4544858c66a3: > >> > >>Merge remote-tracking branch > >> 'remotes/philmd-gitlab/tags/fw_cfg-next-pull-request' into staging > >> (2019-11-05 20:17:11 +) > >> > >> are available in the Git repository at: &

Re: [PATCH v2] virtio: notify virtqueue via host notifier when available

2019-11-07 Thread Felipe Franciosi
Thanks Stefan for the quick fix! Sorry for not adding a Tested-by. It's implicit. :) F. > On Nov 6, 2019, at 11:33 AM, Michael S. Tsirkin wrote: > > On Tue, Nov 05, 2019 at 03:09:46PM +0100, Stefan Hajnoczi wrote: >> Host notifiers are used in several cases: >> 1. Traditional ioeventfd where vi

Re: [PATCH-for-4.1? 0/7] vl: Allow building with CONFIG_BLUETOOTH disabled

2019-11-07 Thread Philippe Mathieu-Daudé
On 8/14/19 2:45 PM, Philippe Mathieu-Daudé wrote: On 8/13/19 4:04 PM, Peter Maydell wrote: On Tue, 13 Aug 2019 at 15:01, Philippe Mathieu-Daudé wrote: On 7/15/19 3:13 PM, Thomas Huth wrote: On 12/07/2019 15.39, Philippe Mathieu-Daudé wrote: A series of obvious patches to build without the de

Re: [Qemu-devel] Exposing feature deprecation to machine clients

2019-11-07 Thread Vladimir Sementsov-Ogievskiy
07.11.2019 21:52, Philippe Mathieu-Daudé wrote: > Hi Markus, > > On 8/15/19 7:40 PM, John Snow wrote: >> On 8/15/19 10:16 AM, Markus Armbruster wrote: >>> John Snow writes: > [...] I asked Markus this not too long ago; do we want to amend the QAPI schema specification to allow commands

Re: [PATCH v1 Resend] target/i386: set the CPUID level to 0x14 on old machine-type

2019-11-07 Thread Eduardo Habkost
On Wed, Nov 06, 2019 at 12:55:32AM +, Kang, Luwei wrote: > > > The CPUID level need to be set to 0x14 manually on old machine-type if > > > Intel PT is enabled in guest. e.g. in Qemu 3.1 -machine pc-i440fx-3.1 > > > -cpu qemu64,+intel-pt will be CPUID[0].EAX(level)=7 and > > > CPUID[7].EBX[25](

Re: [PATCH v7 5/8] Acceptance tests: keep a stable reference to the QEMU build dir

2019-11-07 Thread Wainer dos Santos Moschetta
On 11/4/19 1:13 PM, Cleber Rosa wrote: This is related to the the differences in in-tree and out-of-tree builds in QEMU. For simplification, means my build directory. Currently, by running a `make check-acceptance` one gets (in tests/acceptance/avocado_qemu/__init__.py): SRC_ROOT_DIR: /

[PATCH 0/3] Some memory leak fixes

2019-11-07 Thread Marc-André Lureau
Hi, Another bunch of fixes spotted by ASAN when running check-qtest-x86_64. Marc-André Lureau (3): virtio-input: fix memory leak on unrealize qtest: fix qtest_qmp_device_add leak cpu-plug-test: fix leaks hw/input/virtio-input.c | 3 +++ tests/cpu-plug-test.c | 2 ++ tests/libqtest.c

[PATCH 3/3] cpu-plug-test: fix leaks

2019-11-07 Thread Marc-André Lureau
Spotted by ASAN. Signed-off-by: Marc-André Lureau --- tests/cpu-plug-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/cpu-plug-test.c b/tests/cpu-plug-test.c index 058cef5ac1..30e514bbfb 100644 --- a/tests/cpu-plug-test.c +++ b/tests/cpu-plug-test.c @@ -99,6 +99,7 @@ static voi

[PATCH 1/3] virtio-input: fix memory leak on unrealize

2019-11-07 Thread Marc-André Lureau
Spotted by ASAN + minor stylistic change. Signed-off-by: Marc-André Lureau --- hw/input/virtio-input.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/input/virtio-input.c b/hw/input/virtio-input.c index 51617a5885..ec54e46ad6 100644 --- a/hw/input/virtio-input.c +++ b/hw/input/virtio-

[PATCH 2/3] qtest: fix qtest_qmp_device_add leak

2019-11-07 Thread Marc-André Lureau
Spotted by ASAN. Signed-off-by: Marc-André Lureau --- tests/libqtest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/libqtest.c b/tests/libqtest.c index 3706bccd8d..91e9cb220c 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -1274,6 +1274,7 @@ void qtest_qmp_device_add(QTestSt

Re: [PATCH-for-4.1? 0/7] vl: Allow building with CONFIG_BLUETOOTH disabled

2019-11-07 Thread Thomas Huth
On 07/11/2019 20.09, Philippe Mathieu-Daudé wrote: [...] Bluetooth is dead, long live BT! v4.2.0-rc0 just got tagged. We should stop linking unmaintained dead code. If nobody step in to nuke BT, we should consider applying this series before we release QEMU 5.0 with dead Bluetooth. This approa

Re: [PATCH 4/4] Added tests for close and change of logfile.

2019-11-07 Thread Robert Foley
Thanks for providing the stack trace. We debugged this and it seems to come about because of an interesting circumstance. We added our new tests after a pre-existing test, parse_path(), which runs into an issue, a dangling pointer, which could lead to a double free. There were no other tests aft

Should QEMU's configure script check for bzip2 ?

2019-11-07 Thread Thomas Huth
Hi, I just tried to compile QEMU on a freshly installed system. "configure" finished without problems, but during "make" I hit this error: BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 /bin/sh: bzip2: command not found make: *** [Makefile:305: pc-bios/edk2-i386-secure-code.fd] Error 127 ma

Re: [PATCH v7 6/8] Acceptance tests: add the build directory to the system PATH

2019-11-07 Thread Wainer dos Santos Moschetta
On 11/4/19 1:13 PM, Cleber Rosa wrote: So that when binaries such as qemu-img are searched for, those in the build tree will be favored. As a clarification, SRC_ROOT_DIR is dependent on the location from where tests are executed, so they are equal to the build directory if one is being used.

[PATCH v2] WHPX: support for xcr0

2019-11-07 Thread Sunil Muthuswamy
Support for xcr0 to be able to enable xsave/xrstor. This by itself is not sufficient to enable xsave/xrstor. WHPX XSAVE API's also needs to be hooked up. Signed-off-by: Sunil Muthuswamy --- You will need the Windows 10 SDK for RS5 (build 17763) or above to to be able to compile this patch because

Re: Should QEMU's configure script check for bzip2 ?

2019-11-07 Thread Wainer dos Santos Moschetta
On 11/7/19 5:43 PM, Thomas Huth wrote:  Hi, I just tried to compile QEMU on a freshly installed system. "configure" finished without problems, but during "make" I hit this error:   BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 /bin/sh: bzip2: command not found make: *** [Makefile:305: pc-b

Re: [PATCH v2] WHPX: support for xcr0

2019-11-07 Thread Stefan Weil
Am 07.11.19 um 20:48 schrieb Sunil Muthuswamy: > Support for xcr0 to be able to enable xsave/xrstor. This by itself > is not sufficient to enable xsave/xrstor. WHPX XSAVE API's also > needs to be hooked up. > > Signed-off-by: Sunil Muthuswamy > --- > You will need the Windows 10 SDK for RS5 (buil

Re: [PATCH 4/4] Added tests for close and change of logfile.

2019-11-07 Thread Alex Bennée
Robert Foley writes: > Thanks for providing the stack trace. > > We debugged this and it seems to come about because of an interesting > circumstance. We added our new tests after a pre-existing test, > parse_path(), which runs into an issue, a dangling pointer, which > could lead to a double

Re: [PATCH 2/3] qtest: fix qtest_qmp_device_add leak

2019-11-07 Thread Laurent Vivier
On 07/11/2019 20:27, Marc-André Lureau wrote: > Spotted by ASAN. > > Signed-off-by: Marc-André Lureau > --- > tests/libqtest.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/libqtest.c b/tests/libqtest.c > index 3706bccd8d..91e9cb220c 100644 > --- a/tests/libqtest.c > +++ b/test

Re: [PATCH v7 7/8] Acceptance tests: depend on qemu-img

2019-11-07 Thread Wainer dos Santos Moschetta
On 11/4/19 1:13 PM, Cleber Rosa wrote: Tests using the avocado.utils.vmimage library make use of qemu-img, and because it makes sense to use the version matching the rest of the source code, let's make sure it gets built. Its selection, instead of a possible qemu-img binary installed system wi

Re: [RFC PATCH 02/18] qemu-storage-daemon: Add --object option

2019-11-07 Thread Markus Armbruster
Kevin Wolf writes: > Add a command line option to create user-creatable QOM objects. > > Signed-off-by: Kevin Wolf > --- > qemu-storage-daemon.c | 35 +++ > 1 file changed, 35 insertions(+) > > diff --git a/qemu-storage-daemon.c b/qemu-storage-daemon.c > index a2

Re: [PATCH 2/3] qtest: fix qtest_qmp_device_add leak

2019-11-07 Thread Marc-André Lureau
Hi On Fri, Nov 8, 2019 at 12:31 AM Laurent Vivier wrote: > > On 07/11/2019 20:27, Marc-André Lureau wrote: > > Spotted by ASAN. > > > > Signed-off-by: Marc-André Lureau > > --- > > tests/libqtest.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tests/libqtest.c b/tests/libqtest.

Re: [PATCH v3 00/22] iotests: Allow ./check -o data_file

2019-11-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191107163708.833192-1-mre...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v3 00/22] iotests: Allow ./check -o data_file Type: series Message-id: 20191107163708.833192-1-mre..

Re: [PATCH 2/4] Add use of RCU for qemu_logfile.

2019-11-07 Thread Robert Foley
On Thu, 7 Nov 2019 at 11:24, Alex Bennée wrote: > > Robert Foley writes: > > diff --git a/include/qemu/log.h b/include/qemu/log.h > > index a91105b2ad..975de18e23 100644 > > --- a/include/qemu/log.h > > +++ b/include/qemu/log.h > > @@ -3,9 +3,17 @@ > > > > /* A small part of this API is split i

Re: [PATCH 3/4] qemu_log_lock/unlock now preserves the qemu_logfile handle.

2019-11-07 Thread Robert Foley
On Thu, 7 Nov 2019 at 11:25, Alex Bennée wrote: > > Ahh there it is! > > We probably want to put the API change through before we add the RCU > support - so swap the patch order around. > Absolutely, we will swap around the order of the patch. -Rob Foley On Thu, 7 Nov 2019 at 11:25, Alex Bennée

Re: [PATCH 4/4] Added tests for close and change of logfile.

2019-11-07 Thread Robert Foley
Agree with all the suggestions below. These are great ideas. Will make the changes. Thanks, -Rob Foley On Thu, 7 Nov 2019 at 11:32, Alex Bennée wrote: > > > Robert Foley writes: > > > One test ensures that the logfile handle is still valid even if > > the logfile is changed during logging. >

Re: [PATCH 1/4] Add a mutex to guarantee single writer to qemu_logfile handle.

2019-11-07 Thread Robert Foley
On Thu, 7 Nov 2019 at 11:53, Alex Bennée wrote: > > It wouldn't be the worst thing in the world to expose: > > qemu_logfile_init() > > and make vl.c and main.c call it before the setup. Then you can drop the > flag or even just g_assert(qemu_log_mutex_initialised) in qemu_set_log > and qemu_set_

Re: [PATCH 0/3] Some memory leak fixes

2019-11-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191107192731.17330-1-marcandre.lur...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [PATCH 4/4] Added tests for close and change of logfile.

2019-11-07 Thread Robert Foley
On Thu, 7 Nov 2019 at 15:12, Alex Bennée wrote: > > > > For a fix, we could put this at the beginning of qemu_set_log_filename(). > > if (logfilename) { > > g_free(logfilename); > > logfilename = NULL; > > } > > g_free(logfilename) should be safe against NULL. However we need to > ensure t

RE: [PATCH v2] WHPX: support for xcr0

2019-11-07 Thread Sunil Muthuswamy
> > You will need the Windows 10 SDK for RS5 (build 17763) or above to > > to be able to compile this patch because of the definition of the > > XCR0 register. > > > > Changes since v1: > > - Added a sign-off line in the patch. > > > I am not very happy with the current situation which suggests u

[ANNOUNCE] QEMU 4.2.0-rc0 is now available

2019-11-07 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 4.2 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-4.2.0-rc0.tar.xz http://downl

Re: [Patch v2 5/6] migration/postcopy: enable random order target page arrival

2019-11-07 Thread Wei Yang
On Thu, Nov 07, 2019 at 02:30:25PM +, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> After using number of target page received to track one host page, we >> could have the capability to handle random order target page arrival in >> one host page. >> >> Thi

Re: [PATCH v15 00/12] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

2019-11-07 Thread Tao Xu
On 11/7/2019 5:03 PM, Michael S. Tsirkin wrote: On Thu, Nov 07, 2019 at 03:44:59PM +0800, Tao Xu wrote: This series of patches will build Heterogeneous Memory Attribute Table (HMAT) according to the command line. The ACPI HMAT describes the memory attributes, such as memory side cache attributes

Re: [RFC v2 11/14] linux-headers/kvm.h: add capability to forward hypercall

2019-11-07 Thread Guoheyi
On 2019/11/7 20:12, Cornelia Huck wrote: On Thu, 7 Nov 2019 19:57:22 +0800 Guoheyi wrote: On 2019/11/7 16:57, Michael S. Tsirkin wrote: On Thu, Nov 07, 2019 at 09:44:36AM +0800, Guoheyi wrote: On 2019/11/7 1:55, Cornelia Huck wrote: On Tue, 5 Nov 2019 17:10:53 +0800 Heyi Guo wrote:

Re: Looking for issues/features for my first contribution

2019-11-07 Thread Rajath Shashidhara
On 07-11-2019 07:33, Aleksandar Markovic wrote: I did a quick Google search on datasheets of existing RTC implemtations, and the result is: DS1338: https://datasheets.maximintegrated.com/en/ds/DS1338-DS1338Z.pdf M41T80: https://www.st.com/resource/en/datasheet/m41t80.pdf M48T59: http://www.el

RE: [PATCH V2 0/4] Introduce Advanced Watch Dog module

2019-11-07 Thread Zhang, Chen
Hi~ All~ Ping Anyone have time to review this series? I need more comments~ Thanks Zhang Chen > -Original Message- > From: Zhang, Chen > Sent: Friday, November 1, 2019 10:49 AM > To: Jason Wang ; Paolo Bonzini > ; Philippe Mathieu-Daudé ; > qemu-dev > Cc: Zhang Chen ; Zhang, Chen

Re: The problems about COLO

2019-11-07 Thread Daniel Cho
Lukas Straub 於 2019年11月7日 週四 下午9:34寫道: > On Thu, 7 Nov 2019 16:14:43 +0800 > Daniel Cho wrote: > > > Hi Lukas, > > Thanks for your reply. > > > > However, we test the question 1 with steps below the error message, we > > notice the secondary VM's image > > will break while it reboots. > > Here

Re: [PATCH v14 03/11] tests: Add test for QAPI builtin type time

2019-11-07 Thread Tao Xu
On 11/7/2019 9:31 PM, Eduardo Habkost wrote: On Thu, Nov 07, 2019 at 02:24:52PM +0800, Tao Xu wrote: On 11/7/2019 4:53 AM, Eduardo Habkost wrote: On Mon, Oct 28, 2019 at 03:52:12PM +0800, Tao Xu wrote: Add tests for time input such as zero, around limit of precision, signed upper limit, actual

Deprecating stuff for 4.2 (was: [Qemu-devel] Exposing feature deprecation to machine clients)

2019-11-07 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 07.11.2019 21:52, Philippe Mathieu-Daudé wrote: [...] >> Pre-release period, time to deprecate some stuffs :) >> >> How should we proceed? Do you have something in mind? >> >> There are older threads about this. Should we start a new thread? Gather the >>

Re: [virtio-dev] Re: guest / host buffer sharing ...

2019-11-07 Thread Gerd Hoffmann
On Thu, Nov 07, 2019 at 11:16:18AM +, Dr. David Alan Gilbert wrote: > * Gerd Hoffmann (kra...@redhat.com) wrote: > > Hi, > > > > > > This is not about host memory, buffers are in guest ram, everything else > > > > would make sharing those buffers between drivers inside the guest (as > > > >

Re: [PATCH v1 4/4] iotests: add test for virtio-scsi and virtio-blk machine type settings

2019-11-07 Thread Denis Plotnikov
On 07.11.2019 19:30, Cleber Rosa wrote: > On Wed, Nov 06, 2019 at 04:26:41PM -0300, Eduardo Habkost wrote: >> On Wed, Nov 06, 2019 at 11:04:16AM +0100, Max Reitz wrote: >>> On 06.11.19 10:24, Stefan Hajnoczi wrote: On Tue, Nov 05, 2019 at 07:11:05PM +0300, Denis Plotnikov wrote: > It test

Re: guest / host buffer sharing ...

2019-11-07 Thread Gerd Hoffmann
Hi, > > Adding a list of common properties to the spec certainly makes sense, > > so everybody uses the same names. Adding struct-ed properties for > > common use cases might be useful too. > > Why not define VIRTIO devices for wayland and friends? There is an out-of-tree implementation of th

Re: guest / host buffer sharing ...

2019-11-07 Thread Stefan Hajnoczi
On Fri, Nov 8, 2019 at 8:22 AM Gerd Hoffmann wrote: > > > Adding a list of common properties to the spec certainly makes sense, > > > so everybody uses the same names. Adding struct-ed properties for > > > common use cases might be useful too. > > > > Why not define VIRTIO devices for wayland and

Re: [PATCH v1 2/4] virtio: make seg_max virtqueue size dependent

2019-11-07 Thread Denis Plotnikov
The 1st patch from the series seems to be useless. The patch extending queue length by adding machine type may break vm-s which use seabios with max queue size = 128. Looks like only this patch doesn't break anything and helps to express queue size and seg max dependency (the specification cons

<    1   2   3