Re: [PATCH 0/8] Misc hw/ide legacy clean up

BALATON Zoltan writes: > These are some clean ups to remove more legacy init functions and > lessen dependence on include/hw/ide.h with some simplifications in > board code. There should be no functional change. PATCH 1 could quote precedence more clearly in the commit message, but that's detail

Re: [PATCH 4/8] hw/ide: Move MAX_IDE_BUS define to one header

BALATON Zoltan writes: > There are several definitions of MAX_IDE_BUS in different boards (some > of them unused) with the same value. Move it to include/hw/ide/internal.h > to have it in a central place. > > Signed-off-by: BALATON Zoltan This one feels a bit questionable. The number of (PATA)

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

On 14.03.2020 00:54, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 13.03.2020 18:42, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 12.03.2020 19:36, Markus Armbruster wrote: I may have a second look tomorrow with fresher eyes, but let's get this out now

Re: [PATCH v2 1/8] target/i386: Restrict X86CPUFeatureWord to X86 targets

On 3/16/20 1:29 AM, Aleksandar Markovic wrote: On Monday, March 16, 2020, Philippe Mathieu-Daudé > wrote: Move out x86-specific structures from generic machine code. Philippe, I a kind of have hard time understanding what is achieved with this patch. Is this

Re: [PATCH v7 2/5] virtio-iommu: Add iommu notifier for map/unmap

Hi Bharat, On 3/16/20 7:36 AM, Bharat Bhushan wrote: > Hi Eric, > > On Fri, Mar 13, 2020 at 7:55 PM Auger Eric wrote: >> >> Hi Bharat, >> On 3/13/20 8:48 AM, Bharat Bhushan wrote: >>> This patch extends VIRTIO_IOMMU_T_MAP/UNMAP request to >>> notify registered iommu-notifier. Which will call vfi

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

Hi Bharat, On 3/16/20 7:41 AM, Bharat Bhushan wrote: > Hi Eric, > > On Fri, Mar 13, 2020 at 8:11 PM Auger Eric wrote: >> >> Hi Bharat >> >> On 3/13/20 8:48 AM, Bharat Bhushan wrote: >>> iommu-notifier are called when a device is attached >> IOMMU notifiers >>> or detached to as address-space. >>

Re: [PATCH v5 08/26] nvme: refactor device realization

On Feb 12 11:27, Maxim Levitsky wrote: > On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > > This patch splits up nvme_realize into multiple individual functions, > > each initializing a different subset of the device. > > > > Signed-off-by: Klaus Jensen > > --- > > hw/block/nvme.c | 175

Re: [PATCH v2 00/12] user-mode: Prune build dependencies (part 1)

On 3/16/20 1:16 AM, Aleksandar Markovic wrote: On Monday, March 16, 2020, Philippe Mathieu-Daudé > wrote: This is the first part of a series reducing user-mode dependencies. By stripping out unused code, the build and testing time is reduced (as is space

Re: [PATCH v5 09/26] nvme: add temperature threshold feature

On Feb 12 11:31, Maxim Levitsky wrote: > On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > > It might seem wierd to implement this feature for an emulated device, > > but it is mandatory to support and the feature is useful for testing > > asynchronous event request support, which will be ad

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

Hi Eric, On Mon, Mar 16, 2020 at 1:02 PM Auger Eric wrote: > > Hi Bharat, > > On 3/16/20 7:41 AM, Bharat Bhushan wrote: > > Hi Eric, > > > > On Fri, Mar 13, 2020 at 8:11 PM Auger Eric wrote: > >> > >> Hi Bharat > >> > >> On 3/13/20 8:48 AM, Bharat Bhushan wrote: > >>> iommu-notifier are called w

Re: [PATCH v5 10/26] nvme: add support for the get log page command

On Feb 12 11:35, Maxim Levitsky wrote: > On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > > Add support for the Get Log Page command and basic implementations of > > the mandatory Error Information, SMART / Health Information and Firmware > > Slot Information log pages. > > > > In violatio

Re: [PATCH v5 12/26] nvme: add missing mandatory features

On Feb 12 12:27, Maxim Levitsky wrote: > On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > > Add support for returning a resonable response to Get/Set Features of > > mandatory features. > > > > Signed-off-by: Klaus Jensen > > --- > > hw/block/nvme.c | 57 +++

Re: [PATCH v5 57/60] target/riscv: vector slide instructions

On 2020/3/15 13:16, Richard Henderson wrote: On 3/12/20 7:58 AM, LIU Zhiwei wrote: +#define GEN_VEXT_VSLIDEUP_VX(NAME, ETYPE, H, CLEAR_FN)\ +void HELPER(NAME)(void *vd, void *v0, target_ulong s1, void *vs2, \ +CPURISCVState *env, uint32_t desc)

Re: [PATCH v5 14/26] nvme: make sure ncqr and nsqr is valid

On Feb 12 12:30, Maxim Levitsky wrote: > On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > > 0x is not an allowed value for NCQR and NSQR in Set Features on > > Number of Queues. > > > > Signed-off-by: Klaus Jensen > > --- > > hw/block/nvme.c | 4 > > 1 file changed, 4 insertions

Re: [PATCH v5 15/26] nvme: bump supported specification to 1.3

On Feb 12 12:35, Maxim Levitsky wrote: > On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > > Add new fields to the Identify Controller and Identify Namespace data > > structures accoding to NVM Express 1.3d. > > > > NVM Express 1.3d requires the following additional features: > > - additi

Re: [PATCH v5 21/26] nvme: add support for scatter gather lists

On Feb 12 14:07, Maxim Levitsky wrote: > On Tue, 2020-02-04 at 10:52 +0100, Klaus Jensen wrote: > > For now, support the Data Block, Segment and Last Segment descriptor > > types. > > > > See NVM Express 1.3d, Section 4.4 ("Scatter Gather List (SGL)"). > > > > Signed-off-by: Klaus Jensen > > Ack

Re: [PATCH v5 16/26] nvme: refactor prp mapping

On Feb 12 13:44, Maxim Levitsky wrote: > On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > > Refactor nvme_map_prp and allow PRPs to be located in the CMB. The logic > > ensures that if some of the PRP is in the CMB, all of it must be located > > there, as per the specification. > > To be h

Re: [PATCH v5 17/26] nvme: allow multiple aios per command

On Feb 12 13:48, Maxim Levitsky wrote: > On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > > This refactors how the device issues asynchronous block backend > > requests. The NvmeRequest now holds a queue of NvmeAIOs that are > > associated with the command. This allows multiple aios to be i

[PATCH v7 2/4] qcow2: rework the cluster compression routine

The patch enables processing the image compression type defined for the image and chooses an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- block/qcow2-threads.c | 71 ++

[PATCH v7 4/4] iotests: 287: add qcow2 compression type test

The test checks fulfilling qcow2 requiriements for the compression type feature and zstd compression type operability. Signed-off-by: Denis Plotnikov Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/287 | 128 + tests/qemu-iotests/287.out

Re: [PATCH v5 20/26] nvme: handle dma errors

On Feb 12 13:52, Maxim Levitsky wrote: > On Tue, 2020-02-04 at 10:52 +0100, Klaus Jensen wrote: > > Handling DMA errors gracefully is required for the device to pass the > > block/011 test ("disable PCI device while doing I/O") in the blktests > > suite. > > > > With this patch the device passes t

Re: [PATCH v5 22/26] nvme: support multiple namespaces

On Feb 12 14:34, Maxim Levitsky wrote: > On Tue, 2020-02-04 at 10:52 +0100, Klaus Jensen wrote: > > This adds support for multiple namespaces by introducing a new 'nvme-ns' > > device model. The nvme device creates a bus named from the device name > > ('id'). The nvme-ns devices then connect to thi

[PATCH v7 3/4] qcow2: add zstd cluster compression

zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment, is the only compression method available. The performance test results: Test compresses and decompresse

Re: [PATCH 6/8] hw/ide: Do ide_drive_get() within pci_ide_create_devs()

On 3/16/20 7:23 AM, Markus Armbruster wrote: Paolo Bonzini writes: On 13/03/20 23:16, BALATON Zoltan wrote: +    pci_dev = pci_create_simple(pci_bus, -1, "cmd646-ide"); +    pci_ide_create_devs(pci_dev); Additionally, I think it may also make sense to move pci_ide_create_devs call into the

Re: [PATCH v6 1/4] qcow2: introduce compression type feature

Thanks for the comments. I'll make the fixes accordingly and re-sent the series shortly. Denis On 14.03.2020 00:40, Eric Blake wrote: On 3/12/20 4:22 AM, Denis Plotnikov wrote: The patch adds some preparation parts for incompatible compression type feature to qcow2 allowing the use different c

Re: [PATCH] cpus: avoid stucking in pause_all_vcpus due to race

On 16/03/20 09:37, Longpeng(Mike) wrote: > From: Longpeng > > We found an issue when repeat reboot in guest during migration, it cause the > migration thread never be waken up again. > > | >| > LOCK BQL | > ...

[PATCH v7 0/4] qcow2: Implement zstd cluster compression method

v7: * use qapi_enum_parse instead of the open-coding [Eric] * fix wording, typos and spelling [Eric] v6: * "block/qcow2-threads: fix qcow2_decompress" is removed from the series since it has been accepted by Max already * add compile time checking for Qcow2Header to be a multiple

Re: [PATCH 0/2] Fix Cooperlake CPU model

On 16/03/20 02:39, Zhang, Cathy wrote: > On 1/7/2020 9:31 PM, Paolo Bonzini wrote: >> On 25/12/19 07:30, Xiaoyao Li wrote: >>> Current Cooperlake CPU model lacks VMX features which are introduced >>> by Paolo >>> several months ago, and it also lacks 2 security features in >>> MSR_IA32_ARCH_CAPABIL

[PATCH v7 1/4] qcow2: introduce compression type feature

The patch adds some preparation parts for incompatible compression type feature to qcow2 allowing the use different compression methods for image clusters (de)compressing. It is implied that the compression type is set on the image creation and can be changed only later by image conversion, thus c

Re: [PULL 132/136] mem-prealloc: optimize large guest startup

Hi, a bug has been reported in launchpad for this patch: [Regression]Powerpc kvm guest unable to start with hugepage backed memory https://bugs.launchpad.net/qemu/+bug/1866962 Thanks, Laurent Le 25/02/2020 à 13:07, Paolo Bonzini a écrit : > From: bauerchen > > [desc]: > Large

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

Hi Bharat, On 3/16/20 9:58 AM, Bharat Bhushan wrote: > Hi Eric, > > On Mon, Mar 16, 2020 at 1:15 PM Bharat Bhushan > wrote: >> >> Hi Eric, >> >> On Mon, Mar 16, 2020 at 1:02 PM Auger Eric wrote: >>> >>> Hi Bharat, >>> >>> On 3/16/20 7:41 AM, Bharat Bhushan wrote: Hi Eric, On Fri

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

Vladimir Sementsov-Ogievskiy writes: > On 14.03.2020 00:54, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 13.03.2020 18:42, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: > 12.03.2020 19:36, Markus Armbruster wrote: >> I may have a seco

Re: [PATCH 1/2] block: bdrv_set_backing_bs: fix use-after-free

On 3/16/20 7:06 AM, Vladimir Sementsov-Ogievskiy wrote: There is a use-after-free possible: bdrv_unref_child() leaves bs->backing freed but not NULL. bdrv_attach_child may produce nested polling loop due to drain, than access of freed pointer is possible. I've produced the following crash on 30

[PATCH v3 2/4] linux-user, aarch64: sync syscall numbers with kernel v5.5

Use helper script scripts/gensyscalls.sh to generate the file. This change TARGET_NR_fstatat64 by TARGET_NR_newfstatat that is correct because definitions from linux are: arch/arm64/include/uapi/asm/unistd.h #define __ARCH_WANT_NEW_STAT include/uapi/asm-generic/unistd.h #if defined(__ARCH_

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

Hi Eric, On Mon, Mar 16, 2020 at 2:35 PM Auger Eric wrote: > > Hi Bharat, > > On 3/16/20 9:58 AM, Bharat Bhushan wrote: > > Hi Eric, > > > > On Mon, Mar 16, 2020 at 1:15 PM Bharat Bhushan > > wrote: > >> > >> Hi Eric, > >> > >> On Mon, Mar 16, 2020 at 1:02 PM Auger Eric wrote: > >>> > >>> Hi B

Re: [PATCH 4/8] hw/ide: Move MAX_IDE_BUS define to one header

On 3/16/20 7:53 AM, Markus Armbruster wrote: BALATON Zoltan writes: There are several definitions of MAX_IDE_BUS in different boards (some of them unused) with the same value. Move it to include/hw/ide/internal.h to have it in a central place. Signed-off-by: BALATON Zoltan This one feels a

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

Hi Eric, On Mon, Mar 16, 2020 at 1:15 PM Bharat Bhushan wrote: > > Hi Eric, > > On Mon, Mar 16, 2020 at 1:02 PM Auger Eric wrote: > > > > Hi Bharat, > > > > On 3/16/20 7:41 AM, Bharat Bhushan wrote: > > > Hi Eric, > > > > > > On Fri, Mar 13, 2020 at 8:11 PM Auger Eric wrote: > > >> > > >> Hi Bh

[PATCH v3 1/4] scripts: add a script to generate syscall_nr.h

This script is needed for targets based on asm-generic syscall numbers generation Signed-off-by: Laurent Vivier Reviewed-by: Alistair Francis Reviewed-by: Taylor Simpson Reviewed-by: Richard Henderson --- Notes: v3: remove useless upper command v2: add comments suggested by Taylor

[PATCH] cpus: avoid stucking in pause_all_vcpus due to race

From: Longpeng We found an issue when repeat reboot in guest during migration, it cause the migration thread never be waken up again. | | LOCK BQL | ...| main_loop_should_exit

[PATCH v3 4/4] linux-user, openrisc: sync syscall numbers with kernel v5.5

Use helper script scripts/gensyscalls.sh to generate the file. Add TARGET_NR_or1k_atomic Remove useless comments and blank lines. Define diretly the __NR_XXX64 syscalls rather than using the intermediate __NR3264 definition. Remove wrong cut'n'paste (like "#ifdef __ARCH_WANT_SYNC_FILE_RANGE2") A

Re: [PATCH v2 3/8] qapi/misc: Restrict balloon-related commands to machine code

On 16.03.20 01:03, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > qapi/machine.json | 83 ++ > qapi/misc.json | 83 -- > include/sysemu/balloon.h | 2 +- > balloon.c

Re: [PATCH] target/i386: Add ARCH_CAPABILITIES related bits into Icelake-Server CPU model

On 16/03/20 06:33, Xiaoyao Li wrote: > Current Icelake-Server CPU model lacks all the features enumerated by > MSR_IA32_ARCH_CAPABILITIES. > > Add them, so that guest of "Icelake-Server" can see all of them. > > Signed-off-by: Xiaoyao Li > --- > target/i386/cpu.c | 7 ++- > 1 file changed,

[PATCH v3 3/4] linux-user, nios2: sync syscall numbers with kernel v5.5

Use helper script scripts/gensyscalls.sh to generate the file. This adds TARGET_NR_llseek that was missing and remove syscalls 1024 to 1079. Add new syscalls from 288 (pkey_mprotect) to 434 (pidfd_open) Signed-off-by: Laurent Vivier Reviewed-by: Alistair Francis --- Notes: v2: add comment

Re: [PATCH v4 2/3] mac_via: fix incorrect creation of mos6522 device in mac_via

On 16/03/20 07:03, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 15/03/20 15:56, Markus Armbruster wrote: The question is why they are not, i.e. where does the above reasoning break. >>> I don't know. But let's for the sake of the argument assume this >>> actually work

Re: [PATCH] target/rx/cpu: Use address_space_ldl() to read reset vector address

On Sun, 15 Mar 2020 at 13:49, Philippe Mathieu-Daudé wrote: > > From: Philippe Mathieu-Daudé > > The RX code flash is not a Masked ROM but a EEPROM (electrically > erasable programmable flash memory). > When implementing the flash hardware, the rom_ptr() returns NULL > and the reset vector is not

Re: [PULL 132/136] mem-prealloc: optimize large guest startup

On 16/03/20 09:42, Laurent Vivier wrote: > Hi, > > a bug has been reported in launchpad for this patch: > > [Regression]Powerpc kvm guest unable to start with hugepage backed > memory > https://bugs.launchpad.net/qemu/+bug/1866962 Indeed, I'm sending the pull request with the fix tod

Re: [PATCH v9] s390x: protvirt: Fence huge pages

On 3/13/20 9:21 AM, Christian Borntraeger wrote: > > > On 12.03.20 17:25, Janosch Frank wrote: >> Let's bail out of the protected transition if we detect that huge >> pages might be in use. >> >> Signed-off-by: Janosch Frank >> --- >> >> I'd like to squash this into the unpack patch to give a pr

[PATCH v4 3/6] virtio-net: implement RX RSS processing

If VIRTIO_NET_F_RSS negotiated and RSS is enabled, process incoming packets, calculate packet's hash and place the packet into respective RX virtqueue. Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c| 88 +- include/hw/virtio/virtio-net.h | 1

Re: [PATCH] checkpatch: enforce process for expected files

On Sun, Mar 15, 2020 at 07:35:46AM -0400, Michael S. Tsirkin wrote: > If the process documented in tests/qtest/bios-tables-test.c > is followed, then same patch never touches both expected > files and code. Teach checkpatch to enforce this rule. > > Signed-off-by: Michael S. Tsirkin > --- > > Pe

[PATCH v3 0/4] linux-user: generate syscall_nr.h from linux unistd.h

This series adds a script to generate syscall_nr.h for architectures that don't use syscall.tbl but asm-generic/unistd.h The script uses several cpp passes and filters result with a grep/sed/tr sequence. The result must be checked before being used, so it's why the script is not automatically run

[PATCH v4 0/6] reference implementation of RSS and hash report

Support for VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT features in QEMU for reference purpose. Implements Toeplitz hash calculation for incoming packets according to configuration provided by driver. Uses calculated hash for decision on receive virtqueue and/or reports the hash in the virtio hea

[PATCH v4 5/6] virtio-net: reference implementation of hash report

Suggest VIRTIO_NET_F_HASH_REPORT if specified in device parameters. If the VIRTIO_NET_F_HASH_REPORT is set, the device extends configuration space. If the feature is negotiated, the packet layout is extended to accomodate the hash information. In this case deliver packet's hash value and report typ

[PATCH v2] target/i386: Add ARCH_CAPABILITIES related bits into Icelake-Server CPU model

Current Icelake-Server CPU model lacks all the features enumerated by MSR_IA32_ARCH_CAPABILITIES. Add them, so that guest of "Icelake-Server" can see all of them. Signed-off-by: Xiaoyao Li --- v2: - Add it as a new version. --- target/i386/cpu.c | 13 + 1 file changed, 13 insertion

[PATCH] travis.yml: Set G_MESSAGES_DEBUG do report GLib errors

Since commit f5852efa293 we can display GLib errors with the QEMU error reporting API. Set it to the 'error' level, as this helps understanding failures from QEMU calls to GLib on Travis-CI. Signed-off-by: Philippe Mathieu-Daudé --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH v4 1/6] virtio-net: introduce RSS and hash report features

Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c | 65 + 1 file changed, 65 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 3627bb1717..90b01221e9 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -71,6 +71

Re: [PATCH] docs/conf.py: Raise ConfigError for bad Sphinx Python version

On Fri, 13 Mar 2020 at 22:30, John Snow wrote: > When was ConfigError introduced, and what's our minimum Sphinx version? > (Hm, looks like it's not versioned, so I'll trust it's been around a while.) Yeah, it's been around a long time; our minimum Sphinx version is 1.3. thanks -- PMM

Re: [PATCH] tools/virtiofsd: add support for --socket-group

On Sat, Mar 14, 2020 at 02:33:25PM +0100, Marc-André Lureau wrote: > Hi > > On Thu, Mar 12, 2020 at 11:49 AM Daniel P. Berrangé > wrote: > > > > On Thu, Mar 12, 2020 at 10:41:42AM +, Alex Bennée wrote: > > > If you like running QEMU as a normal user (very common for TCG runs) > > > but you h

[PATCH v4 2/6] virtio-net: implement RSS configuration command

Optionally report RSS feature. Handle RSS configuration command and keep RSS parameters in virtio-net device context. Signed-off-by: Yuri Benditovich --- hw/net/trace-events| 3 + hw/net/virtio-net.c| 189 + include/hw/virtio/virtio-net.h

Re: [PATCH 0/2] Fix Cooperlake CPU model

On 16/03/20 11:19, Zhang, Cathy wrote: > Yes, I see they are already in master, but not in v4.2 yet, so will they > be in the next release v5.0? Yes, that's what master will become. Paolo

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

Thanks David! While bisecting on upstream git with just "-cpu Penryn" we have seen that it always works there. So it might be an interaction with some Ubuntu build/packaging/configure detail together with these old chips. While we still can't be sure if the VMX warnings are a red-herring chance

[PATCH v4 6/6] virtio-net: add migration support for RSS and hash report

Save and restore RSS/hash report configuration. Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index a0614ad4e6..f343762a0f 100644 --- a/hw/net/virtio-net.c +++ b/hw

Re: [PATCH v2 2/3] acpi: Add Windows ACPI Emulated Device Table (WAET)

On Fri, 13 Mar 2020 16:50:08 +0200 Liran Alon wrote: > Microsoft introduced this ACPI table to avoid Windows guests performing > various workarounds for device erratas. As the virtual device emulated > by VMM may not have the errata. > > Currently, WAET allows hypervisor to inform guest about tw

[Bug 1867601] [NEW] test-char not concurrent with unix socket

Public bug reported: 'make check-unit' might fail when running multiple tests in parallel. Apparently occurred on OSX CI: https://travis-ci.org/github/philmd/qemu/jobs/662357430 Guess is same unix path used: static SocketAddress unixaddr = { .type = SOCKET_ADDRESS_TYPE_UNIX, .u.q_unix.p

Re: [PATCH 0/2] Fix Cooperlake CPU model

On 3/16/2020 4:41 PM, Paolo Bonzini wrote: On 16/03/20 02:39, Zhang, Cathy wrote: On 1/7/2020 9:31 PM, Paolo Bonzini wrote: On 25/12/19 07:30, Xiaoyao Li wrote: Current Cooperlake CPU model lacks VMX features which are introduced by Paolo several months ago, and it also lacks 2 security featur

[PATCH v2 0/2] thread: add lock guard macros

Lock guards automatically call qemu_(rec_)mutex_unlock() when returning from a function or leaving leaving a lexical scope. This simplifies code and eliminates leaks (especially in error code paths). This series adds lock guards for QemuMutex and QemuRecMutex. It does not convert the entire tree

Re: [PATCH v2] python/qemu/qmp.py: QMP debug with VM label

Hi Eduardo I'm already fixing it. Thank you, On Sun, Mar 15, 2020 at 5:39 PM Eduardo Habkost wrote: > On Thu, Mar 12, 2020 at 04:05:47PM +0200, Oksana Vohchana wrote: > > QEMUMachine writes some messages to the default logger. > > But it sometimes hard to read the output if we have requests to

[PATCH v2 1/2] lockable: add lock guards

This patch introduces two lock guard macros that automatically unlock a lock object (QemuMutex and others): void f(void) { QEMU_LOCK_GUARD(&mutex); if (!may_fail()) { return; /* automatically unlocks mutex */ } ... } and: WITH_QEMU_LOCK_GUARD(&mutex) {

[PATCH v4] python/qemu/qmp.py: QMP debug with VM label

QEMUMachine writes some messages to the default logger. But it sometimes hard to read the output if we have requests to more than one VM. This patch adds a label to the logger in the debug mode. Signed-off-by: Oksana Vohchana --- v2: - Instead of shown the label in the message it provides the la

[PATCH v4 4/6] tap: allow extended virtio header with hash info

Signed-off-by: Yuri Benditovich --- net/tap.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/net/tap.c b/net/tap.c index 6207f61f84..47de7fdeb6 100644 --- a/net/tap.c +++ b/net/tap.c @@ -63,6 +63,14 @@ typedef struct TAPState { Notifier exit; } TAPState; +

Re: [PATCH] softmmu/vl.c: Handle '-cpu help' and '-device help' before 'no default machine'

[Cc: Markus; he'd be pleasantly surprised with this, if he already hadn't noticed this, as he was also mildly annoyed about this the other day.] On Fri, Mar 13, 2020 at 05:24:47PM +, Peter Maydell wrote: > Currently if you try to ask for the list of CPUs for a target > architecture which does

[PULL 0/6] Audio 20200316 patches

The following changes since commit 61c265f0660ee476985808c8aa7915617c44fd53: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20200313a' into staging (2020-03-13 10:33:04 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/audio-202

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

Hi Bharat, Could you Cc me on your next posting? Unfortunately I don't have much hardware for testing this at the moment, but I might be able to help a little on the review. On Mon, Mar 16, 2020 at 02:40:00PM +0530, Bharat Bhushan wrote: > > >>> First issue is: your guest can use 4K page and you

Re: [PATCH] kvm: support to get/set dirty log initial-all-set capability

On Wed, 4 Mar 2020 10:55:54 +0800 Jay Zhou wrote: > Since the new capability KVM_DIRTY_LOG_INITIALLY_SET of > KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2 has been introduced in the > kernel, tweak the userspace side to detect and enable this > capability. > > Signed-off-by: Jay Zhou > --- > accel/kvm/kv

[PULL 6/6] audio: add audiodev format=f32 option documentation

From: Volker Rümelin The documentaion for -audiodev format=f32 option was missing. Signed-off-by: Volker Rümelin Message-id: [email protected] Signed-off-by: Gerd Hoffmann --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu

Re: [PATCH v2 0/2] thread: add lock guard macros

On 16/03/20 12:09, Stefan Hajnoczi wrote: > Lock guards automatically call qemu_(rec_)mutex_unlock() when returning from a > function or leaving leaving a lexical scope. This simplifies code and > eliminates leaks (especially in error code paths). > > This series adds lock guards for QemuMutex an

Re: [PATCH v3 0/4] linux-user: generate syscall_nr.h from linux unistd.h

Patchew URL: https://patchew.org/QEMU/[email protected]/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash expor

[PULL 5/6] audio: fix saturation nonlinearity in clip_* functions

From: Volker Rümelin The current positive limit for the saturation nonlinearity is only correct if the type of the result has 8 bits or less. Signed-off-by: Volker Rümelin Message-id: [email protected] Signed-off-by: Gerd Hoffmann --- audio/mixeng_template.h | 5 ++---

[PATCH v2 2/2] lockable: add QemuRecMutex support

The polymorphic locking macros don't support QemuRecMutex yet. Add it so that lock guards can be used with QemuRecMutex. Convert TCG plugins functions that benefit from these macros. Manual qemu_rec_mutex_lock/unlock() callers are left unmodified in cases where clarity would not improve by switc

[PULL 1/6] qapi/audio: add documentation for AudioFormat

From: Volker Rümelin The review for patch ed2a4a7941 "audio: proper support for float samples in mixeng" suggested this would be a good idea. Acked-by: Markus Armbruster Signed-off-by: Volker Rümelin Tested-by: John Arbuckle Message-id: [email protected] Signed-off-by

[PATCH] Update copyright date for user-facing copyright strings

Update the copyright date to 2020 for the copyright strings which are user-facing and represent overall copyright info for all of QEMU. Reported-by: John Arbuckle Signed-off-by: Peter Maydell --- include/qemu-common.h | 2 +- docs/conf.py | 2 +- 2 files changed, 2 insertions(+), 2 del

Re: [PATCH] checkpatch: enforce process for expected files

On Sun, 15 Mar 2020 07:35:46 -0400 "Michael S. Tsirkin" wrote: > If the process documented in tests/qtest/bios-tables-test.c > is followed, then same patch never touches both expected > files and code. Teach checkpatch to enforce this rule. > > Signed-off-by: Michael S. Tsirkin Tested-by: Igor

[PATCH 2/2] accel/tcg: avoid integer overflow

This fixes coverity issues 75235919, etc., 1524/* Handle CPU specific unaligned behaviour */ CID 75235919: (OVERFLOW_BEFORE_WIDEN) 1525. overflow_before_widen: Potentially overflowing expression "1 << a_bits" with type "int" (32 bits, signed) is evaluated using 32-bit arithmetic, and

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

No luck when testing [2]. Reports are attached ** Attachment added: "PPA packages installed" https://bugs.launchpad.net/qemu/+bug/1866870/+attachment/5337552/+files/report.install.ppa -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEM

Re: [PATCH v5 07/50] multi-process: define mpqemu-link object

On Tue, Mar 10, 2020 at 11:26:23AM -0700, Elena Ufimtseva wrote: > On Tue, Mar 10, 2020 at 04:09:41PM +, Stefan Hajnoczi wrote: > > On Mon, Feb 24, 2020 at 03:54:58PM -0500, Jagannathan Raman wrote: > > > +msg->num_fds = 0; > > > +for (chdr = CMSG_FIRSTHDR(&hdr); chdr != NULL; > > > +

Re: [PATCH] modules: load modules from versioned /var/run dir

On Tue, Mar 10, 2020 at 12:47:49PM +0100, Christian Ehrhardt wrote: > On Tue, Mar 10, 2020 at 10:39 AM Stefan Hajnoczi wrote: > > On Fri, Mar 06, 2020 at 02:26:48PM +0100, Christian Ehrhardt wrote: > And finally this has to be considered an "offer" by qemu to the packagers > to fix a real field is

[PATCH 0/2] avoid integer overflow

the constant default type is "int", when the constant is shifted to the left, it may exceed 32 bits, resulting in integer overflowing. So constant type need change to "long" Yifei Jiang (2): tcg: avoid integer overflow accel/tcg: avoid integer overflow accel/tcg/cputlb.c | 6 +++--- tcg/tcg

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

** Attachment added: "Check PPA [2} installed" https://bugs.launchpad.net/qemu/+bug/1866870/+attachment/5337555/+files/ppa2installed.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1866870 Titl

[PULL 3/6] audio: consistency changes

From: Volker Rümelin Change the clip_natural_float_from_mono() function in audio/mixeng.c to be consistent with the clip_*_from_mono() functions in audio/mixeng_template.h. Signed-off-by: Volker Rümelin Message-id: [email protected] Signed-off-by: Gerd Hoffmann --- au

[PULL 4/6] audio: change mixing engine float range to [-1.f, 1.f]

From: Volker Rümelin Currently the internal float range of the mixing engine is [-.5f, .5f]. PulseAudio, SDL2 and libasound use a [-1.f, 1.f] range. This means with float samples the audio playback volume is 6dB too low and audio recording signals will be clipped in most cases. To avoid another

Re: [PATCH 0/2] Fix Cooperlake CPU model

On 3/16/2020 6:24 PM, Paolo Bonzini wrote: On 16/03/20 11:19, Zhang, Cathy wrote: Yes, I see they are already in master, but not in v4.2 yet, so will they be in the next release v5.0? Yes, that's what master will become. Paolo That's great! Thanks for your response!

[PATCH 06/11] accel/Kconfig: Extract accel selectors into their own config

Move the accel selectors from the global Kconfig.host to their own Kconfig file. Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 1 + Kconfig.host | 7 --- accel/Kconfig | 6 ++ 3 files changed, 7 insertions(+), 7 deletions(-) create mode 100644 accel/Kconfig diff --git a/Ma

[PULL 2/6] audio: change naming scheme of FLOAT_CONV macros

From: Volker Rümelin This patch changes the naming scheme of the FLOAT_CONV_TO and FLOAT_CONV_FROM macros to the scheme used in mixeng_template.h. Signed-off-by: Volker Rümelin Message-id: [email protected] Signed-off-by: Gerd Hoffmann --- audio/mixeng.c | 22

Re: [PATCH v2 0/6] mostly changes related to audio float samples

On Sun, Mar 08, 2020 at 08:29:05PM +0100, Volker Rümelin wrote: > v2: > - "qapi/audio: add documentation for AudioFormat" >   Markus suggested to correct a spelling mistake. > > - "audio: add audiodev format=f32 option documentation" >   New patch. Pull request sent. thanks, Gerd

[PATCH 01/11] MAINTAINERS: Fix KVM path expansion glob

The KVM files has been moved from target-ARCH to the target/ARCH/ folder in commit fcf5ef2a. Fix the pathname expansion. Fixes: fcf5ef2a ("Move target-* CPU file into a target/ folder") Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[PATCH 09/11] target/mips: Always enable CONFIG_SEMIHOSTING

On MIPS, the semihosting feature is always required on user-space. Signed-off-by: Philippe Mathieu-Daudé --- default-configs/mips-linux-user-common.mak | 4 default-configs/mips-linux-user.mak| 2 ++ default-configs/mips64-linux-user.mak | 2 ++ default-configs/mips64el-linux-u

[PATCH 03/11] MAINTAINERS: Add an entry for the HAX accelerator

Signed-off-by: Philippe Mathieu-Daudé --- Cc: Sergio Andres Gomez Del Real Cc: Vincent Palatin Cc: Yu Ning Cc: Tao Wu Cc: [email protected] Cc: Colin Xu Cc: Hang Yuan Cc: David Chou Cc: Wenchao Wang --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/

Re: [PATCH RESEND v2] block/nvme: introduce PMR support from NVMe 1.4 spec

On Wed, Mar 11, 2020 at 11:08:27PM -0700, Klaus Birkelund Jensen wrote: > On Mar 11 15:54, Andrzej Jakowski wrote: > > On 3/11/20 2:20 AM, Stefan Hajnoczi wrote: > > > Please try: > > > > > > $ git grep pmem > > > > > > backends/hostmem-file.c is the backend that can be used and the > > > pmem_

Re: [PATCH 1/4] usb-serial: Move USB_TOKEN_IN into a helper function

Hi, > +if (len > s->recv_used) > +len = s->recv_used; scripts/checkpatch.pl flags a codestyle error here. > -if (len > s->recv_used) > -len = s->recv_used; Which is strictly speaking not your fault as you are just moving around existing code. It's common pract

Re: [PATCH 0/5] QEMU Gating CI

- Original Message - > From: "Peter Maydell" > To: "Cleber Rosa" > Cc: "Alex Bennée" , "QEMU Developers" > , "Fam Zheng" , > "Eduardo Habkost" , "Beraldo Leal" , > "Philippe Mathieu-Daudé" > , "Thomas Huth" , "Wainer dos Santos > Moschetta" , "Erik > Skultety" , "Willian Rampazzo" ,

[PATCH 1/2] tcg: avoid integer overflow

This fixes coverity issues 75234842, etc.,: 2221tcg_gen_andi_i64(t, t, dup_const(vece, 1)); CID 75234842: (OVERFLOW_BEFORE_WIDEN) . overflow_before_widen: Potentially overflowing expression "1 << nbit" with type "int" (32 bits, signed) is evaluated using 32-bit arithmetic, and the

  1   2   3   4   5   6   7   >