[PATCH] target/riscv/vector_helper.c: clean up reference of MTYPE

2023-06-07 Thread Xiao Wang
There's no code using MTYPE, which was a concept used in older vector implementation. Signed-off-by: Xiao Wang --- target/riscv/vector_helper.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index

Re: [RFC PATCH 00/19] hugetlb support for KVM guest_mem

2023-06-07 Thread Isaku Yamahata
On Tue, Jun 06, 2023 at 07:03:45PM +, Ackerley Tng wrote: > Hello, > > This patchset builds upon a soon-to-be-published WIP patchset that Sean > published at https://github.com/sean-jc/linux/tree/x86/kvm_gmem_solo, > mentioned > at [1]. > > The tree can be found at: >

[QEMU PATCH 1/1] virtgpu: do not destroy resources when guest suspend

2023-06-07 Thread Jiqian Chen
After suspending and resuming guest VM, you will get a black screen, and the display can't come back. This is because when guest did suspending, it called into qemu to call virtio_gpu_gl_reset. In function virtio_gpu_gl_reset, it destroyed resources and reset renderer, which were used for

[PATCH QEMU v5 2/8] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter

2023-06-07 Thread ~hyman
From: Hyman Huang(黄勇) Introduce "x-vcpu-dirty-limit-period" migration experimental parameter, which is in the range of 1 to 1000ms and used to make dirtyrate calculation period configurable. Currently with the "x-vcpu-dirty-limit-period" varies, the total time of live migration changes, test

[PATCH QEMU v5 3/8] qapi/migration: Introduce vcpu-dirty-limit parameters

2023-06-07 Thread ~hyman
From: Hyman Huang(黄勇) Introduce "vcpu-dirty-limit" migration parameter used to limit dirty page rate during live migration. "vcpu-dirty-limit" and "x-vcpu-dirty-limit-period" are two dirty-limit-related migration parameters, which can be set before and during live migration by qmp

[QEMU PATCH 0/1]

2023-06-07 Thread Jiqian Chen
Hi all, I am working to implement virtgpu S3 function on Xen. Currently on Xen, if we start a guest who enables virtgpu, and then run "echo mem > /sys/power/state" to suspend guest. And run "sudo xl trigger s3resume" to resume guest. We can find that the guest kernel comes back, but the display

[PATCH QEMU v5 7/8] migration: Extend query-migrate to provide dirty page limit info

2023-06-07 Thread ~hyman
From: Hyman Huang(黄勇) Extend query-migrate to provide throttle time and estimated ring full time with dirty-limit capability enabled, through which we can observe if dirty limit take effect during live migration. Signed-off-by: Hyman Huang(黄勇) Signed-off-by: Markus Armbruster ---

[PATCH QEMU v5 0/8] migration: introduce dirtylimit capability

2023-06-07 Thread ~hyman
I'm awfully sorry about having not updated the patchset for a long time. I have changed my email address to "yong.hu...@smartx.com", and this email address will used to post the unfinished commits in the further. I have dropped the performance improvement data, please refer to the following link

[PATCH QEMU v5 6/8] migration: Implement dirty-limit convergence algo

2023-06-07 Thread ~hyman
From: Hyman Huang(黄勇) Implement dirty-limit convergence algo for live migration, which is kind of like auto-converge algo but using dirty-limit instead of cpu throttle to make migration convergent. Enable dirty page limit if dirty_rate_high_cnt greater than 2 when dirty-limit capability

[PATCH QEMU v5 8/8] tests: Add migration dirty-limit capability test

2023-06-07 Thread ~hyman
From: Hyman Huang(黄勇) Add migration dirty-limit capability test if kernel support dirty ring. Migration dirty-limit capability introduce dirty limit capability, two parameters: x-vcpu-dirty-limit-period and vcpu-dirty-limit are introduced to implement the live migration with dirty limit. The

[PATCH QEMU v5 1/8] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit"

2023-06-07 Thread ~hyman
From: Hyman Huang(黄勇) dirty_rate paraemter of hmp command "set_vcpu_dirty_limit" is invalid if less than 0, so add parameter check for it. Note that this patch also delete the unsolicited help message and clean up the code. Signed-off-by: Hyman Huang(黄勇) Signed-off-by: Markus Armbruster

[PATCH QEMU v5 4/8] migration: Introduce dirty-limit capability

2023-06-07 Thread ~hyman
From: Hyman Huang(黄勇) Introduce migration dirty-limit capability, which can be turned on before live migration and limit dirty page rate durty live migration. Introduce migrate_dirty_limit function to help check if dirty-limit capability enabled during live migration. Meanwhile, refactor

[PATCH QEMU v5 5/8] migration: Refactor auto-converge capability logic

2023-06-07 Thread ~hyman
From: Hyman Huang(黄勇) Check if block migration is running before throttling guest down in auto-converge way. Note that this modification is kind of like code clean, because block migration does not depend on auto-converge capability, so the order of checks can be adjusted. Signed-off-by: Hyman

Re: [Qemu RFC 0/7] Early enabling of DCD emulation in Qemu

2023-06-07 Thread Shesha Bhushan Sreenivasamurthy
Hi Fan, I am implementing DCD FMAPI commands and planning to start pushing changes to the below branch. That requires the contributions you have made. Can your changes be pushed to the below branch ? https://gitlab.com/jic23/qemu/-/tree/cxl-2023-05-25 From: Fan Ni Sent: Monday, June 5,

Re: [PATCH v2] block/file-posix: fix wps checking in raw_co_prw

2023-06-07 Thread Sam Li
Damien Le Moal 于2023年6月8日周四 09:29写道: > > On 6/8/23 03:57, Sam Li wrote: > > If the write operation fails and the wps is NULL, then accessing it will > > lead to data corruption. > > > > Solving the issue by adding a nullptr checking in get_zones_wp() where > > the wps is used. > > > > This issue

Re: [PATCH v2 3/3] hw/smbios: Fix core count in type4

2023-06-07 Thread Zhao Liu
On Wed, Jun 07, 2023 at 04:51:07PM +0200, Igor Mammedov wrote: > Date: Wed, 7 Jun 2023 16:51:07 +0200 > From: Igor Mammedov > Subject: Re: [PATCH v2 3/3] hw/smbios: Fix core count in type4 > X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) > > On Thu, 1 Jun 2023 17:29:52 +0800

Re: [PATCH v2 2/3] hw/smbios: Fix thread count in type4

2023-06-07 Thread Zhao Liu
On Wed, Jun 07, 2023 at 04:49:34PM +0200, Igor Mammedov wrote: > Date: Wed, 7 Jun 2023 16:49:34 +0200 > From: Igor Mammedov > Subject: Re: [PATCH v2 2/3] hw/smbios: Fix thread count in type4 > X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) > > On Thu, 1 Jun 2023 17:29:51

Re: [PATCH v2 1/3] hw/smbios: Fix smbios_smp_sockets caculation

2023-06-07 Thread Zhao Liu
On Wed, Jun 07, 2023 at 04:35:03PM +0200, Igor Mammedov wrote: > Date: Wed, 7 Jun 2023 16:35:03 +0200 > From: Igor Mammedov > Subject: Re: [PATCH v2 1/3] hw/smbios: Fix smbios_smp_sockets caculation > X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) Hi Igor, > > On Thu, 1 Jun

Re: [PATCH v2] block/file-posix: fix wps checking in raw_co_prw

2023-06-07 Thread Damien Le Moal
On 6/8/23 03:57, Sam Li wrote: > If the write operation fails and the wps is NULL, then accessing it will > lead to data corruption. > > Solving the issue by adding a nullptr checking in get_zones_wp() where > the wps is used. > > This issue is found by Peter Maydell using the Coverity Tool (CID

Re: Building of docs does not work anymore

2023-06-07 Thread John Snow
On Wed, Jun 7, 2023 at 5:46 AM Thomas Huth wrote: > > On 07/06/2023 11.42, Thomas Huth wrote: > > > > Hi Paolo, hi John, > > > > since the recent reworks with the Python venv, building of the docs does not > > work for me on my RHEL 8 installation anymore. > > > > If I just run "configure"

Re: [PATCH 1/1] tests/avocado: update firmware to enable sbsa-ref/max

2023-06-07 Thread Philippe Mathieu-Daudé
On 7/6/23 17:29, Marcin Juszkiewicz wrote: W dniu 7.06.2023 o 16:33, Philippe Mathieu-Daudé pisze: On 30/5/23 17:22, Marcin Juszkiewicz wrote: Update prebuilt firmware images to have TF-A with FEAT_FGT support enabled. This allowed us to enable test for "max" cpu in sbsa-ref machine.

[PATCH v6 1/2] hw/i386/pc: Default to use SMBIOS 3.0 for newer machine models

2023-06-07 Thread Suravee Suthikulpanit
Currently, pc-q35 and pc-i44fx machine models are default to use SMBIOS 2.8 (32-bit entry point). Since SMBIOS 3.0 (64-bit entry point) is now fully supported since QEMU 7.0, default to use SMBIOS 3.0 for newer machine models. This is necessary to avoid the following message when launching a VM

[PATCH v6 0/2] hw/i386/pc: Update max_cpus and default to SMBIOS

2023-06-07 Thread Suravee Suthikulpanit
In order to support large number of vcpus, a newer 64-bit SMBIOS entry point type is needed. Therefore, upgrade the default SMBIOS version for PC machines to SMBIOS 3.0 for newer systems. Then increase the maximum number of vCPUs for Q35 models to 1024, which is the limit for KVM. Changes from

[PATCH v6 2/2] pc: q35: Bump max_cpus to 1024

2023-06-07 Thread Suravee Suthikulpanit
Since KVM_MAX_VCPUS is currently defined to 1024 for x86 as shown in arch/x86/include/asm/kvm_host.h, update QEMU limits to the same number. In case KVM could not support the specified number of vcpus, QEMU would return the following error message: qemu-system-x86_64: kvm_init_vcpu:

Re: [PATCH 1/1] maintainers: update maintainers list for vfio-user & multi-process QEMU

2023-06-07 Thread Philippe Mathieu-Daudé
On 7/6/23 17:58, Jagannathan Raman wrote: Signed-off-by: Jagannathan Raman --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 436b3f0afefd..4a80a385118d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3786,7 +3786,6 @@ F:

Re: [PATCH v5 1/3] hw/i386/pc: Refactor logic to set SMBIOS defaults

2023-06-07 Thread Suthikulpanit, Suravee
On 6/7/2023 3:11 PM, Daniel P. Berrangé wrote: On Tue, Jun 06, 2023 at 09:49:37PM -0500, Suravee Suthikulpanit wrote: Into a helper function pc_machine_init_smbios() in preparation for subsequent code to upgrade default SMBIOS entry point type. Then, call the helper function from the

Re: [PATCH v5 2/3] hw/i386/pc: Default to use SMBIOS 3.0 for newer machine models

2023-06-07 Thread Suthikulpanit, Suravee
On 6/7/2023 8:49 PM, Igor Mammedov wrote: On Tue, 6 Jun 2023 21:49:38 -0500 Suravee Suthikulpanit wrote: and use this with the rest of your patch diff --git a/hw/i386/pc.c b/hw/i386/pc.c index b3d826a83a..c5bab28e9c 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1859,7 +1859,7 @@

Re: [PATCH 16/16] target/riscv/kvm.c: read/write (cbom|cboz)_blocksize in KVM

2023-06-07 Thread Daniel Henrique Barboza
On 6/7/23 10:01, Andrew Jones wrote: On Tue, May 30, 2023 at 04:46:23PM -0300, Daniel Henrique Barboza wrote: If we don't set a proper cbom_blocksize|cboz_blocksize in the FDT the Linux Kernel will fail to detect the availability of the CBOM/CBOZ extensions, regardless of the contents of the

[PATCH v2] hw/acpi: Fix PM control register access

2023-06-07 Thread BALATON Zoltan
On pegasos2 which has ACPI as part of VT8231 south bridge the board firmware writes PM control register by accessing the second byte so addr will be 1. This wasn't handled correctly and the write went to addr 0 instead. Remove the acpi_pm1_cnt_write() function which is used only once and does not

Re: [PATCH 13/16] target/riscv/kvm.c: add multi-letter extension KVM properties

2023-06-07 Thread Daniel Henrique Barboza
On 6/7/23 08:48, Andrew Jones wrote: On Tue, May 30, 2023 at 04:46:20PM -0300, Daniel Henrique Barboza wrote: Let's add KVM user properties for the multi-letter extensions that KVM currently supports: zicbom, zicboz, zihintpause, zbb, ssaia, sstc, svinval and svpbmt. As with the recently

Re: [RFC v2 3/6] target/i386: Add native library calls

2023-06-07 Thread Richard Henderson
On 6/7/23 09:47, Yeqi Fu wrote: +/* One unknown opcode for native call */ +#if defined(CONFIG_USER_ONLY) && defined(CONFIG_USER_NATIVE_CALL) +case 0x1ff: +uint16_t sig = x86_lduw_code(env, s); +switch (sig) { +case NATIVE_MEMCPY: +

Re: [RFC v2 4/6] target/mips: Add native library calls

2023-06-07 Thread Richard Henderson
On 6/7/23 09:47, Yeqi Fu wrote: +void helper_native_memcpy(CPUMIPSState *env) +{ +CPUState *cs = env_cpu(env); +NATIVE_FN_W_3W(); +void *ret; +void *dest = g2h(cs, arg0); +void *src = g2h(cs, arg1); +size_t n = (size_t)arg2; +ret = memcpy(dest, src, n); +

Re: [RFC v2 3/6] target/i386: Add native library calls

2023-06-07 Thread Richard Henderson
On 6/7/23 09:47, Yeqi Fu wrote: +arg0 = *(target_ulong *)g2h(cs, env->regs[R_ESP] + 4); \ +arg1 = *(target_ulong *)g2h(cs, env->regs[R_ESP] + 8); \ +arg2 = *(target_ulong *)g2h(cs, env->regs[R_ESP] + 12); This is not correct, and will fail on big-endian hosts. You need to use

Re: [PATCH v5 00/11] *** Add allwinner-r40 support ***

2023-06-07 Thread Niek Linnenbank
Hi Peter, Qianfan, On Mon, Jun 5, 2023 at 5:31 PM Peter Maydell wrote: > On Thu, 1 Jun 2023 at 19:48, Niek Linnenbank > wrote: > > > > Hi Qianfan, > > > > Thanks for sending the v5. From my side, I have no further comments on > the content. > > So please feel free to add the following to each

[PATCH v2] block/file-posix: fix wps checking in raw_co_prw

2023-06-07 Thread Sam Li
If the write operation fails and the wps is NULL, then accessing it will lead to data corruption. Solving the issue by adding a nullptr checking in get_zones_wp() where the wps is used. This issue is found by Peter Maydell using the Coverity Tool (CID 1512459). Signed-off-by: Sam Li ---

Re: [PATCH] iotests: fix 194: filter out racy postcopy-active event

2023-06-07 Thread Richard Henderson
On 6/7/23 07:36, Vladimir Sementsov-Ogievskiy wrote: The event is racy: it will not appear in the output if bitmap is migrated during downtime period of migration and postcopy phase is not started. Fixes: ae00aa239847 "iotests: 194: test also migration of dirty bitmap" Reported-by: Richard

Re: [PULL 00/12] xen queue

2023-06-07 Thread Richard Henderson
in the Git repository at: https://xenbits.xen.org/git-http/people/aperard/qemu-dm.git tags/pull-xen-20230607 for you to fetch changes up to 9000666052f99ed4217e75b73636acae61e6fc2c: xen-block: fix segv on unrealize (2023-06-07 15:07:10 +0100

Re: [PULL 0/2] vfio-user queue

2023-06-07 Thread Richard Henderson
at: https://gitlab.com/jraman/qemu.git tags/pull-vfio-user-20230607 for you to fetch changes up to 7771e8b86335968ee46538d1afd44246e7a062bc: docs: fix multi-process QEMU documentation (2023-06-07 10:21:53 -0400) vfio-user: Fix

Re: [PATCH 04/20] migration: file URI

2023-06-07 Thread Steven Sistare
Please ignore this, wrong subject line. I will resend. - steve On 6/7/2023 2:37 PM, Steve Sistare wrote: > Extend the migration URI to support file:. This can be used for > any migration scenario that does not require a reverse path. It can be used > as an alternative to 'exec:cat > file' in

[PATCH V2] migration: file URI

2023-06-07 Thread Steve Sistare
Extend the migration URI to support file:. This can be used for any migration scenario that does not require a reverse path. It can be used as an alternative to 'exec:cat > file' in minimized containers that do not contain /bin/sh, and it is easier to use than the fd: URI. It can be used in HMP

[PATCH 04/20] migration: file URI

2023-06-07 Thread Steve Sistare
Extend the migration URI to support file:. This can be used for any migration scenario that does not require a reverse path. It can be used as an alternative to 'exec:cat > file' in minimized containers that do not contain /bin/sh, and it is easier to use than the fd: URI. It can be used in HMP

Re: [Qemu RFC 0/7] Early enabling of DCD emulation in Qemu

2023-06-07 Thread Fan Ni
On Wed, Jun 07, 2023 at 06:13:01PM +, Shesha Bhushan Sreenivasamurthy wrote: > Hi Fan, >I am implementing DCD FMAPI commands and planning to start pushing changes > to the below branch. That requires the contributions you have made. Can your > changes be pushed to the below branch ? > >

Re: [PATCH v3 10/14] nbd/client: Initial support for extended headers

2023-06-07 Thread Eric Blake
The subject lines are confusing: 9/14 enables extended headers in the server, while this one does not yet enable the headers but is merely a preliminary step. I'll probably retitle one or the other in v4. On Wed, May 31, 2023 at 06:26:17PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 15.05.23

Re: [PATCH] iotests: fix 194: filter out racy postcopy-active event

2023-06-07 Thread Stefan Hajnoczi
On Wed, Jun 07, 2023 at 05:36:06PM +0300, Vladimir Sementsov-Ogievskiy wrote: > The event is racy: it will not appear in the output if bitmap is > migrated during downtime period of migration and postcopy phase is not > started. > > Fixes: ae00aa239847 "iotests: 194: test also migration of dirty

Re: [PATCH 2/2] block/file-posix: fix wps checking in raw_co_prw

2023-06-07 Thread Stefan Hajnoczi
On Sun, Jun 04, 2023 at 02:16:58PM +0800, Sam Li wrote: > If the write operation fails and the wps is NULL, then accessing it will > lead to data corruption. > > Solving the issue by adding a nullptr checking in get_zones_wp() where > the wps is used. > > This issue is found by Peter Maydell

Re: [PATCH 1/2] block/file-posix: fix g_file_get_contents return path

2023-06-07 Thread Stefan Hajnoczi
On Sun, Jun 04, 2023 at 02:16:57PM +0800, Sam Li wrote: > The g_file_get_contents() function returns a g_boolean. If it fails, the > returned value will be 0 instead of -1. Solve the issue by skipping > assigning ret value. > > This issue was found by Matthew Rosato using virtio-blk-{pci,ccw}

Re: [PATCH v2 00/11] block: Re-enable the graph lock

2023-06-07 Thread Stefan Hajnoczi
On Mon, Jun 05, 2023 at 10:57:00AM +0200, Kevin Wolf wrote: > This series fixes the deadlock that was observed before commit ad128dff > ('graph-lock: Disable locking for now'), which just disabled the graph > lock completely as a workaround to get 8.0.1 stable. > > In theory the problem is

Re: [PATCH V9 00/46] Live Update

2023-06-07 Thread Steven Sistare
On 6/7/2023 11:55 AM, Michael Galaxy wrote: > Another option could be to expose "-migrate-mode-disable" (instead of enable) > and just enable all 3 modes by default, > since we are already required to switch from "normal" mode to a CPR-specific > mode when it is time to do a live update, > if

Re: [PATCH v4] 9pfs: prevent opening special files (CVE-2023-2861)

2023-06-07 Thread Michael Tokarev
07.06.2023 19:29, Christian Schoenebeck wrote: The 9p protocol does not specifically define how server shall behave when client tries to open a special file, however from security POV it does make sense for 9p server to prohibit opening any special file on host side in general. A sane Linux 9p

[QEMU][PATCH v7 09/10] hw/arm: introduce xenpvh machine

2023-06-07 Thread Vikram Garhwal
Add a new machine xenpvh which creates a IOREQ server to register/connect with Xen Hypervisor. Optional: When CONFIG_TPM is enabled, it also creates a tpm-tis-device, adds a TPM emulator and connects to swtpm running on host machine via chardev socket and support TPM functionalities for a guest

[QEMU][PATCH v7 07/10] hw/xen/xen-hvm-common: Use g_new and error_report

2023-06-07 Thread Vikram Garhwal
Replace g_malloc with g_new and perror with error_report. Signed-off-by: Vikram Garhwal Reviewed-by: Stefano Stabellini Reviewed-by: Paul Durrant --- hw/xen/xen-hvm-common.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/xen/xen-hvm-common.c

[QEMU][PATCH v7 06/10] hw/xen/xen-hvm-common: skip ioreq creation on ioreq registration failure

2023-06-07 Thread Vikram Garhwal
From: Stefano Stabellini On ARM it is possible to have a functioning xenpv machine with only the PV backends and no IOREQ server. If the IOREQ server creation fails continue to the PV backends initialization. Also, moved the IOREQ registration and mapping subroutine to new function

[QEMU][PATCH v7 10/10] meson.build: enable xenpv machine build for ARM

2023-06-07 Thread Vikram Garhwal
Add CONFIG_XEN for aarch64 device to support build for ARM targets. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed-by: Alex Bennée --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index

[QEMU][PATCH v7 08/10] meson.build: do not set have_xen_pci_passthrough for aarch64 targets

2023-06-07 Thread Vikram Garhwal
From: Stefano Stabellini have_xen_pci_passthrough is only used for Xen x86 VMs. Signed-off-by: Stefano Stabellini Reviewed-by: Alex Bennée --- meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meson.build b/meson.build index a61d3e9b06..786c69b06d 100644 --- a/meson.build +++

[QEMU][PATCH v7 04/10] xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common

2023-06-07 Thread Vikram Garhwal
From: Stefano Stabellini This patch does following: 1. creates arch_handle_ioreq() and arch_xen_set_memory(). This is done in preparation for moving most of xen-hvm code to an arch-neutral location, move the x86-specific portion of xen_set_memory to arch_xen_set_memory. Also, move

[QEMU][PATCH v7 01/10] hw/i386/xen/: move xen-mapcache.c to hw/xen/

2023-06-07 Thread Vikram Garhwal
xen-mapcache.c contains common functions which can be used for enabling Xen on aarch64 with IOREQ handling. Moving it out from hw/i386/xen to hw/xen to make it accessible for both aarch64 and x86. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed-by: Paul Durrant ---

[QEMU][PATCH v7 05/10] include/hw/xen/xen_common: return error from xen_create_ioreq_server

2023-06-07 Thread Vikram Garhwal
From: Stefano Stabellini This is done to prepare for enabling xenpv support for ARM architecture. On ARM it is possible to have a functioning xenpv machine with only the PV backends and no IOREQ server. If the IOREQ server creation fails, continue to the PV backends initialization.

[QEMU][PATCH v7 03/10] hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState

2023-06-07 Thread Vikram Garhwal
From: Stefano Stabellini In preparation to moving most of xen-hvm code to an arch-neutral location, move: - shared_vmport_page - log_for_dirtybit - dirty_bitmap - suspend - wakeup out of XenIOState struct as these are only used on x86, especially the ones related to dirty logging. Updated

[QEMU][PATCH v7 00/10] Introduce xenpvh machine for arm architecture

2023-06-07 Thread Vikram Garhwal
Hi, Rebased and resending the series with latest QEMU as it's been quite sometime. There is one line code change in patch 04/10. Rest is just rebased with latest. Also, this series has dependency on following gitlab-ci patch: https://lists.nongnu.org/archive/html/qemu-devel/2023-06/msg01471.html.

[QEMU][PATCH v7 02/10] hw/i386/xen: rearrange xen_hvm_init_pc

2023-06-07 Thread Vikram Garhwal
In preparation to moving most of xen-hvm code to an arch-neutral location, move non IOREQ references to: - xen_get_vmport_regs_pfn - xen_suspend_notifier - xen_wakeup_notifier - xen_ram_init towards the end of the xen_hvm_init_pc() function. This is done to keep the common ioreq functions in one

Re: [PATCH v2 06/12] aspeed/smc: Wire CS lines at reset

2023-06-07 Thread Cédric Le Goater
On 6/7/23 12:49, Joel Stanley wrote: On Wed, 7 Jun 2023 at 04:40, Cédric Le Goater wrote: Currently, a set of default flash devices is created at machine init and drives defined on the QEMU command line are associated to the FMC and SPI controllers in sequence : -drive

Re: [PULL 0/5] misc ci fixes

2023-06-07 Thread Richard Henderson
at: https://gitlab.com/rth7680/qemu.git tags/pull-ci-20230607 for you to fetch changes up to dcc28ab603f30df5cc8be1f759b423e94ae7d10f: iotests: fix 194: filter out racy postcopy-active event (2023-06-07 08:36:55 -0700) Fix TCI

[RFC v2 4/6] target/mips: Add native library calls

2023-06-07 Thread Yeqi Fu
Signed-off-by: Yeqi Fu --- target/mips/helper.h| 6 target/mips/tcg/meson.build | 1 + target/mips/tcg/native_helper.c | 55 + target/mips/tcg/translate.c | 20 +++- target/mips/tcg/translate.h | 12 +++ 5 files changed,

Re: [PATCH 2/3] migration/multifd: Protect accesses to migration_threads

2023-06-07 Thread Juan Quintela
Sounds good. On Wed, Jun 7, 2023, 18:28 Peter Xu wrote: > On Wed, Jun 07, 2023 at 09:00:14AM -0300, Fabiano Rosas wrote: > > >> diff --git a/migration/migration.c b/migration/migration.c > > >> index e731fc98a1..b3b8345eb2 100644 > > >> --- a/migration/migration.c > > >> +++

[PATCH v4] 9pfs: prevent opening special files (CVE-2023-2861)

2023-06-07 Thread Christian Schoenebeck
The 9p protocol does not specifically define how server shall behave when client tries to open a special file, however from security POV it does make sense for 9p server to prohibit opening any special file on host side in general. A sane Linux 9p client for instance would never attempt to open a

[RFC v2 6/6] linux-user: Add '-native-bypass' option

2023-06-07 Thread Yeqi Fu
Signed-off-by: Yeqi Fu --- include/qemu/envlist.h | 1 + linux-user/main.c | 23 + util/envlist.c | 56 ++ 3 files changed, 80 insertions(+) diff --git a/include/qemu/envlist.h b/include/qemu/envlist.h index

[RFC v2 2/6] Add the libnative library

2023-06-07 Thread Yeqi Fu
Signed-off-by: Yeqi Fu --- common-user/native/libnative.c | 65 ++ include/native/libnative.h | 11 ++ include/native/native-func.h | 11 ++ 3 files changed, 87 insertions(+) create mode 100644 common-user/native/libnative.c create mode 100644

Re: [PATCH 0/1] update maintainers list for vfio-user & multi-process QEMU

2023-06-07 Thread Jag Raman
> On Jun 7, 2023, at 12:44 PM, Stefan Hajnoczi wrote: > > On Wed, 7 Jun 2023 at 11:58, Jagannathan Raman wrote: >> >> John Johnson doesn't work at Oracle anymore. I tried to contact him to >> get his updated email address, but I haven't heard anything from him. >> >> Jagannathan Raman (1):

[RFC v2 5/6] target/arm: Add native library calls

2023-06-07 Thread Yeqi Fu
Signed-off-by: Yeqi Fu --- target/arm/helper.c| 47 ++ target/arm/helper.h| 6 + target/arm/tcg/translate-a64.c | 22 target/arm/tcg/translate.c | 25 +- target/arm/tcg/translate.h | 19

[RFC v2 1/6] build: Add configure options for native calls

2023-06-07 Thread Yeqi Fu
Signed-off-by: Yeqi Fu --- Makefile| 4 +++ common-user/native/Makefile.include | 9 ++ common-user/native/Makefile.target | 22 + configure | 50 + docs/devel/build-system.rst | 4 +++

[RFC v2 0/6] Native Library Calls

2023-06-07 Thread Yeqi Fu
This patch introduces a set of feature instructions for native calls and provides helpers to translate these instructions to corresponding native functions. A shared library is also implemented, where native functions are rewritten as feature instructions. At runtime, user programs load the shared

[RFC v2 3/6] target/i386: Add native library calls

2023-06-07 Thread Yeqi Fu
Signed-off-by: Yeqi Fu --- target/i386/helper.h | 6 +++ target/i386/tcg/translate.c | 20 + target/i386/tcg/user/meson.build | 1 + target/i386/tcg/user/native_helper.c | 65 4 files changed, 92 insertions(+) create mode

Re: [PATCH 0/1] update maintainers list for vfio-user & multi-process QEMU

2023-06-07 Thread Stefan Hajnoczi
On Wed, 7 Jun 2023 at 11:58, Jagannathan Raman wrote: > > John Johnson doesn't work at Oracle anymore. I tried to contact him to > get his updated email address, but I haven't heard anything from him. > > Jagannathan Raman (1): > maintainers: update maintainers list for vfio-user &

Re: [PATCH V2] oslib: qemu_clear_cloexec

2023-06-07 Thread Steven Sistare
Hi Paolo, Can I get an RB from you on this patch, since you maintain posix? This is needed for live update, to preserve vfio device descriptors and character device descriptors across the exec of the new qemu binary. If yes, I will rebase to the tip and repost a V3. - Steve On 2/7/2023 2:03

Re: [PATCH v2] target/riscv/vector_helper.c: Remove the check for extra tail elements

2023-06-07 Thread Weiwei Li
On 2023/6/7 17:16, Xiao Wang wrote: Commit 752614cab8e6 ("target/riscv: rvv: Add tail agnostic for vector load / store instructions") added an extra check for LMUL fragmentation, intended for setting the "rest tail elements" in the last register for a segment load insn. Actually, the

Re: [PATCH v5 1/3] hw/i386/pc: Refactor logic to set SMBIOS defaults

2023-06-07 Thread Igor Mammedov
On Tue, 6 Jun 2023 21:49:37 -0500 Suravee Suthikulpanit wrote: > Into a helper function pc_machine_init_smbios() in preparation for > subsequent code to upgrade default SMBIOS entry point type. > > Then, call the helper function from the pc_machine_initfn() to eliminate > duplicate code in

[PULL 5/5] iotests: fix 194: filter out racy postcopy-active event

2023-06-07 Thread Richard Henderson
From: Vladimir Sementsov-Ogievskiy The event is racy: it will not appear in the output if bitmap is migrated during downtime period of migration and postcopy phase is not started. Fixes: ae00aa239847 "iotests: 194: test also migration of dirty bitmap" Reported-by: Richard Henderson

Re: [PATCH v2 5/8] hw/ide/ahci: PxCI should not get cleared when ERR_STAT is set

2023-06-07 Thread Niklas Cassel
On Wed, Jun 07, 2023 at 06:01:17PM +0200, Niklas Cassel wrote: > On Mon, Jun 05, 2023 at 08:19:43PM -0400, John Snow wrote: > > On Thu, Jun 1, 2023 at 9:46 AM Niklas Cassel wrote: > > > > > > From: Niklas Cassel > > > > > > For NCQ, PxCI is cleared on command queued successfully. > > > For

[PULL 1/3] meson: fix "static build" entry in summary

2023-06-07 Thread Paolo Bonzini
Fixes: a0cbd2e8496 ("meson: use prefer_static option", 2023-05-18) Signed-off-by: Paolo Bonzini --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 553c8e0b9c5..c03326c922e 100644 --- a/meson.build +++ b/meson.build @@ -4088,7

[PULL 2/3] configure: check for $download value properly

2023-06-07 Thread Paolo Bonzini
From: Michal Privoznik If configure was invoked with --disable-download and git submodules were not checked out a warning is produced and the configure script fails. But the $download variable (which reflects the enable/disable download argument) is checked for in a weird fashion: test -f

[PULL 3/3] tests: fp: remove unused submodules

2023-06-07 Thread Paolo Bonzini
tests/fp/berkeley-softfloat-3 and tests/fp/berkeley-testfloat-3 have been replaced by subprojects, so remove the now-unnecessary submodules. Reported-by: Michal Privoznik Signed-off-by: Paolo Bonzini --- tests/fp/berkeley-softfloat-3 | 1 - tests/fp/berkeley-testfloat-3 | 1 - 2 files changed,

[PULL 3/5] target/arm: Only include tcg/oversized-guest.h if CONFIG_TCG

2023-06-07 Thread Richard Henderson
Fixes the build for --disable-tcg. This header is only needed for cross-hosting. Without CONFIG_TCG, we know this is an AArch64 host, CONFIG_ATOMIC64 will be set, and the TCG_OVERSIZED_GUEST block will never be compiled. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson ---

[PULL 5/6] target/tricore: Fix wrong PSW for call insns

2023-06-07 Thread Bastian Koppelmann
we were copying PSW into a local variable, updated PSW.CDE in the local and never wrote it back. So when we called save_context_upper() we were using the non-local version of PSW which did not contain the updated PSW.CDE. Signed-off-by: Bastian Koppelmann Message-Id:

[PULL 6/6] tests/tcg/tricore: Add recursion test for CSAs

2023-06-07 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann Message-Id: <20230526061946.54514-7-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/Makefile.softmmu-target | 3 ++- tests/tcg/tricore/c/test_context_save_areas.c | 15 +++ 2 files changed, 17 insertions(+), 1 deletion(-) create mode

[PULL 3/6] tests/tcg/tricore: Add first C program

2023-06-07 Thread Bastian Koppelmann
this allows us to exercise the startup code used by GCC to call main(). Signed-off-by: Bastian Koppelmann Message-Id: <20230526061946.54514-4-kbast...@mail.uni-paderborn.de> --- configure | 1 + tests/tcg/tricore/Makefile.softmmu-target | 13 +

[PULL 4/6] target/tricore: Refactor PCXI/ICR register fields

2023-06-07 Thread Bastian Koppelmann
starting from ISA version 1.6.1 (previously known as 1.6P/E), some bitfields in PCXI and ICR have changed. We also refactor these registers using the register fields API. Signed-off-by: Bastian Koppelmann Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1453 Message-Id:

[PULL 0/6] tricore queue

2023-06-07 Thread Bastian Koppelmann
tags/pull-tricore-20230607 for you to fetch changes up to e926c94171ae37397c8c4b54cef60e5c7ebbf243: tests/tcg/tricore: Add recursion test for CSAs (2023-06-07 18:20:51 +0200) - Refactor PCXI/ICR field handling in newer ISA versions

[PULL 2/6] tests/tcg/tricore: Uses label for memory addresses

2023-06-07 Thread Bastian Koppelmann
the linker might rearrange sections, so lets reference memory by label name instead of addr + off. Signed-off-by: Bastian Koppelmann Message-Id: <20230526061946.54514-3-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/asm/macros.h | 1 - tests/tcg/tricore/asm/test_ld_bu.S | 4 ++--

[PULL 1/6] tests/tcg/tricore: Move asm tests into 'asm' directory

2023-06-07 Thread Bastian Koppelmann
this seperates these tests from the upcoming tests written in C. Also rename the compiled test to 'test_.asm.tst'. Signed-off-by: Bastian Koppelmann Message-Id: <20230526061946.54514-2-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/Makefile.softmmu-target | 35 ---

Re: [PATCH v2 0/3] migration: Fix multifd cancel test

2023-06-07 Thread Peter Xu
On Wed, Jun 07, 2023 at 01:13:03PM -0300, Fabiano Rosas wrote: > Fabiano Rosas (3): > migration/multifd: Rename threadinfo.c functions > migration/multifd: Protect accesses to migration_threads > tests/qtest: Re-enable multifd cancel test Reviewed-by: Peter Xu -- Peter Xu

[PATCH v2 0/3] migration: Fix multifd cancel test

2023-06-07 Thread Fabiano Rosas
v2: - patch 1: dropped the qmp_ prefix; - patch 2: dropped the qemu_mutex_destroy; stopped moving the _remove functions (don't strictly need it anymore since not destroying the mutex explicitly); added the lock to protect the loop in

[PATCH v2 3/3] tests/qtest: Re-enable multifd cancel test

2023-06-07 Thread Fabiano Rosas
We've found the source of flakiness in this test, so re-enable it. Reviewed-by: Juan Quintela Signed-off-by: Fabiano Rosas --- tests/qtest/migration-test.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c

[PATCH v2 2/3] migration/multifd: Protect accesses to migration_threads

2023-06-07 Thread Fabiano Rosas
This doubly linked list is common for all the multifd and migration threads so we need to avoid concurrent access. Add a mutex to protect the data from concurrent access. This fixes a crash when removing two MigrationThread objects from the list at the same time during cleanup of multifd threads.

[PATCH v2 1/3] migration/multifd: Rename threadinfo.c functions

2023-06-07 Thread Fabiano Rosas
We're about to add more functions to this file so make it use the same coding style as the rest of the code. Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela Reviewed-by: Philippe Mathieu-Daudé --- migration/migration.c | 4 ++-- migration/multifd.c| 4 ++-- migration/threadinfo.c

Re: [PATCH] vdpa: fix not using CVQ buffer in case of error

2023-06-07 Thread Michael Tokarev
07.06.2023 16:52, Eugenio Perez Martin wrote: On Wed, Jun 7, 2023 at 12:11 PM Michael Tokarev wrote: .. Again, smells like a stable material, is it not? Please Cc: qemu-sta...@nongnu.org for other changes you think should be applied to stable qemu series. Sorry, I totally forgot. This one

Re: [PATCH v2 5/8] hw/ide/ahci: PxCI should not get cleared when ERR_STAT is set

2023-06-07 Thread Niklas Cassel
On Mon, Jun 05, 2023 at 08:19:43PM -0400, John Snow wrote: > On Thu, Jun 1, 2023 at 9:46 AM Niklas Cassel wrote: > > > > From: Niklas Cassel > > > > For NCQ, PxCI is cleared on command queued successfully. > > For non-NCQ, PxCI is cleared on command completed successfully. > > Successfully means

[PATCH 1/1] maintainers: update maintainers list for vfio-user & multi-process QEMU

2023-06-07 Thread Jagannathan Raman
Signed-off-by: Jagannathan Raman --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 436b3f0afefd..4a80a385118d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3786,7 +3786,6 @@ F: tests/tcg/aarch64/system/semiheap.c Multi-process QEMU M: Elena

[PATCH 0/1] update maintainers list for vfio-user & multi-process QEMU

2023-06-07 Thread Jagannathan Raman
John Johnson doesn't work at Oracle anymore. I tried to contact him to get his updated email address, but I haven't heard anything from him. Jagannathan Raman (1): maintainers: update maintainers list for vfio-user & multi-process QEMU MAINTAINERS | 1 - 1 file changed, 1 deletion(-) --

Re: [PATCH V3] migration: simplify blockers

2023-06-07 Thread Peter Xu
On Wed, Jun 07, 2023 at 07:35:32AM -0700, Steve Sistare wrote: > Modify migrate_add_blocker and migrate_del_blocker to take an Error ** > reason. This allows migration to own the Error object, so that if > an error occurs, migration code can free the Error and clear the client > handle,

Re: [PATCH V9 00/46] Live Update

2023-06-07 Thread Michael Galaxy
Another option could be to expose "-migrate-mode-disable" (instead of enable) and just enable all 3 modes by default, since we are already required to switch from "normal" mode to a CPR-specific mode when it is time to do a live update, if the intention is to preserve the capability to

  1   2   3   >