Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU

2024-01-14 Thread Xiaoyao Li
On 1/15/2024 1:59 PM, Zhao Liu wrote: (Also cc "machine core" maintainers.) Hi Xiaoyao, On Mon, Jan 15, 2024 at 12:18:17PM +0800, Xiaoyao Li wrote: Date: Mon, 15 Jan 2024 12:18:17 +0800 From: Xiaoyao Li Subject: Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU On 1/15/2024

Re: [PATCH V2 08/11] migration: refactor migrate_fd_connect failures

2024-01-14 Thread Peter Xu
On Fri, Jan 12, 2024 at 07:05:07AM -0800, Steve Sistare wrote: > Move common code for the error path in migrate_fd_connect to a shared > fail label. No functional change. > > Signed-off-by: Steve Sistare Reviewed-by: Peter Xu One nitpick below: > --- > migration/migration.c | 22

Re: [PATCH V2 11/11] vfio: allow cpr-reboot migration if suspended

2024-01-14 Thread Peter Xu
On Fri, Jan 12, 2024 at 07:05:10AM -0800, Steve Sistare wrote: > Allow cpr-reboot for vfio if the guest is in the suspended runstate. The > guest drivers' suspend methods flush outstanding requests and re-initialize > the devices, and thus there is no device state to save and restore. The > user

[PATCH] qemu/osdep: Add huge page aligned support on LoongArch platform

2024-01-14 Thread Bibo Mao
On LoongArch kvm mode if transparent huge page wants to be enabled, base address and size of memslot from both HVA and GPA view. And LoongArch supports both 4K and 16K page size with Linux kernel, so transparent huge page size is calculated from real page size rather than hardcoded size.

[PATCH] configure: Add linux header compile support for LoongArch

2024-01-14 Thread Bibo Mao
When compiling qemu with system KVM mode for LoongArch, header files in directory linux-headers/asm-loongarch should be used firstly. Otherwise it fails to find kvm.h on system with old glibc, since latest kernel header files are not installed. This patch adds linux_arch definition for LoongArch

Re: [PATCH] linux-user: Fixed cpu restore with pc 0 on SIGBUS

2024-01-14 Thread Robbin Ehn
Hi, Palmer, On Fri, Jan 12, 2024 at 10:03 PM Palmer Dabbelt wrote: > > On Fri, 12 Jan 2024 12:57:22 PST (-0800), r...@rivosinc.com wrote: > > Commit f4e1168198 (linux-user: Split out host_sig{segv,bus}_handler) > > introduced a bug, when returning from host_sigbus_handler the PC is > > So we

Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F]

2024-01-14 Thread Xiaoyao Li
On 1/15/2024 2:35 PM, Zhao Liu wrote: On Mon, Jan 15, 2024 at 02:11:17PM +0800, Xiaoyao Li wrote: Date: Mon, 15 Jan 2024 14:11:17 +0800 From: Xiaoyao Li Subject: Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F] On 1/15/2024 2:12 PM, Zhao Liu wrote: Hi Xiaoyao, On Mon, Jan 15,

[PATCH] tests/qtest/meson.build: Bump the boot-serial-test timeout to 4 minutes

2024-01-14 Thread Thomas Huth
When running with TCI, the boot-serial-test can take longer than 3 minutes: https://gitlab.com/qemu-project/qemu/-/jobs/5890481086#L4774 Bump the timeout to 4 minutes to avoid CI failures here. Signed-off-by: Thomas Huth --- tests/qtest/meson.build | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH V2] Handle wrap around in limit calculation

2024-01-14 Thread Shlomo Pongratz
Thank you. Please see comments inline. On Fri, Jan 12, 2024 at 7:03 PM Peter Maydell wrote: On Tue, 9 Jan 2024 at 12:45, Shlomo Pongratz wrote: Hi; thanks for this patch. Hanlde wrap around caused by the fact that perior to version 460A Is this "460A" version number a version of the

Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F]

2024-01-14 Thread Zhao Liu
On Mon, Jan 15, 2024 at 02:57:30PM +0800, Yuan Yao wrote: > Date: Mon, 15 Jan 2024 14:57:30 +0800 > From: Yuan Yao > Subject: Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F] > > On Mon, Jan 15, 2024 at 02:20:20PM +0800, Zhao Liu wrote: > > On Mon, Jan 15, 2024 at 01:20:22PM +0800,

Re: [PATCH 03/12] tests/plugin: add test plugin for inline operations

2024-01-14 Thread Pierrick Bouvier
On 1/13/24 21:16, Alex Bennée wrote: Pierrick Bouvier writes: On 1/12/24 21:20, Alex Bennée wrote: Pierrick Bouvier writes: On 1/11/24 19:57, Philippe Mathieu-Daudé wrote: Hi Pierrick, On 11/1/24 15:23, Pierrick Bouvier wrote: For now, it simply performs instruction, bb and mem count,

[PATCH] tests/qtest/npcm7xx_watchdog_timer: Only test the corner cases by default

2024-01-14 Thread Thomas Huth
The test_prescaler() part in the npcm7xx_watchdog_timer test is quite repetive, testing all possible combinations of the WTCLK and WTIS bitfields. Since each test spins up a new instance of QEMU, this is rather an expensive test, especially on loaded host systems. For the normal quick test mode,

Re: [PATCH v3 03/20] multifd: Zero pages transmission

2024-01-14 Thread Shivam Kumar
> On 04-Jan-2024, at 6:14 AM, Hao Xiang wrote: > > From: Juan Quintela > > This implements the zero page dection and handling. > > Signed-off-by: Juan Quintela > --- > migration/multifd.c | 41 +++-- > migration/multifd.h | 5 + > 2 files changed, 44

Re: [PATCH v7 14/16] i386: Use CPUCacheInfo.share_level to encode CPUID[4]

2024-01-14 Thread Xiaoyao Li
On 1/15/2024 2:25 PM, Zhao Liu wrote: Hi Xiaoyao, On Mon, Jan 15, 2024 at 12:25:19PM +0800, Xiaoyao Li wrote: Date: Mon, 15 Jan 2024 12:25:19 +0800 From: Xiaoyao Li Subject: Re: [PATCH v7 14/16] i386: Use CPUCacheInfo.share_level to encode CPUID[4] On 1/15/2024 11:40 AM, Zhao Liu wrote:

Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F]

2024-01-14 Thread Yuan Yao
On Mon, Jan 15, 2024 at 02:20:20PM +0800, Zhao Liu wrote: > On Mon, Jan 15, 2024 at 01:20:22PM +0800, Yuan Yao wrote: > > Date: Mon, 15 Jan 2024 13:20:22 +0800 > > From: Yuan Yao > > Subject: Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F] > > > > Ah, so my understanding is

Re: [PATCH V2 04/11] migration: remove migration_in_postcopy parameter

2024-01-14 Thread Peter Xu
On Fri, Jan 12, 2024 at 07:05:03AM -0800, Steve Sistare wrote: > bool migration_in_incoming_postcopy(void) > diff --git a/ui/spice-core.c b/ui/spice-core.c > index b3cd229..e43a93f 100644 > --- a/ui/spice-core.c > +++ b/ui/spice-core.c > @@ -580,7 +580,7 @@ static int

Re: [PATCH v3 13/20] migration/multifd: Prepare to introduce DSA acceleration on the multifd path.

2024-01-14 Thread Shivam Kumar
> On 04-Jan-2024, at 6:14 AM, Hao Xiang wrote: > > 1. Refactor multifd_send_thread function. > 2. Implement buffer_is_zero_use_cpu to handle CPU based zero page > checking. > 3. Introduce the batch task structure in MultiFDSendParams. > > Signed-off-by: Hao Xiang > --- > include/qemu/dsa.h

Re: [PATCH 1/2] migration/rdma: define htonll/ntohll only if not predefined

2024-01-14 Thread Nick Briggs
Thank you. Yes, with those two patches applied I have compiled qemu on Solaris 11.4 running on a SPARC-T4-1 (sun4v) system to emulate a single target: an HP PA-RISC. > On Jan 14, 2024, at 8:35 PM, Peter Xu wrote: > > On Thu, Jan 11, 2024 at 01:20:17PM -0500, Nick Briggs wrote: >> Solaris has

Re: [PATCH V2 03/11] migration: convert to NotifierWithReturn

2024-01-14 Thread Peter Xu
On Fri, Jan 12, 2024 at 07:05:02AM -0800, Steve Sistare wrote: > Change all migration notifiers to type NotifierWithReturn, so notifiers > can return an error status in a future patch. For now, pass NULL for the > notifier error parameter, and do not check the return value. > > Signed-off-by:

Re: [PATCH V2 02/11] migration: remove error from notifier data

2024-01-14 Thread Peter Xu
On Fri, Jan 12, 2024 at 07:05:01AM -0800, Steve Sistare wrote: > Remove the error object from opaque data passed to notifiers. > Use the new error parameter passed to the notifier instead. > > Signed-off-by: Steve Sistare Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH V2 01/11] notify: pass error to notifier with return

2024-01-14 Thread Peter Xu
On Fri, Jan 12, 2024 at 07:05:00AM -0800, Steve Sistare wrote: > Pass an error object as the third parameter to "notifier with return" > notifiers, so clients no longer need to bundle an error object in the > opaque data. The new parameter is used in a later patch. > > Signed-off-by: Steve

[PATCH v9 1/4] hw/riscv: Use misa_mxl instead of misa_mxl_max

2024-01-14 Thread Akihiko Odaki
A later commit requires one extra step to retrieve misa_mxl_max. As misa_mxl is semantically more correct and does not need such a extra step, refer to misa_mxl instead. Below is the explanation why misa_mxl is more semantically correct to refer to than misa_mxl_max in this case. Currently

[PATCH v9 4/4] target/riscv: Validate misa_mxl_max only once

2024-01-14 Thread Akihiko Odaki
misa_mxl_max is now a class member and initialized only once for each class. This also moves the initialization of gdb_core_xml_file which will be referenced before realization in the future. Signed-off-by: Akihiko Odaki Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 21

Re: [PATCH] target/i386: Eip error in x86_64-softmmu

2024-01-14 Thread Michael Tokarev
15.01.2024 05:08, guoguangyao : When closing PCREL, qemu-system-x86_64 run into error. Eip modification here leads to the result. Using s->pc in func gen_update_eip_next() solves the problem. Fixes: b5e0d5d22fbf("target/i386: Fix 32-bit wrapping of pc/eip computation") Signed-off-by:

[PATCH v9 0/4] gdbstub and TCG plugin improvements

2024-01-14 Thread Akihiko Odaki
This series extracts fixes and refactorings that can be applied independently from "[PATCH v9 00/23] plugins: Allow to read registers". The patch "target/riscv: Move MISA limits to class" was replaced with patch "target/riscv: Move misa_mxl_max to class" since I found instances may have different

[PATCH v9 2/4] target/riscv: Remove misa_mxl validation

2024-01-14 Thread Akihiko Odaki
It is initialized with a simple assignment and there is little room for error. In fact, the validation is even more complex. Signed-off-by: Akihiko Odaki Acked-by: LIU Zhiwei Reviewed-by: Daniel Henrique Barboza Acked-by: Alistair Francis --- target/riscv/tcg/tcg-cpu.c | 15 +++

[PATCH v9 3/4] target/riscv: Move misa_mxl_max to class

2024-01-14 Thread Akihiko Odaki
misa_mxl_max is common for all instances of a RISC-V CPU class so they are better put into class. Signed-off-by: Akihiko Odaki Reviewed-by: Alistair Francis --- target/riscv/cpu.h | 4 +- target/riscv/cpu.c | 162 -

Re: [PATCH v2 0/2] Nitpick at the error message's output

2024-01-14 Thread Yong Huang
Ping On Sun, Jan 7, 2024 at 7:53 PM Hyman Huang wrote: > v2: > - rebase on master > - add a commit to sort the error message so that an explanation > error number can be returned on all failure paths > > Hyman Huang (2): > i386/sev: Sort the error message > i386/sev: Nitpick at the error

Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F]

2024-01-14 Thread Zhao Liu
On Mon, Jan 15, 2024 at 02:11:17PM +0800, Xiaoyao Li wrote: > Date: Mon, 15 Jan 2024 14:11:17 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F] > > On 1/15/2024 2:12 PM, Zhao Liu wrote: > > Hi Xiaoyao, > > > > On Mon, Jan 15, 2024 at 12:34:12PM

Re: [RFC PATCH v3 00/30] migration: File based migration with multifd and fixed-ram

2024-01-14 Thread Peter Xu
On Thu, Jan 11, 2024 at 03:38:31PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Mon, Nov 27, 2023 at 05:25:42PM -0300, Fabiano Rosas wrote: > >> Hi, > >> > >> In this v3: > >> > >> Added support for the "file:/dev/fdset/" syntax to receive multiple > >> file descriptors. This allows

Re: [PATCH v7 14/16] i386: Use CPUCacheInfo.share_level to encode CPUID[4]

2024-01-14 Thread Zhao Liu
Hi Xiaoyao, On Mon, Jan 15, 2024 at 12:25:19PM +0800, Xiaoyao Li wrote: > Date: Mon, 15 Jan 2024 12:25:19 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH v7 14/16] i386: Use CPUCacheInfo.share_level to encode > CPUID[4] > > On 1/15/2024 11:40 AM, Zhao Liu wrote: > > > > +{ > > > > +uint32_t

Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F]

2024-01-14 Thread Xiaoyao Li
On 1/15/2024 2:12 PM, Zhao Liu wrote: Hi Xiaoyao, On Mon, Jan 15, 2024 at 12:34:12PM +0800, Xiaoyao Li wrote: Date: Mon, 15 Jan 2024 12:34:12 +0800 From: Xiaoyao Li Subject: Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F] Yes, I think it's time to move to default 0x1f. we

Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F]

2024-01-14 Thread Zhao Liu
On Mon, Jan 15, 2024 at 01:20:22PM +0800, Yuan Yao wrote: > Date: Mon, 15 Jan 2024 13:20:22 +0800 > From: Yuan Yao > Subject: Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F] > > Ah, so my understanding is incorrect on this. > > I tried on one raptor lake i5-i335U, which also

Re: [PATCH v3 01/20] multifd: Add capability to enable/disable zero_page

2024-01-14 Thread Shivam Kumar
> On 04-Jan-2024, at 6:14 AM, Hao Xiang wrote: > > From: Juan Quintela > > We have to enable it by default until we introduce the new code. > > Signed-off-by: Juan Quintela > --- > migration/options.c | 15 +++ > migration/options.h | 1 + > qapi/migration.json | 8 +++- > 3

Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F]

2024-01-14 Thread Zhao Liu
Hi Xiaoyao, On Mon, Jan 15, 2024 at 12:34:12PM +0800, Xiaoyao Li wrote: > Date: Mon, 15 Jan 2024 12:34:12 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F] > > > Yes, I think it's time to move to default 0x1f. > > we don't need to do so until

Re: [PATCH V2] Handle wrap around in limit calculation

2024-01-14 Thread Shlomo Pongratz
Thank you. Please see comments inline. On Fri, Jan 12, 2024 at 7:03 PM Peter Maydell wrote: > > On Tue, 9 Jan 2024 at 12:45, Shlomo Pongratz wrote: > > Hi; thanks for this patch. > > > Hanlde wrap around caused by the fact that perior to version 460A > > Is this "460A" version number a version

Re: [RFC 3/3] tests/qtest: Add STM32L4x5 GPIO QTest testcase

2024-01-14 Thread Thomas Huth
Hi! On 12/01/2024 18.05, Inès Varhol wrote: Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- Maybe add a short patch description (e.g. saying what aspects of the GPIOs are tested here)? diff --git a/tests/qtest/stm32l4x5_gpio-test.c b/tests/qtest/stm32l4x5_gpio-test.c new

Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU

2024-01-14 Thread Zhao Liu
(Also cc "machine core" maintainers.) Hi Xiaoyao, On Mon, Jan 15, 2024 at 12:18:17PM +0800, Xiaoyao Li wrote: > Date: Mon, 15 Jan 2024 12:18:17 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU > > On 1/15/2024 11:27 AM, Zhao Liu wrote: > > On

Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F]

2024-01-14 Thread Yuan Yao
On Mon, Jan 15, 2024 at 12:34:12PM +0800, Xiaoyao Li wrote: > On 1/15/2024 12:09 PM, Zhao Liu wrote: > > Hi Yuan, > > > > On Mon, Jan 15, 2024 at 11:25:24AM +0800, Yuan Yao wrote: > > > Date: Mon, 15 Jan 2024 11:25:24 +0800 > > > From: Yuan Yao > > > Subject: Re: [PATCH v7 08/16] i386: Expose

Re: [PATCH 1/2] migration/rdma: define htonll/ntohll only if not predefined

2024-01-14 Thread Peter Xu
On Thu, Jan 11, 2024 at 01:20:17PM -0500, Nick Briggs wrote: > Solaris has #defines for htonll and ntohll which cause syntax errors > when compiling code that attempts to (re)define these functions.. > > Signed-off-by: Nick Briggs I left the other QGA patch for QGA maintainers, assuming this

[PATCH 1/3] hw/arm: Refactor struct arm_boot_info::get_dtb()

2024-01-14 Thread Bin Meng
At present we expect struct arm_boot_info::get_dtb() to return the device tree pointer as well as the device tree size. However, this is not necessary as we can get the device tree size via the device tree header directly. Change get_dtb() signature to drop the *size argument, and get the size by

[PATCH 3/3] tests/acpi: Update virt/SSDT.memhp

2024-01-14 Thread Bin Meng
The Arm dtb changes caused an address change: DefinitionBlock ("", "SSDT", 1, "BOCHS ", "NVDIMM", 0x0001) { [ ... ] -Name (MEMA, 0x43C8) +Name (MEMA, 0x43D8) } Signed-off-by: Bin Meng --- tests/data/acpi/virt/SSDT.memhp | Bin 1817 -> 1817 bytes 1 file changed, 0

[PATCH 0/3] hw/arm: Pack the QEMU generated device tree

2024-01-14 Thread Bin Meng
By default, QEMU generates a 1 MiB sized device tree. This appears to be unnecessary, as the actual size is much smaller than what the DTB header claims. Let's pack it to save some room. Bin Meng (3): hw/arm: Refactor struct arm_boot_info::get_dtb() hw/arm: Pack the QEMU generated device

[PATCH 2/3] hw/arm: Pack the QEMU generated device tree

2024-01-14 Thread Bin Meng
By default QEMU generates a 1 MiB sized device tree. Let's pack it to save some room. Signed-off-by: Bin Meng --- hw/arm/boot.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index ff1173299f..511ec10ed0 100644 --- a/hw/arm/boot.c +++

Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F]

2024-01-14 Thread Xiaoyao Li
On 1/15/2024 12:09 PM, Zhao Liu wrote: Hi Yuan, On Mon, Jan 15, 2024 at 11:25:24AM +0800, Yuan Yao wrote: Date: Mon, 15 Jan 2024 11:25:24 +0800 From: Yuan Yao Subject: Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F] On Mon, Jan 08, 2024 at 04:27:19PM +0800, Zhao Liu wrote:

Re: [PATCH v7 15/16] i386: Use offsets get NumSharingCache for CPUID[0x8000001D].EAX[bits 25:14]

2024-01-14 Thread Xiaoyao Li
On 1/15/2024 11:48 AM, Zhao Liu wrote: Hi Xiaoyao, On Sun, Jan 14, 2024 at 10:42:41PM +0800, Xiaoyao Li wrote: Date: Sun, 14 Jan 2024 22:42:41 +0800 From: Xiaoyao Li Subject: Re: [PATCH v7 15/16] i386: Use offsets get NumSharingCache for CPUID[0x801D].EAX[bits 25:14] On 1/8/2024 4:27

Re: [PATCH v7 14/16] i386: Use CPUCacheInfo.share_level to encode CPUID[4]

2024-01-14 Thread Xiaoyao Li
On 1/15/2024 11:40 AM, Zhao Liu wrote: +{ +uint32_t num_ids = 0; + +switch (share_level) { +case CPU_TOPO_LEVEL_CORE: +num_ids = 1 << apicid_core_offset(topo_info); +break; +case CPU_TOPO_LEVEL_DIE: +num_ids = 1 << apicid_die_offset(topo_info); +

Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU

2024-01-14 Thread Xiaoyao Li
On 1/15/2024 11:27 AM, Zhao Liu wrote: On Sun, Jan 14, 2024 at 09:49:18PM +0800, Xiaoyao Li wrote: Date: Sun, 14 Jan 2024 21:49:18 +0800 From: Xiaoyao Li Subject: Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU On 1/8/2024 4:27 PM, Zhao Liu wrote: From: Zhuocheng Ding

Re: [PATCH v3 4/4] [NOT FOR MERGE] tests/qtest/migration: Adapt tests to use older QEMUs

2024-01-14 Thread Peter Xu
On Thu, Jan 11, 2024 at 10:58:49AM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Wed, Jan 10, 2024 at 11:42:18AM -0300, Fabiano Rosas wrote: > >> Peter Xu writes: > >> > >> > On Tue, Jan 09, 2024 at 11:46:32AM -0300, Fabiano Rosas wrote: > >> >> Hm, it would be better to avoid the

Re: [PATCH v7 02/16] i386/cpu: Use APIC ID offset to encode cache topo in CPUID[4]

2024-01-14 Thread Zhao Liu
Hi Xiaoyao, On Mon, Jan 15, 2024 at 11:51:05AM +0800, Xiaoyao Li wrote: > Date: Mon, 15 Jan 2024 11:51:05 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH v7 02/16] i386/cpu: Use APIC ID offset to encode cache > topo in CPUID[4] > > On 1/11/2024 4:43 PM, Zhao Liu wrote: > > Hi Xiaoyao, > > > >

Re: [PATCH 40/40] vdpa: add trace event for vhost_vdpa_net_load_mq

2024-01-14 Thread Jason Wang
On Fri, Dec 8, 2023 at 2:51 AM Si-Wei Liu wrote: > > For better debuggability and observability. > > Signed-off-by: Si-Wei Liu > --- > net/trace-events | 1 + > net/vhost-vdpa.c | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/net/trace-events b/net/trace-events > index

Re: [PATCH 38/40] vdpa: add trace events for eval_flush

2024-01-14 Thread Jason Wang
On Fri, Dec 8, 2023 at 2:51 AM Si-Wei Liu wrote: > > For better debuggability and observability. > > Signed-off-by: Si-Wei Liu > --- > net/trace-events | 2 ++ > net/vhost-vdpa.c | 7 +++ > 2 files changed, 9 insertions(+) > > diff --git a/net/trace-events b/net/trace-events > index

Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F]

2024-01-14 Thread Zhao Liu
Hi Yuan, On Mon, Jan 15, 2024 at 11:25:24AM +0800, Yuan Yao wrote: > Date: Mon, 15 Jan 2024 11:25:24 +0800 > From: Yuan Yao > Subject: Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F] > > On Mon, Jan 08, 2024 at 04:27:19PM +0800, Zhao Liu wrote: > > From: Zhao Liu > > > > Linux

Re: [PATCH 37/40] vdpa: add vhost_vdpa_set_dev_vring_base trace for svq mode

2024-01-14 Thread Jason Wang
On Fri, Dec 8, 2023 at 2:51 AM Si-Wei Liu wrote: > > For better debuggability and observability. > > Signed-off-by: Si-Wei Liu Acked-by: Jason Wang Thanks

Re: [PATCH 36/40] vdpa: add vhost_vdpa_get_vring_base trace for svq mode

2024-01-14 Thread Jason Wang
On Fri, Dec 8, 2023 at 2:51 AM Si-Wei Liu wrote: > > For better debuggability and observability. > > Signed-off-by: Si-Wei Liu > --- > hw/virtio/trace-events | 2 +- > hw/virtio/vhost-vdpa.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/hw/virtio/trace-events

Re: [PATCH v7 02/16] i386/cpu: Use APIC ID offset to encode cache topo in CPUID[4]

2024-01-14 Thread Xiaoyao Li
On 1/11/2024 4:43 PM, Zhao Liu wrote: Hi Xiaoyao, On Wed, Jan 10, 2024 at 05:31:28PM +0800, Xiaoyao Li wrote: Date: Wed, 10 Jan 2024 17:31:28 +0800 From: Xiaoyao Li Subject: Re: [PATCH v7 02/16] i386/cpu: Use APIC ID offset to encode cache topo in CPUID[4] On 1/8/2024 4:27 PM, Zhao Liu

Re: [PATCH 35/40] vdpa: add vhost_vdpa_set_address_space_id trace

2024-01-14 Thread Jason Wang
On Fri, Dec 8, 2023 at 2:51 AM Si-Wei Liu wrote: > > For better debuggability and observability. > > Signed-off-by: Si-Wei Liu > --- > net/trace-events | 3 +++ > net/vhost-vdpa.c | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/net/trace-events b/net/trace-events > index

Re: [PATCH 34/40] vdpa: fix network breakage after cancelling migration

2024-01-14 Thread Jason Wang
On Fri, Dec 8, 2023 at 2:51 AM Si-Wei Liu wrote: > > Fix an issue where cancellation of ongoing migration ends up > with no network connectivity. > > When canceling migration, SVQ will be switched back to the > passthrough mode, but the right call fd is not programed to > the device and the svq's

Re: [PATCH 33/40] vdpa: batch multiple dma_unmap to a single call for vm stop

2024-01-14 Thread Jason Wang
On Fri, Dec 8, 2023 at 2:51 AM Si-Wei Liu wrote: > > Should help live migration downtime on source host. Below are the > coalesced dma_unmap time series on 2 queue pair config (no > dedicated descriptor group ASID for SVQ). It's better to explain how we can batch into a single call (e.g do we

Re: [PATCH v7 09/16] i386: Support module_id in X86CPUTopoIDs

2024-01-14 Thread Zhao Liu
Hi Xiaoyao, On Sun, Jan 14, 2024 at 08:42:00PM +0800, Xiaoyao Li wrote: > Date: Sun, 14 Jan 2024 20:42:00 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH v7 09/16] i386: Support module_id in X86CPUTopoIDs > > On 1/8/2024 4:27 PM, Zhao Liu wrote: > > From: Zhuocheng Ding > > > > Add module_id

Re: [RFC PATCH v3 04/30] io: fsync before closing a file channel

2024-01-14 Thread Peter Xu
On Fri, Jan 12, 2024 at 10:40:28AM +, Daniel P. Berrangé wrote: > On Fri, Jan 12, 2024 at 08:01:36AM +0800, Peter Xu wrote: > > On Thu, Jan 11, 2024 at 03:46:02PM -0300, Fabiano Rosas wrote: > > > > (1) Does this apply to all io channel users, or only migration? > > > > > > All file channel

Re: [PATCH v7 15/16] i386: Use offsets get NumSharingCache for CPUID[0x8000001D].EAX[bits 25:14]

2024-01-14 Thread Zhao Liu
Hi Xiaoyao, On Sun, Jan 14, 2024 at 10:42:41PM +0800, Xiaoyao Li wrote: > Date: Sun, 14 Jan 2024 22:42:41 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH v7 15/16] i386: Use offsets get NumSharingCache for > CPUID[0x801D].EAX[bits 25:14] > > On 1/8/2024 4:27 PM, Zhao Liu wrote: > > From:

Re: [PATCH 32/40] vdpa: factor out vhost_vdpa_net_get_nc_vdpa

2024-01-14 Thread Jason Wang
On Fri, Dec 8, 2023 at 2:51 AM Si-Wei Liu wrote: > > Introduce new API. No functional change on existing API. > > Signed-off-by: Si-Wei Liu Acked-by: Jason Wang Thanks

Re: [PATCH 31/40] vdpa: batch map and unmap around cvq svq start/stop

2024-01-14 Thread Jason Wang
On Fri, Dec 8, 2023 at 2:51 AM Si-Wei Liu wrote: > > Coalesce map or unmap operations to exact one DMA > batch to reduce potential impact on performance. > > Signed-off-by: Si-Wei Liu Acked-by: Jason Wang Thanks

Re: [PATCH 30/40] vdpa: batch map/unmap op per svq pair basis

2024-01-14 Thread Jason Wang
On Fri, Dec 8, 2023 at 2:51 AM Si-Wei Liu wrote: > > Coalesce multiple map or unmap operations to just one > so that all mapping setup or teardown can occur in a > single DMA batch. > > Signed-off-by: Si-Wei Liu Acked-by: Jason Wang Thanks

Re: [PATCH 29/40] vdpa: expose API vhost_vdpa_dma_batch_once

2024-01-14 Thread Jason Wang
On Fri, Dec 8, 2023 at 2:51 AM Si-Wei Liu wrote: > > So that the batching API can be called from other file > externally than the local. > > Signed-off-by: Si-Wei Liu > --- > hw/virtio/vhost-vdpa.c | 21 +++-- > include/hw/virtio/vhost-vdpa.h | 3 +++ > 2 files changed,

Re: [PATCH v7 14/16] i386: Use CPUCacheInfo.share_level to encode CPUID[4]

2024-01-14 Thread Zhao Liu
Hi Xiaoyao, On Sun, Jan 14, 2024 at 10:31:50PM +0800, Xiaoyao Li wrote: > Date: Sun, 14 Jan 2024 22:31:50 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH v7 14/16] i386: Use CPUCacheInfo.share_level to encode > CPUID[4] > > On 1/8/2024 4:27 PM, Zhao Liu wrote: > > From: Zhao Liu > > > >

Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F]

2024-01-14 Thread Yuan Yao
On Mon, Jan 08, 2024 at 04:27:19PM +0800, Zhao Liu wrote: > From: Zhao Liu > > Linux kernel (from v6.4, with commit edc0a2b595765 ("x86/topology: Fix > erroneous smp_num_siblings on Intel Hybrid platforms") is able to > handle platforms with Module level enumerated via CPUID.1F. > > Expose the

Re: [PATCH 28/40] vdpa: support iotlb_batch_asid

2024-01-14 Thread Jason Wang
On Fri, Dec 8, 2023 at 2:51 AM Si-Wei Liu wrote: > > Then it's possible to specify ASID when calling the DMA > batching API. If the ASID to work on doesn't align with > the ASID for ongoing transaction, the API will fail the > request and return negative, and the transaction will > remain intact

Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU

2024-01-14 Thread Zhao Liu
On Sun, Jan 14, 2024 at 09:49:18PM +0800, Xiaoyao Li wrote: > Date: Sun, 14 Jan 2024 21:49:18 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU > > On 1/8/2024 4:27 PM, Zhao Liu wrote: > > From: Zhuocheng Ding > > > > Introduce cluster-id other

Re: [PATCH 25/40] vdpa: add asid to dma_batch_once API

2024-01-14 Thread Jason Wang
On Fri, Dec 8, 2023 at 2:51 AM Si-Wei Liu wrote: > > So that DMA batching API can operate on other ASID than 0. > > Signed-off-by: Si-Wei Liu > --- > hw/virtio/trace-events | 4 ++-- > hw/virtio/vhost-vdpa.c | 14 -- > 2 files changed, 10 insertions(+), 8 deletions(-) > > diff

Re: [PATCH 24/40] vdpa: factor out vhost_vdpa_dma_batch_end

2024-01-14 Thread Jason Wang
On Fri, Dec 8, 2023 at 2:52 AM Si-Wei Liu wrote: > > Refactoring only. No functional change. > > Signed-off-by: Si-Wei Liu > --- > hw/virtio/trace-events | 2 +- > hw/virtio/vhost-vdpa.c | 30 ++ > 2 files changed, 19 insertions(+), 13 deletions(-) > > diff --git

Re: [PATCH 23/40] vdpa: vhost_vdpa_dma_batch_begin_once rename

2024-01-14 Thread Jason Wang
On Fri, Dec 8, 2023 at 2:51 AM Si-Wei Liu wrote: > > No functional changes. Rename only. > > Signed-off-by: Si-Wei Liu > --- > hw/virtio/vhost-vdpa.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c > index

Re: [PATCH 22/40] vdpa: factor out vhost_vdpa_map_batch_begin

2024-01-14 Thread Jason Wang
On Fri, Dec 8, 2023 at 2:51 AM Si-Wei Liu wrote: > > Refactoring only. No functional change. > > Signed-off-by: Si-Wei Liu Acked-by: Jason Wang Thanks > --- > hw/virtio/trace-events | 2 +- > hw/virtio/vhost-vdpa.c | 25 - > 2 files changed, 17 insertions(+), 10

Re: [PATCH] target/i386: Eip error in x86_64-softmmu

2024-01-14 Thread Richard Henderson
On 1/15/24 13:08, guoguangyao wrote: When closing PCREL, qemu-system-x86_64 run into error. Eip modification here leads to the result. Using s->pc in func gen_update_eip_next() solves the problem. Fixes: b5e0d5d22fbf("target/i386: Fix 32-bit wrapping of pc/eip computation") Signed-off-by:

Re: [PATCH 21/40] vdpa: vhost_vdpa_dma_batch_end_once rename

2024-01-14 Thread Jason Wang
On Mon, Jan 15, 2024 at 10:40 AM Jason Wang wrote: > > On Fri, Dec 8, 2023 at 2:51 AM Si-Wei Liu wrote: > > > > No functional changes. Rename only. > > > > Signed-off-by: Si-Wei Liu > > --- > > hw/virtio/vhost-vdpa.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff

Re: [PATCH v7 02/16] i386/cpu: Use APIC ID offset to encode cache topo in CPUID[4]

2024-01-14 Thread Zhao Liu
Hi Xiaoyao, On Sun, Jan 14, 2024 at 10:11:59PM +0800, Xiaoyao Li wrote: > Date: Sun, 14 Jan 2024 22:11:59 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH v7 02/16] i386/cpu: Use APIC ID offset to encode cache > topo in CPUID[4] > > On 1/11/2024 4:43 PM, Zhao Liu wrote: > > Hi Xiaoyao, > > > >

Re: [PATCH 21/40] vdpa: vhost_vdpa_dma_batch_end_once rename

2024-01-14 Thread Jason Wang
On Fri, Dec 8, 2023 at 2:51 AM Si-Wei Liu wrote: > > No functional changes. Rename only. > > Signed-off-by: Si-Wei Liu > --- > hw/virtio/vhost-vdpa.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c > index

Re: [PATCH] virtio-net: correctly copy vnet header when flushing TX

2024-01-14 Thread Jason Wang
On Tue, Jan 2, 2024 at 11:29 AM Jason Wang wrote: > > When HASH_REPORT is negotiated, the guest_hdr_len might be larger than > the size of the mergeable rx buffer header. Using > virtio_net_hdr_mrg_rxbuf during the header swap might lead a stack > overflow in this case. Fixing this by using

Re: [PATCH 0/6] net: fix non-deterministic failures of the 'netdev-socket' qtest

2024-01-14 Thread Jason Wang
On Fri, Jan 5, 2024 at 12:45 AM Stefan Hajnoczi wrote: > > On Thu, 4 Jan 2024 at 11:30, Daniel P. Berrangé wrote: > > > > We've previously bumped up the timeouts in the netdev-socket qtest > > to supposedly fix non-deterministic failures, however, the failures > > are still hitting CI. > > > > A

[PATCH] target/i386: Eip error in x86_64-softmmu

2024-01-14 Thread guoguangyao
When closing PCREL, qemu-system-x86_64 run into error. Eip modification here leads to the result. Using s->pc in func gen_update_eip_next() solves the problem. Fixes: b5e0d5d22fbf("target/i386: Fix 32-bit wrapping of pc/eip computation") Signed-off-by: guoguangyao modified:

Re: [PATCH v5 0/8] target/riscv: deprecate riscv_cpu_options[]

2024-01-14 Thread Alistair Francis
On Sat, Jan 13, 2024 at 12:05 AM Daniel Henrique Barboza wrote: > > Hi, > > This version is a resend of patches 10 to 17 from v4, reviewed-by and > tested-by tags added, rebased with Alistair's riscv-to-apply.next. > Patches 01 to 09 of v4 are already queued. > > All patches acked. > > Changes

RE: [PATCH v2 3/3] Hexagon (target/hexagon) Remove old dectree.py

2024-01-14 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Monday, January 8, 2024 4:49 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org; a...@rev.ng; a...@rev.ng;

RE: [PATCH v2 2/3] Hexagon (target/hexagon) Use QEMU decodetree (16-bit instructions)

2024-01-14 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Monday, January 8, 2024 4:49 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org; a...@rev.ng; a...@rev.ng;

RE: [PATCH v2 1/3] Hexagon (target/hexagon) Use QEMU decodetree (32-bit instructions)

2024-01-14 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Monday, January 8, 2024 4:49 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org; a...@rev.ng; a...@rev.ng;

Re: FW: [PATCH] vhost-user: add VIRTIO_F_IN_ORDER and VIRTIO_F_NOTIFICATION_DATA feature

2024-01-14 Thread Jason Wang
On Fri, Jan 12, 2024 at 4:18 PM Wentao Jia wrote: > > Hi, Michael and Jason > > Do you have any other comments? > Is there a schedule for merge the patch into the community? > Thank you I think as discussed, we need to add compatibility support for those features. Thanks > > Wentao > >

Re: [PULL 15/21] linux-user/riscv: Add vdso

2024-01-14 Thread Richard Henderson
On 1/13/24 11:22, Vineet Gupta wrote: Now we just need to debug what in the vdso call frame information is wrong and any pointers to debug that would be appreciated, even if you are able to fix it right away ;-) The only way is to step through uw_frame_state_for() in libgcc and figure out

[PATCH] Reduce scope of def_regnum, remove dead assignment

2024-01-14 Thread Brian Cain
This is intended to address a coverity finding: CID 1527408. Signed-off-by: Brian Cain --- target/hexagon/mmvec/decode_ext_mmvec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/hexagon/mmvec/decode_ext_mmvec.c b/target/hexagon/mmvec/decode_ext_mmvec.c index

[PATCH] tests/docker: Hexagon toolchain update

2024-01-14 Thread Brian Cain
This update includes support for privileged instructions. Signed-off-by: Brian Cain --- tests/docker/dockerfiles/debian-hexagon-cross.docker | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/docker/dockerfiles/debian-hexagon-cross.docker

Re: [PATCH v2] Optimize buffer_is_zero

2024-01-14 Thread Alexander Monakov
On Tue, 9 Jan 2024, Daniel P. Berrangé wrote: > On Thu, Nov 09, 2023 at 03:52:38PM +0300, Alexander Monakov wrote: > > I'd like to ping this patch on behalf of Mikhail. > > > > https://patchew.org/QEMU/20231027143704.7060-1-mmroma...@ispras.ru/ > > > > If this needs to be split up a bit to

Re: [PATCH v7 15/16] i386: Use offsets get NumSharingCache for CPUID[0x8000001D].EAX[bits 25:14]

2024-01-14 Thread Xiaoyao Li
On 1/8/2024 4:27 PM, Zhao Liu wrote: From: Zhao Liu The commit 8f4202fb1080 ("i386: Populate AMD Processor Cache Information for cpuid 0x801D") adds the cache topology for AMD CPU by encoding the number of sharing threads directly. From AMD's APM, NumSharingCache

Re: [PATCH v7 14/16] i386: Use CPUCacheInfo.share_level to encode CPUID[4]

2024-01-14 Thread Xiaoyao Li
On 1/8/2024 4:27 PM, Zhao Liu wrote: From: Zhao Liu CPUID[4].EAX[bits 25:14] is used to represent the cache topology for Intel CPUs. After cache models have topology information, we can use CPUCacheInfo.share_level to decide which topology level to be encoded into CPUID[4].EAX[bits 25:14].

Re: [PATCH v7 02/16] i386/cpu: Use APIC ID offset to encode cache topo in CPUID[4]

2024-01-14 Thread Xiaoyao Li
On 1/11/2024 4:43 PM, Zhao Liu wrote: Hi Xiaoyao, On Wed, Jan 10, 2024 at 05:31:28PM +0800, Xiaoyao Li wrote: Date: Wed, 10 Jan 2024 17:31:28 +0800 From: Xiaoyao Li Subject: Re: [PATCH v7 02/16] i386/cpu: Use APIC ID offset to encode cache topo in CPUID[4] On 1/8/2024 4:27 PM, Zhao Liu

Re: [PATCH v5 00/11] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2024-01-14 Thread Bernhard Beschow
Am 14. Januar 2024 13:03:07 UTC schrieb "Michael S. Tsirkin" : >On Sun, Jan 14, 2024 at 12:52:53PM +, Bernhard Beschow wrote: >> >> >> Am 14. Januar 2024 12:39:00 UTC schrieb Bernhard Beschow : >> >This series implements relocation of the SuperI/O functions of the VIA south >> > >>

Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

2024-01-14 Thread Marc-André Lureau
Hi On Fri, Jan 12, 2024 at 5:57 PM Fiona Ebner wrote: > > With VNC, it can be that a client sends a VNC_MSG_CLIENT_CUT_TEXT > message before sending a VNC_MSG_CLIENT_SET_ENCODINGS message with > VNC_ENCODING_CLIPBOARD_EXT for configuring the clipboard extension. > > This means that

Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU

2024-01-14 Thread Xiaoyao Li
On 1/8/2024 4:27 PM, Zhao Liu wrote: From: Zhuocheng Ding Introduce cluster-id other than module-id to be consistent with CpuInstanceProperties.cluster-id, and this avoids the confusion of parameter names when hotplugging. I don't think reusing 'cluster' from arm for x86's 'module' is a good

Re: [PATCH v5 00/11] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2024-01-14 Thread Michael S. Tsirkin
On Sun, Jan 14, 2024 at 12:52:53PM +, Bernhard Beschow wrote: > > > Am 14. Januar 2024 12:39:00 UTC schrieb Bernhard Beschow : > >This series implements relocation of the SuperI/O functions of the VIA south > > > >bridges which resolves some FIXME's. It is part of my via-apollo-pro-133t > >

Re: [PATCH v5 00/11] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2024-01-14 Thread Bernhard Beschow
Am 14. Januar 2024 12:39:00 UTC schrieb Bernhard Beschow : >This series implements relocation of the SuperI/O functions of the VIA south > >bridges which resolves some FIXME's. It is part of my via-apollo-pro-133t > >branch [1] which is an extension of bringing the VIA south bridges to the PC >

[PATCH v5 03/11] hw/char/parallel: Move portio_list from ParallelState to ISAParallelState

2024-01-14 Thread Bernhard Beschow
ParallelState::portio_list isn't used inside ParallelState context but only inside ISAParallelState context, so move it there. Signed-off-by: Bernhard Beschow Reviewed-by: BALATON Zoltan --- include/hw/char/parallel-isa.h | 2 ++ include/hw/char/parallel.h | 2 -- hw/char/parallel.c

[PATCH v5 02/11] hw/block/fdc-sysbus: Move iomem from FDCtrl to FDCtrlSysBus

2024-01-14 Thread Bernhard Beschow
FDCtrl::iomem isn't used inside FDCtrl context but only inside FDCtrlSysBus context, so move it there. Signed-off-by: Bernhard Beschow Reviewed-by: BALATON Zoltan --- hw/block/fdc-internal.h | 2 -- hw/block/fdc-sysbus.c | 6 -- 2 files changed, 4 insertions(+), 4 deletions(-) diff

  1   2   >