[PATCH v3 15/16] virtio-pci: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate heare because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v3 00/16] pci: Abort if pci_add_capability fails

tencies. v3: - Correct patch split between virtio-pci and pci (Markus Armbruster) - Add messages for individual patches (Markus Armbruster) - Acked-by: Jonathan Cameron v2: Split the patch (Markus Armbruster) Akihiko Odaki (16): pci: Allow to omit errp for pci_add_capability hw/i386/amd_iomm

[PATCH v3 10/16] pci/shpc: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of shpc_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci-bridge/pci_bridge_dev.c | 2 +- hw/pci-bridge

[PATCH v3 13/16] hw/pci-bridge/pcie_pci_bridge: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate heare because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v3 14/16] hw/vfio/pci: Omit errp for pci_add_capability

mitting errp. Signed-off-by: Akihiko Odaki --- hw/vfio/pci-quirks.c | 15 +++ hw/vfio/pci.c| 14 +- 2 files changed, 8 insertions(+), 21 deletions(-) diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c index f0147a050a..e94fd273ea 100644 --- a/hw/vfio/pci-quirks.c +

[PATCH v3 02/16] hw/i386/amd_iommu: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate heare because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v3 06/16] hw/nvme: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate heare because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v3 11/16] msix: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of msix_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/msix.c | 8 ++-- 1 file changed, 2 insertions(+), 6

[PATCH v3 07/16] msi: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of msi_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/msi.c | 9 + 1 file changed, 1 insertion(+), 8

[PATCH v4 07/17] hw/nvme: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v4 03/17] hw/i386/amd_iommu: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v4 02/17] pci: Allow to omit errp for pci_add_capability

as the first step. Signed-off-by: Akihiko Odaki --- hw/pci/pci.c | 8 include/hw/pci/pci.h | 13 ++--- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 2f450f6a72..8ee2171011 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c

[PATCH v4 00/17] pci: Abort if pci_add_capability fails

atch (Markus Armbruster) Akihiko Odaki (17): hw/vfio/pci: Ensure MSI and MSI-X do not overlap pci: Allow to omit errp for pci_add_capability hw/i386/amd_iommu: Omit errp for pci_add_capability ahci: Omit errp for pci_add_capability e1000e: Omit errp for pci_add_capability eepro10

[PATCH v4 09/17] hw/pci/pci_bridge: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of pci_bridge_ssvid_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci-bridge/i82801b11.c | 14

[PATCH v4 10/17] pcie: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of a PCIe function which calls pci_add_capability() in turn is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki Acked-by: Jonathan Cameron (for CXL parts) --- docs/pcie_sriov.txt

[PATCH v4 05/17] e1000e: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v4 06/17] eepro100: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v4 12/17] msix: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of msix_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/msix.c | 8 ++-- 1 file changed, 2 insertions(+), 6

[PATCH v4 15/17] hw/vfio/pci: Omit errp for pci_add_capability

mitting errp. Signed-off-by: Akihiko Odaki --- hw/vfio/pci-quirks.c | 15 +++ hw/vfio/pci.c| 14 +- 2 files changed, 8 insertions(+), 21 deletions(-) diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c index f0147a050a..e94fd273ea 100644 --- a/hw/vfio/pci-quirks.c +

[PATCH v4 16/17] virtio-pci: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v4 11/17] pci/shpc: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of shpc_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci-bridge/pci_bridge_dev.c | 2 +- hw/pci-bridge

[PATCH v4 01/17] hw/vfio/pci: Ensure MSI and MSI-X do not overlap

vfio_add_std_cap() is designed to ensure that capabilities do not overlap, but it failed to do so for MSI and MSI-X capabilities. Ensure MSI and MSI-X capabilities do not overlap with others by omitting other overlapping capabilities. Signed-off-by: Akihiko Odaki --- hw/vfio/pci.c | 55

[PATCH v4 04/17] ahci: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v4 17/17] pci: Remove legacy errp from pci_add_capability

Signed-off-by: Akihiko Odaki --- hw/pci/pci.c | 29 +++-- include/hw/pci/pci.h | 12 ++-- 2 files changed, 9 insertions(+), 32 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 8ee2171011..8ff71e4553 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c

[PATCH v4 13/17] pci/slotid: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of slotid_cap_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/slotid_cap.c | 8 ++-- 1 file changed, 2 insertions

[PATCH v4 14/17] hw/pci-bridge/pcie_pci_bridge: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate heare because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v4 08/17] msi: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of msi_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/msi.c | 9 + 1 file changed, 1 insertion(+), 8

Re: [PATCH] ui/cocoa: Support hardware cursor interface

h in a way that does not depend on the Virgl patch. I'm also aware that the cursor composition using Core Graphics is somewhat laggy so it may be better to rewrite it using subview, Core Animation, Metal, or something else. But I have not done that yet. Regards, Akihiko Odaki Many thanks, Ell

Re: [PATCH] ui/cocoa: Support hardware cursor interface

library like ANGLE. Regards, Akihiko Odaki Not that I have any influence, but I think your virgl patch is an excellent contribution and should go upstream. Thanks again, Elliot

[PATCH] cutils: Fix get_relocated_path on Windows

will be passed as is in the case. Implement a proper error handling of PathCchSkipRoot() in get_relocated_path() so that it can handle a path without a drive letter or UNC server/share path elements. Reported-by: Stefan Weil Signed-off-by: Akihiko Odaki --- util/cutils.c | 18 +++--- 1

[PATCH v5 00/17] pci: Abort if pci_add_capability fails

verlap (Alex Williamson) v3: - Correct patch split between virtio-pci and pci (Markus Armbruster) - Add messages for individual patches (Markus Armbruster) - Acked-by: Jonathan Cameron Akihiko Odaki (17): hw/vfio/pci: Ensure MSI and MSI-X do not overlap pci: Allow to omit errp for pci_add_capabili

[PATCH v5 01/17] hw/vfio/pci: Ensure MSI and MSI-X do not overlap

vfio_add_std_cap() is designed to ensure that capabilities do not overlap, but it failed to do so for MSI and MSI-X capabilities. Ensure MSI and MSI-X capabilities do not overlap with others by omitting other overlapping capabilities. Signed-off-by: Akihiko Odaki --- hw/vfio/pci.c | 63

[PATCH v5 12/17] msix: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of msix_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/msix.c | 8 ++-- 1 file changed, 2 insertions(+), 6

[PATCH v5 10/17] pcie: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of a PCIe function which calls pci_add_capability() in turn is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki Acked-by: Jonathan Cameron (for CXL parts) --- docs/pcie_sriov.txt

[PATCH v5 15/17] hw/vfio/pci: Omit errp for pci_add_capability

mitting errp. Signed-off-by: Akihiko Odaki --- hw/vfio/pci-quirks.c | 15 +++ hw/vfio/pci.c| 14 +- 2 files changed, 8 insertions(+), 21 deletions(-) diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c index f0147a050a..e94fd273ea 100644 --- a/hw/vfio/pci-quirks.c +

[PATCH v5 17/17] pci: Remove legacy errp from pci_add_capability

Signed-off-by: Akihiko Odaki --- hw/pci/pci.c | 29 +++-- include/hw/pci/pci.h | 12 ++-- 2 files changed, 9 insertions(+), 32 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 8ee2171011..8ff71e4553 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c

[PATCH v5 05/17] e1000e: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v5 09/17] hw/pci/pci_bridge: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of pci_bridge_ssvid_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci-bridge/i82801b11.c | 14

[PATCH v5 02/17] pci: Allow to omit errp for pci_add_capability

as the first step. Signed-off-by: Akihiko Odaki --- hw/pci/pci.c | 8 include/hw/pci/pci.h | 13 ++--- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 2f450f6a72..8ee2171011 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c

[PATCH v5 03/17] hw/i386/amd_iommu: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v5 06/17] eepro100: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v5 07/17] hw/nvme: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v5 08/17] msi: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of msi_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/msi.c | 9 + 1 file changed, 1 insertion(+), 8

[PATCH v5 16/17] virtio-pci: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v5 14/17] hw/pci-bridge/pcie_pci_bridge: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate heare because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v5 04/17] ahci: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

Re: [PATCH v4 01/17] hw/vfio/pci: Ensure MSI and MSI-X do not overlap

Hi, Thanks for keeping reviewing. I have just sent v5 so please check it out. On 2022/10/28 4:31, Alex Williamson wrote: On Thu, 27 Oct 2022 15:36:49 +0900 Akihiko Odaki wrote: vfio_add_std_cap() is designed to ensure that capabilities do not overlap, but it failed to do so for MSI and MSI

[PATCH v5 11/17] pci/shpc: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of shpc_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci-bridge/pci_bridge_dev.c | 2 +- hw/pci-bridge

[PATCH v5 13/17] pci/slotid: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of slotid_cap_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/slotid_cap.c | 8 ++-- 1 file changed, 2 insertions

Re: [PATCH v5 01/17] hw/vfio/pci: Ensure MSI and MSI-X do not overlap

On 2022/10/28 23:16, Alex Williamson wrote: On Fri, 28 Oct 2022 21:26:13 +0900 Akihiko Odaki wrote: vfio_add_std_cap() is designed to ensure that capabilities do not overlap, but it failed to do so for MSI and MSI-X capabilities. Ensure MSI and MSI-X capabilities do not overlap with others

[PATCH v6 05/17] e1000e: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

Re: [PATCH v5 01/17] hw/vfio/pci: Ensure MSI and MSI-X do not overlap

On 2022/10/29 4:23, Alex Williamson wrote: On Sat, 29 Oct 2022 01:12:11 +0900 Akihiko Odaki wrote: On 2022/10/28 23:16, Alex Williamson wrote: On Fri, 28 Oct 2022 21:26:13 +0900 Akihiko Odaki wrote: vfio_add_std_cap() is designed to ensure that capabilities do not overlap

[PATCH v6 06/17] eepro100: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v6 11/17] pci/shpc: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of shpc_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci-bridge/pci_bridge_dev.c | 2 +- hw/pci-bridge

[PATCH v6 04/17] ahci: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v6 02/17] pci: Allow to omit errp for pci_add_capability

as the first step. Signed-off-by: Akihiko Odaki --- hw/pci/pci.c | 8 include/hw/pci/pci.h | 13 ++--- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 2f450f6a72..8ee2171011 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c

[PATCH v6 16/17] virtio-pci: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

Re: [PATCH v5 02/17] pci: Allow to omit errp for pci_add_capability

On 2022/10/29 7:35, Philippe Mathieu-Daudé wrote: On 28/10/22 14:26, Akihiko Odaki wrote: pci_add_capability appears most PCI devices. Its error handling required lots of code, and led to inconsistent behaviors such as: - passing error_abort - passing error_fatal - asserting the returned

[PATCH v6 01/17] hw/vfio/pci: Ensure MSI and MSI-X do not overlap

and hw/vfio/pci knows much about PCI capabilities, adding code specific to the cases to hw/vfio/pci still results in less code than having error handling code everywhere in total. Signed-off-by: Akihiko Odaki --- hw/vfio/pci.c | 61 ++- hw/vfio/pci.h

[PATCH v6 13/17] pci/slotid: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of slotid_cap_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/slotid_cap.c | 8 ++-- 1 file changed, 2 insertions

[PATCH v6 08/17] msi: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of msi_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/msi.c | 9 + 1 file changed, 1 insertion(+), 8

[PATCH v6 00/17] pci: Abort if pci_add_capability fails

ter) - Acked-by: Jonathan Cameron Akihiko Odaki (17): hw/vfio/pci: Ensure MSI and MSI-X do not overlap pci: Allow to omit errp for pci_add_capability hw/i386/amd_iommu: Omit errp for pci_add_capability ahci: Omit errp for pci_add_capability e1000e: Omit errp for pci_add_capability eepro10

[PATCH v6 12/17] msix: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of msix_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/msix.c | 8 ++-- 1 file changed, 2 insertions(+), 6

[PATCH v6 15/17] hw/vfio/pci: Omit errp for pci_add_capability

mitting errp. Signed-off-by: Akihiko Odaki --- hw/vfio/pci-quirks.c | 15 +++ hw/vfio/pci.c| 14 +- 2 files changed, 8 insertions(+), 21 deletions(-) diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c index f0147a050a..e94fd273ea 100644 --- a/hw/vfio/pci-quirks.c +

[PATCH v6 17/17] pci: Remove legacy errp from pci_add_capability

Signed-off-by: Akihiko Odaki --- hw/pci/pci.c | 29 +++-- include/hw/pci/pci.h | 12 ++-- 2 files changed, 9 insertions(+), 32 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 8ee2171011..8ff71e4553 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c

[PATCH v6 07/17] hw/nvme: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v6 03/17] hw/i386/amd_iommu: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v6 14/17] hw/pci-bridge/pcie_pci_bridge: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate heare because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v6 09/17] hw/pci/pci_bridge: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of pci_bridge_ssvid_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci-bridge/i82801b11.c | 14

Re: [PATCH v2] pci: Assert that capabilities never overlap

On Thu, Sep 29, 2022 at 7:55 PM Markus Armbruster wrote: > > Akihiko Odaki writes: > > > On Mon, Sep 5, 2022 at 6:26 PM Markus Armbruster wrote: > >> > >> Akihiko Odaki writes: > >> > >> > On Fri, Sep 2, 2022 at 7:23 PM Markus Armbruster

[PATCH] tests/qtest/libqos/e1000e: Use e1000_regs.h

is removed from E1000E_CTRL_EXT settings because hw/net/e1000_regs.h does not have the definition and it is for TCP segmentation offload, which does not matter for the implemented tests. Signed-off-by: Akihiko Odaki --- hw/net/e1000_regs.h | 1 + tests/qtest/libqos/e1000e.c | 119

Re: [PATCH] ui/cocoa: Support hardware cursor interface

comments to the patch. Please see the below. Regards, Akihiko Odaki On Wed, Oct 5, 2022 at 12:39 AM Peter Maydell wrote: > > Ccing Akihiko to see if he wants to review this cocoa ui frontend > patch. > > also available at: > https://lore.kernel.org/qemu-devel/54930451-d85f-4

[PATCH] ui/gtk: Fix the implicit mouse ungrabbing logic

in gd_mouse_mode_change() strictly follows the corresponding grabbing logic found in gd_button_event(). Signed-off-by: Akihiko Odaki --- ui/gtk.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 1467b8c7d7..6fc2e23963 100644 --- a/ui/gtk.c +++ b/ui/gtk.c

[PATCH] input: Allow to choose console with qemu_input_is_absolute

Although an input is routed depending on the console, qemu_input_is_absolute() had no mechanism to specify the console. Accept QemuConsole as an argument for qemu_input_is_absolute, and let the display know the absolute/relative state for a particular console. Signed-off-by: Akihiko Odaki

Re: [PATCH v2] pci: Assert that capabilities never overlap

On Mon, Sep 5, 2022 at 6:26 PM Markus Armbruster wrote: > > Akihiko Odaki writes: > > > On Fri, Sep 2, 2022 at 7:23 PM Markus Armbruster wrote: > >> > >> Akihiko Odaki writes: > >> > >> > pci_add_capability appears most PCI devices. It

[PATCH v9 01/17] hw/vfio/pci: Ensure MSI and MSI-X do not overlap

and hw/vfio/pci knows much about PCI capabilities, adding code specific to the cases to hw/vfio/pci still results in less code than having error handling code everywhere in total. Signed-off-by: Akihiko Odaki --- include/hw/pci/pci.h | 7 +++ hw/pci/pci.c | 33

[PATCH v8 03/17] hw/i386/amd_iommu: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v9 14/17] hw/pci-bridge/pcie_pci_bridge: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate heare because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v8 08/17] msi: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of msi_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/msi.c | 9 + 1 file changed, 1 insertion(+), 8

[PATCH v9 17/17] pci: Remove legacy errp from pci_add_capability

Signed-off-by: Akihiko Odaki --- include/hw/pci/pci.h | 12 ++-- hw/pci/pci.c | 18 -- 2 files changed, 6 insertions(+), 24 deletions(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 555ac03010..da414dc728 100644 --- a/include/hw/pci/pci.h +++ b

[PATCH v9 15/17] hw/vfio/pci: Omit errp for pci_add_capability

mitting errp. Signed-off-by: Akihiko Odaki --- hw/vfio/pci-quirks.c | 15 +++ hw/vfio/pci.c| 14 +- 2 files changed, 8 insertions(+), 21 deletions(-) diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c index f0147a050a..e94fd273ea 100644 --- a/hw/vfio/pci-quirks.c +

[PATCH v9 02/17] pci: Allow to omit errp for pci_add_capability

as the first step. Signed-off-by: Akihiko Odaki --- include/hw/pci/pci.h | 13 ++--- hw/pci/pci.c | 8 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index f4e6612440..555ac03010 100644 --- a/include/hw/pci

[PATCH v9 11/17] pci/shpc: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of shpc_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- include/hw/pci/shpc.h | 3 +-- hw/pci-bridge

[PATCH v8 04/17] ahci: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v9 00/17] pci: Abort if pci_add_capability fails

orrect patch split between virtio-pci and pci (Markus Armbruster) - Add messages for individual patches (Markus Armbruster) - Acked-by: Jonathan Cameron Akihiko Odaki (17): hw/vfio/pci: Ensure MSI and MSI-X do not overlap pci: Allow to omit errp for pci_add_capability hw/i386/amd_iomm

[PATCH v9 10/17] pcie: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of a PCIe function which calls pci_add_capability() in turn is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki Acked-by: Jonathan Cameron (for CXL parts) --- docs/pcie_sriov.txt

[PATCH v9 07/17] hw/nvme: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v9 12/17] msix: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of msix_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/msix.c | 8 ++-- 1 file changed, 2 insertions(+), 6

[PATCH v8 10/17] pcie: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of a PCIe function which calls pci_add_capability() in turn is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki Acked-by: Jonathan Cameron (for CXL parts) --- docs/pcie_sriov.txt

[PATCH v9 03/17] hw/i386/amd_iommu: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v8 15/17] hw/vfio/pci: Omit errp for pci_add_capability

mitting errp. Signed-off-by: Akihiko Odaki --- hw/vfio/pci-quirks.c | 15 +++ hw/vfio/pci.c| 14 +- 2 files changed, 8 insertions(+), 21 deletions(-) diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c index f0147a050a..e94fd273ea 100644 --- a/hw/vfio/pci-quirks.c +

[PATCH v8 01/17] hw/vfio/pci: Ensure MSI and MSI-X do not overlap

and hw/vfio/pci knows much about PCI capabilities, adding code specific to the cases to hw/vfio/pci still results in less code than having error handling code everywhere in total. Signed-off-by: Akihiko Odaki --- hw/pci/pci.c | 34 ++ hw/vfio/pci.c| 15

[PATCH v9 13/17] pci/slotid: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of slotid_cap_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/slotid_cap.c | 8 ++-- 1 file changed, 2 insertions

[PATCH v8 05/17] e1000e: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v9 04/17] ahci: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v8 00/17] pci: Abort if pci_add_capability fails

not overlap (Alex Williamson) v3: - Correct patch split between virtio-pci and pci (Markus Armbruster) - Add messages for individual patches (Markus Armbruster) - Acked-by: Jonathan Cameron Akihiko Odaki (17): hw/vfio/pci: Ensure MSI and MSI-X do not overlap pci: Allow to omit errp for pci_ad

[PATCH v8 16/17] virtio-pci: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v8 17/17] pci: Remove legacy errp from pci_add_capability

Signed-off-by: Akihiko Odaki --- hw/pci/pci.c | 20 +--- include/hw/pci/pci.h | 12 ++-- 2 files changed, 7 insertions(+), 25 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index cce57f572c..41de7643af 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c

[PATCH v9 05/17] e1000e: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v8 12/17] msix: Omit errp for pci_add_capability

Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of msix_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/msix.c | 8 ++-- 1 file changed, 2 insertions(+), 6

<    7   8   9   10   11   12   13   14   15   16   >