Re: [PATCH v2 00/12] GL & D-Bus display related fixes

2022-03-05 Thread Akihiko Odaki
On 2022/02/18 1:11, Akihiko Odaki wrote: You missed only one thing: - that console_select and register_displaychangelistener may not call dpy_gfx_switch and call dpy_gl_scanout_texture instead. It is incompatible with non-OpenGL displays displaychangelistener_display_console always has

[PATCH 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed

2022-03-06 Thread Akihiko Odaki
#discussion https://support.apple.com/en-in/guide/mac-help/mh32356/mac Acked-by: Markus Armbruster Signed-off-by: Gustavo Noronha Silva Message-Id: <20210713213200.2547-2-gust...@noronha.dev.br> Signed-off-by: Akihiko Odaki --- qapi/ui.json| 16 qemu-options.hx | 3 +

[PATCH 2/2] ui/cocoa: add option to swap Option and Command

2022-03-06 Thread Akihiko Odaki
. Acked-by: Markus Armbruster Signed-off-by: Gustavo Noronha Silva Message-Id: <20210713213200.2547-3-gust...@noronha.dev.br> Signed-off-by: Akihiko Odaki --- qapi/ui.json| 8 ++- qemu-options.hx | 3 ++- ui/cocoa.m | 64 ++--- 3

[PATCH v2 2/2] ui/cocoa: add option to swap Option and Command

2022-03-06 Thread Akihiko Odaki
. Acked-by: Markus Armbruster Signed-off-by: Gustavo Noronha Silva Message-Id: <20210713213200.2547-3-gust...@noronha.dev.br> Signed-off-by: Akihiko Odaki --- qapi/ui.json| 7 ++- qemu-options.hx | 2 +- ui/cocoa.m | 46 ++ 3 files c

Re: [PATCH v3 12/12] ui/console: call gfx_switch() even if the current scanout is GL

2022-03-08 Thread Akihiko Odaki
On 2022/03/08 23:26, Marc-André Lureau wrote: Hi On Mon, Mar 7, 2022 at 4:49 PM Akihiko Odaki wrote: (taking notes, mostly for myself) Could you provide a failing test case or a more concrete suggestion on what to do instead? I am all ears :) thanks Let me describe a more concrete

Re: [RFC PATCH-for-7.0 v3 2/2] ui/cocoa: run qemu_init in the main thread

2022-03-17 Thread Akihiko Odaki
24 +2069,13 @@ static void cocoa_refresh(DisplayChangeListener *dcl) > static void cocoa_display_init(DisplayState *ds, DisplayOptions *opts) > { > COCOA_DEBUG("qemu_cocoa: cocoa_display_init\n"); > +have_cocoa_ui = 1; > > -/* Tell main threa

Re: [RFC PATCH-for-7.0 v3 2/2] ui/cocoa: run qemu_init in the main thread

2022-03-17 Thread Akihiko Odaki
or consoles > * and removeable devices). These make calls back into QEMU functions, > * which is OK because at this point we know that the second thread > * holds the iothread lock and is synchronously waiting for us to > * finish. > */ Regards, Akihiko Odaki

Re: [PATCH v20 5/7] net/vmnet: implement bridged mode (vmnet-bridged)

2022-03-15 Thread Akihiko Odaki
fix. It should be dynamically allocated as it was done in an older version. I'm sorry for missing things repeatedly. This should be *really* the last comment so please have a look at this. P.S. I'm testing the current version and it is pleasantly working well. (I'm actually writing t

[PATCH v2] coreaudio: Commit the result of init in the end

2022-03-15 Thread Akihiko Odaki
now whether the output device is initialized after calling init_out_device. Signed-off-by: Akihiko Odaki --- audio/coreaudio.m | 49 ++- 1 file changed, 27 insertions(+), 22 deletions(-) diff --git a/audio/coreaudio.m b/audio/coreaudio.m index 3186b684

[PATCH v5] ui/cocoa: Use NSWindow's ability to resize

2022-03-16 Thread Akihiko Odaki
This change brings two new features: - The window will be resizable if "Zoom To Fit" is eanbled - The window can be made full screen by clicking full screen button provided by the platform. (The left-top green button.) Signed-off-by: Akihiko Odaki --- ui/coc

[PATCH] audio/mixeng: Do not declare unused variables

2022-03-16 Thread Akihiko Odaki
The unused variables when FLOAT_MIXENG is defined caused warnings on Apple clang version 13.1.6 (clang-1316.0.21.2). Signed-off-by: Akihiko Odaki --- audio/mixeng.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/audio/mixeng.c b/audio/mixeng.c index f27deb165b6

Re: [RFC PATCH-for-7.0 v2] cocoa: run qemu_init in the main thread

2022-03-16 Thread Akihiko Odaki
ill by 7.0.) Regards, Akihiko Odaki Signed-off-by: Paolo Bonzini Message-Id: <20220307151004.578069-1-pbonz...@redhat.com> [PMD: Fixed trivial build failures & rebased] Signed-off-by: Philippe Mathieu-Daudé --- Cc: Akihiko Odaki Cc: Peter Maydell Cc: Emanuele Giuseppe Esposito v1: htt

Re: [RFC PATCH-for-7.0 v2] cocoa: run qemu_init in the main thread

2022-03-16 Thread Akihiko Odaki
complain about this. Signed-off-by: Paolo Bonzini Message-Id: <20220307151004.578069-1-pbonz...@redhat.com> [PMD: Fixed trivial build failures & rebased] Signed-off-by: Philippe Mathieu-Daudé --- Cc: Akihiko Odaki Cc: Peter Maydell Cc: Emanuele Giuseppe Esposito v1: https://lore.kerne

Re: [PATCH v21 3/7] net/vmnet: implement shared mode (vmnet-shared)

2022-03-17 Thread Akihiko Odaki
MNET_SHARED, +.size = sizeof(VmnetState), +.receive = vmnet_receive_common, +.cleanup = vmnet_cleanup_common, +}; + int net_init_vmnet_shared(const Netdev *netdev, const char *name, NetClientState *peer, Error **errp) { - error_setg(errp, "vmnet-shared is not

[PATCH] ui/cocoa: Respect left-command-key option

2022-03-17 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index cb6e7c41dc6..c4e5468f9e6 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -923,7 +923,8 @@ - (bool) handleEventLocked:(NSEvent *)event

Re: [PATCH v16 4/7] net/vmnet: implement host mode (vmnet-host)

2022-03-14 Thread Akihiko Odaki
On 2022/03/15 4:15, Vladislav Yaroshchuk wrote: Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-host.c | 116 --- 1 file changed, 110 insertions(+), 6 deletions(-) diff --git a/net/vmnet-host.c b/net/vmnet-host.c index 32dc437037..15a832701a

Re: [PATCH v16 3/7] net/vmnet: implement shared mode (vmnet-shared)

2022-03-14 Thread Akihiko Odaki
us; + +if (size > s->max_packet_size) { +warn_report("vmnet: packet is too big, %zu > %" PRIu64, +packet.vm_pkt_size, +s->max_packet_size); +return -1; +} + +iov.iov_base = (char *) buf; +iov.iov_len = size; + + packet.vm_

Re: [PATCH v16 3/7] net/vmnet: implement shared mode (vmnet-shared)

2022-03-14 Thread Akihiko Odaki
On 2022/03/15 7:34, Akihiko Odaki wrote: On 2022/03/15 6:50, Vladislav Yaroshchuk wrote: Thank you, Akihiko On Mon, Mar 14, 2022 at 10:46 PM Akihiko Odaki mailto:akihiko.od...@gmail.com>> wrote:     On 2022/03/15 4:15, Vladislav Yaroshchuk wrote: > vmnet.framework sup

Re: [PATCH v16 3/7] net/vmnet: implement shared mode (vmnet-shared)

2022-03-14 Thread Akihiko Odaki
On 2022/03/15 6:50, Vladislav Yaroshchuk wrote: Thank you, Akihiko On Mon, Mar 14, 2022 at 10:46 PM Akihiko Odaki <mailto:akihiko.od...@gmail.com>> wrote: On 2022/03/15 4:15, Vladislav Yaroshchuk wrote: > vmnet.framework supports iov, but writing more than > one

Re: [PATCH v16 3/7] net/vmnet: implement shared mode (vmnet-shared)

2022-03-14 Thread Akihiko Odaki
On 2022/03/15 8:02, Vladislav Yaroshchuk wrote: вт, 15 мар. 2022 г., 1:34 AM Akihiko Odaki <mailto:akihiko.od...@gmail.com>>: On 2022/03/15 6:50, Vladislav Yaroshchuk wrote: > Thank you, Akihiko > > On Mon, Mar 14, 2022 at 10:46 PM Akihiko Odaki

Re: [PATCH v17 3/7] net/vmnet: implement shared mode (vmnet-shared)

2022-03-15 Thread Akihiko Odaki
lientState nc; +NetClientState nc; + interface_ref vmnet_if; + +uint64_t mtu; +uint64_t max_packet_size; +dispatch_queue_t if_queue; + +QEMUBH *send_bh; +bool send_enabled; I'm still not convinced it is preferred to have send_enabled and packets_send_current_pos not to po

Re: [PATCH v17 2/7] net/vmnet: add vmnet backends to qapi/net

2022-03-15 Thread Akihiko Odaki
dep.h" +#include "vmnet_int.h" +#include "clients.h" + +#include + +typedef struct VmnetCommonState { + NetClientState nc; + +} VmnetCommonState; Now VmnetCommonState is the only state of the concrete implementations. It may be renamed to VmnetState and the implement

Re: [PATCH v17 3/7] net/vmnet: implement shared mode (vmnet-shared)

2022-03-15 Thread Akihiko Odaki
On 2022/03/16 2:45, Vladislav Yaroshchuk wrote: On Tue, Mar 15, 2022 at 1:18 PM Akihiko Odaki <mailto:akihiko.od...@gmail.com>> wrote: On 2022/03/15 19:02, Vladislav Yaroshchuk wrote: > Interaction with vmnet.framework in different modes > differs only on conf

Re: [PATCH v19 4/7] net/vmnet: implement host mode (vmnet-host)

2022-03-15 Thread Akihiko Odaki
fy the names of identifiers. There are options->net_uuid, uuid, and network_uuid, but the differences tells nothing. This should be the last thing to be addressed (unless I missed something again.) Thank you for persistence (It's v19!). I really appreciate your contribution. Regards, Aki

Re: [PATCH v18 3/7] net/vmnet: implement shared mode (vmnet-shared)

2022-03-15 Thread Akihiko Odaki
only after this + * continue reading more packets from vmnet interface. + * + * Packets to be transferred are stored into packets_buf, + * in the window (packets_send_current_pos..packets_send_end_pos] + * excluding current_pos, including end_pos. I wonder why you changed the window from [packets_send_current_pos, p

Re: [PATCH v3 12/12] ui/console: call gfx_switch() even if the current scanout is GL

2022-03-09 Thread Akihiko Odaki
On 2022/03/09 19:07, Marc-André Lureau wrote: Hi On Wed, Mar 9, 2022 at 2:01 PM Akihiko Odaki <mailto:akihiko.od...@gmail.com>> wrote: On 2022/03/09 18:53, Marc-André Lureau wrote: > Hi > > On Wed, Mar 9, 2022 at 1:32 PM Akihiko Odaki mailto:akihi

Re: [PATCH v3 12/12] ui/console: call gfx_switch() even if the current scanout is GL

2022-03-09 Thread Akihiko Odaki
On 2022/03/09 19:27, Marc-André Lureau wrote: Hi On Wed, Mar 9, 2022 at 2:20 PM Akihiko Odaki <mailto:akihiko.od...@gmail.com>> wrote: On 2022/03/09 19:07, Marc-André Lureau wrote: > Hi > > On Wed, Mar 9, 2022 at 2:01 PM Akihiko Odaki mailto:akihi

Re: [PATCH v3 12/12] ui/console: call gfx_switch() even if the current scanout is GL

2022-03-09 Thread Akihiko Odaki
On 2022/03/09 19:45, Marc-André Lureau wrote: Hi On Wed, Mar 9, 2022 at 2:38 PM Akihiko Odaki <mailto:akihiko.od...@gmail.com>> wrote: On 2022/03/09 19:27, Marc-André Lureau wrote: > Hi > > On Wed, Mar 9, 2022 at 2:20 PM Akihiko Odaki mailto:akihi

Re: [PATCH v3 12/12] ui/console: call gfx_switch() even if the current scanout is GL

2022-03-09 Thread Akihiko Odaki
On 2022/03/09 18:53, Marc-André Lureau wrote: Hi On Wed, Mar 9, 2022 at 1:32 PM Akihiko Odaki <mailto:akihiko.od...@gmail.com>> wrote: On 2022/03/09 18:26, Gerd Hoffmann wrote: >    Hi, > >> dpy_gfx_switch and dpy_gfx_update need t

Re: [PATCH v22 0/7] Add vmnet.framework based network backend

2022-03-18 Thread Akihiko Odaki
Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki Thank you for this great work! On 2022/03/18 2:28, Vladislav Yaroshchuk wrote: macOS provides networking API for VMs called 'vmnet.framework': https://developer.apple.com/documentation/vmnet We can provide its support as the new QEMU

Re: [PATCH] gitattributes: Cover Objective-C source files

2022-03-18 Thread Akihiko Odaki
stopped displaying C function context correctly. So I suspect Git has some knowledge of common file extensions like .c, .h and .m although I couldn't find in the source code of Git. Regards, Akihiko Odaki On 2022/03/18 23:10, Philippe Mathieu-Daudé wrote: +qemu-trivial@ On 17/3/22 14:03, Ph

Re: [PATCH] gitattributes: Cover Objective-C source files

2022-03-18 Thread Akihiko Odaki
found you are the author of commit 29cf16db23. Can you test the above conclusion? Regards, Akihiko Odaki

Re: [PATCH v3 12/12] ui/console: call gfx_switch() even if the current scanout is GL

2022-03-09 Thread Akihiko Odaki
On 2022/03/09 17:02, Marc-André Lureau wrote: Hi On Tue, Mar 8, 2022 at 6:43 PM Akihiko Odaki <mailto:akihiko.od...@gmail.com>> wrote: On 2022/03/08 23:26, Marc-André Lureau wrote: > Hi > > On Mon, Mar 7, 2022 at 4:49 PM Akihiko Odaki mailto:akihi

Re: [PATCH v3 12/12] ui/console: call gfx_switch() even if the current scanout is GL

2022-03-09 Thread Akihiko Odaki
On 2022/03/09 17:33, Marc-André Lureau wrote: Hi On Wed, Mar 9, 2022 at 12:21 PM Akihiko Odaki <mailto:akihiko.od...@gmail.com>> wrote: If it is expected that dpy_gfx_update is required, it should call dpy_gfx_update. I agree it is not a right timing to fix vnc

Re: [PATCH v3 12/12] ui/console: call gfx_switch() even if the current scanout is GL

2022-03-09 Thread Akihiko Odaki
On 2022/03/09 17:40, Marc-André Lureau wrote: Hi On Wed, Mar 9, 2022 at 12:34 PM Akihiko Odaki <mailto:akihiko.od...@gmail.com>> wrote: On 2022/03/09 17:33, Marc-André Lureau wrote: > Hi > > On Wed, Mar 9, 2022 at 12:21 PM Akihiko Odaki mailto:akihi

Re: [PATCH v3 12/12] ui/console: call gfx_switch() even if the current scanout is GL

2022-03-09 Thread Akihiko Odaki
On 2022/03/09 17:54, Marc-André Lureau wrote: Hi On Wed, Mar 9, 2022 at 12:49 PM Akihiko Odaki <mailto:akihiko.od...@gmail.com>> wrote: On 2022/03/09 17:40, Marc-André Lureau wrote: > Hi > > On Wed, Mar 9, 2022 at 12:34 PM Akihiko Odaki mailto:akihi

Re: [PATCH v3 12/12] ui/console: call gfx_switch() even if the current scanout is GL

2022-03-09 Thread Akihiko Odaki
tch shouldn't do the implicit update in the future. I'll write a patch to do the update in cocoa's dpy_gfx_switch implementation otherwise. Regards, Akihiko Odaki

Re: [PATCH v3 12/12] ui/console: call gfx_switch() even if the current scanout is GL

2022-03-09 Thread Akihiko Odaki
On 2022/03/09 17:11, Marc-André Lureau wrote: Hi On Wed, Mar 9, 2022 at 12:05 PM Akihiko Odaki <mailto:akihiko.od...@gmail.com>> wrote: On 2022/03/09 17:02, Marc-André Lureau wrote: > Hi > > On Tue, Mar 8, 2022 at 6:43 PM Akihiko Odaki mailto:akihi

Re: [PATCH] coreaudio: Always return 0 in handle_voice_change

2022-03-06 Thread Akihiko Odaki
On Sun, Mar 6, 2022 at 9:16 PM Christian Schoenebeck wrote: > > On Sonntag, 6. März 2022 11:54:00 CET Akihiko Odaki wrote: > > On 2022/03/06 19:49, Christian Schoenebeck wrote: > > > On Sonntag, 6. März 2022 07:39:49 CET Akihiko Odaki wrote: > > >> Mac

[PATCH v2] coreaudio: Always return 0 in handle_voice_change

2022-03-06 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- audio/coreaudio.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/audio/coreaudio.c b/audio/coreaudio.c index 0f19d0ce01c..91445096358 100644 --- a/audio/coreaudio.c +++ b/audio/coreaudio.c @@ -540,7 +540,6 @@ static OSStatus handle_voice_change(

[PATCH v2 0/2] cocoa: keyboard quality of life

2022-03-06 Thread Akihiko Odaki
The patch series was originally posted by Gustavo Noronha Silva, and rebased to commit 2acf5e1d0e0f15be1b0ad85cf05b3a6e6307680c by Akihiko Odaki. This series adds two new options to the cocoa display: - full-grab causes it to use a global tap to steal system combos away from Mac OS X, so

[PATCH v2 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed

2022-03-06 Thread Akihiko Odaki
#discussion https://support.apple.com/en-in/guide/mac-help/mh32356/mac Acked-by: Markus Armbruster Signed-off-by: Gustavo Noronha Silva Message-Id: <20210713213200.2547-2-gust...@noronha.dev.br> Signed-off-by: Akihiko Odaki --- qapi/ui.json| 16 qemu-options.hx | 3 +

Re: [PATCH v2 00/12] GL & D-Bus display related fixes

2022-02-17 Thread Akihiko Odaki
On Fri, Feb 18, 2022 at 1:12 AM Marc-André Lureau wrote: > > Hi > > On Thu, Feb 17, 2022 at 5:09 PM Akihiko Odaki wrote: >> >> On Thu, Feb 17, 2022 at 8:58 PM wrote: >> > >> > From: Marc-André Lureau >> > >> > Hi, >> > >

[PATCH 3/6] Revert "ui: split the GL context in a different object"

2022-02-12 Thread Akihiko Odaki
This reverts commit 5e79d516e8ac818d2a90aae9f787775055434ee9. Signed-off-by: Akihiko Odaki --- include/ui/console.h | 34 -- include/ui/egl-context.h | 6 +++--- include/ui/gtk.h | 11 +-- include/ui/sdl2.h | 7

[PATCH 1/6] ui/dbus: Share one listener for a console

2022-02-12 Thread Akihiko Odaki
This fixes surface texture double free with multiple connections and out-of-sync display size with multiple displays. This also reduces resource usage a little and allows to remove code to support multiple listeners for OpenGL displays. Signed-off-by: Akihiko Odaki --- ui/dbus-console.c | 109

[PATCH 0/6] ui/dbus: Share one listener for a console

2022-02-12 Thread Akihiko Odaki
is needed. Changes for the common code to support multiple OpenGL DisplayChangeListeners were reverted to fix egl-headless and reduce the code size. Akihiko Odaki (6): ui/dbus: Share one listener for a console Revert "console: save current scanout details" Revert "ui: split

[PATCH 5/6] Revert "ui: associate GL context outside of display listener registration"

2022-02-12 Thread Akihiko Odaki
This reverts commit ac32b2fff127843355b4f7e7ac9f93dd4a395adf. Signed-off-by: Akihiko Odaki --- ui/console.c | 7 ++- ui/egl-headless.c | 1 - ui/gtk.c | 3 --- ui/sdl2.c | 3 --- ui/spice-display.c | 3 --- 5 files changed, 2 insertions(+), 15 deletions(-) diff

[PATCH 4/6] Revert "ui: dispatch GL events to all listeners"

2022-02-12 Thread Akihiko Odaki
This reverts commit 7cc712e9862ffdbe4161dbdf3bbf41bcbe547472. Signed-off-by: Akihiko Odaki --- ui/console.c | 58 +++- 1 file changed, 16 insertions(+), 42 deletions(-) diff --git a/ui/console.c b/ui/console.c index 13c0d001c09..6f21007737e

[PATCH 2/6] Revert "console: save current scanout details"

2022-02-12 Thread Akihiko Odaki
This reverts commit ebced091854517f063c46ce8e522ebc45e9bccdf. This fixes the compatibility between egl-headless and displays using console_select, most importantly vnc. Signed-off-by: Akihiko Odaki --- include/ui/console.h | 27 --- ui/console.c | 165

[PATCH 6/6] Revert "ui: factor out qemu_console_set_display_gl_ctx()"

2022-02-12 Thread Akihiko Odaki
This reverts commit 4f4181499170dcf80182745b319607802ea32896. This eliminates the situation where a display is registered as a GL context provider but not as a listener. Signed-off-by: Akihiko Odaki --- include/ui/console.h | 3 --- ui/console.c | 22 -- 2 files

[PATCH v2] target/arm: Support PSCI 1.1 and SMCCC 1.0

2022-02-12 Thread Akihiko Odaki
Support the latest PSCI on TCG and HVF. A 64-bit function called from AArch32 now returns NOT_SUPPORTED, which is necessary to adhere to SMC Calling Convention 1.0. It is still not compliant with SMCCC 1.3 since they do not implement mandatory functions. Signed-off-by: Akihiko Odaki --- hw/arm

Re: [PULL 18/38] hw/arm/virt: Honor highmem setting when computing the memory map

2022-02-12 Thread Akihiko Odaki
came from? I also don't quite understand what failures virt_kvm_type() had. Regards, Akihiko Odaki

Re: [PATCH v2 00/12] GL & D-Bus display related fixes

2022-02-17 Thread Akihiko Odaki
On Fri, Feb 18, 2022 at 2:07 AM Marc-André Lureau wrote: > > Hi > > On Thu, Feb 17, 2022 at 8:39 PM Akihiko Odaki wrote: >> >> On Fri, Feb 18, 2022 at 1:12 AM Marc-André Lureau >> wrote: >> > >> > Hi >> > >> > On Thu, Feb 17, 2

Re: [PATCH v2 00/12] GL & D-Bus display related fixes

2022-02-17 Thread Akihiko Odaki
On Fri, Feb 18, 2022 at 2:36 AM Marc-André Lureau wrote: > > Hi > > On Thu, Feb 17, 2022 at 9:25 PM Akihiko Odaki wrote: >> >> On Fri, Feb 18, 2022 at 2:07 AM Marc-André Lureau >> wrote: >> > >> > Hi >> > >> > On Thu, Feb 17, 2

[PATCH v2] target/arm: Support PSCI 1.1 and SMCCC 1.0

2022-02-24 Thread Akihiko Odaki
Support the latest PSCI on TCG and HVF. A 64-bit function called from AArch32 now returns NOT_SUPPORTED, which is necessary to adhere to SMC Calling Convention 1.0. It is still not compliant with SMCCC 1.3 since they do not implement mandatory functions. Signed-off-by: Akihiko Odaki --- hw/arm

Re: [PATCH v2 0/2] ui/cocoa: updateUIInfo threading, autorelease pools

2022-02-24 Thread Akihiko Odaki
Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki On 2022/02/24 19:13, Peter Maydell wrote: This patchset was originally provoked by Akihiko Odaki noting that we have some unnecessary creation and deletion of autorelease pools in the Cocoa UI code. Patch 2 deletes them; but to get there we

Re: [PATCH] target/arm: Report KVM's actual PSCI version to guest in dtb

2022-02-24 Thread Akihiko Odaki
Reviewed-by: Akihiko Odaki On Thu, Feb 24, 2022 at 10:46 PM Peter Maydell wrote: > > When we're using KVM, the PSCI implementation is provided by the > kernel, but QEMU has to tell the guest about it via the device tree. > Currently we look at the KVM_CAP_ARM_PSCI_0_2 capability

Re: [PATCH v2] target/arm: Support PSCI 1.1 and SMCCC 1.0

2022-02-24 Thread Akihiko Odaki
On 2022/02/24 21:53, Peter Maydell wrote: On Sun, 13 Feb 2022 at 03:58, Akihiko Odaki wrote: Support the latest PSCI on TCG and HVF. A 64-bit function called from AArch32 now returns NOT_SUPPORTED, which is necessary to adhere to SMC Calling Convention 1.0. It is still not compliant

Re: [PATCH v2 4/8] configure: Disable out-of-line atomic operations on Aarch64

2022-02-16 Thread Akihiko Odaki
On 2022/02/17 0:08, Philippe Mathieu-Daudé wrote: On 16/2/22 11:19, Richard Henderson wrote: On 2/16/22 04:01, Philippe Mathieu-Daudé via wrote: GCC 10.1 introduced the -moutline-atomics option on Aarch64. This options is enabled by default, and triggers a link failure:    Undefined symbols

Re: [PATCH 0/6] ui/dbus: Share one listener for a console

2022-02-16 Thread Akihiko Odaki
On 2022/02/17 1:51, Marc-André Lureau wrote: Hi Akihiko, (I suppose you meant to reply-all, feel free to add back qemu-devel) My bad, restored Ccs. On Tue, Feb 15, 2022 at 5:56 PM Akihiko Odaki <mailto:akihiko.od...@gmail.com>> wrote: On Tue, Feb 15, 2022 at 10:32 PM M

Re: [PATCH 1/1] ui/cocoa: show/hide menu in fullscreen on mouse ungrab/grab

2022-02-18 Thread Akihiko Odaki
tle:[NSString stringWithFormat:@"QEMU %s", qemu_name]]; else [QemuCocoaView -toggleFullscreen:] also has the calls to [NSMenu setMenuBarVisible:], which should be removed. Regards, Akihiko Odaki

Re: [PATCH 2/2] ui/cocoa: release mouse when user switches away from QEMU window

2022-02-18 Thread Akihiko Odaki
Reviewed-by: Akihiko Odaki On 2022/01/03 2:41, Carwyn Ellis wrote: This resolves an issue where using command-tab to switch between QEMU and other windows on the host can leave the mouse pointer visible. By releasing the mouse when the user switches away, the user must left click on the QEMU

Re: [PATCH 1/2] ui/cocoa: add option to disable left-command forwarding to guest

2022-02-18 Thread Akihiko Odaki
Reviewed-by: Akihiko Odaki On 2022/01/03 2:41, Carwyn Ellis wrote: When switching between guest and host on a Mac using command-tab the command key is sent to the guest which can trigger functionality in the guest OS. Specifying left-command-key=off disables forwarding this key to the guest

Fwd: [PATCH v2 12/12] ui/dbus: fix texture sharing

2022-02-17 Thread Akihiko Odaki
I mistakenly dropped CC (again). My apologies. -- Forwarded message - From: Akihiko Odaki Date: Thu, Feb 17, 2022 at 9:38 PM Subject: Re: [PATCH v2 12/12] ui/dbus: fix texture sharing To: Marc-André Lureau On Thu, Feb 17, 2022 at 9:02 PM wrote: > > From: Marc-André

Re: [PATCH v2 00/12] GL & D-Bus display related fixes

2022-02-17 Thread Akihiko Odaki
On Thu, Feb 17, 2022 at 8:58 PM wrote: > > From: Marc-André Lureau > > Hi, > > In the thread "[PATCH 0/6] ui/dbus: Share one listener for a console", Akihiko > Odaki reported a number of issues with the GL and D-Bus display. His series > propose a differen

Re: [PATCH v15 5/8] net/vmnet: implement bridged mode (vmnet-bridged)

2022-02-25 Thread Akihiko Odaki
On 2022/02/26 2:13, Vladislav Yaroshchuk wrote: Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-bridged.m | 129 ++-- 1 file changed, 124 insertions(+), 5 deletions(-) diff --git a/net/vmnet-bridged.m b/net/vmnet-bridged.m index

Re: [PATCH v14 1/8] net/vmnet: add vmnet dependency and customizable option

2022-02-25 Thread Akihiko Odaki
On 2022/02/26 1:52, Vladislav Yaroshchuk wrote: vmnet.framework dependency is added with 'vmnet' option to enable or disable it. Default value is 'auto'. vmnet features to be used are available since macOS 11.0, corresponding probe is created into meson.build. Signed-off-by: Vladislav

Re: [PATCH v15 3/8] net/vmnet: implement shared mode (vmnet-shared)

2022-02-25 Thread Akihiko Odaki
On 2022/02/26 2:13, Vladislav Yaroshchuk wrote: Interaction with vmnet.framework in different modes differs only on configuration stage, so we can create common `send`, `receive`, etc. procedures and reuse them. vmnet.framework supports iov, but writing more than one iov into vmnet interface

[PATCH v3 2/3] ui: Deliver refresh rate via QemuUIInfo

2022-02-26 Thread Akihiko Odaki
nts frequent changes of the display mode. Signed-off-by: Akihiko Odaki --- hw/display/xenfb.c | 14 +++--- include/ui/console.h | 2 +- include/ui/gtk.h | 2 +- ui/console.c | 6 -- ui/gtk-egl.c | 4 ++-- ui/gtk-gl-area.c | 3 +-- ui/gt

[PATCH v2 0/4] cutils: Introduce bundle mechanism

2022-02-26 Thread Akihiko Odaki
Developers often run QEMU without installing. The bundle mechanism allows to look up files which should be present in installation even in such a situation. v2: Rebased to the latest QEMU. Akihiko Odaki (4): cutils: Introduce bundle mechanism datadir: Use bundle mechanism ui/icons: Use

[PATCH v2 1/4] cutils: Introduce bundle mechanism

2022-02-26 Thread Akihiko Odaki
Developers often run QEMU without installing. The bundle mechanism allows to look up files which should be present in installation even in such a situation. Signed-off-by: Akihiko Odaki --- include/qemu/cutils.h | 19 +++ util/cutils.c | 33

[PATCH v2] ui/cocoa: Use the standard about panel

2022-02-26 Thread Akihiko Odaki
This provides standard look and feel for the about panel and reduces code. Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 112 +++-- 1 file changed, 23 insertions(+), 89 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index a8f1cdaf926

[PATCH] coreaudio: Notify error in coreaudio_init_out

2022-02-26 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- audio/coreaudio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/audio/coreaudio.c b/audio/coreaudio.c index d8a21d3e507..d7cfdcc4fc4 100644 --- a/audio/coreaudio.c +++ b/audio/coreaudio.c @@ -604,6 +604,8 @@ static int coreaudio_init_out(HWVoiceOut *hw

[PATCH v4] ui/cocoa: Use NSWindow's ability to resize

2022-02-26 Thread Akihiko Odaki
This change brings two new features: - The window will be resizable if "Zoom To Fit" is eanbled - The window can be made full screen by clicking full screen button provided by the platform. (The left-top green button.) Signed-off-by: Akihiko Odaki --- ui/coc

[PATCH v2] coreaudio: Notify error in coreaudio_init_out

2022-02-26 Thread Akihiko Odaki
Otherwise, the audio subsystem tries to use the voice and eventually aborts due to the maximum number of samples in the buffer is not set. Signed-off-by: Akihiko Odaki Reviewed-by: Christian Schoenebeck --- audio/coreaudio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/audio

[PATCH v2 2/4] datadir: Use bundle mechanism

2022-02-26 Thread Akihiko Odaki
bundle mechanism and softmmu/datadir.c provides some overlapped functionality. Use bundle mechanism in softmmu/datadir.c to remove the redundancy. Signed-off-by: Akihiko Odaki --- configure | 2 ++ meson.build | 2 +- softmmu/datadir.c | 35 --- 3

[PATCH v3 3/3] virtio-gpu: Respect UI refresh rate for EDID

2022-02-26 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- hw/display/virtio-gpu-base.c | 1 + hw/display/virtio-gpu.c| 1 + include/hw/virtio/virtio-gpu.h | 1 + 3 files changed, 3 insertions(+) diff --git a/hw/display/virtio-gpu-base.c b/hw/display/virtio-gpu-base.c index c73b3aa06b8..ee2587a8c36 100644

Re: [PATCH v15 3/8] net/vmnet: implement shared mode (vmnet-shared)

2022-02-26 Thread Akihiko Odaki
On Sat, Feb 26, 2022 at 8:33 PM Vladislav Yaroshchuk wrote: > > > > On Sat, Feb 26, 2022 at 12:16 PM Akihiko Odaki > wrote: >> >> On 2022/02/26 17:37, Vladislav Yaroshchuk wrote: >> > >> > Hi Akihiko, >> > >> > On Fri, Feb 25, 20

[PATCH v2 3/4] ui/icons: Use bundle mechanism

2022-02-26 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- configure | 10 ++ meson.build | 3 +-- ui/cocoa.m | 20 +++- ui/gtk.c| 8 +--- ui/sdl2.c | 18 +++--- 5 files changed, 38 insertions(+), 21 deletions(-) diff --git a/configure b/configure index fda1a35cbc0

[PATCH v2 4/4] net: Use bundle mechanism

2022-02-26 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- configure | 1 + include/net/net.h | 2 +- meson.build | 1 + net/tap.c | 6 +- qemu-options.hx | 4 ++-- 5 files changed, 10 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 80d36a85bc5..63df8f5886e 100755

Re: [PATCH v2 0/4] cutils: Introduce bundle mechanism

2022-02-26 Thread Akihiko Odaki
On 2022/02/26 22:02, Peter Maydell wrote: On Sat, 26 Feb 2022 at 12:45, Akihiko Odaki wrote: Developers often run QEMU without installing. The bundle mechanism allows to look up files which should be present in installation even in such a situation. This is supposed to work already

Re: [PATCH v15 3/8] net/vmnet: implement shared mode (vmnet-shared)

2022-03-01 Thread Akihiko Odaki
ason Wang, I saw you are in the MAINTAINERS for net/. Can you tell if calling qemu_send_packet_async is allowed after it returns 0? Regards, Akihiko Odaki

Re: [PATCH v15 3/8] net/vmnet: implement shared mode (vmnet-shared)

2022-02-28 Thread Akihiko Odaki
On 2022/02/28 20:59, Vladislav Yaroshchuk wrote: On Sat, Feb 26, 2022 at 3:27 PM Akihiko Odaki <mailto:akihiko.od...@gmail.com>> wrote: On Sat, Feb 26, 2022 at 8:33 PM Vladislav Yaroshchuk mailto:vladislav.yaroshc...@jetbrains.com>> wrote: > > &g

Re: [PATCH v2 2/8] osdep: Ignore 'unguarded-availability-new' warnings on macOS Catalina

2022-02-15 Thread Akihiko Odaki
On Wed, Feb 16, 2022 at 2:01 AM Philippe Mathieu-Daudé wrote: > > When building with GCC on macOS Catalina we get 2254 times: > > include/qemu/osdep.h:780:5: warning: 'pthread_jit_write_protect_np' is only > available on macOS 11.0 or newer [-Wunguarded-availability-new] >

Re: [PATCH v2 4/8] configure: Disable out-of-line atomic operations on Aarch64

2022-02-15 Thread Akihiko Odaki
On Wed, Feb 16, 2022 at 2:01 AM Philippe Mathieu-Daudé wrote: > > GCC 10.1 introduced the -moutline-atomics option on Aarch64. > This options is enabled by default, and triggers a link failure: > > Undefined symbols for architecture arm64: > "___aarch64_cas1_acq_rel", referenced from: >

Re: [RFC PATCH 0/4] buildsys: More fixes to use GCC on macOS

2022-02-15 Thread Akihiko Odaki
On Tue, Feb 15, 2022 at 10:25 PM Philippe Mathieu-Daudé wrote: > > On 15/2/22 14:06, Akihiko Odaki wrote: > > On Tue, Feb 15, 2022 at 9:06 PM Philippe Mathieu-Daudé > > wrote: > >> > >> Few fixes to be able to use GCC extensions which are not > >> a

Fwd: Undelivered Mail Returned to Sender

2022-02-15 Thread Akihiko Odaki
Hi postmas...@amsat.org, Apparently your system is rejected by Gmail. Could you fix the problem? Thanks, Akihiko Odaki -- Forwarded message - From: Mail Delivery System Date: Wed, Feb 16, 2022 at 11:29 AM Subject: Undelivered Mail Returned to Sender To: This is the mail

Re: [PATCH v3 01/15] audio: replace open-coded buffer arithmetic

2022-03-01 Thread Akihiko Odaki
Reviewed-by: Akihiko Odaki On 2022/03/02 4:12, Volker Rümelin wrote: Replace open-coded buffer arithmetic with the new function audio_ring_posb(). That's the position in backward direction of a given point at a given distance. Signed-off-by: Volker Rümelin --- audio/audio.c | 25

Re: [PATCH v3 10/15] audio: restore mixing-engine playback buffer size

2022-03-01 Thread Akihiko Odaki
Reviewed-by: Akihiko Odaki On 2022/03/02 4:13, Volker Rümelin wrote: Commit ff095e5231 "audio: api for mixeng code free backends" introduced another FIFO for the audio subsystem with exactly the same size as the mixing-engine FIFO. Most audio backends use this generic FIFO. The ge

Re: [PATCH v15 3/8] net/vmnet: implement shared mode (vmnet-shared)

2022-03-03 Thread Akihiko Odaki
On Fri, Mar 4, 2022 at 12:43 AM Vladislav Yaroshchuk wrote: > > > > On Tue, Mar 1, 2022 at 11:21 AM Akihiko Odaki wrote: >> >> On 2022/03/01 17:09, Vladislav Yaroshchuk wrote: >> > > Not sure that only one field is enough, cause >> > &

Re: [PATCH v15 3/8] net/vmnet: implement shared mode (vmnet-shared)

2022-03-03 Thread Akihiko Odaki
On 2022/03/04 3:34, Akihiko Odaki wrote: On Fri, Mar 4, 2022 at 12:43 AM Vladislav Yaroshchuk wrote: On Tue, Mar 1, 2022 at 11:21 AM Akihiko Odaki wrote: On 2022/03/01 17:09, Vladislav Yaroshchuk wrote: > Not sure that only one field is enough, cause > we may have two

Re: [PATCH v15 3/8] net/vmnet: implement shared mode (vmnet-shared)

2022-03-03 Thread Akihiko Odaki
On 2022/03/04 10:37, Jason Wang wrote: On Thu, Mar 3, 2022 at 11:43 PM Vladislav Yaroshchuk wrote: On Tue, Mar 1, 2022 at 11:21 AM Akihiko Odaki wrote: On 2022/03/01 17:09, Vladislav Yaroshchuk wrote: > Not sure that only one field is enough, cause > we may have two

Re: [PATCH] ui/cocoa: Do not alert even without block devices

2022-02-14 Thread Akihiko Odaki
On Mon, Feb 14, 2022 at 9:31 PM Philippe Mathieu-Daudé wrote: > Is this menu updated when removable blkdev are hot-plugged from > the monitor or QMP? Actually no.

Re: [PATCH 0/6] ui/dbus: Share one listener for a console

2022-02-14 Thread Akihiko Odaki
On Mon, Feb 14, 2022 at 9:07 PM Marc-André Lureau wrote: > > Hi Akihiko > > On Sun, Feb 13, 2022 at 6:44 AM Akihiko Odaki wrote: >> >> ui/dbus required to have multiple DisplayChangeListeners (possibly with >> OpenGL) >> for a console but that caused several

[PATCH] ui/cocoa: Add Services menu

2022-02-14 Thread Akihiko Odaki
Services menu functionality of Cocoa is described at: https://developer.apple.com/design/human-interface-guidelines/macos/extensions/services/ Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 4 1 file changed, 4 insertions(+) diff --git a/ui/cocoa.m b/ui/cocoa.m index ac18e14ce01

Re: [PATCH v4 10/13] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-02-12 Thread Akihiko Odaki
redefining it to kAudioObjectPropertyElementMaster if not available. Suggested-by: Akihiko Odaki Suggested-by: Christian Schoenebeck Suggested-by: Roman Bolshakov Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Christian Schoenebeck --- audio/coreaudio.c | 17 +++-- 1 file changed, 11 insertions(+), 6

Re: [PATCH v4 01/13] lcitool: refresh

2022-02-12 Thread Akihiko Odaki
error: tests/docker/dockerfiles/ubuntu2004.docker: patch does not apply Patch failed at 0001 lcitool: refresh Regards, Akihiko Odaki

[PATCH] MAINTAINERS: Add Akihiko Odaki to macOS-relateds

2022-02-12 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2fd74c46426..5aefb5b431a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2333,6 +2333,7 @@ F: audio/alsaaudio.c Core Audio framework backend M: Gerd Hoffmann R

[PATCH] edid: Fix clock of Detailed Timing Descriptor

2022-02-12 Thread Akihiko Odaki
The clock field is 16-bits in EDID Detailed Timing Descriptor, but edid_desc_timing assumed it is 32-bit. Write the 16-bit value if it fits in 16-bit. Write DisplayID otherwise. Signed-off-by: Akihiko Odaki --- hw/display/edid-generate.c | 66 ++ 1 file

[PATCH] ui/cocoa: Fix the leak of qemu_console_get_label

2022-02-12 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index ac18e14ce01..fdf52a7c2f7 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -1680,7 +1680,10 @@ static void create_initial_menus(void) /* Returns a name

<    1   2   3   4   5   6   7   8   9   10   >