On 2023/01/31 0:47, Michael S. Tsirkin wrote:
On Tue, Jan 31, 2023 at 12:36:38AM +0900, Akihiko Odaki wrote:
On 2023/01/31 0:12, Michael S. Tsirkin wrote:
On Mon, Jan 30, 2023 at 10:47:07PM +0900, Akihiko Odaki wrote:
filter-dump specifiees Ethernet as PCAP LinkType, which does not expect
...@bu.edu/
The fixed test case is:
fuzz/crash_2d7036941dcda1ad4380bb8a9174ed0c949bcefd
Fixes: 16b29ae180 ("Add HPET emulation to qemu (Beth Kon)")
Signed-off-by: Akihiko Odaki
Acked-by: Michael S. Tsirkin
---
V1 -> V2: Renamed arm() to hpet_arm()
hw/timer/hpet.c | 19 +
/crash_47dfe62d9f911bf523ff48cd441b61c0013ed805
Signed-off-by: Akihiko Odaki
Acked-by: Alexander Bulekov
---
V1 -> V2: Correct spellings in the message
softmmu/physmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/softmmu/physmem.c b/softmmu/physmem.c
index cb998cdf23..3cd27b1c9d 100644
--- a/softmmu/physme
On 2023/01/31 8:58, BALATON Zoltan wrote:
On Sat, 28 Jan 2023, Akihiko Odaki wrote:
On 2023/01/23 8:28, BALATON Zoltan wrote:
On Thu, 19 Jan 2023, Akihiko Odaki wrote:
On 2023/01/15 3:11, BALATON Zoltan wrote:
On Sat, 14 Jan 2023, Akihiko Odaki wrote:
On 2023/01/13 22:43, BALATON Zoltan
On 2023/01/31 22:04, Thomas Huth wrote:
On 30/01/2023 15.08, Akihiko Odaki wrote:
This change is derived from qtest for e1000e device.
Signed-off-by: Akihiko Odaki
---
MAINTAINERS | 2 +
tests/qtest/fuzz/generic_fuzz_configs.h | 5 +
tests/qtest/igb-test.c
Added "hw/net/net_tx_pkt: Automatically determine if virtio-net header is
used".
- Added "hw/net/net_rx_pkt: Remove net_rx_pkt_has_virt_hdr".
- Added "e1000e: Perform software segmentation for loopback".
- Added "hw/net/net_tx_pkt: Implement TCP segmentation"
- Added &q
The definitions will be used by igb.
Signed-off-by: Akihiko Odaki
---
include/hw/net/mii.h | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/include/hw/net/mii.h b/include/hw/net/mii.h
index 4ae4dcce7e..c6a767a49a 100644
--- a/include/hw/net/mii.h
+++ b/include
Use memcpy instead of memmove to initialize registers. The initial
register templates and register table instances will never overlap.
Signed-off-by: Akihiko Odaki
---
hw/net/e1000.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/net/e1000.c b/hw/net/e1000.c
index
hw/net/mii.h provides common definitions for MII.
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
---
hw/net/fsl_etsec/etsec.c | 11 ++-
hw/net/fsl_etsec/etsec.h | 17 -
hw/net/fsl_etsec/miim.c | 5 +++--
include/hw/net/mii.h | 1 +
4 files
igb implementation first starts off by copying e1000e code. Correct the
code style before that.
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
---
hw/net/e1000.c | 41
hw/net/e1000e.c| 72 ++--
hw/net/e1000e_core.c
ot;)
Signed-off-by: Akihiko Odaki
---
hw/net/e1000e_core.c | 4
1 file changed, 4 deletions(-)
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
index ff93547f88..76c7814cb8 100644
--- a/hw/net/e1000e_core.c
+++ b/hw/net/e1000e_core.c
@@ -162,8 +162,6 @@ e1000e_intrmgr_on_thrott
, E1000_MC_TBL_SIZE, and
E1000_VLAN_FILTER_TBL_SIZE were copied from:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/net/ethernet/intel/e1000/e1000_hw.h?h=v6.0.9#n707
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
---
hw/net/e1000.c | 50
mismatch.
> ACTION: Configure the link partner for auto-negotiation.
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
---
hw/net/e1000e_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
index d8c17baf8f
Before this change, e1000e_write_packet_to_guest() allocated the
receive descriptor buffer as an array of uint8_t. This does not ensure
the buffer is sufficiently aligned.
Introduce e1000_rx_desc_union type, a union type of all receive
descriptor types to correct this.
Signed-off-by: Akihiko
This change makes e1000e reset more things when software reset was
triggered. Some registers are exempted from software reset in the
datasheet and this change also implements the behavior accordingly.
Signed-off-by: Akihiko Odaki
---
hw/net/e1000e_core.c | 24 +++-
1 file
I want to know to be notified when there is a new change for e1000e
as e1000e is similar to igb and such a change may also be applicable for
igb.
Signed-off-by: Akihiko Odaki
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 08ad1e5341
NetTxPkt has a valid virtio-net header.
Signed-off-by: Akihiko Odaki
---
hw/net/e1000e_core.c | 16
hw/net/net_rx_pkt.c | 11 +--
hw/net/net_rx_pkt.h | 12 +---
hw/net/trace-events | 1 -
hw/net/virtio-net.c | 2 +-
hw/net/vmxnet3.c | 12 ++--
6
/crash_6aeaa33e7211ecd603726c53e834df4c6d1e08bc
Fixes: e263cd49c7 ("Packet abstraction for VMWARE network devices")
Signed-off-by: Akihiko Odaki
---
hw/net/net_tx_pkt.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/hw/net/net_tx_pkt.c b/hw/net/net_tx_pkt.c
index 4a35e8429d..986a3adfe9 100644
--- a/hw/net/net_tx_p
hw/net/mii.h provides common definitions for MII.
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
---
hw/net/e1000.c | 86 ++--
hw/net/e1000_regs.h| 46
hw/net/e1000e.c| 1 +
hw/net/e1000e_core.c | 99
e1000x_is_vlan_packet() had a pointer to uint8_t as a parameter, but
it does not have to be uint8_t. Change the type to void *.
Signed-off-by: Akihiko Odaki
---
hw/net/e1000x_common.c | 2 +-
hw/net/e1000x_common.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/net
-off-by: Akihiko Odaki
---
include/net/net.h | 6 ++
net/dump.c| 11 +++
net/net.c | 18 ++
net/tap.c | 16
4 files changed, 47 insertions(+), 4 deletions(-)
diff --git a/include/net/net.h b/include/net/net.h
index dc20b31e9f
They are duplicate of running throttling timer flags and incomplete as
the flags are not cleared when the interrupts are fired or the device is
reset.
Signed-off-by: Akihiko Odaki
---
hw/net/e1000e.c | 5 ++---
hw/net/e1000e_core.c | 19 +++
hw/net/e1000e_core.h | 2
net_tx_pkt_build_vheader() inspects TCP header but had no check for
the header size, resulting in an undefined behavior. Check the header
size and drop the packet if the header is too small.
Signed-off-by: Akihiko Odaki
---
hw/net/e1000e_core.c | 19 ++-
hw/net/net_tx_pkt.c
Use memcpy instead of memmove to initialize registers. The initial
register templates and register table instances will never overlap.
Signed-off-by: Akihiko Odaki
---
hw/net/e1000e_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/net/e1000e_core.c b/hw/net
This is part of recent efforts of refactoring e1000 and e1000e.
DeviceClass's reset member is deprecated so migrate to ResettableClass.
There is no behavioral difference.
Signed-off-by: Akihiko Odaki
Reviewed-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
---
hw/net/e1000.c
pointer indirection.
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
---
hw/net/e1000e_core.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
index 736708407c..d143f2ae6f
The new function qemu_get_using_vnet_hdr() allows to automatically
determine if virtio-net header is used.
Signed-off-by: Akihiko Odaki
---
hw/net/e1000e_core.c | 3 +--
hw/net/net_tx_pkt.c | 19 ++-
hw/net/net_tx_pkt.h | 3 +--
hw/net/vmxnet3.c | 6 ++
4 files
ation if VIRTIO_NET_HDR_F_DATA_VALID is set.
Signed-off-by: Akihiko Odaki
---
hw/net/e1000e_core.c | 27 ++--
hw/net/net_rx_pkt.c | 7
hw/net/net_rx_pkt.h | 8 +
hw/net/net_tx_pkt.c | 76 +---
hw/net/net_tx_pkt.h | 21 ++
implementation; igb provides loopback feature for VMDq and the feature
relies on software segmentation.
Implement proper TCP segmentation in net_tx_pkt to fix such a scenario.
Signed-off-by: Akihiko Odaki
---
hw/net/net_tx_pkt.c | 248
include/net
When a register has effective bits fewer than their width, the old code
inconsistently masked when writing or reading. Make the code consistent
by always masking when writing, and remove some code duplication.
Signed-off-by: Akihiko Odaki
---
hw/net/e1000.c | 84
The definitions of SW Semaphore Register were copied from:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/net/ethernet/intel/e1000e/defines.h?h=v6.0.9#n374
Signed-off-by: Akihiko Odaki
---
hw/net/e1000_regs.h | 7 +++
hw/net/e1000e_core.c | 49
When a register has effective bits fewer than their width, the old code
inconsistently masked when writing or reading. Make the code consistent
by always masking when writing, and remove some code duplication.
Signed-off-by: Akihiko Odaki
---
hw/net/e1000e_core.c | 94
Signed-off-by: Akihiko Odaki
Acked-by: Thomas Huth
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 958915f227..e920d0061e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2218,6 +2218,8 @@ R: Akihiko Odaki
S: Maintained
F: hw/net/e1000e*
F
e1000e_rx_rss_dispatched_to_queue, which logs the queue index.
Signed-off-by: Akihiko Odaki
---
hw/net/e1000e_core.c | 6 ++
hw/net/trace-events | 5 ++---
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
index 76c7814cb8..4fec6dfe7e 100644
--- a/hw/net
This is part of recent efforts of refactoring e1000 and e1000e.
DeviceClass's reset member is deprecated so migrate to ResettableClass.
There is no behavioral difference.
Signed-off-by: Akihiko Odaki
Reviewed-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
---
hw/net/e1000e.c
ries.
- Restored vnet_hdr offload as there seems nothing preventing from that.
Akihiko Odaki (9):
hw/net/net_tx_pkt: Introduce net_tx_pkt_get_eth_hdr
pcie: Introduce pcie_sriov_num_vfs
e1000: Split header files
Intrdocue igb device emulation
tests/qtest/e1000e-test: Fabricate ethernet hea
igb can use this function to change its behavior depending on the
number of virtual functions currently enabled.
Signed-off-by: Gal Hammer
Signed-off-by: Marcel Apfelbaum
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
---
hw/pci/pcie_sriov.c | 5 +
include/hw
This automates ethtool tests for igb registers, interrupts, etc.
Signed-off-by: Akihiko Odaki
---
MAINTAINERS | 1 +
.../org.centos/stream/8/x86_64/test-avocado | 1 +
tests/avocado/igb.py | 38 +++
3 files changed
Some definitions in the header files are invalid for igb so extract
them to new header files to keep igb from referring to them.
Signed-off-by: Gal Hammer
Signed-off-by: Marcel Apfelbaum
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
---
hw/net/e1000.c | 1 +
hw
They will be useful for igb testing.
Signed-off-by: Akihiko Odaki
Reviewed-by: Thomas Huth
---
tests/qtest/libqos/e1000e.c | 12
tests/qtest/libqos/e1000e.h | 12
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/tests/qtest/libqos/e1000e.c b/tests
This change is derived from qtest for e1000e device.
Signed-off-by: Akihiko Odaki
Acked-by: Thomas Huth
---
MAINTAINERS | 2 +
tests/qtest/fuzz/generic_fuzz_configs.h | 5 +
tests/qtest/igb-test.c | 243
tests/qtest
e1000e understands ethernet header so fabricate something convincing.
Signed-off-by: Akihiko Odaki
Reviewed-by: Thomas Huth
---
tests/qtest/e1000e-test.c | 25 +++--
tests/qtest/libqos/e1000e.h | 2 ++
2 files changed, 17 insertions(+), 10 deletions(-)
diff --git a
Expose the ethernet header so that igb can utilize it to perform the
internal routing among its SR-IOV functions.
Signed-off-by: Gal Hammer
Signed-off-by: Marcel Apfelbaum
Signed-off-by: Akihiko Odaki
---
hw/net/net_tx_pkt.c | 6 ++
hw/net/net_tx_pkt.h | 8
2 files changed, 14
Signed-off-by: Akihiko Odaki
---
MAINTAINERS | 1 +
docs/system/device-emulation.rst | 1 +
docs/system/devices/igb.rst | 71
3 files changed, 73 insertions(+)
create mode 100644 docs/system/devices/igb.rst
diff --git a/MAINTAINERS b
TL.Def_PL.
- Implemented the combination of VMDq and RSS.
- Noted that igb is tested with Windows HLK.
V1 -> V2:
- Spun off e1000e general improvements to a distinct series.
- Restored vnet_hdr offload as there seems nothing preventing from that.
Akihiko Odaki (9):
hw/net/net_tx_pkt: Introduce
e1000e understands ethernet header so fabricate something convincing.
Signed-off-by: Akihiko Odaki
Reviewed-by: Thomas Huth
---
tests/qtest/e1000e-test.c | 25 +++--
tests/qtest/libqos/e1000e.h | 2 ++
2 files changed, 17 insertions(+), 10 deletions(-)
diff --git a
igb can use this function to change its behavior depending on the
number of virtual functions currently enabled.
Signed-off-by: Gal Hammer
Signed-off-by: Marcel Apfelbaum
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
---
hw/pci/pcie_sriov.c | 5 +
include/hw
Expose the ethernet header so that igb can utilize it to perform the
internal routing among its SR-IOV functions.
Signed-off-by: Gal Hammer
Signed-off-by: Marcel Apfelbaum
Signed-off-by: Akihiko Odaki
---
hw/net/net_tx_pkt.c | 6 ++
hw/net/net_tx_pkt.h | 8
2 files changed, 14
This automates ethtool tests for igb registers, interrupts, etc.
Signed-off-by: Akihiko Odaki
---
MAINTAINERS | 1 +
.../org.centos/stream/8/x86_64/test-avocado | 1 +
tests/avocado/igb.py | 38 +++
3 files changed
They will be useful for igb testing.
Signed-off-by: Akihiko Odaki
Reviewed-by: Thomas Huth
---
tests/qtest/libqos/e1000e.c | 12
tests/qtest/libqos/e1000e.h | 12
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/tests/qtest/libqos/e1000e.c b/tests
This change is derived from qtest for e1000e device.
Signed-off-by: Akihiko Odaki
Acked-by: Thomas Huth
---
MAINTAINERS | 2 +
hw/net/igb_core.c | 8 +-
tests/qtest/fuzz/generic_fuzz_configs.h | 5 +
tests/qtest/igb-test.c
Some definitions in the header files are invalid for igb so extract
them to new header files to keep igb from referring to them.
Signed-off-by: Gal Hammer
Signed-off-by: Marcel Apfelbaum
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
---
hw/net/e1000.c | 1 +
hw
Signed-off-by: Akihiko Odaki
---
MAINTAINERS | 1 +
docs/system/device-emulation.rst | 1 +
docs/system/devices/igb.rst | 71
3 files changed, 73 insertions(+)
create mode 100644 docs/system/devices/igb.rst
diff --git a/MAINTAINERS b
On 2023/01/31 18:42, Sriram Yagnaraman wrote:
IGB uses RXDW ICR bit to indicate that rx descriptor has been written
back. This is the same as RXT0 bit in older HW.
Signed-off-by: Sriram Yagnaraman
---
hw/net/e1000x_regs.h | 4
hw/net/igb_core.c| 46 +
On 2023/01/31 18:42, Sriram Yagnaraman wrote:
Signed-off-by: Sriram Yagnaraman
---
hw/net/igb_core.c | 48 +++
1 file changed, 40 insertions(+), 8 deletions(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 4a1b98bf0e..2f6f30341f 100644
-
On 2023/01/31 18:42, Sriram Yagnaraman wrote:
Also add checks for RXDCTL/TXDCTL queue enable bits
Signed-off-by: Sriram Yagnaraman
---
hw/net/igb_core.c | 30 +-
hw/net/igb_core.h | 1 +
hw/net/igb_regs.h | 3 +++
3 files changed, 29 insertions(+), 5 deletions
On 2023/01/31 18:42, Sriram Yagnaraman wrote:
Add support for stripping/inserting VLAN for VFs.
Signed-off-by: Sriram Yagnaraman
---
hw/net/igb_core.c | 51 ++-
1 file changed, 42 insertions(+), 9 deletions(-)
diff --git a/hw/net/igb_core.c b/hw/n
On 2023/01/31 18:42, Sriram Yagnaraman wrote:
Also trace out a warning if replication mode is disabled, since we only
support replication mode enabled.
Signed-off-by: Sriram Yagnaraman
---
hw/net/igb_core.c | 9 +
hw/net/trace-events | 2 ++
2 files changed, 11 insertions(+)
diff
On 2023/02/01 19:29, Sriram Yagnaraman wrote:
-Original Message-
From: Akihiko Odaki
Sent: Wednesday, 1 February 2023 05:58
To: Sriram Yagnaraman
Cc: qemu-devel@nongnu.org; Jason Wang ; Dmitry
Fleytman ; Michael S . Tsirkin
; Marcel Apfelbaum
Subject: Re: [PATCH v3 8/9] igb
On 2023/02/01 20:17, Sriram Yagnaraman wrote:
Also introduce:
- Checks for RXDCTL/TXDCTL queue enable bits
- IGB_NUM_VM_POOLS enum (Sec 1.5: Table 1-7)
It may be better to have RXDCTL.ENABLE check in igb_can_receive().
Signed-off-by: Sriram Yagnaraman
---
hw/net/igb_core.c | 36 ++
From: Akihiko Odaki
I am now employed by Daynix. Although my role as a reviewer of
macOS-related change is not very relevant to the employment, I decided
to use the company email address to avoid confusions from different
addresses.
Signed-off-by: Akihiko Odaki
Reviewed-by: Marc-André Lureau
Hi,
Thank you for continuously working on this series. I have some comments,
but I guess this series will be ready after one or two more rounds.
On 2023/05/10 17:22, Tomasz Dzieciol wrote:
Packet-split descriptors are used by Linux VF driver for MTU values from 2048
Signed-off-by: Tomasz Dzi
On 2023/05/13 0:43, Tomasz Dzieciol wrote:
Packet-split descriptors are used by Linux VF driver for MTU values from 2048
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 360 ++--
hw/net/igb_regs.h | 9 ++
hw/net/trace-events | 2 +-
3
On 2023/05/18 0:46, Tomasz Dzieciol wrote:
Refactoring is done in preparation for support of multiple advanced
descriptors RX modes, especially packet-split modes.
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 176 ++--
hw/net/igb_regs.h |
Before this change, the directory of the executable was being added to
resolve modules in the build tree. However, get_relocated_path() can now
resolve them with the new bundle mechanism.
Signed-off-by: Akihiko Odaki
---
util/module.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/util
installation.
Just remove the -bios option, since it is unnecessary and in fact
there are other x86 VM tests that do not bother specifying it.
Signed-off-by: Paolo Bonzini
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Thomas Huth
Signed-off-by: Akihiko Odaki
Message-Id: <20220616083025.116902-1-pb
system.
Signed-off-by: Akihiko Odaki
Suggested-by: Paolo Bonzini
---
docs/about/build-platforms.rst | 2 +-
include/qemu/cutils.h | 18 +++--
meson.build | 4 ++
scripts/symlink-install-tree.py | 37 ++
util/cutils.c | 68
luding but not limited to datadir. (Peter Maydell)
* Fix "bridge" typo (Philippe Mathieu-Daudé)
v2: Rebased to the latest QEMU.
Akihiko Odaki (3):
cutils: Introduce bundle mechanism
datadir: Use bundle mechanism
module: Use bundle mechanism
Paolo Bonzini (1):
tests/vm: do not
Signed-off-by: Akihiko Odaki
---
qga/main.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/qga/main.c b/qga/main.c
index c373fec3ee6..5f1efa23334 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -223,6 +223,10 @@ void reopen_fd_to_null(int fd)
static void usage(const char
softmmu/datadir.c had its own implementation to find files in the
build tree, but now bundle mechanism provides the unified
implementation which works for datadir and the other files.
Signed-off-by: Akihiko Odaki
---
.travis.yml | 2 +-
pc-bios/keymaps/meson.build | 21
Commit 45f1eecdd63f9e4fa93fef01dd826e7706ac6d7b removed the dependency
from configure to pc-bios
Signed-off-by: Akihiko Odaki
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 3c0d89057eb..2e95d473b3e 100644
--- a/Makefile
+++ b/Makefile
inions?
Actually I prepended qemu- to the directory because all executables of
QEMU has the prefix. We can safely say QEMU installation will never
collide if no file prefixed with qemu- exists in the bindir.
If anyone has an idea what should follow "qemu-", please tell us.
Regards,
Akihiko Odaki
Signed-off-by: Akihiko Odaki
---
configure | 23 +++
meson.build | 10 --
meson_options.txt | 2 +-
scripts/meson-buildoptions.py | 7 +--
scripts/meson-buildoptions.sh | 6 +++---
softmmu/datadir.c
d d2[1] == ':':
+ return d1 + d2[2:]
+ return d1 + d2
This is from Meson but buggy so I fixed it and opened a pull request for
Meson:
https://github.com/mesonbuild/meson/pull/10531
The script included in v8 has the fixed version of destdir_join.
Regards,
Akihiko Odaki
is for any files located relative to the
installation tree including but not limited to datadir. (Peter Maydell)
* Fix "bridge" typo (Philippe Mathieu-Daudé)
v2: Rebased to the latest QEMU.
Akihiko Odaki (3):
cutils: Introduce bundle mechanism
datadir: Use bundle mechanism
module:
installation.
Just remove the -bios option, since it is unnecessary and in fact
there are other x86 VM tests that do not bother specifying it.
Signed-off-by: Paolo Bonzini
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Thomas Huth
Signed-off-by: Akihiko Odaki
Message-Id: <20220616083025.116902-1-pb
softmmu/datadir.c had its own implementation to find files in the
build tree, but now bundle mechanism provides the unified
implementation which works for datadir and the other files.
Signed-off-by: Akihiko Odaki
---
.travis.yml | 2 +-
pc-bios/keymaps/meson.build | 21
system.
Signed-off-by: Akihiko Odaki
Suggested-by: Paolo Bonzini
---
docs/about/build-platforms.rst | 2 +-
include/qemu/cutils.h | 18 +++--
include/qemu/osdep.h| 2 +-
meson.build | 4 ++
scripts/symlink-install-tree.py | 37
Before this change, the directory of the executable was being added to
resolve modules in the build tree. However, get_relocated_path() can now
resolve them with the new bundle mechanism.
Signed-off-by: Akihiko Odaki
---
util/module.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/util
po (Philippe Mathieu-Daudé)
v2: Rebased to the latest QEMU.
Akihiko Odaki (3):
cutils: Introduce bundle mechanism
datadir: Use bundle mechanism
module: Use bundle mechanism
Paolo Bonzini (1):
tests/vm: do not specify -bios option
.travis.yml | 2 +-
docs/about/build
installation.
Just remove the -bios option, since it is unnecessary and in fact
there are other x86 VM tests that do not bother specifying it.
Signed-off-by: Paolo Bonzini
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Thomas Huth
Signed-off-by: Akihiko Odaki
Message-Id: <20220616083025.116902-1-pb
Before this change, the directory of the executable was being added to
resolve modules in the build tree. However, get_relocated_path() can now
resolve them with the new bundle mechanism.
Signed-off-by: Akihiko Odaki
---
util/module.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/util
system.
Signed-off-by: Akihiko Odaki
Suggested-by: Paolo Bonzini
---
docs/about/build-platforms.rst | 2 +-
include/qemu/cutils.h | 18 +++--
include/qemu/osdep.h| 2 +-
meson.build | 4 ++
scripts/symlink-install-tree.py | 34
softmmu/datadir.c had its own implementation to find files in the
build tree, but now bundle mechanism provides the unified
implementation which works for datadir and the other files.
Signed-off-by: Akihiko Odaki
---
.travis.yml | 2 +-
pc-bios/keymaps/meson.build | 21
Hz physical display updates
it is pointless for the guest to update the screen at 60Hz
frequency, the guest can spare some work instead.
Signed-off-by: Akihiko Odaki
---
meson.build | 3 ++-
ui/cocoa.m | 12
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/meson.build
Reviewed-by: Akihiko Odaki
On 2022/07/02 13:43, Peter Delevoryas wrote:
I noticed this error while building QEMU on Mac OS X:
[1040/1660] Compiling Objective-C object libcommon.fa.p/ui_cocoa.m.o
../ui/cocoa.m:803:17: warning: variable 'switched_to_fullscreen' set but
implementation of main() for
builds with ui/cocoa and ones without ui/cocoa.
Akihiko Odaki (3):
ui/cocoa: Run qemu_init in the main thread
Revert "main-loop: Disable block backend global state assertion on
Cocoa"
meson: Allow to enable gtk and sdl while cocoa is enabled
implementation of main() for
builds with ui/cocoa and ones without ui/cocoa.
Signed-off-by: Akihiko Odaki
---
docs/devel/fuzzing.rst | 4 +-
include/qemu-main.h | 3 +-
include/sysemu/sysemu.h | 2 +-
softmmu/main.c | 14 +--
softmmu/vl.c| 2 +-
tests/qtest/fuzz
This reverts commit 47281859f66bdab1974fb122cab2cbb4a1c9af7f.
Signed-off-by: Akihiko Odaki
---
include/qemu/main-loop.h | 13 -
1 file changed, 13 deletions(-)
diff --git a/include/qemu/main-loop.h b/include/qemu/main-loop.h
index 5518845299d..0aa36a4f17e 100644
--- a/include/qemu
As ui/cocoa does no longer override main(), ui/gtk and ui/sdl
can be enabled even ui/cocoa is enabled.
Signed-off-by: Akihiko Odaki
---
meson.build | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/meson.build b/meson.build
index 6e1c3eb2bc5..4714a0d5cf8 100644
t on
QEMU-side.
It is not completely clear for me which solution is more appropriate as
the virtio-iommu specification is written in a way independent of the
endpoint mechanism and does not say what should be done when a PCI
device is unplugged.
Regards,
Akihiko Odaki
On 2023/04/13 19:40, Jean-Philippe Brucker wrote:
Hello,
On Thu, Apr 13, 2023 at 01:49:43PM +0900, Akihiko Odaki wrote:
Hi,
Recently I encountered a problem with the combination of Linux's
virtio-iommu driver and QEMU when a SR-IOV virtual function gets disabled.
I'd like to ask you
On 2023/04/13 22:39, Eric Auger wrote:
Hi,
On 4/13/23 13:01, Akihiko Odaki wrote:
On 2023/04/13 19:40, Jean-Philippe Brucker wrote:
Hello,
On Thu, Apr 13, 2023 at 01:49:43PM +0900, Akihiko Odaki wrote:
Hi,
Recently I encountered a problem with the combination of Linux's
virtio-iommu d
The documentation used to say there is no device implemented with
SR-IOV, but igb and nvme support SR-IOV today.
Signed-off-by: Akihiko Odaki
---
docs/pcie_sriov.txt | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/docs/pcie_sriov.txt b/docs/pcie_sriov.txt
index
] implement new features.
Patch [39, 40] update documentations.
While this includes so many patches, it is not necessary to land them at once.
Only bug fix patches may be applied first, for example.
Akihiko Odaki (40):
hw/net/net_tx_pkt: Decouple from PCI
e1000x: Fix BPRC and MPRC
igb: Fix Rx
ned-off-by: Akihiko Odaki
---
hw/net/e1000.c | 6 +++---
hw/net/e1000e_core.c | 20 +++-
hw/net/e1000x_common.c | 25 +++--
hw/net/e1000x_common.h | 5 +++--
hw/net/igb_core.c | 22 +-
5 files changed, 33 insertions(+), 45
Signed-off-by: Akihiko Odaki
---
hw/net/igb_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 55de212447..f725ab97ae 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -1590,7 +1590,7 @@ static ssize_t
igb's advanced descriptor uses a packet type encoding different from
one used in e1000e's extended descriptor. Fix the logic to encode
Rx packet type accordingly.
Fixes: 3a977deebe ("Intrdocue igb device emulation")
Signed-off-by: Akihiko Odaki
---
hw
It is unlikely to find more bugs with KVM so remove test_igb_nomsi_kvm
to save time to run it.
Signed-off-by: Akihiko Odaki
---
tests/avocado/netdev-ethtool.py | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/tests/avocado/netdev-ethtool.py b/tests/avocado/netdev
This function is not used.
Signed-off-by: Akihiko Odaki
---
hw/net/net_rx_pkt.c | 5 -
hw/net/net_rx_pkt.h | 9 -
2 files changed, 14 deletions(-)
diff --git a/hw/net/net_rx_pkt.c b/hw/net/net_rx_pkt.c
index 63be6e05ad..6125a063d7 100644
--- a/hw/net/net_rx_pkt.c
+++ b/hw/net
801 - 900 of 3324 matches
Mail list logo
