Re: [Qemu-devel] [PATCH 1/2 v2] virtio-rng: Bump up quota value only when guest requests entropy

2015-07-14 Thread Amit Shah
j Gupta Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v7 14/42] Return path: Send responses from destination to source

2015-07-15 Thread Amit Shah
gt; Add migrate_send_rp_shut to send a 'shut' message to indicate > the destination is finished with the RP. > Add migrate_send_rp_ack to send a 'PONG' message in response to a PING > Use it in the MSG_RP_PING handler > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v7 15/42] Return path: Source handling of return path

2015-07-15 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:28], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Open a return path, and handle messages that are received upon it. > > Signed-off-by: Dr. David Alan Gilbert > -/* migration thread support */ > +/* > + * Something bad happened to the RP

Re: [Qemu-devel] [PATCH] migration: We also want to store the global state for savevm

2015-07-15 Thread Amit Shah
On (Wed) 15 Jul 2015 [09:56:22], Juan Quintela wrote: > Previous commit only stored a valid state for migration. It stored the > empty string for savevm. Now, we are also storing the current state for > savevm. Can you include some more information in the commit message? Like the commit hash in

Re: [Qemu-devel] [PATCH 2/2 v2] virtio-rng: Serve pending request if any after timer bumps up quota.

2015-07-15 Thread Amit Shah
On (Wed) 15 Jul 2015 [03:05:06], Pankaj Gupta wrote: > > > - Original Message - > > From: "Amit Shah" > > To: "Pankaj Gupta" > > Cc: qemu-devel@nongnu.org, m...@redhat.com > > Sent: Wednesday, 15 July, 2015 12:09:57 PM > >

Re: [Qemu-devel] [PATCH] migration: We also want to store the global state for savevm

2015-07-15 Thread Amit Shah
On (Wed) 15 Jul 2015 [10:19:04], Juan Quintela wrote: > Amit Shah wrote: > > On (Wed) 15 Jul 2015 [09:56:22], Juan Quintela wrote: > >> Previous commit only stored a valid state for migration. It stored the > >> empty string for savevm. Now, we are also storing the cu

Re: [Qemu-devel] [PATCH v7 16/42] Rework loadvm path for subloops

2015-07-15 Thread Amit Shah
s. > > Split the core of qemu_loadvm_state out so we can use it for both. > > Allow the inner loadvm loop to quit and cause the parent loops to > exit as well. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v7 17/42] Add migration-capability boolean for postcopy-ram.

2015-07-15 Thread Amit Shah
On (Tue) 16 Jun 2015 [16:58:17], Dr. David Alan Gilbert wrote: > * Eric Blake (ebl...@redhat.com) wrote: > > On 06/16/2015 04:26 AM, Dr. David Alan Gilbert (git) wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > The 'postcopy ram' capability allows postcopy migration of RAM; > > > note that

Re: [Qemu-devel] [PATCH v7 17/42] Add migration-capability boolean for postcopy-ram.

2015-07-15 Thread Amit Shah
red (see the migrate_start_postcopy > patch later in the series). > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PULL 0/6] Migration pull request

2015-07-15 Thread Amit Shah
On (Wed) 15 Jul 2015 [11:04:34], Juan Quintela wrote: > Hi > > This pull requset: > - small optimization by Li > - fixes global state with savevm (reported by John Snow) > - get migration traces for migration state changes even if migration > events are not enabled > - Change state after migrati

Re: [Qemu-devel] [PATCH 2/2 v3] virtio-rng: Serve pending request if any after timer bumps up quota.

2015-07-15 Thread Amit Shah
On (Wed) 15 Jul 2015 [17:46:48], Pankaj Gupta wrote: > We are arming timer when we get first request from guest. > Even if guest pulls all the data we will be serving guest > only when timer bumps up new quota. When timer expires > we check if we have a pending request from guest, we > serve it and

Re: [Qemu-devel] [PATCH] qemu-char: Fix missed data on unix socket

2015-07-15 Thread Amit Shah
On (Wed) 15 Jul 2015 [23:44:52], Nils Carlson wrote: > On Mon, 13 Jul 2015, Nils Carlson wrote: > > >On Mon, 13 Jul 2015, Amit Shah wrote: > > > > >>Also, returning TRUE there isn't right - if the connection ends, we > >>should return FALSE. >

Re: [Qemu-devel] [PATCH] qemu-char: Fix missed data on unix socket

2015-07-16 Thread Amit Shah
On (Thu) 16 Jul 2015 [10:11:04], Nils Carlson wrote: > On Thu, 16 Jul 2015, Amit Shah wrote: > > >On (Wed) 15 Jul 2015 [23:44:52], Nils Carlson wrote: > >>On Mon, 13 Jul 2015, Nils Carlson wrote: > >> > >>>On Mon, 13 Jul 2015, Amit Shah wrote: > >&g

[Qemu-devel] [PULL for-2.4 1/1] virtio-rng: trigger timer only when guest requests for entropy

2015-07-17 Thread Amit Shah
From: Pankaj Gupta This patch triggers timer only when guest requests for entropy. As soon as first request from guest for entropy comes we set the timer. Timer bumps up the quota value when it gets triggered. Signed-off-by: Pankaj Gupta Reviewed-by: Amit Shah Message-Id: <1436962608-996

[Qemu-devel] [PULL for-2.4 0/1] virtio-rng: reduce wakeups

2015-07-17 Thread Amit Shah
The following changes since commit 5b5e8cdd7da7a2214dd062afff5b866234aab228: Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-20150717-1' into staging (2015-07-17 12:39:12 +0100) are available in the git repository at: https://git.kernel.org/pub/scm/virt/qemu/amit/virtio-rng.git t

Re: [Qemu-devel] [PATCH 2/2 v3] virtio-rng: Serve pending request if any after timer bumps up quota.

2015-07-17 Thread Amit Shah
On (Thu) 16 Jul 2015 [02:34:34], Pankaj Gupta wrote: > > Anyway we can look at that later, patch 1 is already a big improvement > > so I think we should just stick with that, and think about other > > things in a different series. > > Sure. I think we can apply patch 1 for 2.4, since it reduces t

Re: [Qemu-devel] [PATCH v7 18/42] Add wrappers and handlers for sending/receiving the postcopy-ram migration messages.

2015-07-20 Thread Amit Shah
le that track the current state of postcopy > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah But: > +void qemu_savevm_send_postcopy_ram_discard(QEMUFile *f, const char *name, > + uint16_t len, > +

Re: [Qemu-devel] [PATCH v7 18/42] Add wrappers and handlers for sending/receiving the postcopy-ram migration messages.

2015-07-20 Thread Amit Shah
On (Mon) 13 Jul 2015 [13:02:09], Juan Quintela wrote: > > +/* We're expecting a > > + *Version (0) > > + *a RAM ID string (length byte, name, 0 term) > > + *then at least 1 16 byte chunk > > +*/ > > +if (len < 20) { 1 + > >1+1+1+1+2*8 > > Humm, thinkin

Re: [Qemu-devel] [PATCH v7 19/42] MIG_CMD_PACKAGED: Send a packaged chunk of migration stream

2015-07-20 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:32], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > MIG_CMD_PACKAGED is a migration command that wraps a chunk of migration > stream inside a package whose length can be determined purely by reading > its header. The destination guarantees th

Re: [Qemu-devel] [PATCH v7 20/42] Modify save_live_pending for postcopy

2015-07-20 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:33], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Modify save_live_pending to return separate postcopiable and > non-postcopiable counts. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v7 21/42] postcopy: OS support test

2015-07-21 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:34], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Provide a check to see if the OS we're running on has all the bits > needed for postcopy. > > Creates postcopy-ram.c which will get most of the other helpers we need. > > Signed-off-by: Dr.

Re: [Qemu-devel] [PATCH v7 22/42] migrate_start_postcopy: Command to trigger transition to postcopy

2015-07-21 Thread Amit Shah
On (Mon) 13 Jul 2015 [20:07:52], Juan Quintela wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> > +void qmp_migrate_start_postcopy(Error **errp) > >> > +{ > >> > +MigrationState *s = migrate_get_current(); > >> > + > >> > +if (!migrate_postcop

Re: [Qemu-devel] [PATCH] qemu-char: handle EINTR for TCP character devices

2015-07-21 Thread Amit Shah
On (Tue) 21 Jul 2015 [09:34:29], Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v7 23/42] MIGRATION_STATUS_POSTCOPY_ACTIVE: Add new migration state

2015-07-21 Thread Amit Shah
tive() > +bool migration_postcopy_phase(MigrationState *s) > +{ > +return (s->state == MIGRATION_STATUS_POSTCOPY_ACTIVE); > +} And this is better named migration_in_postcopy() otherwise, Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v7 24/42] Add qemu_savevm_state_complete_postcopy

2015-07-21 Thread Amit Shah
es. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah But: > --- a/migration/savevm.c > +++ b/migration/savevm.c > @@ -938,7 +938,47 @@ int qemu_savevm_state_iterate(QEMUFile *f) > static bool should_send_vmdesc(void) > { > MachineState *machine

Re: [Qemu-devel] [PATCH v7 25/42] Postcopy: Maintain sentmap and calculate discard

2015-07-21 Thread Amit Shah
he destination must throw these pages away before > starting it's CPUs. > > Maintain a 'sentmap' of pages that have already been sent. > Calculate list of sent & dirty pages > Provide helpers on the destination side to discard these. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v7 26/42] postcopy: Incoming initialisation

2015-07-21 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:39], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: David Gibson Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v9 02/22] virtio-serial: don't migrate the config space

2014-06-26 Thread Amit Shah
; Signed-off-by: Alexander Graf > [ added missing casts to uint16_t *, > added From, SoB and commit message, > Greg Kurz ] > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Greg Kurz Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH for-2.1 v2 0/2] help libvirt know what's up with qga

2014-06-26 Thread Amit Shah
oken out per patch. > > The series builds at each patch. I repeated the tests described in the > v1 blurb. Please review. > > Thanks, > Laszlo > > Laszlo Ersek (2): > virtio-serial: report frontend connection state via monitor > char: report frontend op

Re: [Qemu-devel] [PATCH for-2.1 v3 1/2] virtio-serial: report frontend connection state via monitor

2014-06-26 Thread Amit Shah
om/show_bug.cgi?id=1080376 > Signed-off-by: Laszlo Ersek Reviewed-by: Amit Shah Luiz, will you pick this up via your tree? Thanks, Amit

Re: [Qemu-devel] vmstate: struct (VMS_STRUCT) migration

2014-07-03 Thread Amit Shah
On (Wed) 25 Jun 2014 [16:36:59], Alexey Kardashevskiy wrote: > Hi! > > VMStateDescription supports enclosed VMStateDescription's via .vmsd. This > is used in multiple places and VMStateDescription definitions look the same > way - name, version_id, minimum_version_id, etc. > > QEMU handles first

Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load

2014-07-09 Thread Amit Shah
On (Wed) 09 Jul 2014 [11:28:27], Peter Maydell wrote: > On 9 July 2014 05:25, Amit Shah wrote: > > (CC'ing Peter Maydell for his thoughts) > > > > On (Tue) 08 Jul 2014 [22:55:42], Peter Lieven wrote: > >> Hi Juan, > >> > >> Am 25.06.2014 um 1

Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load

2014-07-09 Thread Amit Shah
On (Wed) 09 Jul 2014 [11:50:18], Peter Maydell wrote: > On 9 July 2014 11:44, Amit Shah wrote: > > On (Wed) 09 Jul 2014 [11:28:27], Peter Maydell wrote: > >> On 9 July 2014 05:25, Amit Shah wrote: > >> > Juan is away for a couple of weeks. This looks like a good

Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load

2014-07-10 Thread Amit Shah
(CC'ing Peter Maydell for his thoughts) On (Tue) 08 Jul 2014 [22:55:42], Peter Lieven wrote: > Hi Juan, > > Am 25.06.2014 um 13:55 schrieb Juan Quintela : > > > Peter Lieven wrote: > >> this patch extends commit db80fac by not only checking > >> for unknown flags, but also filtering out unknown

[Qemu-devel] [PATCH for 2.1 1/1] vmstate static checker: detect section renames

2014-07-11 Thread Amit Shah
ose renames. Reported-by: "Dr. David Alan Gilbert" Signed-off-by: Amit Shah --- This is a small patch to a script; doesn't break qemu and helps with the static checker, so it's a very low-risk patch for 2.1. --- scripts/vmstate-static-checker.py | 27 ++--

Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load

2014-07-11 Thread Amit Shah
On (Wed) 09 Jul 2014 [12:00:13], Peter Maydell wrote: > On 9 July 2014 11:56, Amit Shah wrote: > > On (Wed) 09 Jul 2014 [11:50:18], Peter Maydell wrote: > >> OK; we're treating those as bugs so yes, I think this is 2.1 > >> material. Has somebody other than th

Re: [Qemu-devel] [PATCH] rdma: fix memory leak

2015-06-22 Thread Amit Shah
On (Tue) 23 Jun 2015 [09:02:28], arei.gong...@huawei.com wrote: > From: Gonglei > > Variable "r" going out of scope leaks the storage > it points to in line 3268. Interestingly Dave posted a different patch for the same issue. I prefer this approach.

Re: [Qemu-devel] [PATCH 0/3] Introduce virtqueue_get_avail_bytes()

2012-07-16 Thread Amit Shah
On (Fri) 06 Jul 2012 [16:07:06], Amit Shah wrote: > The current virtqueue_avail_bytes() is a weird API: it's oddly-named: > doesn't tell us what the API is going to do, and also suits just one > use-case (that in virtio-net.c). > > Introduce virtqueue_get_avail_bytes(),

Re: [Qemu-devel] [RFC PATCH 0/6] virtio-trace: Support virtio-trace

2012-07-26 Thread Amit Shah
On (Tue) 24 Jul 2012 [11:36:57], Yoshihiro YUNOMAE wrote: > Hi All, > > The following patch set provides a low-overhead system for collecting kernel > tracing data of guests by a host in a virtualization environment. > > A guest OS generally shares some devices with other guests or a host, so > r

Re: [Qemu-devel] [PATCH 0/3] Introduce virtqueue_get_avail_bytes()

2012-07-26 Thread Amit Shah
On (Fri) 06 Jul 2012 [16:07:06], Amit Shah wrote: > The current virtqueue_avail_bytes() is a weird API: it's oddly-named: > doesn't tell us what the API is going to do, and also suits just one > use-case (that in virtio-net.c). > > Introduce virtqueue_get_avail_bytes(),

Re: [Qemu-devel] [RFC PATCH 0/6] virtio-trace: Support virtio-trace

2012-07-27 Thread Amit Shah
On (Fri) 27 Jul 2012 [17:55:11], Yoshihiro YUNOMAE wrote: > Hi Amit, > > Thank you for commenting on our work. > > (2012/07/26 20:35), Amit Shah wrote: > >On (Tue) 24 Jul 2012 [11:36:57], Yoshihiro YUNOMAE wrote: > > [...] > > >> > >>Therefor

Re: [Qemu-devel] [PATCH v2 3/4] rng: move request queue cleanup from RngEgd to RngBackend

2016-03-01 Thread Amit Shah
On (Wed) 10 Feb 2016 [16:53:24], Ladi Prosek wrote: > RngBackend is now in charge of cleaning up the linked list on > instance finalization. It also exposes a function to finalize > individual RngRequest instances, called by its child classes. > > Signed-off-by: Ladi Prosek > @@ -183,8 +162,6 @@

Re: [Qemu-devel] [PATCH v2 4/4] rng: add request queue support to rng-random

2016-03-02 Thread Amit Shah
On (Wed) 10 Feb 2016 [16:53:25], Ladi Prosek wrote: > Requests are now created in the RngBackend parent class and the > code path is shared by both rng-egd and rng-random. > > This commit fixes the rng-random implementation which currently > processes only one request at a time and simply discards

Re: [Qemu-devel] [PATCH v2 3/4] rng: move request queue cleanup from RngEgd to RngBackend

2016-03-02 Thread Amit Shah
On (Wed) 02 Mar 2016 [09:32:48], Ladi Prosek wrote: > On Wed, Mar 2, 2016 at 8:15 AM, Amit Shah wrote: > > On (Wed) 10 Feb 2016 [16:53:24], Ladi Prosek wrote: > >> RngBackend is now in charge of cleaning up the linked list on > >> instance finalization. It also exp

Re: [Qemu-devel] [PATCH] rng-random: implement request queue

2016-03-02 Thread Amit Shah
On (Thu) 04 Feb 2016 [13:07:35], Ladi Prosek wrote: > - Original Message - > > - Original Message - > > > > > > > > > On 03/02/2016 13:36, Amit Shah wrote: > > > > ... and this can lead to breaking migration (the queue of request

Re: [Qemu-devel] [PATCH v3 02/27] migration: remove use of qemu_bufopen from vmstate tests

2016-03-03 Thread Amit Shah
t; Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: Daniel P. Berrange Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v3 0/4] rng-random: implement request queue

2016-03-03 Thread Amit Shah
else they need to do (walk the queue, peek the head > of the queue, ..) > > Changes from v2: > - updated commit message in 1/4 and 4/4 as requested by Amit Reviewed-by: Amit Shah Thanks, Amit

Re: [Qemu-devel] [PATCH] virtio-rng: ask for more data if queue is not fully drained

2016-03-03 Thread Amit Shah
On (Thu) 03 Mar 2016 [10:48:34], Ladi Prosek wrote: > This commit effectively reverts: > > commit 4621c1768ef5d12171cca2aa1473595ecb9f1c9e > Author: Amit Shah > Date: Wed Nov 21 11:21:19 2012 +0530 > > virtio-rng: remove extra request for entropy >

[Qemu-devel] [PULL 0/6] virtio-rng

2016-03-03 Thread Amit Shah
The following changes since commit ed6128ebbdd7cd885d39980659dad4b5c8ae8158: Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2016-03-01 15:54:03 +) are available in the git repository at: https://git.kernel.org/pub/scm/virt/qemu/amit/virtio-rng.gi

[Qemu-devel] [PULL 1/6] MAINTAINERS: Add an entry for the include/sysemu/rng*.h files

2016-03-03 Thread Amit Shah
From: Thomas Huth These headers are used by the virtio-rng and rng backends code, so they should be listed in the same section in MAINTAINERS, too. Signed-off-by: Thomas Huth Reviewed-by: Amit Shah Message-Id: <1456404260-26928-1-git-send-email-th...@redhat.com> Signed-off-by: Ami

[Qemu-devel] [PULL 2/6] rng: remove the unused request cancellation code

2016-03-03 Thread Amit Shah
From: Ladi Prosek rng_backend_cancel_requests had no callers and none of the code deleted in this commit ever ran. Signed-off-by: Ladi Prosek Reviewed-by: Amit Shah Message-Id: <1456994238-9585-2-git-send-email-lpro...@redhat.com> Signed-off-by: Amit Shah --- backends/rng-egd.c

[Qemu-devel] [PULL 3/6] rng: move request queue from RngEgd to RngBackend

2016-03-03 Thread Amit Shah
From: Ladi Prosek The 'requests' field now lives in the RngBackend parent class. There are no functional changes in this commit. Signed-off-by: Ladi Prosek Reviewed-by: Amit Shah Message-Id: <1456994238-9585-3-git-send-email-lpro...@redhat.com> Signed-off-by: Amit Shah -

[Qemu-devel] [PULL 5/6] rng: add request queue support to rng-random

2016-03-03 Thread Amit Shah
: Ladi Prosek Reviewed-by: Amit Shah Message-Id: <1456994238-9585-5-git-send-email-lpro...@redhat.com> Signed-off-by: Amit Shah --- backends/rng-egd.c| 16 ++-- backends/rng-random.c | 43 +++ backends/rng.c| 13 - i

[Qemu-devel] [PULL 4/6] rng: move request queue cleanup from RngEgd to RngBackend

2016-03-03 Thread Amit Shah
From: Ladi Prosek RngBackend is now in charge of cleaning up the linked list on instance finalization. It also exposes a function to finalize individual RngRequest instances, called by its child classes. Signed-off-by: Ladi Prosek Reviewed-by: Amit Shah Message-Id: <1456994238-9585-4-git-s

[Qemu-devel] [PULL 6/6] virtio-rng: ask for more data if queue is not fully drained

2016-03-03 Thread Amit Shah
From: Ladi Prosek This commit effectively reverts: commit 4621c1768ef5d12171cca2aa1473595ecb9f1c9e Author: Amit Shah Date: Wed Nov 21 11:21:19 2012 +0530 virtio-rng: remove extra request for entropy but instead of calling virtio_rng_process unconditionally, it first checks to see

Re: [Qemu-devel] [PATCH] rng: switch request queue to QSIMPLEQ

2016-03-03 Thread Amit Shah
On (Thu) 03 Mar 2016 [14:16:11], Ladi Prosek wrote: > QSIMPLEQ supports appending to tail in O(1) and is intrusive so > it doesn't require extra memory allocations for the bookkeeping > data. > > Suggested-by: Paolo Bonzini > Signed-off-by: Ladi Prosek > @@ -83,24 +83,27 @@ static void rng_back

Re: [Qemu-devel] [PATCH] rng: switch request queue to QSIMPLEQ

2016-03-04 Thread Amit Shah
On (Fri) 04 Mar 2016 [09:04:22], Ladi Prosek wrote: > On Fri, Mar 4, 2016 at 7:27 AM, Amit Shah wrote: > > On (Thu) 03 Mar 2016 [14:16:11], Ladi Prosek wrote: > >> QSIMPLEQ supports appending to tail in O(1) and is intrusive so > >> it doesn't require extra memory

Re: [Qemu-devel] [PATCH] rng: switch request queue to QSIMPLEQ

2016-03-04 Thread Amit Shah
On (Fri) 04 Mar 2016 [10:27:57], Paolo Bonzini wrote: > > > On 04/03/2016 10:19, Ladi Prosek wrote: > > On Fri, Mar 4, 2016 at 10:12 AM, Paolo Bonzini wrote: > >> > >> > >> On 04/03/2016 09:04, Ladi Prosek wrote: > >>> +QSIMPLEQ_INIT(&s->requests); > >>> } > > > > This init

Re: [Qemu-devel] [PATCH] rng: switch request queue to QSIMPLEQ

2016-03-04 Thread Amit Shah
On (Thu) 03 Mar 2016 [14:16:11], Ladi Prosek wrote: > QSIMPLEQ supports appending to tail in O(1) and is intrusive so > it doesn't require extra memory allocations for the bookkeeping > data. > > Suggested-by: Paolo Bonzini > Signed-off-by: Ladi Prosek

Re: [Qemu-devel] [PULL 0/5] migration pull

2016-03-07 Thread Amit Shah
On (Wed) 24 Feb 2016 [09:27:50], Li, Liang Z wrote: > > It's a bug in the header file, it was fixed in 4.9. > > > > https://gcc.gnu.org/ml/gcc-patches/2013-06/txtvBBiTsFs8g.txt > > > > Amit or Liang, can you restrict the new optimization to GCC 4.9+? > > > > Paolo > > Of course, how about using

[Qemu-devel] [PULL 0/1] rng: use simpleq instead of gslist

2016-03-08 Thread Amit Shah
The following changes since commit 97556fe80e4f7252300b3498b3477fb4295153a3: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2016-03-08 04:53:37 +) are available in the git repository at: https://git.kernel.org/pub/scm/virt/qemu/amit/virtio-rng.git tags/r

[Qemu-devel] [PULL 1/1] rng: switch request queue to QSIMPLEQ

2016-03-08 Thread Amit Shah
From: Ladi Prosek QSIMPLEQ supports appending to tail in O(1) and is intrusive so it doesn't require extra memory allocations for the bookkeeping data. Suggested-by: Paolo Bonzini Signed-off-by: Ladi Prosek Reviewed-by: Paolo Bonzini Reviewed-by: Amit Shah Message-Id: <1457010971

Re: [Qemu-devel] [RFC qemu 0/4] A PV solution for live migration optimization

2016-03-08 Thread Amit Shah
On (Fri) 04 Mar 2016 [15:02:47], Jitendra Kolhe wrote: > > > > > > * Liang Li (liang.z...@intel.com) wrote: > > > > The current QEMU live migration implementation mark the all the > > > > guest's RAM pages as dirtied in the ram bulk stage, all these pages > > > > will be processed and that takes qu

Re: [Qemu-devel] [RFC qemu 0/4] A PV solution for live migration optimization

2016-03-08 Thread Amit Shah
On (Thu) 03 Mar 2016 [18:44:24], Liang Li wrote: > The current QEMU live migration implementation mark the all the > guest's RAM pages as dirtied in the ram bulk stage, all these pages > will be processed and that takes quit a lot of CPU cycles. > > From guest's point of view, it doesn't care abou

[Qemu-devel] [PULL 0/3] migration: avx2, 'info migrate' updates

2016-03-08 Thread Amit Shah
The following changes since commit 97556fe80e4f7252300b3498b3477fb4295153a3: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2016-03-08 04:53:37 +) are available in the git repository at: https://git.kernel.org/pub/scm/virt/qemu/amit/migration.git tags/mi

[Qemu-devel] [PULL 1/3] Postcopy: Fix sync count in info migrate

2016-03-08 Thread Amit Shah
at.com> Signed-off-by: Amit Shah --- migration/migration.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/migration.c b/migration/migration.c index 0129d9f..7d13377 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -635,6 +635,7 @@ MigrationInfo *qmp_query

[Qemu-devel] [PULL 3/3] cutils: add avx2 instruction optimization

2016-03-08 Thread Amit Shah
supports AVX2, execute the AVX2 instructions, else, execute the original instructions. Signed-off-by: Liang Li Suggested-by: Paolo Bonzini Suggested-by: Richard Henderson Reviewed-by: Paolo Bonzini Message-Id: <1457416397-26671-3-git-send-email-liang.z...@intel.com> Signed-off-by: Ami

[Qemu-devel] [PULL 2/3] configure: detect ifunc and avx2 attribute

2016-03-08 Thread Amit Shah
ail-liang.z...@intel.com> Signed-off-by: Amit Shah --- configure | 21 + 1 file changed, 21 insertions(+) diff --git a/configure b/configure index 0c0472a..2b32876 100755 --- a/configure +++ b/configure @@ -280,6 +280,7 @@ libusb="" usb_redir="" op

Re: [Qemu-devel] [PATCH v3 0/2] Fix flaw of qemu_put_compression_data

2016-03-09 Thread Amit Shah
On (Wed) 09 Mar 2016 [08:41:41], Li, Liang Z wrote: > > > -Original Message- > > From: Li, Liang Z > > Sent: Thursday, February 25, 2016 11:50 AM > > To: quint...@redhat.com; amit.s...@redhat.com > > Cc: qemu-devel@nongnu.org; dgilb...@redhat.com; > > zhang.zhanghaili...@huawei.com; Li, Li

Re: [Qemu-devel] [RFC kernel 0/2]A PV solution for KVM live migration optimization

2016-03-09 Thread Amit Shah
On (Thu) 10 Mar 2016 [12:31:32], Jitendra Kolhe wrote: > On 3/8/2016 4:44 PM, Amit Shah wrote: > >>>> Hi, > >>>> An interesting solution; I know a few different people have been > >>>> looking at > >>>> how to speed up ballooned VM

Re: [Qemu-devel] [RFC qemu 0/4] A PV solution for live migration optimization

2016-03-09 Thread Amit Shah
On (Thu) 10 Mar 2016 [07:44:19], Li, Liang Z wrote: > > Hi Amit, > > Could provide more information on how to use virtio-serial to exchange data? > Thread , Wiki or code are all OK. > I have not find some useful information yet. See this commit in the Linux sources: 108fc82596e3b66b819df9d

[Qemu-devel] [PULL 0/4] migration fixes

2016-03-11 Thread Amit Shah
The following changes since commit a648c137383d84bc4f95696e5293978d9541a26e: Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160309-1' into staging (2016-03-10 02:51:14 +) are available in the git repository at: https://git.kernel.org/pub/scm/virt/qemu/amit/migration.git ta

[Qemu-devel] [PULL 1/4] migration: fix warning for source_return_path_thread

2016-03-11 Thread Amit Shah
From: Peter Xu max_len is not necessary, while it brings a warning during compilation when specify "-Wstack-usage=100". Replacing using sizeof(). Signed-off-by: Peter Xu Message-Id: <1457503932-31763-1-git-send-email-pet...@redhat.com> Signed-off-by: Amit Shah --- migra

[Qemu-devel] [PULL 4/4] postcopy: Remove the x-

2016-03-11 Thread Amit Shah
an Gilbert Reviewed-by: Eric Blake Message-Id: <1457690016-9070-3-git-send-email-dgilb...@redhat.com> Signed-off-by: Amit Shah --- docs/migration.txt| 2 +- hmp-commands.hx | 2 +- migration/migration.c | 4 ++-- qapi-schema.json | 8 qmp-commands.hx | 6 +++---

[Qemu-devel] [PULL 2/4] migration: fix use-after-free in loadvm_postcopy_handle_run_bh

2016-03-11 Thread Amit Shah
From: "Denis V. Lunev" MigrationState is destroyed before we can come into bottom half. Signed-off-by: Denis V. Lunev Reviewed-by: Dr. David Alan Gilbert CC: Juan Quintela CC: Amit Shah CC: Dr. David Alan Gilbert Message-Id: <1457537708-8622-1-git-send-email-...@openvz.org&g

[Qemu-devel] [PULL 3/4] postcopy: listen thread is never joined

2016-03-11 Thread Amit Shah
com> Signed-off-by: Amit Shah --- migration/savevm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/savevm.c b/migration/savevm.c index 384e872..0a33c22 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -1494,7 +1494,7 @@ static int loadvm_p

Re: [Qemu-devel] Ballooning on TPS!=HPS hosts

2016-04-01 Thread Amit Shah
CC'ing virtualization list. On (Thu) 31 Mar 2016 [19:00:24], Dr. David Alan Gilbert wrote: > Hi, > I was reading the balloon code and am confused as to how/if ballooning > works on hosts where the host page size is larger than the > target page size. > > static void balloon_page(void *addr, int

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-04-01 Thread Amit Shah
On (Tue) 22 Mar 2016 [19:05:31], Dr. David Alan Gilbert wrote: > * Liang Li (liang.z...@intel.com) wrote: > > b. Implement a new virtio device > > Implementing a brand new virtio device to exchange information > > between host and guest is another choice. It requires modifying the > > virtio spec

Re: [Qemu-devel] [PULL 8/9] static checker: e1000-82540em got aliased to e1000

2016-04-06 Thread Amit Shah
On (Wed) 06 Apr 2016 [09:48:19], Jason Wang wrote: > > > On 04/05/2016 09:32 PM, Dr. David Alan Gilbert wrote: > > * Amit Shah (amit.s...@redhat.com) wrote: > >> On (Tue) 23 Feb 2016 [15:02:58], Jason Wang wrote: > >>>>> This means that 2.5 cannot mig

[Qemu-devel] Move autoconverge out of experimental?

2016-04-18 Thread Amit Shah
Hi Jason, We've had the new autoconverge features enabled for a full release now, what are your thoughts on dropping the x- ? Some factors I consider are direct user feedback, changes to the functionality / API, and higher-level user feedback (like libvirt). I believe libvirt is now using the ne

Re: [Qemu-devel] Move autoconverge out of experimental?

2016-04-19 Thread Amit Shah
On (Tue) 19 Apr 2016 [09:28:34], Jason J. Herne wrote: > On 04/19/2016 02:39 AM, Amit Shah wrote: > >Hi Jason, > > > >We've had the new autoconverge features enabled for a full release > >now, what are your thoughts on dropping the x- ? > > > >Some

Re: [Qemu-devel] [PATCH kernel 0/2] speed up live migration by skipping free pages

2016-04-24 Thread Amit Shah
On (Tue) 19 Apr 2016 [22:34:32], Liang Li wrote: > Current QEMU live migration implementation mark all guest's RAM pages > as dirtied in the ram bulk stage, all these pages will be processed > and it consumes quite a lot of CPU cycles and network bandwidth. > > From guest's point of view, it doesn

Re: [Qemu-devel] [PATCH kernel 0/2] speed up live migration by skipping free pages

2016-04-25 Thread Amit Shah
On (Mon) 25 Apr 2016 [14:04:06], Michael S. Tsirkin wrote: > On Mon, Apr 25, 2016 at 11:36:41AM +0530, Amit Shah wrote: > > On (Tue) 19 Apr 2016 [22:34:32], Liang Li wrote: > > > Current QEMU live migration implementation mark all guest's RAM pages > > > as dirtied

Re: [Qemu-devel] [PATCH v1 0/6] A migration performance testing framework

2016-05-06 Thread Amit Shah
On (Thu) 05 May 2016 [15:27:54], Daniel P. Berrange wrote: > This series of patches provides a framework for testing migration performance > characteristics. The motivating factor for this is planning that is underway > in OpenStack wrt making use of QEMU migration features such as compression, > a

Re: [Qemu-devel] [PATCH v6 for-2.7 24/28] migration: don't use an array for storing migrate parameters

2016-05-25 Thread Amit Shah
On (Wed) 27 Apr 2016 [11:05:14], Daniel P. Berrange wrote: > The MigrateState struct uses an array for storing migration > parameters. This presumes that all future parameters will > be integers too, which is not going to be the case. There > is no functional reason why an array is used, if anythin

Re: [Qemu-devel] [PATCH v6 for-2.7 25/28] migration: define 'tls-creds' and 'tls-hostname' migration parameters

2016-05-25 Thread Amit Shah
On (Wed) 27 Apr 2016 [11:05:15], Daniel P. Berrange wrote: > Define two new migration parameters to be used with TLS encryption. > The 'tls-creds' parameter provides the ID of an instance of the > 'tls-creds' object type, or rather a subclass such as 'tls-creds-x509'. > Providing these credentials

[Qemu-devel] [PULL 05/28] migration: split migration hooks out of QEMUFileOps

2016-05-25 Thread Amit Shah
an Gilbert Signed-off-by: Daniel P. Berrange Reviewed-by: Juan Quintela Message-Id: <1461751518-12128-6-git-send-email-berra...@redhat.com> Signed-off-by: Amit Shah --- include/migration/qemu-file.h | 10 +++--- migration/qemu-file-internal.h | 1 + migration/qemu-file

[Qemu-devel] [PULL 03/28] migration: remove use of qemu_bufopen from vmstate tests

2016-05-25 Thread Amit Shah
: Daniel P. Berrange Reviewed-by: Juan Quintela Message-Id: <1461751518-12128-4-git-send-email-berra...@redhat.com> Signed-off-by: Amit Shah --- tests/Makefile | 2 +- tests/test-vmstate.c | 44 +--- 2 files changed, 14 insertions(+), 32 deletion

[Qemu-devel] [PULL 00/28] migration: support for TLS

2016-05-25 Thread Amit Shah
The following changes since commit 287db79df8af8e31f18e262feb5e05103a09e4d4: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into staging (2016-05-24 13:06:33 +0100) are available in the git repository at: https://git.kernel.org/pub/scm/virt/qemu/amit/migration.git ta

[Qemu-devel] [PULL 02/28] io: avoid double-free when closing QIOChannelBuffer

2016-05-25 Thread Amit Shah
ert Signed-off-by: Daniel P. Berrange Reviewed-by: Juan Quintela Message-Id: <1461751518-12128-3-git-send-email-berra...@redhat.com> Signed-off-by: Amit Shah --- io/channel-buffer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/io/channel-buffer.c b/io/channel-buffer.c index 3e5117b.

[Qemu-devel] [PULL 04/28] migration: ensure qemu_fflush() always writes full data amount

2016-05-25 Thread Amit Shah
o the code to catch mistaken implementations. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrange Reviewed-by: Juan Quintela Message-Id: <1461751518-12128-5-git-send-email-berra...@redhat.com> Signed-off-by: Amit Shah --- include/migration/qemu-file.h | 6 -- migra

[Qemu-devel] [PULL 09/28] migration: add helpers for creating QEMUFile from a QIOChannel

2016-05-25 Thread Amit Shah
. Berrange Acked-by: Juan Quintela Message-Id: <1461751518-12128-10-git-send-email-berra...@redhat.com> Signed-off-by: Amit Shah --- include/migration/migration.h | 6 ++ migration/migration.c | 21 + 2 files changed, 27 insertions(+) diff --git a/i

[Qemu-devel] [PULL 01/28] s390: use FILE instead of QEMUFile for creating text file

2016-05-25 Thread Amit Shah
Message-Id: <1461751518-12128-2-git-send-email-berra...@redhat.com> Signed-off-by: Amit Shah --- hw/s390x/s390-skeys.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/hw/s390x/s390-skeys.c b/hw/s390x/s390-skeys.c index d772cfc..e2d4e1a 100644 ---

[Qemu-devel] [PULL 11/28] migration: convert post-copy to use QIOChannelBuffer

2016-05-25 Thread Amit Shah
. Berrange Message-Id: <1461751518-12128-12-git-send-email-berra...@redhat.com> Signed-off-by: Amit Shah --- docs/migration.txt | 4 ++-- include/sysemu/sysemu.h | 2 +- migration/migration.c | 15 +++ migration/savevm.c | 47

[Qemu-devel] [PULL 13/28] migration: rename unix.c to socket.c

2016-05-25 Thread Amit Shah
: Daniel P. Berrange Message-Id: <1461751518-12128-14-git-send-email-berra...@redhat.com> Signed-off-by: Amit Shah --- migration/Makefile.objs | 2 +- migration/socket.c | 132 migration/uni

[Qemu-devel] [PULL 10/28] migration: add reporting of errors for outgoing migration

2016-05-25 Thread Amit Shah
} } Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrange Reviewed-by: Juan Quintela Message-Id: <1461751518-12128-11-git-send-email-berra...@redhat.com> Signed-off-by: Amit Shah --- hmp.c | 13 - include/migration/migration.h | 5

[Qemu-devel] [PULL 15/28] migration: convert fd socket protocol to use QIOChannel

2016-05-25 Thread Amit Shah
Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrange Message-Id: <1461751518-12128-16-git-send-email-berra...@redhat.com> Signed-off-by: Amit Shah --- migration/Makefile.objs | 4 +-- migration/fd.c | 75 +++-- migration/mi

[Qemu-devel] [PULL 07/28] migration: force QEMUFile to blocking mode for outgoing migration

2016-05-25 Thread Amit Shah
n Quintela Message-Id: <1461751518-12128-8-git-send-email-berra...@redhat.com> Signed-off-by: Amit Shah --- migration/migration.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/migration.c b/migration/migration.c index ac7790f..c8d10ee 100644 --- a/migration/migration.c

[Qemu-devel] [PULL 16/28] migration: convert exec socket protocol to use QIOChannel

2016-05-25 Thread Amit Shah
fork processes. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrange Message-Id: <1461751518-12128-17-git-send-email-berra...@redhat.com> Signed-off-by: Amit Shah --- migration/Makefile.objs | 3 +-- migration/exec.c| 62 +--

[Qemu-devel] [PULL 06/28] migration: introduce set_blocking function in QEMUFileOps

2016-05-25 Thread Amit Shah
eviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrange Reviewed-by: Juan Quintela Message-Id: <1461751518-12128-7-git-send-email-berra...@redhat.com> Signed-off-by: Amit Shah --- include/migration/qemu-file.h | 5 + migration/migration.c | 4 +--- migra

<    6   7   8   9   10   11   12   13   14   15   >