On (Wed) 16 Feb 2011 [08:41:27], Anthony Liguori wrote:
> On 02/16/2011 08:39 AM, Amit Shah wrote:
> >On (Tue) 15 Feb 2011 [17:13:13], Anthony Liguori wrote:
> >>On 02/15/2011 10:26 AM, Chris Wright wrote:
> >>>revisit new -> old migration
> >>>
On (Tue) 15 Feb 2011 [10:10:23], Anthony Liguori wrote:
> >diff --git a/hw/virtio-serial.h b/hw/virtio-serial.h
> >index a308196..2c5e336 100644
> >--- a/hw/virtio-serial.h
> >+++ b/hw/virtio-serial.h
> >@@ -57,6 +57,19 @@ struct virtio_console_control {
> >
> > /* == In-qemu interface == */
> >
On (Tue) 15 Feb 2011 [10:43:42], Anthony Liguori wrote:
> > #define DEFINE_BLOCK_PROPERTIES(_state, _conf) \
> >-DEFINE_PROP_DRIVE("drive", _state, _conf.bs), \
> >+DEFINE_PROP_DRIVE("drive", _state, _conf.bs, ""), \
> >
On (Thu) 17 Feb 2011 [07:12:42], Anthony Liguori wrote:
> On 02/17/2011 07:06 AM, Amit Shah wrote:
> >On (Tue) 15 Feb 2011 [10:43:42], Anthony Liguori wrote:
> >
> >>> #define DEFINE_BLOCK_PROPERTIES(_state, _conf) \
> >>>-DEFI
On (Thu) 17 Feb 2011 [07:11:44], Anthony Liguori wrote:
> On 02/17/2011 07:03 AM, Amit Shah wrote:
> >On (Tue) 15 Feb 2011 [10:10:23], Anthony Liguori wrote:
> >
> >>>diff --git a/hw/virtio-serial.h b/hw/virtio-serial.h
> >>>index a308196..2c5e336 100644
>
On (Tue) 15 Feb 2011 [10:12:23], Anthony Liguori wrote:
> On 02/04/2011 12:18 AM, Amit Shah wrote:
> >Hello,
> >
> >This is yet another rebase of the patchset I'd sent earlier.
> >
> >The usual notes apply: this is just the start, just getting the
> >f
allow instantiating a port at id 0 as well.
Signed-off-by: Amit Shah
---
hw/virtio-console.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index 62624ec..3560db3 100644
--- a/hw/virtio-console.c
+++ b/hw/virtio-console.c
@@ -11,6
The following changes since commit 57a8821bc6e4457230075a5c8da5f8a083889686:
w32: Remove implementation of function ffs (2011-02-20 20:18:21 +)
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/qemu/amit/virtio-serial.git for-anthony
Amit Shah (3):
virtio
Instead of using a single variable to pass to the virtio_serial_init
function, use a struct so that expanding the number of variables to be
passed on later is easier.
Signed-off-by: Amit Shah
---
hw/virtio-pci.c| 12 ++--
hw/virtio-serial-bus.c | 16
hw
Enable ioeventfd for virtio-serial devices by default. Commit
25db9ebe15125deb32958c6df74996f745edf1f9 lists the benefits of using
ioeventfd.
Copying a file from guest to host over a virtio-serial channel didn't
show much difference in time or io_exit rate.
Signed-off-by: Amit Shah
--
Prevent:
-chardev socket,path=/tmp/foo,server,nowait,id=c0 \
-device virtserialport,chardev=c0,id=vs0 \
-device virtserialport,chardev=c0,id=vs1
Reported-by: Mike Cao
Signed-off-by: Amit Shah
---
hw/qdev-properties.c |7 ++-
qemu-char.h |1 +
2 files changed, 7 insertions
Mark the current iohandler list as 'old'. In the next commit we'll
introduce a new iohandler api that will replace the list name.
The 'old' list will eventually be completely replaced by the new
implementation.
Signed-off-by: Amit Shah
---
vl.c | 14 +++--
Update the udp code to use the new iohandler api. The change is mostly
mechanical with a new iohandler function calling the older functions
depending on the value of the 'mask' field.
Signed-off-by: Amit Shah
---
qemu-char.c | 22 +++---
1 files changed, 19 insert
acks
altogether.
I tested this series in two scenarios: monitor on stdio and by running
the virtio-serial testsuite, which uses unix sockets and does
open/close/read/write/poll calls on the sockets. It all works fine.
Please review and apply.
Amit Shah (7):
iohandlers: Mark current impleme
Update the fd code to use the new iohandler api. The change is mostly
mechanical with a new iohandler function calling the older functions
depending on the value of the 'mask' field.
Signed-off-by: Amit Shah
---
qemu-char.c | 24
1 files changed, 20 insert
Introduce a new iohandler api that doesn't have multiple callbacks.
Instead, a single callback and a mask of events that got set will be
passed on to the handler. This will ease our transition to a poll()
interface instead of the current select() that happens on the fds.
Signed-off-by: Amit
Update the tcp code to use the new iohandler api. The change is mostly
mechanical with a new iohandler function calling the older functions
depending on the value of the 'mask' field.
Signed-off-by: Amit Shah
---
qemu-char.c | 48 ---
Update the stdio code to use the new iohandler api. The change is
mostly mechanical with a new iohandler function calling the older
functions depending on the value of the 'mask' field.
Signed-off-by: Amit Shah
---
qemu-char.c | 22 +++---
1 files changed, 19 insert
Update the pty code to use the new iohandler api. The change is mostly
mechanical with a new iohandler function calling the older functions
depending on the value of the 'mask' field.
Signed-off-by: Amit Shah
---
qemu-char.c | 24
1 files changed, 20 insert
On (Tue) 22 Feb 2011 [13:09:34], Avi Kivity wrote:
> On 02/22/2011 12:18 PM, Amit Shah wrote:
> >Mark the current iohandler list as 'old'. In the next commit we'll
> >introduce a new iohandler api that will replace the list name.
> >
> >The 'old'
On (Tue) 22 Feb 2011 [14:39:03], Alon Levy wrote:
> On Tue, Feb 22, 2011 at 03:48:31PM +0530, Amit Shah wrote:
> > Introduce a new iohandler api that doesn't have multiple callbacks.
> > Instead, a single callback and a mask of events that got set will be
> > passed on
On (Tue) 22 Feb 2011 [15:28:59], Avi Kivity wrote:
> On 02/22/2011 01:17 PM, Amit Shah wrote:
> >On (Tue) 22 Feb 2011 [13:09:34], Avi Kivity wrote:
> >> On 02/22/2011 12:18 PM, Amit Shah wrote:
> >> >Mark the current iohandler list as 'old'. In the
On (Tue) 22 Feb 2011 [15:28:02], Avi Kivity wrote:
> On 02/22/2011 12:18 PM, Amit Shah wrote:
> >Introduce a new iohandler api that doesn't have multiple callbacks.
> >Instead, a single callback and a mask of events that got set will be
> >passed on to the handler. Thi
On (Tue) 22 Feb 2011 [16:40:55], Michael Roth wrote:
> If something in the guest is attempting to read/write from the
> virtio-serial device, and nothing is connected to virtio-serial's
> host character device (say, a socket)
>
> 1. writes will block until something connect()s, at which point the
s in virtio-serial.h ]
Signed-off-by: Gerd Hoffmann
Signed-off-by: Amit Shah
---
hw/virtio-console.c| 17 ++---
hw/virtio-serial-bus.c | 15 ++-
hw/virtio-serial.h |9 ++---
3 files changed, 14 insertions(+), 27 deletions(-)
diff --git a/hw/virtio-c
On (Wed) 23 Feb 2011 [08:31:52], Michael Roth wrote:
> On 02/22/2011 10:59 PM, Amit Shah wrote:
> >On (Tue) 22 Feb 2011 [16:40:55], Michael Roth wrote:
> >>If something in the guest is attempting to read/write from the
> >>virtio-serial device, and nothing is connected
Prevent:
-chardev socket,path=/tmp/foo,server,nowait,id=c0 \
-device virtserialport,chardev=c0,id=vs0 \
-device virtserialport,chardev=c0,id=vs1
Reported-by: Mike Cao
Signed-off-by: Amit Shah
---
hw/qdev-properties.c |7 ++-
qemu-char.h |1 +
2 files changed, 7 insertions
Instead of using a single variable to pass to the virtio_serial_init
function, use a struct so that expanding the number of variables to be
passed on later is easier.
Signed-off-by: Amit Shah
---
hw/virtio-pci.c| 12 ++--
hw/virtio-serial-bus.c | 16
hw
-anthony
Amit Shah (3):
virtio-serial: Use a struct to pass config information from proxy
virtio-serial: Disallow generic ports at id 0
virtio-serial: Enable ioeventfd
hw/virtio-console.c| 11 ++-
hw/virtio-pci.c| 15 +--
hw/virtio-serial-bus.c | 16
allow instantiating a port at id 0 as well.
Signed-off-by: Amit Shah
---
hw/virtio-console.c | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index c235b27..699f190 100644
--- a/hw/virtio-console.c
+++ b/hw/virtio-console.c
@@
Enable ioeventfd for virtio-serial devices by default. Commit
25db9ebe15125deb32958c6df74996f745edf1f9 lists the benefits of using
ioeventfd.
Copying a file from guest to host over a virtio-serial channel didn't
show much difference in time or io_exit rate.
Signed-off-by: Amit Shah
--
On (Thu) 24 Feb 2011 [08:44:07], Anthony Liguori wrote:
> For instance, if the host side disconnects, then reconnects before
> we read(), we may never get the read()=0, and our FD remains valid.
> Whereas with a tcp/unix socket our FD is no longer valid, and the
> read()=0 is an eve
On (Fri) 25 Feb 2011 [14:25:20], Michael Roth wrote:
> On 02/24/2011 06:48 AM, Amit Shah wrote:
> >On (Wed) 23 Feb 2011 [08:31:52], Michael Roth wrote:
> >>On 02/22/2011 10:59 PM, Amit Shah wrote:
> >>>On (Tue) 22 Feb 2011 [16:40:55], Michael Roth wrote:
>
On (Mon) 28 Feb 2011 [15:28:49], Stefan Hajnoczi wrote:
> On Mon, Feb 28, 2011 at 11:12 AM, Amit Shah wrote:
> > Enable ioeventfd for virtio-serial devices by default. Commit
> > 25db9ebe15125deb32958c6df74996f745edf1f9 lists the benefits of using
> > ioeventfd.
> >
&g
vvfat.c:1068:
/usr/include/bits/stdio2.h:65: error: call to __builtin___snprintf_chk will
always overflow destination buffer
make: *** [block/vvfat.o] Error 1
Signed-off-by: Kirill A. Shutemov
Signed-off-by: Juan Quintela
Signed-off-by: Anthony Liguori
(cherry picked from commit 2dedf83ef0cc
cture.
Signed-off-by: Amit Shah
---
vl.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index 920717a..f9c8086 100644
--- a/vl.c
+++ b/vl.c
@@ -418,6 +418,7 @@ static void configure_rtc(QemuOpts *opts)
exit(1);
}
}
+#ifdef TARGET
qemu-config.c doesn't contain any target-specific code, and the
TARGET_I386 conditional code didn't get compiled as a result. Removing
this enables the driftfix parameter for rtc.
Signed-off-by: Amit Shah
---
qemu-config.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
On (Wed) Jun 23 2010 [16:35:26], Paolo Bonzini wrote:
> On 06/23/2010 04:29 PM, Amit Shah wrote:
> >The driftfix option is only useful for Windows guests, and for the x86
> >architecture, so limit the option parsing to TARGET_I386. This ifdef
> >conditional is moved from qemu-
qemu-config.c doesn't contain any target-specific code, and the
TARGET_I386 conditional code didn't get compiled as a result. Removing
this enables the driftfix parameter for rtc.
Signed-off-by: Amit Shah
---
qemu-config.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
ch has this typo.
Reported-by: Daniel P. Berrange
Signed-off-by: Amit Shah
---
hw/pc_piix.c |6 +++---
hw/ppc440_bamboo.c |2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/pc_piix.c b/hw/pc_piix.c
index 68040b7..84e6c7f 100644
--- a/hw/pc_piix.c
+++ b
On (Wed) Jun 23 2010 [12:51:18], Michael S. Tsirkin wrote:
> We were requesting too much when checking buffer
> length: size already includes host header length.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> hw/virtio-net.c | 20 +++-
> 1 files changed, 11 insertions(+), 9 dele
On (Thu) Jun 24 2010 [18:54:07], Michael S. Tsirkin wrote:
> We were requesting too much when checking buffer
> length: size already includes host header length.
>
> Further, we should not exit if we get a packet that
> is too long, since this might not be under control
> of the guest. Just drop t
virtqueue
operations.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index 7f9d28f..b89daa6 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw/virtio-serial-bus.c
@@ -139,6
In addition to the previous fix for calling do_flush_queued_data() only
when the virtqueue is ready, ensure do_flush_queued_data() gets a vq
that's suitably initialised.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --
On (Thu) Jul 01 2010 [14:58:16], Amit Shah wrote:
> If a virtio-serial port is removed before the guest comes up and
> initialises the virtqueues, qemu exits with the message
>
> Guest moved used index from 0 to 61440
>
> This happens because we try to clear any pendin
On (Wed) Jun 23 2010 [22:49:20], Amit Shah wrote:
> Starting with qemu -M pc-0.12 -device virtio-serial
>
> results in
>
> -device virtio-serial: Property 'virtio-serial-pci.max_nr_ports' not found
>
> The property name 'max_ports' is incorrectly named
On (Wed) Jun 23 2010 [20:14:04], Amit Shah wrote:
> qemu-config.c doesn't contain any target-specific code, and the
> TARGET_I386 conditional code didn't get compiled as a result. Removing
> this enables the driftfix parameter for rtc.
>
> Signed-off-by: Amit Shah
Ping
Amit
Currently virtio-serial supports a maximum of 31 ports. Specifying the
'max_ports' parameter to be > 31 on the cmd line causes badness.
Ensure we initialise virtio-serial only if max_ports is within the
supported range.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c | 10
hen an incoming
migration successfully completes.
Reported-by: Laine Stump
Signed-off-by: Amit Shah
---
migration.c |3 +++
monitor.c |4
sysemu.h|1 +
vl.c|3 +++
4 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/migration.c b/migration.c
index 650e
On (Fri) Jul 23 2010 [15:08:18], Luiz Capitulino wrote:
> > diff --git a/monitor.c b/monitor.c
> > index 45fd482..d12a7b5 100644
> > --- a/monitor.c
> > +++ b/monitor.c
> > @@ -1056,6 +1056,10 @@ static int do_cont(Monitor *mon, const QDict *qdict,
> > QObject **ret_data)
> > {
> > struct bd
hen an incoming
migration successfully completes.
A new qerror, QERR_MIGRATION_EXPECTED, is added to signal that 'cont'
failed due to no incoming migration has been attempted yet.
Reported-by: Laine Stump
Signed-off-by: Amit Shah
---
Luiz, does the QERR bit look OK?
migration.c |2 ++
On (Tue) Jul 27 2010 [10:55:03], Anthony Liguori wrote:
> +case QEMU_OPTION_libvirt_caps:
> +printf("version: " QEMU_VERSION "\n"
> + "package: " QEMU_PKGVERSION "\n"
> + "caps: name,enable-kvm,no-reboot,uuid,xen-domid,drive"
>
On (Mon) Aug 02 2010 [04:33:49], Alon Levy wrote:
> Hi,
>
> This patch adds three CHR_IOCTLs and uses them in virtserial devices, to be
> used
> by a chardev backend, such as a spice vm channel (spice is a vdi solution).
>
> Basically virtio-serial provides three driver initiated events for gu
On (Fri) Aug 06 2010 [12:12:45], Daniel P. Berrange wrote:
> On Wed, Jun 23, 2010 at 08:14:04PM +0530, Amit Shah wrote:
> > qemu-config.c doesn't contain any target-specific code, and the
> > TARGET_I386 conditional code didn't get compiled as a result. Removing
>
Free malloc'ed memory, unregister from savevm and clean up virtio-common
bits on device hot-unplug.
This was found performing a migration after device hot-unplug.
Reported-by:
Signed-off-by: Amit Shah
---
hw/virtio-pci.c| 10 +-
hw/virtio-serial-bus.c |
If the machine is stopped and 'info balloon' is invoked, the monitor
process just hangs waiting for info from the guest. Return the most
recent balloon data in that case.
See https://bugzilla.redhat.com/show_bug.cgi?id=623903
Reported-by:
Signed-off-by: Amit Shah
---
If the machine is stopped and 'info balloon' is invoked, the monitor
process just hangs waiting for info from the guest. Return the most
recent balloon data in that case.
See https://bugzilla.redhat.com/show_bug.cgi?id=623903
Reported-by:
Signed-off-by: Amit Shah
---
v2: simpli
On (Thu) Aug 19 2010 [06:51:04], Amit Shah wrote:
> Free malloc'ed memory, unregister from savevm and clean up virtio-common
> bits on device hot-unplug.
>
> This was found performing a migration after device hot-unplug.
>
> Reported-by:
> Signed-off-by: Amit Shah
On (Fri) Aug 20 2010 [06:18:11], Amit Shah wrote:
> If the machine is stopped and 'info balloon' is invoked, the monitor
> process just hangs waiting for info from the guest. Return the most
> recent balloon data in that case.
>
> See https://bugzilla.redhat.c
On (Sun) Aug 22 2010 [16:54:06], Anthony Liguori wrote:
> On 08/19/2010 07:48 PM, Amit Shah wrote:
> >If the machine is stopped and 'info balloon' is invoked, the monitor
> >process just hangs waiting for info from the guest. Return the most
> >recent balloon data
On (Sun) Aug 22 2010 [16:54:06], Anthony Liguori wrote:
> On 08/19/2010 07:48 PM, Amit Shah wrote:
> >If the machine is stopped and 'info balloon' is invoked, the monitor
> >process just hangs waiting for info from the guest. Return the most
> >recent balloon data
On (Thu) Aug 26 2010 [10:05:44], Paolo Bonzini wrote:
> On 08/26/2010 08:05 AM, Amit Shah wrote:
> >This is what I have currently. It would need some timer handling in
> >the save/load case as well, right?
>
> When loading you won't have any pending "info balloon&q
on't think we do
that for any other command. libvirt should be prepared to handle
this. If not, please suggest a better alternative.
Differences from v2:
- Add a timeout for uncooperative/hung guests
- Add an qerror message for letting users/management know of guest
stopped status.
Amit Shah
See https://bugzilla.redhat.com/show_bug.cgi?id=623903
Reported-by:
Signed-off-by: Amit Shah
---
hw/virtio-balloon.c | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c
index 9fe3886..d6c66cf 100644
--- a/hw/virtio-balloon.c
+++ b
This error message denotes some command was not successful in completing
as the guest was unresponsive.
Use it in the virtio-balloon code when showing older, cached data.
Signed-off-by: Amit Shah
---
hw/virtio-balloon.c |1 +
qerror.c|4
qerror.h|3
If the machine is stopped and 'info balloon' is invoked, instead of
querying the guest and waiting for a timeout, just display the most
recent stats available in this case and log an error report.
See https://bugzilla.redhat.com/show_bug.cgi?id=623903
Reported-by:
Signed-off-by:
On (Fri) Aug 27 2010 [07:39:37], Anthony Liguori wrote:
> >
> >NACK. It has always been allowed& valid to call query-balloon
> >to get the current balloon level. We must not throw an error
> >just because the recently added mem stats can't be refreshed.
>
> I think that's a fair comment but why e
On (Thu) Jan 21 2010 [10:53:36], Markus Armbruster wrote:
> Amit, what about renaming hw/virtio-serial.c to a less misleading name
> now?
I'm going to push that upstream; Anthony in the past indicated he was ok
with it.
Amit
This file was renamed to ease the reviews of the recent changes
that went in.
Now that the changes are done, rename the file back to its original
name.
Signed-off-by: Amit Shah
---
Makefile.objs|2 +-
hw/{virtio-serial.c => virtio-console.c} |0
2 fi
These hunks got dropped off mysteriously during the rebasing of my
virtio-serial series. Thanks go to Markus for noticing it.
Without these fixes, -virtioconsole doesn't actually have any effect.
Signed-off-by: Amit Shah
Reported-by: Markus Armbruster
---
roms/seabios |2 +-
On (Wed) Jan 13 2010 [12:32:54], Amit Shah wrote:
> >
> > I'd be very interested in the results of Sparc32 and Sparc64 analyses.
>
> OK, I added the two targets to the run and got the following result:
>
> http://amitshah.fedorapeople.org/clang-output/2010-01-13-
This commit enables one to use multiple virtio-serial devices and to
assign ports to arbitrary devices like this:
-device virtio-serial,id=foo -device virtio-serial,id=bar \
-device virtserialport,bus=foo.0,name=foo \
-device virtserialport,bus=bar.0,name=bar
Signed-off-by: Amit Shah
We have some duplicated code in the CONFIG_IOTHREAD #ifdef and #else
cases. Fix that.
Signed-off-by: Amit Shah
---
kvm-all.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index 15ec38e..a2bd78e 100644
--- a/kvm-all.c
+++ b/kvm-all.c
Just a 1-1 conversion for now.
Signed-off-by: Amit Shah
---
vnc.c | 73 -
vnc.h |5 ++-
2 files changed, 30 insertions(+), 48 deletions(-)
diff --git a/vnc.c b/vnc.c
index 92facde..16fc4e9 100644
--- a/vnc.c
+++ b/vnc.c
Just a 1-1 conversion for now.
Signed-off-by: Amit Shah
---
v2:
- QTAILQ_INIT the queue.
vnc.c | 74
vnc.h |5 ++-
2 files changed, 31 insertions(+), 48 deletions(-)
diff --git a/vnc.c b/vnc.c
index 92facde..2200fbf
Hello,
In my testing of virtio-console, I found qemu-kvm.git introduces a lot
of overhead in thread scheduling compared to qemu.git.
My test sends a 260M file from the host to a guest via a virtio-console
port and then computes the sha1sum of the file on the host as well as on
the guest, compares
On (Mon) Feb 08 2010 [08:57:05], Anthony Liguori wrote:
> On 02/08/2010 07:46 AM, Amit Shah wrote:
>> Hello,
>>
>> In my testing of virtio-console, I found qemu-kvm.git introduces a lot
>> of overhead in thread scheduling compared to qemu.git.
>>
>> My te
Michael noted we don't allow disabling of MSI for the virtio-serial-pci
device. Fix that.
Signed-off-by: Amit Shah
CC: "Michael S. Tsirkin"
---
hw/virtio-pci.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
index f
On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote:
> Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all
> serial devices declare MULTIPORT feature.
> To allow 0.12 compatibility, we should clear this when
> max_nr_ports is 1.
In addition to this, setting max_nr_ports to 1 is needed
On (Mon) Feb 15 2010 [10:03:34], Gerd Hoffmann wrote:
> On 02/12/10 15:23, Amit Shah wrote:
>> On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote:
>>> Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all
>>> serial devices declare MULTIPORT feature.
>>
On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote:
> Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all
> serial devices declare MULTIPORT feature.
> To allow 0.12 compatibility, we should clear this when
> max_nr_ports is 1.
>
> Signed-off-by: Michael S. Tsirki
The version 0.13 will be the new default and compatibility options will
be added to the 0.12 version.
Signed-off-by: Amit Shah
---
hw/pc.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index 6fbe98b..7c9a24e 100644
--- a/hw/pc.c
+++ b/hw/pc.c
virtio-serial-pci can support multiple ports in the current development
version that will become 0.13. Add compatibility options for the 0.12
and 0.11 pc machine types.
Signed-off-by: Amit Shah
---
hw/pc.c | 29 +
1 files changed, 29 insertions(+), 0 deletions
From: Michael S. Tsirkin
Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all
serial devices declare MULTIPORT feature.
To allow 0.12 compatibility, we should clear this when
max_nr_ports is 1.
Signed-off-by: Michael S. Tsirkin
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c |6
On (Mon) Feb 15 2010 [15:36:34], Gerd Hoffmann wrote:
>> @@ -1143,6 +1171,7 @@ static QEMUMachine isapc_machine = {
>> static void pc_machine_init(void)
>> {
>> qemu_register_machine(&pc_machine);
>> +qemu_register_machine(&pc_machine_v0_12);
>> qemu_register_machine(&pc_machine
On (Mon) Feb 15 2010 [16:07:28], Michael S. Tsirkin wrote:
> On Mon, Feb 15, 2010 at 06:51:31PM +0530, Amit Shah wrote:
> > On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote:
> > > Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all
> > > serial device
virtio-serial-pci can support multiple ports in the current development
version that will become 0.13. Add compatibility options for the 0.12
and 0.11 pc machine types.
Signed-off-by: Amit Shah
---
hw/pc.c | 28
1 files changed, 28 insertions(+), 0 deletions
From: Michael S. Tsirkin
Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all
serial devices declare MULTIPORT feature.
To allow 0.12 compatibility, we should clear this when
max_nr_ports is 1.
Signed-off-by: Michael S. Tsirkin
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c |6
The version 0.13 will be the new default and compatibility options will
be added to the 0.12 version.
Signed-off-by: Amit Shah
---
v2: register the 0.12 version in this patch instead of the next one.
hw/pc.c | 10 +-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/hw
net.c used a constant to signify no MSI vectors were specified. Extend
that to all qdev devices.
Signed-off-by: Amit Shah
Reported-by: "Michael S. Tsirkin"
---
hw/qdev.c |2 +-
hw/qdev.h |4
net.c |6 --
net.h |3 ---
4 files changed, 9 insert
Use the named constant instead of -1.
Signed-off-by: Amit Shah
Reported-by: "Michael S. Tsirkin"
---
hw/virtio-pci.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
index bcd40f7..799f664 100644
--- a/hw/virtio-pci.
Hello,
This series fixes a compile error and adds 0.12 and 0.13 machine
types, disabling newer virtio-serial features for 0.12.
Note: The name for the machine type changes from s390-virtio to
s390-virtio-vXX, this may not be compatible for 0.12.
Amit Shah (3):
s390-virtio: Fix compile error
Add a 0.12 s390-virtio machine type for compatibility with older
versions.
Signed-off-by: Amit Shah
---
hw/s390-virtio.c | 14 +-
1 files changed, 13 insertions(+), 1 deletions(-)
diff --git a/hw/s390-virtio.c b/hw/s390-virtio.c
index 3582728..a3cbfb6 100644
--- a/hw/s390
Disable the MULTIPORT feature and MSI vectors for the 0.12 machine
types; those features are added only for 0.13 onwards.
Signed-off-by: Amit Shah
---
hw/s390-virtio.c | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/hw/s390-virtio.c b/hw/s390-virtio.c
index
Commit 428c149b0be790b440e1cbee185b152cdb22feec modified the argument
that virtio_blk_init takes. Update the s390 bus code that calls this
function.
Signed-off-by: Amit Shah
CC: Christoph Hellwig
---
hw/s390-virtio-bus.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a
Add a 0.12 machine type for compatibility with older versions. Mark the
default one as 0.13.
Signed-off-by: Amit Shah
---
hw/ppc440_bamboo.c | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/hw/ppc440_bamboo.c b/hw/ppc440_bamboo.c
index 1ab9872..aa9f594 100644
Disable the MULTIPORT feature and MSI vectors for the 0.12 machine
types; those features are added only for 0.13 onwards.
Signed-off-by: Amit Shah
---
hw/ppc440_bamboo.c | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/hw/ppc440_bamboo.c b/hw/ppc440_bamboo.c
Commit b5ec5ce0 broke 'make install' from non source-dir build. Fix.
Signed-off-by: Amit Shah
---
Makefile |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 296f500..14c1930 100644
--- a/Makefile
+++ b/Makefile
@@ -207,7 +207,
On (Wed) Mar 03 2010 [19:16:13], Michael S. Tsirkin wrote:
> vhost net backend needs to be notified when
> frontend status changes. Add a callback,
> similar to set_features.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> hw/s390-virtio-bus.c |2 +-
> hw/syborg_virtio.c |2 +-
> hw/virt
On (Wed) Mar 03 2010 [19:16:28], Michael S. Tsirkin wrote:
> make it possible to use type without header include
Why?
> Signed-off-by: Michael S. Tsirkin
> ---
> hw/virtio.h |1 -
> qemu-common.h |1 +
> 2 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/virtio.h b/
1401 - 1500 of 1982 matches
Mail list logo
