Data should be written only when ports are open.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index 3a09f0d..6befd4d 100644
--- a/hw/virtio
If adding of ports or devices in the guest fails we can send out a QMP
event so that management software can deal with it.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial
to hold sizes, the new function is going to use
size_t types.
Later commits will add the opposite functionality -- going from an iov
to a linear buffer.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
Makefile |2 ++
Makefile.objs |1 +
hw/iov.c
iov_to_buf() puts the buffer contents in the iov in a linearized buffer.
iov_size() gets the length of the contents in the iov.
The iov_to_buf() function is the memcpy_to_iovec() function that was
used in virtio-ballon.c.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/iov.c
expect
otherwise we risk accessing memory that we don't own.
Signed-off-by: Amit Shah amit.s...@redhat.com
CC: Avi Kivity a...@redhat.com
Reported-by: Avi Kivity a...@redhat.com
---
hw/virtio-serial-bus.c | 31 ---
1 files changed, 28 insertions(+), 3 deletions
We cannot indicate to the guest how much data was consumed by an app for
out_bufs. So we just have to assume the apps will consume all the data
that are handed over to them.
Fix the virtio api abuse in control_out() and handle_output().
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw
data.
This commit really doesn't change anything from the current behaviour,
just makes the code slightly better by spinning off data handling to
ports in another function.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c | 69
From: Marcelo Tosatti mtosa...@redhat.com
Wake up iothread when buffers are consumed.
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/virtio
buffers in the vq).
The guest kernel can reclaim the buffers when it receives the port close
event or when a port is being removed. Ensure we free up the buffers
before we send out any events to the guest.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c | 50
On (Tue) Apr 27 2010 [12:37:00], Anthony Liguori wrote:
On 04/27/2010 07:33 AM, Amit Shah wrote:
Allow the port 'id's to be set by a user on the command line. This is
needed by management apps that will want a stable port numbering scheme
for hot-plug/unplug and migration.
Since the port
On (Tue) Apr 27 2010 [12:41:27], Anthony Liguori wrote:
On 04/27/2010 07:34 AM, Amit Shah wrote:
From: Marcelo Tosattimtosa...@redhat.com
Wake up iothread when buffers are consumed.
Signed-off-by: Marcelo Tosattimtosa...@redhat.com
Signed-off-by: Amit Shahamit.s...@redhat.com
What's
On (Wed) Apr 28 2010 [08:25:59], Anthony Liguori wrote:
On 04/28/2010 02:29 AM, Amit Shah wrote:
On (Tue) Apr 27 2010 [12:41:27], Anthony Liguori wrote:
On 04/27/2010 07:34 AM, Amit Shah wrote:
From: Marcelo Tosattimtosa...@redhat.com
Wake up iothread when buffers are consumed
On (Thu) Apr 29 2010 [16:12:38], Kusanagi Kouichi wrote:
On 2010-04-16 18:32:19 +0530, Amit Shah wrote:
On (Fri) Apr 16 2010 [20:42:47], Kusanagi Kouichi wrote:
Signed-off-by: Kusanagi Kouichi sl...@ac.auone-net.jp
---
hw/virtio-console.c|3 +++
hw/virtio-serial-bus.c
On (Thu) Apr 29 2010 [21:36:30], Kusanagi Kouichi wrote:
Please include me in the CC when you send it. Also please mention how
you test this feature.
Amit
I put printf()s into involved functions. Then ran qemu on a terminal
emulator, and resized it.
That's how I did. Is
On (Fri) Apr 30 2010 [17:12:19], Kusanagi Kouichi wrote:
I tested this patch as follows:
I put printf()s into involved functions. Then ran qemu on a terminal
emulator, and resized it.
The guest kernel gets initial size. However, it doesn't update the size.
It seems to need to enable multiport
In the flush_queued_data() function, we expect port to be valid. Assert
only for port and not port || discard.
Reported-by: Juan Quintela quint...@redhat.com
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
From: Kusanagi Kouichi sl...@ac.auone-net.jp
Signed-off-by: Kusanagi Kouichi sl...@ac.auone-net.jp
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-char.c | 34 ++
qemu-char.h |3 +++
2 files changed, 37 insertions(+), 0 deletions(-)
diff --git a/qemu
Kouichi sl...@ac.auone-net.jp
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-console.c|3 +++
hw/virtio-serial-bus.c | 15 +++
hw/virtio-serial.h | 11 +--
3 files changed, 27 insertions(+), 2 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio
On (Mon) May 03 2010 [13:58:13], Kusanagi Kouichi wrote:
I tested this patch as follows:
I put printf()s into involved functions. Then ran qemu on a terminal
emulator, and resized it.
The guest kernel gets initial size, and follows host resize. Both
singleport and multiport work.
v3:
If
On (Mon) May 03 2010 [12:06:33], Amit Shah wrote:
From: Kusanagi Kouichi sl...@ac.auone-net.jp
I tested this patch as follows: I put printf()s into involved
functions. Then ran qemu on a terminal emulator, and resized it. The
guest kernel gets initial size, and follows host resize. Both
On (Mon) May 03 2010 [12:17:28], Christoph Hellwig wrote:
Any reasons these files are under hw? They're completely generic
routines that might come in handy for block work, too.
No particular reason. They can be moved around.
Amit
On writing errors, we just returned -1 even if some bytes were already
written out. Ensure we return the number of bytes written before we
return the error (on a subsequent call to qemu_chr_write()).
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-char.c |9 +++--
1 files changed
.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-char.c | 50 ++
1 files changed, 50 insertions(+), 0 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 1cae1d2..476bb4e 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2117,11 +2117,60
The initialisation for generic ports and console ports is similar.
Factor out the parts that are the same in a different function that can
be called from each of the initfns.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-console.c | 31 ++-
1 files
.
No backend currently supports non-blocking writes.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
gdbstub.c|2 +-
hw/debugcon.c|2 +-
hw/escc.c|3 ++-
hw/etraxfs_ser.c |4 ++--
hw/mcf_uart.c|2 +-
hw/pl011.c |2
migration.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-console.c | 127 +--
1 files changed, 123 insertions(+), 4 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index 1552f47..035ef94 100644
--- a/hw/virtio-console.c
or if no
callback was supplied.
Support for other backend types is easy to add and will be done in
later patches.
Amit Shah (5):
char: Let writers know how much data was written in case of errors
char: Add qemu_chr_write_nb() for nonblocking writes
char: unix/tcp: Add a non-blocking write handler
The initialisation for generic ports and console ports is similar.
Factor out the parts that are the same in a different function that can
be called from each of the initfns.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-console.c | 31 ++-
1 files
by Juan's comment)
- Re-arranged patches
Amit Shah (6):
virtio-console: Factor out common init between console and generic
ports
char: Add a QemuChrHandlers struct to initialise chardev handlers
char: Let writers know how much data was written in case of errors
char: Add
On writing errors, we just returned -1 even if some bytes were already
written out. Ensure we return the number of bytes written before we
return the error (on a subsequent call to qemu_chr_write()).
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-char.c |9 -
1 files changed
to add a callback handler,
call qemu_chr_write_nb() instead of qemu_chr_write() if they wish to
receive -EAGAIN notifications.
No backend currently supports non-blocking writes.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
net/socket.c |4 ++--
qemu-char.c | 31
Instead of passing each handler in the qemu_add_handlers() function,
create a struct of handlers that can be passed to the function instead.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
gdbstub.c|9 +++--
hw/debugcon.c|2 +-
hw/escc.c|9
migration.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-console.c | 126 +-
1 files changed, 123 insertions(+), 3 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index 749ed59..7eb6aa1 100644
--- a/hw/virtio-console.c
The iov functions can be useful to other code as well.
Signed-off-by: Amit Shah amit.s...@redhat.com
CC: Christoph Hellwig h...@lst.de
---
hw/iov.c = iov.c |0
hw/iov.h = iov.h |0
2 files changed, 0 insertions(+), 0 deletions(-)
rename hw/iov.c = iov.c (100%)
rename hw/iov.h = iov.h
On (Tue) May 04 2010 [13:24:58], Gerd Hoffmann wrote:
@@ -531,8 +534,12 @@ static int unix_write(int fd, const uint8_t *buf, int
len1)
while (len 0) {
ret = write(fd, buf, len);
if (ret 0) {
-if (errno != EINTR errno != EAGAIN)
+if (len1
On (Tue) May 04 2010 [09:43:04], Gerd Hoffmann wrote:
On 05/04/10 09:17, Amit Shah wrote:
Add a non-blocking write handler that can return with -EAGAIN to the
caller and also callback when the socket becomes writable.
Non-blocking writes are only enabled for sockets that are opened in
non
for passing on handlers to
qemu_chr_add_handlers() instead of passing each one
individually. Simplifies patches. (Inspired by Juan's comment)
- Re-arranged patches
Amit Shah (6):
virtio-console: Factor out common init between console and generic
ports
char: Add a QemuChrHandlers struct
The initialisation for generic ports and console ports is similar.
Factor out the parts that are the same in a different function that can
be called from each of the initfns.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-console.c | 31 ++-
1 files
Instead of passing each handler in the qemu_add_handlers() function,
create a struct of handlers that can be passed to the function instead.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
gdbstub.c|9 +++--
hw/debugcon.c|2 +-
hw/escc.c|9
On writing errors, we just returned -1 even if some bytes were already
written out. Ensure we return the number of bytes written before we
return the error (on a subsequent call to qemu_chr_write()).
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-char.c | 12 +++-
1 files
to add a callback handler,
call qemu_chr_write_nb() instead of qemu_chr_write() if they wish to
receive -EAGAIN notifications.
No backend currently supports non-blocking writes.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
net/socket.c |4 ++--
qemu-char.c | 31
.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-char.c | 50 ++
1 files changed, 50 insertions(+), 0 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index e6934f6..da70b9b 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2129,11 +2129,60
migration.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-console.c | 126 +-
1 files changed, 123 insertions(+), 3 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index 749ed59..7eb6aa1 100644
--- a/hw/virtio-console.c
On (Tue) May 04 2010 [21:54:09], Juan Quintela wrote:
static void tcp_chr_connect(void *opaque)
{
CharDriverState *chr = opaque;
TCPCharDriver *s = chr-opaque;
+IOHandler *write_cb;
+int flags;
+bool nonblock;
+
+flags = fcntl(s-fd, F_GETFL);
+if
to
qemu_chr_add_handlers() instead of passing each one
individually. Simplifies patches. (Inspired by Juan's comment)
- Re-arranged patches
Amit Shah (6):
virtio-console: Factor out common init between console and generic
ports
char: Add a QemuChrHandlers struct to initialise chardev handlers
char: Let
The initialisation for generic ports and console ports is similar.
Factor out the parts that are the same in a different function that can
be called from each of the initfns.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-console.c | 31 ++-
1 files
Instead of passing each handler in the qemu_add_handlers() function,
create a struct of handlers that can be passed to the function instead.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
gdbstub.c|9 +++--
hw/debugcon.c|2 +-
hw/escc.c|9
On writing errors, we just returned -1 even if some bytes were already
written out. Ensure we return the number of bytes written before we
return the error (on a subsequent call to qemu_chr_write()).
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-char.c | 12 +++-
1 files
to add a callback handler,
call qemu_chr_write_nb() instead of qemu_chr_write() if they wish to
receive -EAGAIN notifications.
No backend currently supports non-blocking writes.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
net/socket.c |4 ++--
qemu-char.c | 31
.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-char.c | 47 +++
1 files changed, 47 insertions(+), 0 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 5e4dec3..9aa3401 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2129,11 +2129,57
migration.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-console.c | 120 +-
1 files changed, 117 insertions(+), 3 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index 862a431..b0b4351 100644
--- a/hw/virtio-console.c
[Fix subject]
Amit
On (Wed) May 05 2010 [08:16:37], Anthony Liguori wrote:
On 05/04/2010 04:39 PM, Amit Shah wrote:
For char devices whose backing files are open in non-blocking mode,
non-blocking writes can now be made using qemu_chr_write_nb().
For non-blocking chardevs, we can return -EAGAIN to callers
On (Wed) May 05 2010 [08:15:19], Anthony Liguori wrote:
On 05/04/2010 04:39 PM, Amit Shah wrote:
On writing errors, we just returned -1 even if some bytes were already
written out. Ensure we return the number of bytes written before we
return the error (on a subsequent call to qemu_chr_write
On (Wed) May 05 2010 [08:13:58], Anthony Liguori wrote:
On 05/04/2010 04:39 PM, Amit Shah wrote:
Instead of passing each handler in the qemu_add_handlers() function,
create a struct of handlers that can be passed to the function instead.
Signed-off-by: Amit Shahamit.s...@redhat.com
On (Wed) May 05 2010 [08:54:48], Anthony Liguori wrote:
On 05/05/2010 08:23 AM, Amit Shah wrote:
On (Wed) May 05 2010 [08:15:19], Anthony Liguori wrote:
On 05/04/2010 04:39 PM, Amit Shah wrote:
On writing errors, we just returned -1 even if some bytes were already
written out
,
the config changes are deprecated and the VIRTIO_CONSOLE_RESIZE control
message is used instead.
[Amit: Add per-port row,col notification to the guest via control
message, split off virtio-console.c patch]
Signed-off-by: Kusanagi Kouichi sl...@ac.auone-net.jp
Signed-off-by: Amit Shah amit.s
From: Kusanagi Kouichi sl...@ac.auone-net.jp
When we receive a CHR_EVENT_RESIZE notification, let the guest know of
the console size update.
Signed-off-by: Kusanagi Kouichi sl...@ac.auone-net.jp
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-console.c |3 +++
1 files changed, 3
From: Kusanagi Kouichi sl...@ac.auone-net.jp
Signed-off-by: Kusanagi Kouichi sl...@ac.auone-net.jp
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-char.c | 34 ++
qemu-char.h |3 +++
2 files changed, 37 insertions(+), 0 deletions(-)
diff --git a/qemu
On (Wed) May 12 2010 [17:50:02], Alon Levy wrote:
Fix for too small allocation to ports_map
Signed-off-by: Alon Levy al...@redhat.com
ACK
Amit
From: Alon Levy al...@redhat.com
Fix for too small allocation to ports_map
Signed-off-by: Alon Levy al...@redhat.com
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-console.c | 17 ++---
hw/virtio-serial.h | 12
2 files changed, 22 insertions(+), 7 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index ccd277a..8a99a99 100644
--- a/hw/virtio
Add a 'description' along with each qdev property to document the input
each qdev property takes.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
block_int.h | 10 +++---
hw/a9mpcore.c |2 +-
hw/acpi_piix4.c |2 +-
hw/arm11mpcore.c |4 +-
hw
Signed-off-by: Amit Shah amit.s...@redhat.com
---
net.h | 13 ++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/net.h b/net.h
index 0e9cc5d..8ad439a 100644
--- a/net.h
+++ b/net.h
@@ -20,10 +20,17 @@ typedef struct NICConf {
VLANClientState *peer;
} NICConf
On (Fri) May 28 2010 [14:49:39], Markus Armbruster wrote:
Amit Shah amit.s...@redhat.com writes:
Add a 'description' along with each qdev property to document the input
each qdev property takes.
Signed-off-by: Amit Shah amit.s...@redhat.com
I always wanted this, and never got around
On (Fri) May 28 2010 [14:50:17], Markus Armbruster wrote:
Amit Shah amit.s...@redhat.com writes:
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-console.c | 17 ++---
hw/virtio-serial.h | 12
2 files changed, 22 insertions(+), 7 deletions
target.
Changes from previous send:
- Removed the 'RFC' tag
- Not using macros in net.h (Markus)
It'll be helpful to have people submit some short descriptive text for
the subsystems they care about.
Amit Shah (5):
qdev: Add a description field for qdev properties for documentation
virtio-serial
Add a 'description' along with each qdev property to document the input
each qdev property takes.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
block_int.h | 10 +++---
hw/a9mpcore.c |2 +-
hw/acpi_piix4.c |2 +-
hw/arm11mpcore.c |4 +-
hw
.
virtserialport.chardev=chr, The chardev to associate this port with.
virtserialport.name=string, Name for the port that's exposed to \
the guest for port discovery.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-console.c | 17 ++---
hw/virtio-serial.h | 13
with the device as part of a complete coverage for all
devices and options associated with each of them.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/qdev.c | 41 -
1 files changed, 24 insertions(+), 17 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
The new '-device help' option shows all the devices that are registered
with qdev and prints out all the properties each device has, along with
the description for each property.
This is useful in creating automatic documentation for all the options
that we have and support.
Signed-off-by: Amit
with this
virtual NIC.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
net.h |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/net.h b/net.h
index 0e9cc5d..9ffd4d0 100644
--- a/net.h
+++ b/net.h
@@ -21,9 +21,12 @@ typedef struct NICConf {
} NICConf;
#define
, 3 insertions(+), 9 deletions(-)
Thanks,
Acked-by: Amit Shah amit.s...@redhat.com
Amit
On (Mon) Jun 07 2010 [16:43:05], Markus Armbruster wrote:
There is -device \? and -device help, but the user interface
provides no clue about the difference between them.
-device help loses when we ever pick up a device model with name
help. Not that ? was a particularly smart choice...
On (Mon) Jun 07 2010 [11:09:32], Anthony Liguori wrote:
On 05/31/2010 07:41 AM, Amit Shah wrote:
Hello,
This patch series adds support to specify some descriptive help text
to qdev device parameters. This series adds some help text to the
virtserialport and net family of devices
The correct model type wasn't getting added when hotplugging nics with
pci_add.
Testcase: start VM with default nic type. In the qemu_monitor:
(qemu) pci_add auto nic model=virtio
This results in a nic hot-plug of the same nic type as the default.
Signed-off-by: Amit Shah amit.s...@redhat.com
in 5294e2c774f120e10b44652ac143abda356f44eb
Also changes the behaviour where no .init is defined for a
net_client_type. Previously, 0 was returned, which indicated the init
was successful and that 0 was the index into the nd_tables[] array.
Return -1, indicating unsuccessful init, in such a case.
Signed-off-by: Amit Shah
On (Tue) Jun 08 2010 [17:31:04], Gerd Hoffmann wrote:
On 06/08/10 17:17, Amit Shah wrote:
The correct model type wasn't getting added when hotplugging nics with
pci_add.
Testcase: start VM with default nic type. In the qemu_monitor:
(qemu) pci_add auto nic model=virtio
This results
On (Tue) Jun 08 2010 [18:33:00], Markus Armbruster wrote:
Amit Shah amit.s...@redhat.com writes:
The correct model type wasn't getting added when hotplugging nics with
pci_add.
Testcase: start VM with default nic type. In the qemu_monitor:
(qemu) pci_add auto nic model=virtio
On (Wed) Jun 09 2010 [09:59:50], Juan Quintela wrote:
BTW, once here, didn't default nic should be e1000? not rtl8139?
Are you looking at qemu-kvm sources? ;-)
Amit
to an entry in nd_table[]. With the current code, callers can
erroneously poke into nd_table[0] when -net nic is used, which can lead
to badness.
However, this commit just returns to the previous behaviour before the
offending commit.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
net.c |2 +-
1
On (Wed) Jun 09 2010 [15:28:11], Amit Shah wrote:
Let me rephrase: Behavior changes for -net types without an init()
method. The only one without an init() method is none. Before,
net_client_init() succeeded for it. Now it fails. What's the impact of
that change? And why does it make
On (Thu) Jun 17 2010 [09:15:02], Alex Williamson wrote:
The comment suggests we're checking for the driver in the ready
state and bus master disabled, but the code is checking that it's
not in the ready state.
Signed-off-by: Alex Williamson alex.william...@redhat.com
Found-by: Amit Shah
from commit 2dedf83ef0cc3463783d6b71bf1b25476f691f3a)
Signed-off-by: Amit Shah amit.s...@redhat.com
---
block/vvfat.c |9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index c1acb35..592d6e6 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
vl.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index 920717a..f9c8086 100644
--- a/vl.c
+++ b/vl.c
@@ -418,6 +418,7 @@ static void configure_rtc(QemuOpts *opts)
exit(1
qemu-config.c doesn't contain any target-specific code, and the
TARGET_I386 conditional code didn't get compiled as a result. Removing
this enables the driftfix parameter for rtc.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-config.c |2 --
1 files changed, 0 insertions(+), 2
On (Wed) Jun 23 2010 [16:35:26], Paolo Bonzini wrote:
On 06/23/2010 04:29 PM, Amit Shah wrote:
The driftfix option is only useful for Windows guests, and for the x86
architecture, so limit the option parsing to TARGET_I386. This ifdef
conditional is moved from qemu-config.c to vl.c. The next
qemu-config.c doesn't contain any target-specific code, and the
TARGET_I386 conditional code didn't get compiled as a result. Removing
this enables the driftfix parameter for rtc.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-config.c |2 --
1 files changed, 0 insertions(+), 2
-by: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/pc_piix.c |6 +++---
hw/ppc440_bamboo.c |2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/pc_piix.c b/hw/pc_piix.c
index 68040b7..84e6c7f 100644
--- a/hw/pc_piix.c
+++ b
On (Wed) Jun 23 2010 [12:51:18], Michael S. Tsirkin wrote:
We were requesting too much when checking buffer
length: size already includes host header length.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
hw/virtio-net.c | 20 +++-
1 files changed, 11
On (Thu) Jun 24 2010 [18:54:07], Michael S. Tsirkin wrote:
We were requesting too much when checking buffer
length: size already includes host header length.
Further, we should not exit if we get a packet that
is too long, since this might not be under control
of the guest. Just drop the
virtqueue
operations.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index 7f9d28f..b89daa6 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw/virtio-serial
In addition to the previous fix for calling do_flush_queued_data() only
when the virtqueue is ready, ensure do_flush_queued_data() gets a vq
that's suitably initialised.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c |1 +
1 files changed, 1 insertions(+), 0
On (Thu) Jul 01 2010 [14:58:16], Amit Shah wrote:
If a virtio-serial port is removed before the guest comes up and
initialises the virtqueues, qemu exits with the message
Guest moved used index from 0 to 61440
This happens because we try to clear any pending buffers from the
virtqueue
On (Wed) Jun 23 2010 [22:49:20], Amit Shah wrote:
Starting with qemu -M pc-0.12 -device virtio-serial
results in
-device virtio-serial: Property 'virtio-serial-pci.max_nr_ports' not found
The property name 'max_ports' is incorrectly named 'max_nr_ports'. Fix
that.
Also fix the ppc440
On (Wed) Jun 23 2010 [20:14:04], Amit Shah wrote:
qemu-config.c doesn't contain any target-specific code, and the
TARGET_I386 conditional code didn't get compiled as a result. Removing
this enables the driftfix parameter for rtc.
Signed-off-by: Amit Shah amit.s...@redhat.com
Ping
Currently virtio-serial supports a maximum of 31 ports. Specifying the
'max_ports' parameter to be 31 on the cmd line causes badness.
Ensure we initialise virtio-serial only if max_ports is within the
supported range.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c
successfully completes.
Reported-by: Laine Stump la...@redhat.com
Signed-off-by: Amit Shah amit.s...@redhat.com
---
migration.c |3 +++
monitor.c |4
sysemu.h|1 +
vl.c|3 +++
4 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/migration.c b/migration.c
On (Fri) Jul 23 2010 [15:08:18], Luiz Capitulino wrote:
diff --git a/monitor.c b/monitor.c
index 45fd482..d12a7b5 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1056,6 +1056,10 @@ static int do_cont(Monitor *mon, const QDict *qdict,
QObject **ret_data)
{
struct
.
The major change from the last time this patch series was sent is that
each port now has its own IO vqs instead of a common pair for all the
ports.
Please review,
Amit.
Amit Shah (3):
virtio: Remove duplicate macro definition for max. virtqueues, bump
up the max
virtio
201 - 300 of 1939 matches
Mail list logo
