with
VIRTIO_CONFIG_S_DRIVER_OK by even older non multiport drivers.
[Amit: Add comment, tweak summary]
Signed-off-by: Alon Levy
Acked-by: Michael S. Tsirkin
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c | 29 +
1 files changed, 21 insertions(+), 8 deletions(-)
diff --
Hi,
Please pull for a virtio-serial fix.
The following changes since commit 3c30dd5a68e9fee6af67cfd0d14ed7520820f36a:
target-arm: Move reset handling to arm_cpu_reset (2012-04-21 18:13:22 +)
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/qemu/amit/virtio-seria
On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote:
> On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote:
> > From: Alon Levy
> >
> > guest_connected should be false before guest driver initialization, and
> > true after, both for multiport aware and
On (Tue) 24 Apr 2012 [13:49:53], Michael S. Tsirkin wrote:
> On Tue, Apr 24, 2012 at 03:56:44PM +0530, Amit Shah wrote:
> > On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote:
> > > On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote:
>
On (Tue) 24 Apr 2012 [14:21:36], Michael S. Tsirkin wrote:
> On Tue, Apr 24, 2012 at 04:44:10PM +0530, Amit Shah wrote:
> > On (Tue) 24 Apr 2012 [13:49:53], Michael S. Tsirkin wrote:
> > > On Tue, Apr 24, 2012 at 03:56:44PM +0530, Amit Shah wrote:
> > > > On (Tue) 24
When a guest driver resets the virtio status to not ready, or when qemu
is reset, reset the guest_connected bit and let ports know if they have
the guest_close() callback registered.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c | 28
1 files changed, 28
When a guest driver resets the virtio status to not ready, or when qemu
is reset, reset all ports' guest_connected bit and let port users know
of this event if they have the guest_close() callback registered.
Reviewed-by: Alon Levy
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c |
: fix guest_connected init before driver init
Amit Shah (1):
virtio-serial-bus: Unset guest_connected at reset and driver reset
hw/virtio-serial-bus.c | 57 +--
1 files changed, 49 insertions(+), 8 deletions(-)
--
1.7.7.6
with
VIRTIO_CONFIG_S_DRIVER_OK by even older non multiport drivers.
[Amit: Add comment, tweak summary, only set guest_connected and not
reset it as a side-effect.]
Signed-off-by: Alon Levy
Acked-by: Michael S. Tsirkin
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c |
On (Tue) 28 Feb 2012 [15:31:07], Orit Wasserman wrote:
> Otherwise we crash on error.
A description on how to reproduce the crash would be nice.
> Signed-off-by: Orit Wasserman
> Signed-off-by: Ulrich Obergfell
Acked-by: Amit Shah
Amit
e_name,scsi=off ... -incoming ...
> 3) migrate from 1 to 2.
Thanks.
Acked-by: Amit Shah
Amit
On (Sun) 11 Mar 2012 [17:52:59], Michael Tokarev wrote:
> In case of more than one control message, the code will use
> size of the largest message so far for all subsequent messages,
> instead of using size of current one. Fix it.
Makes sense. How did you detect this? Any reproducible test-cas
On (Mon) 12 Mar 2012 [13:22:22], Michael Tokarev wrote:
> On 12.03.2012 12:59, Amit Shah wrote:
> > On (Sun) 11 Mar 2012 [17:52:59], Michael Tokarev wrote:
> >> In case of more than one control message, the code will use
> >> size of the largest message so far
On (Mon) 20 Jun 2011 [18:24:38], Joel Uckelman wrote:
> I'm trying to set up a unix domain socket with a guest on one end and
> the host on the other, where the server is running on and bound to the
> socket on the guest. I've been able to get the reverse, where the
> server is running on the host,
On (Fri) 17 Jun 2011 [15:58:08], Luiz Capitulino wrote:
> If I start qemu with:
>
> # qemu -hda disks/test.img -enable-kvm -m 1G -snapshot \
> -device virtio-serial \
> -chardev socket,host=localhost,port=1234,server,nowait,id=foo \
> -device virtserialport,chardev=foo
On (Sun) 19 Jun 2011 [00:43:20], Blue Swirl wrote:
> On Sat, Jun 18, 2011 at 6:42 AM, Amit Shah wrote:
> > On (Fri) 17 Jun 2011 [15:08:11], Luiz Capitulino wrote:
> >
> >> > > if (!cpkt.value) {
> >> > > - error_repor
On (Thu) 23 Jun 2011 [17:37:50], Joel Uckelman wrote:
> On Tue, Jun 21, 2011 at 10:47 AM, Amit Shah wrote:
> > On (Mon) 20 Jun 2011 [18:24:38], Joel Uckelman wrote:
> >> I'm trying to set up a unix domain socket with a guest on one end and
> >> the host on the ot
Hello,
This fixes a segfault at startup regression debugged and fixed by
Luiz. Please pull.
The following changes since commit f26e428da505709ec03b2ed2c9eb3db82b30bd7b:
Fix MinGW compilation when --enable-vnc-jpeg is specified (2011-06-26
20:19:38 +)
are available in the git repository
Hello,
On (Fri) 24 Jun 2011 [02:22:44], Edgar E. Iglesias wrote:
> Hi,
>
> Tried to stream 2K of data into a guest via an emulated serial port backed
> by -serial stdio but it failed. Looks like data flows for a while, then
> suddenly even though the last call to can_rceive returns +, nothing com
On (Fri) 24 Jun 2011 [12:54:07], Joel Uckelman wrote:
> On Fri, Jun 24, 2011 at 4:54 AM, Amit Shah wrote:
> >>
> >> I guess this means I need to get networking running on the guest so
> >> that it has a port visible to the host on which my server can listen.
>
On (Sun) 26 Jun 2011 [20:43:16], Blue Swirl wrote:
> On Wed, Jun 22, 2011 at 7:53 AM, Amit Shah wrote:
[snip]
> > From dec93d9eccd639f7bfd1343dca65fa112eb19e3e Mon Sep 17 00:00:00 2001
> > Message-Id:
> >
> > From: Amit Shah
> > Date: Wed, 22 Jun 2011 10:20
On (Fri) 24 Jun 2011 [13:57:28], Markus Armbruster wrote:
> Ping?
There were a couple of things:
> port 0, guest on, host off, throttle off
guest on/off, host on/off doesn't convey much -- what's on/off?
Also, 'throttle' could be 'thottled'?
Amit
On (Wed) 22 Jun 2011 [09:53:35], Luiz Capitulino wrote:
> On Wed, 22 Jun 2011 09:49:22 +0530
> Amit Shah wrote:
> > >
> > > -port = find_port_by_id(vser, ldl_p(&gcpkt->id));
> > > -if (!port && cpkt.event != VIRTIO_CONSOLE_DEVICE_READY
On (Mon) 27 Jun 2011 [14:36:11], Markus Armbruster wrote:
> Amit Shah writes:
>
> > On (Fri) 24 Jun 2011 [13:57:28], Markus Armbruster wrote:
> >> Ping?
> >
> > There were a couple of things:
> >
> >> port 0, guest on, host off, thrott
On (Tue) 28 Jun 2011 [14:24:32], Markus Armbruster wrote:
> Amit Shah writes:
>
> > On (Mon) 27 Jun 2011 [14:36:11], Markus Armbruster wrote:
> >> Amit Shah writes:
> >>
> >> > On (Fri) 24 Jun 2011 [13:57:28], Markus Armbruster wrote:
> >> &
On (Tue) 28 Jun 2011 [10:49:03], 박재민 wrote:
> Dear All,
> This is Jaemin Park, who delves into qemu.
>
> I have 2 questions about the license of qemu.
Legal questions should go to lawyers, not developers.
Amit
On (Sat) 02 Jul 2011 [09:38:30], Stefan Hajnoczi wrote:
...
> I don't see split lines as an issue because I never grep for an entire
> line. Pick a small, unique, fixed part of the message and you'll find
> it.
>
> "Small" in order to avoid any formatting or split line issues.
Unless you pick
Add some trace events for messages passed between the char layer and the
virtio-serial bus.
Signed-off-by: Amit Shah
---
hw/virtio-console.c |9 -
trace-events|5 +
2 files changed, 13 insertions(+), 1 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio
Add some trace events for messages passed between the guest and host.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c |7 +++
trace-events |6 ++
2 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index
Add some trace events for messages passed between the char layer and the
virtio-serial bus.
Signed-off-by: Amit Shah
---
hw/virtio-console.c |9 -
trace-events|5 +
2 files changed, 13 insertions(+), 1 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio
Add some trace events for messages passed between the guest and host.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c |7 +++
trace-events |6 ++
2 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index
ommit 9312805d33e8b106bae356d13a8071fb37d75554:
pxa2xx_lcd: add proper rotation support (2011-07-04 22:12:21 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/qemu/amit/virtio-serial.git for-anthony
Amit Shah (3):
virtio-serial-bus: Add trace events
virtio-console: Add some trace e
Markus fixed offenders in the file but one instance sneaked in via
another patch. Fix it.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index 9859f9f..6d73386 100644
values to its users,
all we get is -1 for any kind of error. Just return 0 for now and wait
for chardevs to return better error messages to act better on the return
messages.
Signed-off-by: Amit Shah
---
hw/virtio-console.c | 20 ++--
1 files changed, 18 insertions(+), 2
values to its users,
all we get is -1 for any kind of error. Just return 0 for now and wait
for chardevs to return better error messages to act better on the return
messages.
Signed-off-by: Amit Shah
---
hw/virtio-console.c | 20 ++--
1 files changed, 18 insertions(+), 2
On (Tue) 12 Jul 2011 [14:58:57], Amit Shah wrote:
> A host chardev could close just before the guest sends some data to be
> written. This will cause an -EPIPE error. This shouldn't be propagated
> to virtio-serial-bus.
>
> Ideally we should close the port once -EPIPE is rec
19:43:00
+)
are available in the git repository at:
git://git.kernel.org/pub/scm/qemu/amit/virtio-serial.git for-anthony
Amit Shah (4):
virtio-serial-bus: Add trace events
virtio-console: Add some trace events
virtio-serial-bus: Fix trailing \n in error_report string
On (Wed) 20 Jul 2011 [09:10:41], Markus Armbruster wrote:
> Amit Shah writes:
>
> > A host chardev could close just before the guest sends some data to be
> > written. This will cause an -EPIPE error. This shouldn't be propagated
> > to virtio-serial-bus.
> &
Separate out the code to retrieve balloon info from the code that sets
balloon values.
This will be used to separate the two callbacks from balloon.c and help
cope with 'balloon 0' on the monitor. Currently, 'balloon 0' causes a
segfault in monitor_resume().
Signed-off-by
balloon.h had function declarations for a couple of functions that are
local to balloon.c. Make them static.
Drop the 'qemu_' prefix for balloon.c-local variables, and make them
static.
Signed-off-by: Amit Shah
---
balloon.c | 22 +++---
balloon.h |4 ---
w cleanups along the way.
Amit Shah (7):
balloon: Make functions, local vars static
balloon: Add braces around if statements
balloon: Simplify code flow
virtio-balloon: Separate status handling into separate function
balloon: Separate out stat and balloon handling
balloon: Fix header co
Passing on '0' as ballooning target to indicate retrieval of stats is
bad API. It also makes 'balloon 0' in the monitor cause a segfault.
Have two different functions handle the different functionality instead.
Reported-by: Mike Cao
Signed-off-by: Amit Shah
---
balloo
Signed-off-by: Amit Shah
---
balloon.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/balloon.c b/balloon.c
index f9bcf07..86f629e 100644
--- a/balloon.c
+++ b/balloon.c
@@ -65,9 +65,10 @@ static void print_balloon_stat(const char *key, QObject
*obj, void *opaque
Replace:
if (foo) {
...
} else {
return 0;
}
by
if (!foo) {
return 0;
}
...
Signed-off-by: Amit Shah
---
balloon.c | 16 +++-
1 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/balloon.c b/balloon.c
index 86f629e..d40be39 100644
--- a
Signed-off-by: Amit Shah
---
balloon.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/balloon.c b/balloon.c
index 8be3812..a938475 100644
--- a/balloon.c
+++ b/balloon.c
@@ -1,7 +1,9 @@
/*
- * QEMU System Emulator
+ * Generic Balloon handlers and management
Signed-off-by: Amit Shah
---
hw/virtio-balloon.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c
index 40b43b0..2ba7e95 100644
--- a/hw/virtio-balloon.c
+++ b/hw/virtio-balloon.c
@@ -1,7 +1,9 @@
/*
- * Virtio Block Device
On (Fri) 22 Jul 2011 [16:45:55], Markus Armbruster wrote:
> Amit Shah writes:
>
> > Passing on '0' as ballooning target to indicate retrieval of stats is
> > bad API. It also makes 'balloon 0' in the monitor cause a segfault.
> > Have two different
On (Wed) 20 Jul 2011 [18:23:34], Markus Armbruster wrote:
> This patch series looks bigger than it is. All the patches are small
> and hopefully easy to review.
>
> Objectives:
>
> * Push BlockDriverState members locked, tray_open, media_changed into
> device models, where they belong.
>
> *
When a balloon device gets unplugged, allow the balloon handlers to be
freed.
Signed-off-by: Amit Shah
---
balloon.c | 10 ++
balloon.h |1 +
2 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/balloon.c b/balloon.c
index f56fdc1..a2133db 100644
--- a/balloon.c
+++ b
ice already registered
Device 'virtio-balloon-pci' could not be initialized
Reported-by: Shaolong Hu
Signed-off-by: Amit Shah
---
hw/virtio-balloon.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c
index 072a88a..5
Hello,
These patches fix one bug (patch 2), and add some stats for bytes
sent, received and discarded, mainly for debugging purposes.. These
stats are shown in the 'info qtree' output. More details in the
commit logs.
Please apply,
Amit Shah (3):
virtio-serial-bus: add p
To discard throttled data as well as maintain statistics of bytes
received and discarded, discard_vq_data() will need the port associated
with the vq.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/hw/virtio
ff-by: Amit Shah
---
hw/virtio-serial-bus.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index 6838d73..2c84398 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw/virtio-serial-bus.c
@@ -122,6 +122,10 @@ static void discard_vq
e's such a need.
The stats remain valid throughout the lifetime of the port. Unplugging a
port will reset the stats. The numbers are not reset across port
opens/closes.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c | 24 ++--
hw/virtio-serial.h | 11 +
On (Wed) 14 Sep 2011 [14:52:50], Markus Armbruster wrote:
> Amit Shah writes:
>
> > To discard throttled data as well as maintain statistics of bytes
> > received and discarded, discard_vq_data() will need the port associated
> > with the vq.
> >
> > Signe
The following changes since commit db237e33c08a279f0179f8f5128a6d10d9adc38a:
Merge remote-tracking branch 'remotes/riku/for-2.0' into staging (2014-03-26
17:10:16 +)
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/qemu/amit/migration.git tags/for_upstream
for
On (Thu) 27 Mar 2014 [14:43:23], Alexey Kardashevskiy wrote:
> On 03/12/2014 06:36 AM, Juan Quintela wrote:
> > Alexey Kardashevskiy wrote:
> >> This adds a helper to format ethernet MAC address.
> >>
> >> Signed-off-by: Alexey Kardashevskiy
> >
> > Reviewed-by: Juan Quintela
>
>
> Di
On (Thu) 27 Mar 2014 [11:18:05], Peter Maydell wrote:
> On 27 March 2014 10:49, Amit Shah wrote:
> > The following changes since commit db237e33c08a279f0179f8f5128a6d10d9adc38a:
> >
> > Merge remote-tracking branch 'remotes/riku/for-2.0' into staging
> > (2
On (Mon) 31 Mar 2014 [17:17:05], Michael S. Tsirkin wrote:
> CVE-2013-4535
> CVE-2013-4536
>
> Both virtio-block and virtio-serial read,
> VirtQueueElements are read in as buffers, and passed to
> virtqueue_map_sg(), where num_sg is taken from the wire and can force
> writes to indicies beyond VIR
_in_watch in fd_chr_update_read_handler as well.
> - fix pty backend.
Reviewed-by: Amit Shah
Gerd, could you take a look as well?
Amit
On (Wed) 08 Jan 2014 [17:14:41], Amos Kong wrote:
> On Wed, Dec 18, 2013 at 11:05:14AM +0100, Giuseppe Scrivano wrote:
> > Markus Armbruster writes:
> >
> > > Amos Kong writes:
> > >
> > >> Bugzilla: https://bugs.launchpad.net/qemu/+bug/1253563
> > >>
> > >> We have a requests queue to cache the
ndom prior to this patch, new->old
> migration was not consistently functional to begin with.
>
> Reported-by: Nicholas Thomas
> Suggested-by: Peter Maydell
> Cc: qemu-sta...@nongnu.org
> Signed-off-by: Michael Roth
> ---
> v2:
> * Fixed s/except/accept/ typo (Laszlo)
Reviewed-by: Amit Shah
Amit
ndom prior to this patch, new->old
> migration was not consistently functional to begin with.
>
> Reported-by: Nicholas Thomas
> Suggested-by: Peter Maydell
> Cc: qemu-sta...@nongnu.org
> Signed-off-by: Michael Roth
Please fix the comment below per Laszlo's comment, and you can add:
Reviewed-by: Amit Shah
Amit
Hi,
This fix by Gal Hammer has been on list for quite a while, please pull.
The following changes since commit
46eef33b89e936ca793e13c4aeea1414e97e8dbb:
Fix QEMU build on OpenBSD on x86 archs (2014-02-17 11:44:00 +)
are available in the git repository at:
git://git.kernel.org/pub/scm/
On (Fri) 21 Feb 2014 [14:55:48], Peter Maydell wrote:
> On 20 February 2014 10:00, Amit Shah wrote:
> > This fix by Gal Hammer has been on list for quite a while, please pull.
> >
> >
> > The following changes since commit
> > 46eef33b89e936ca793e13c4aeea1414e97e
If TMPDIR is not specified, the default was to use /tmp for the working
copy of the block devices. Update this to /var/tmp instead, so systems
using tmp-on-tmpfs don't end up inadvertently using RAM for the block
device.
Signed-off-by: Amit Shah
---
block.c | 5 +++--
1 file chang
On (Thu) 27 Feb 2014 [11:18:15], Stefan Hajnoczi wrote:
> On Wed, Feb 26, 2014 at 03:12:37PM +0530, Amit Shah wrote:
> > If TMPDIR is not specified, the default was to use /tmp for the working
> > copy of the block devices. Update this to /var/tmp instead, so systems
> > usi
Hi,
On (Mon) 25 Nov 2013 [10:07:40], Gal Hammer wrote:
> Fix a bug that was introduced in commit 386a5a1e. A removal of a device
> set the chr handlers to NULL. However when the device is plugged back,
> its read callback is not restored so data can't be transfter from the
> host to the guest via
On (Mon) 09 Dec 2013 [22:10:12], Amos Kong wrote:
> Bugzilla: https://bugs.launchpad.net/qemu/+bug/1253563
>
> We have a requests queue to cache the random data, but the second
> will come in when the first request is returned, so we always
> only have one items in the queue. It effects the perfor
On (Sun) 15 Dec 2013 [12:26:37], Gal Hammer wrote:
> Fix a bug that was introduced in commit 386a5a1e. A removal of a device
> set the chr handlers to NULL. However when the device is plugged back,
> its read callback is not restored so data can't be transferred from the
> host to the guest (e.g. v
On (Mon) 16 Dec 2013 [15:19:31], Anthony Liguori wrote:
> On Mon, Dec 16, 2013 at 8:36 AM, Amit Shah wrote:
> > On (Mon) 09 Dec 2013 [22:10:12], Amos Kong wrote:
> >> Bugzilla: https://bugs.launchpad.net/qemu/+bug/1253563
> >>
> >> We have a requests queue to c
On (Tue) 17 Dec 2013 [08:47:34], Markus Armbruster wrote:
> Amos Kong writes:
>
> > Bugzilla: https://bugs.launchpad.net/qemu/+bug/1253563
> >
> > We have a requests queue to cache the random data, but the second
> > will come in when the first request is returned, so we always
> > only have one
On (Tue) 17 Dec 2013 [11:12:02], Gal Hammer wrote:
> On 16/12/2013 22:32, Amit Shah wrote:
> >On (Sun) 15 Dec 2013 [12:26:37], Gal Hammer wrote:
> >>Fix a bug that was introduced in commit 386a5a1e. A removal of a device
> >>set the chr handlers to NULL. However when
On (Mon) 21 Apr 2014 [16:39:49], Juan Quintela wrote:
> Signed-off-by: Juan Quintela
> ---
> tests/test-vmstate.c | 38 +++---
> 1 file changed, 19 insertions(+), 19 deletions(-)
Reviewed-by: Amit Shah
Amit
nel.org/pub/scm/virt/qemu/amit/virtio-serial.git
char-remove-watch-on-unplug
for you to fetch changes up to 386a5a1e0057e220f79c48fe3689e3dfb17f1b09:
char: remove watch callback on chardev detach from frontend (2013-09-05
18:30:36 +0530)
Amit Shah (3):
char: move backends' io watch tag
On (Fri) 04 Oct 2013 [21:18:02], Amit Shah wrote:
> Hi Anthony,
>
> Please pull to receive a fix for a segfault in the char layer. The
> patches have been on the list for a week, and Gerd has reviewed them.
>
> (I'm overloading the virtio-serial git tree for this series,
On (Tue) 29 Oct 2013 [18:42:45], Amit Shah wrote:
> On (Fri) 04 Oct 2013 [21:18:02], Amit Shah wrote:
> > Hi Anthony,
> >
> > Please pull to receive a fix for a segfault in the char layer. The
> > patches have been on the list for a week, and Gerd has reviewed them.
&g
On (Thu) 27 Feb 2014 [08:57:38], Markus Armbruster wrote:
> Reviewers accepted v2 of the patch, but what got committed was v1,
> with the R-bys for v2. This is the v1->v2 followup fix.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Amit Shah
Th
From: Alexey Kardashevskiy
This adds @idstr to savevm_section_start and savevm_section_end
tracepoints.
Signed-off-by: Alexey Kardashevskiy
Signed-off-by: Amit Shah
---
savevm.c | 12 ++--
trace-events | 4 ++--
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a
mit Shah
Signed-off-by: Amit Shah
---
qemu-file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-file.c b/qemu-file.c
index f074af1..e5ec798 100644
--- a/qemu-file.c
+++ b/qemu-file.c
@@ -105,7 +105,7 @@ static int stdio_put_buffer(void *opaque, const uint8_t
*buf, int6
From: Alexey Kardashevskiy
It might be useful for tracing migration.
Signed-off-by: Alexey Kardashevskiy
Signed-off-by: Amit Shah
---
trace-events | 1 +
vl.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/trace-events b/trace-events
index 580281d..91a2edc 100644
--- a/trace
From: Alexey Kardashevskiy
This replaces DPRINTF macro with tracepoints.
This moves some messages from migration.c to savevm.c.
This adds tracepoint to signal about fields failed to migrate.
Signed-off-by: Alexey Kardashevskiy
Signed-off-by: Amit Shah
---
migration.c | 30
Hi Juan,
Here's a compilation of migration-related patches from the list that
I've reviewed.
For the first patch, I picked Markus's over yours, just because it's
been on the list longer.
The following changes since commit 9fbee91a131a05e443d7108d7fbdf3ca91020290:
Merge remote-tracking branch
On (Wed) 05 Mar 2014 [02:14:56], Alexey Kardashevskiy wrote:
> This replaces DPRINTF macro with tracepoints.
>
> This moves some messages from migration.c to savevm.c.
>
> This adds tracepoint to signal about fileds failed to migrate.
>
> Signed-off-by: Alexey Kardashevskiy
> ---
>
> This is v
Hi,
These are some patches that have received reviews and have been on the
list.
Please pick them up.
The following changes since commit 4c288acbd6b9eccb13076103e59a426af3d15030:
configure: Always build with -fno-common (2014-03-06 21:26:44 +)
are available in the git repository at:
g
Hi Peter,
On (Sat) 08 Mar 2014 [12:19:10], Peter Maydell wrote:
> On 6 March 2014 20:03, Amit Shah wrote:
> > Hi Juan,
> >
> > Here's a compilation of migration-related patches from the list that
> > I've reviewed.
> >
> > For the first patch
On (Wed) 05 Mar 2014 [02:14:56], Alexey Kardashevskiy wrote:
> This replaces DPRINTF macro with tracepoints.
>
> This moves some messages from migration.c to savevm.c.
>
> This adds tracepoint to signal about fileds failed to migrate.
>
> Signed-off-by: Alexey Kardashevskiy
> ---
>
> This is v
Hi,
I haven't really followed the whole discussion, so can't say much
about it -- overall looks alright. A couple of minor nits:
> max_nr_ports = tswap32(port->vser->config.max_nr_ports);
> if (port->id >= max_nr_ports) {
> -error_report("virtio-serial-bus: Out-of-range port id
On (Fri) 06 Feb 2015 [13:41:26], Tiejun Chen wrote:
> Actually we define these device IDs in virtio standard, so
> we'd better put them into one common place to manage conveniently.
> Here I also add VIRTIO_ID_RESERVE according to virtio spec.
>
> Signed-off-by: Tiejun Chen
On (Fri) 06 Feb 2015 [15:41:38], Mark Cave-Ayland wrote:
> On 06/02/15 14:51, Alexander Graf wrote:
>
> > On 06.02.15 15:36, Mark Cave-Ayland wrote:
> >> This patchset follows on from my ppc loadvm/savevm work and converts
> >> openpic over to vmstate.
> >>
> >> With these patches applied, I can s
On (Mon) 09 Feb 2015 [20:57:42], Michael S. Tsirkin wrote:
> On Fri, Feb 06, 2015 at 01:41:26PM +0800, Tiejun Chen wrote:
> > Actually we define these device IDs in virtio standard, so
> > we'd better put them into one common place to manage conveniently.
> > Here I also add VIRTIO_ID_RESERVE accor
On (Wed) 11 Feb 2015 [16:46:21], Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> This patchset provides a way of setting options on an incoming
> migration before the fd/process/socket has been created.
>
>start qemu with -incoming pause
>
>migrate_incoming
On (Tue) 17 Feb 2015 [13:27:03], Dr. David Alan Gilbert wrote:
> * Amit Shah (amit.s...@redhat.com) wrote:
> > On (Wed) 11 Feb 2015 [16:46:21], Dr. David Alan Gilbert (git) wrote:
> > > From: "Dr. David Alan Gilbert"
> > >
> > > This patchset pr
On (Tue) 17 Feb 2015 [09:14:27], Eric Blake wrote:
> On 02/17/2015 07:59 AM, Amit Shah wrote:
> >>>
> >>> So the only comment I have is with the 'pause' name.
> >>>
> >>> 'pause' to me means there's a time period for wh
On (Tue) 17 Feb 2015 [20:13:25], Dr. David Alan Gilbert wrote:
> * Eric Blake (ebl...@redhat.com) wrote:
> > On 02/17/2015 07:59 AM, Amit Shah wrote:
> > >>>
> > >>> So the only comment I have is with the 'pause' name.
> > >>>
> &g
On (Mon) 12 Jan 2015 [01:12:41], Yi Wang wrote:
> From b119164ba6715f53594facfc4d1022c198852e9d Mon Sep 17 00:00:00 2001
> From: Yi Wang
> Date: Mon, 12 Jan 2015 00:05:40 +0800
> Subject: [PATCH] savevm: create snapshot failed when id_str already exits
>
> Create snapshot failed in this case:
> 1
On (Thu) 19 Feb 2015 [18:12:19], Thomas Huth wrote:
> dup_mig_bytes_transferred(), skipped_mig_bytes_transferred(),
> migrate_rdma_pin_all(), qsb_clone() and qsb_set_length()
> are completely unused and thus can be deleted.
>
> Signed-off-by: Thomas Huth
> Cc: Juan Quintel
--
> include/migration/migration.h | 2 +-
> include/migration/qemu-file.h | 2 +-
> migration/qemu-file.c | 3 ++-
> migration/rdma.c | 2 +-
> 5 files changed, 13 insertions(+), 7 deletions(-)
Reviewed-by: Amit Shah
Amit
On (Thu) 12 Feb 2015 [23:03:07], Juan Quintela wrote:
> Add a parameter to pass the number of bytes written, and make it return
> the number of pages written instead.
>
> Signed-off-by: Juan Quintela
> ---
> arch_init.c | 44 ++--
> 1 file changed, 22 inse
On (Thu) 12 Feb 2015 [23:03:09], Juan Quintela wrote:
> Add a parameter to pass the number of bytes written, and make it return
> the number of pages written instead.
>
> Signed-off-by: Juan Quintela
> ---
> arch_init.c | 44 +---
> 1 file changed, 25 inse
401 - 500 of 1982 matches
Mail list logo
