[Qemu-devel] [PATCH] virtio-serial: Don't clear -have_data() pointer after unplug

2011-03-03 Thread Amit Shah
After a port unplug operation, the port-info-have_data() pointer was set to NULL. The problem is, the -info struct is shared by all ports, effectively disabling writes to other ports. Reported-by: juzhang juzh...@redhat.com Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-console.c

[Qemu-devel] Re: [PULL (resend, rebase) 2/5] virtio-serial: Disallow generic ports at id 0

2011-03-10 Thread Amit Shah
On (Thu) 10 Mar 2011 [11:39:16], Amit Shah wrote: Port 0 is reserved for virtconsole devices for backward compatibility with the old -virtioconsole (from qemu 0.12) device type. libvirt prior to commit 8e28c5d40200b4c5d483bd585d237b9d870372e5 used port 0 for generic ports. libvirt

[Qemu-devel] [PATCH 0/2] char, virtio_console: Allow chardevs to be re-used

2011-03-15 Thread Amit Shah
This series does two things: - prevents a single chardev to be used by multiple devices at the same time - virtio-console/serial ports don't close a chardev, instead free it for later use by other devices (or a new hot-plugged virtio serial port). Please apply. Amit Shah (2): virtio

[Qemu-devel] [PATCH 2/2] char: Prevent multiple devices opening same chardev

2011-03-15 Thread Amit Shah
Prevent: -chardev socket,path=/tmp/foo,server,nowait,id=c0 \ -device virtserialport,chardev=c0,id=vs0 \ -device virtserialport,chardev=c0,id=vs1 Reported-by: Mike Cao b...@redhat.com Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/qdev-properties.c |7 ++- qemu-char.c

[Qemu-devel] [PATCH 1/2] virtio-console: Keep chardev open for other users after hot-unplug

2011-03-15 Thread Amit Shah
-console channel can then be hot-plugged with the same chardev and things will continue to work. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-console.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index c235b27

[Qemu-devel] [PATCH 1/7] virtio-serial: Use a struct to pass config information from proxy

2011-03-21 Thread Amit Shah
Instead of using a single variable to pass to the virtio_serial_init function, use a struct so that expanding the number of variables to be passed on later is easier. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-pci.c| 12 ++-- hw/virtio-serial-bus.c | 16

[Qemu-devel] [PULL #7 0/7] virtio-serial fixes, enhancements

2011-03-21 Thread Amit Shah
://git.kernel.org/pub/scm/virt/qemu/amit/virtio-serial.git for-anthony Amit Shah (7): virtio-serial: Use a struct to pass config information from proxy virtio-serial: Disallow generic ports at id 0 virtio-serial: Enable ioeventfd virtio-serial-bus: Simplify handle_output() function virtio-serial

[Qemu-devel] [PATCH 2/7] virtio-serial: Disallow generic ports at id 0

2011-03-21 Thread Amit Shah
at id 0 from qemu as well. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-console.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index c235b27..4440784 100644 --- a/hw/virtio-console.c +++ b/hw/virtio

[Qemu-devel] [PATCH 4/7] virtio-serial-bus: Simplify handle_output() function

2011-03-21 Thread Amit Shah
There's no code change, just re-arrangement to simplify the function after recent modifications. Reported-by: Juan Quintela quint...@redhat.com Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-serial-bus.c | 12 +++- 1 files changed, 3 insertions(+), 9 deletions(-) diff

[Qemu-devel] [PATCH 3/7] virtio-serial: Enable ioeventfd

2011-03-21 Thread Amit Shah
Enable ioeventfd for virtio-serial devices by default. Commit 25db9ebe15125deb32958c6df74996f745edf1f9 lists the benefits of using ioeventfd. Copying a file from guest to host over a virtio-serial channel didn't show much difference in time or io_exit rate. Signed-off-by: Amit Shah amit.s

[Qemu-devel] [PATCH 7/7] char: Prevent multiple devices opening same chardev

2011-03-21 Thread Amit Shah
Prevent: -chardev socket,path=/tmp/foo,server,nowait,id=c0 \ -device virtserialport,chardev=c0,id=vs0 \ -device virtserialport,chardev=c0,id=vs1 Reported-by: Mike Cao b...@redhat.com Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/qdev-properties.c |7 ++- qemu-char.c

[Qemu-devel] [PATCH 6/7] virtio-console: Keep chardev open for other users after hot-unplug

2011-03-21 Thread Amit Shah
-console channel can then be hot-plugged with the same chardev and things will continue to work. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-console.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index be59558

[Qemu-devel] [PATCH 5/7] virtio-serial: Don't clear -have_data() pointer after unplug

2011-03-21 Thread Amit Shah
After a port unplug operation, the port-info-have_data() pointer was set to NULL. The problem is, the -info struct is shared by all ports, effectively disabling writes to other ports. Reported-by: juzhang juzh...@redhat.com Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-console.c

Re: [Qemu-devel] [PATCH 0/3] spicevmc - chardev: restore guest open / close notifcation

2011-03-22 Thread Amit Shah
On (Tue) 22 Mar 2011 [14:15:20], Hans de Goede wrote: Hi All, When we moved from the spicevmc device (which directly implemented a virtio serial port) to doing spicevmc as a chardev backend we lost the notification of the guest opening / closing the port to spice server. This causes the

[Qemu-devel] Re: [PATCH] virtio-serial: don't crash on invalid input

2011-03-22 Thread Amit Shah
On (Tue) 22 Mar 2011 [18:32:50], Michael S. Tsirkin wrote: Fix crash on invalid input in virtio-serial. Discovered by code review, untested. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio-serial-bus.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff

Re: [Qemu-devel] [PATCH v2 0/3] Allow ipv6 for migration

2011-03-23 Thread Amit Shah
On (Fri) 18 Mar 2011 [14:22:47], Juan Quintela wrote: Hi v2: - create socket_set_reuseaddr() to have it different for Windows and everything else (Peter Maydell) - use strerror() instead of perror (Peter Maydell) - fprintf(): one of them removed, the other one ... it is complicated,

Re: [Qemu-devel] [PATCH 1/3] create socket_set_reuseaddr()

2011-03-23 Thread Amit Shah
On (Fri) 18 Mar 2011 [14:22:48], Juan Quintela wrote: Windows is different than unix, SO_REUSEADDR is the default value there. Create one function to do it and change all callers. Signed-off-by: Juan Quintela quint...@redhat.com --- gdbstub.c |6 ++ migration-tcp.c|

Re: [Qemu-devel] [PATCH 2/3] Use getaddrinfo for migration

2011-03-23 Thread Amit Shah
On (Fri) 18 Mar 2011 [14:22:49], Juan Quintela wrote: This allows us to use ipv4/ipv6 for migration addresses. Once there, it also uses /etc/services names (it came free). Signed-off-by: Juan Quintela quint...@redhat.com --- migration-tcp.c | 51 +++ net.c

[Qemu-devel] Re: [PATCH 5/7] virtio-serial: Don't clear -have_data() pointer after unplug

2011-03-23 Thread Amit Shah
On (Wed) 23 Mar 2011 [14:33:25], Juan Quintela wrote: Amit Shah amit.s...@redhat.com wrote: After a port unplug operation, the port-info-have_data() pointer was set to NULL. The problem is, the -info struct is shared by all ports, effectively disabling writes to other ports. Reported

[Qemu-devel] Re: [PULL #7 0/7] virtio-serial fixes, enhancements

2011-03-23 Thread Amit Shah
On (Wed) 23 Mar 2011 [14:31:09], Juan Quintela wrote: Reviewed-by: Juan Quintela quint...@redhat.com Thanks! Anthony, ping again for pulling this. Amit

[Qemu-devel] Re: [PATCH] virtio-serial: don't crash on invalid input

2011-03-23 Thread Amit Shah
On (Tue) 22 Mar 2011 [18:32:50], Michael S. Tsirkin wrote: Fix crash on invalid input in virtio-serial. Discovered by code review, untested. Signed-off-by: Michael S. Tsirkin m...@redhat.com Acked-by: Amit Shah amit.s...@redhat.com Amit

[Qemu-devel] Re: [PATCH] virtio-serial: don't crash on invalid input

2011-03-23 Thread Amit Shah
On (Wed) 23 Mar 2011 [11:56:57], Michael S. Tsirkin wrote: On Tue, Mar 22, 2011 at 10:25:06PM +0530, Amit Shah wrote: On (Tue) 22 Mar 2011 [18:32:50], Michael S. Tsirkin wrote: Fix crash on invalid input in virtio-serial. Discovered by code review, untested. @@ -654,6 +654,9 @@ static

[Qemu-devel] [PATCH] virtio-serial: Print out reason for aborting before calling abort()

2011-03-25 Thread Amit Shah
When a port returns an error for not consuming data, we can only handle the -EAGAIN error type. Any other error isn't handled. Print out a message indicating this and the error returned. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-serial-bus.c |1 + 1 files changed, 1

[Qemu-devel] Re: [PATCH] virtio-serial: Print out reason for aborting before calling abort()

2011-03-25 Thread Amit Shah
On (Fri) 25 Mar 2011 [11:54:02], Amit Shah wrote: When a port returns an error for not consuming data, we can only handle the -EAGAIN error type. Any other error isn't handled. Print out a message indicating this and the error returned. Signed-off-by: Amit Shah amit.s...@redhat.com

[Qemu-devel] [PATCH v2] virtio-serial: Print out reason for aborting before calling abort()

2011-03-25 Thread Amit Shah
When a port returns an error for not consuming data, we can only handle the -EAGAIN error type. Any other error isn't handled. Print out a message indicating this and the error returned. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-serial-bus.c |2 ++ 1 files changed, 2

[Qemu-devel] Re: [PATCH v2] virtio-serial: Print out reason for aborting before calling abort()

2011-03-25 Thread Amit Shah
On (Fri) 25 Mar 2011 [10:23:16], Juan Quintela wrote: Amit Shah amit.s...@redhat.com wrote: When a port returns an error for not consuming data, we can only handle the -EAGAIN error type. Any other error isn't handled. Print out a message indicating this and the error returned. Signed

Re: [Qemu-devel] [PATCH 1/3] virtio: don't exit on guest errors

2011-03-29 Thread Amit Shah
On (Mon) 28 Mar 2011 [23:14:16], Michael S. Tsirkin wrote: When guest does something illegal, such as programming invalid index values in the virtio device, qemu currently tends to crash. With virtio, a better idea is to log an error, and set status to FAIL which stops the device. Add an

[Qemu-devel] Re: [PATCH 04/19] s390x: fix s390-virtio-serial

2011-03-29 Thread Amit Shah
On (Tue) 29 Mar 2011 [15:29:31], Alexander Graf wrote: Commit 6b331efb733a0f913ddc0b7762a1307dec304061 broke the s390 proxy version of virtio-serial by only taking its PCI brother into account. So let's adjust s390-virtio-serial the same way as its PCI counterpart, making it compile and work

[Qemu-devel] Re: CD-ROM bug round-up

2011-03-31 Thread Amit Shah
On (Wed) 30 Mar 2011 [17:40:40], Stefan Hajnoczi wrote: Several of us have been investigating CD-ROM bugs. Let's update each other, make sure we're not duplicating effort, and see if we can help each other make progress. = Stefan = Guests do not notice media change when using Linux host

[Qemu-devel] [RFC PATCH 1/3] ide: Move GET_EVENT_STATUS_NOTIFICATION command handling to its own function

2011-03-31 Thread Amit Shah
This makes the code more readable. Also, there's a block like: if () { ... } else { ... } Split that into if () { ... return; } ... Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/ide/core.c | 37 - 1 files changed, 24 insertions(+), 13

[Qemu-devel] [RFC PATCH 2/3] atapi: implement GET_EVENT_STATUS_NOTIFICATION command

2011-03-31 Thread Amit Shah
This commit could be split further; but the main thing it does is implement this command. Linux kernels (at least upto 2.6.38.2) need a fix to the media change handling to recognise size changes. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/ide/core.c | 138

[Qemu-devel] [RFC PATCH 3/3] atapi: Allow GET_EVENT_STATUS_NOTIFICATION and TEST_UNIT_READY after media change

2011-03-31 Thread Amit Shah
aren't seen. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/ide/core.c | 28 +--- 1 files changed, 21 insertions(+), 7 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 89e212b..362a258 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -625,6 +625,14

[Qemu-devel] [PATCH 1/3] virtio-console: Check if chardev backends available before calling into them

2011-12-20 Thread Amit Shah
For the callback functions invoked by the virtio-serial-bus code, check if we have chardev backends registered before we call into the chardev functions. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-console.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions

[Qemu-devel] [PATCH 3/3] virtio-serial-bus: Ports are expected to implement 'have_data' callback

2011-12-20 Thread Amit Shah
There's no need to check if ports can accept any incoming data from the guest each time the guest sends data. Check if the port implements such functionality during port initialisation. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-serial-bus.c |6 +++--- 1 files changed, 3

[Qemu-devel] [PATCH 2/3] virtio-console: Properly initialise class methods

2011-12-20 Thread Amit Shah
optimisation, and definitely not one that was well-implemented. Get rid of it. Reported-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-console.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/virtio-console.c b/hw

Re: [Qemu-devel] [PATCH] scsi virtio-blk usb-msd: Clean up device init error messages

2011-12-21 Thread Amit Shah
) device_add virtio-blk-pci virtio-blk-pci: drive property not set Device 'virtio-blk-pci' could not be initialized Reported-by: Amit Shah amit.s...@redhat.com Signed-off-by: Markus Armbruster arm...@redhat.com Acked-by: Amit Shah amit.s...@redhat.com Amit

Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty

2011-12-29 Thread Amit Shah
On (Thu) 29 Dec 2011 [15:32:14], Christian Borntraeger wrote: port-throttled never becomes true for qemu. Huh? What did I miss below? if (ret == -EAGAIN || (ret = 0 ret buf_size)) { virtio_serial_throttle_port(port, true); 'ret' here is the return value

Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty

2011-12-29 Thread Amit Shah
On (Thu) 29 Dec 2011 [15:16:55], Christian Borntraeger wrote: +++ b/hw/virtio-serial-bus.c @@ -163,7 +163,19 @@ static void do_flush_queued_data(VirtIOS abort(); } if (ret == -EAGAIN || (ret = 0 ret buf_size)) { -

Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty

2011-12-29 Thread Amit Shah
On (Thu) 29 Dec 2011 [13:47:43], Christian Borntraeger wrote: From: Christian Borntraeger borntrae...@de.ibm.com when I tried qemu with -virtio-console pty the guest hangs and attaching on /dev/pts/x does not return anything if the attachement is too late. Turns out that the console is

Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty

2011-12-29 Thread Amit Shah
On (Thu) 29 Dec 2011 [13:47:43], Christian Borntraeger wrote: From: Christian Borntraeger borntrae...@de.ibm.com when I tried qemu with -virtio-console pty the guest hangs and attaching on /dev/pts/x does not return anything if the attachement is too late. Turns out that the console is

Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty

2011-12-29 Thread Amit Shah
On (Thu) 29 Dec 2011 [15:32:14], Christian Borntraeger wrote: port-throttled never becomes true for qemu. Huh? What did I miss below? if (ret == -EAGAIN || (ret = 0 ret buf_size)) { virtio_serial_throttle_port(port, true); Ah; I see what's happening.

[Qemu-devel] [PULL] virtio-serial: Fix console failure on unconnected pty

2012-01-03 Thread Amit Shah
Hi, This patch fixes a frozen guest on virtio-console output before a pty is connected. Please pull. The following changes since commit 8d3bc5178fbc06cdd89c064ae8f44e77c503e91e: Fix qapi code generation wrt parallel build (2011-12-27 09:28:58 -0600) are available in the git repository at:

Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty

2012-01-03 Thread Amit Shah
On (Mon) 02 Jan 2012 [17:55:06], Alexander Graf wrote: On 02.01.2012, at 16:41, Christian Borntraeger wrote: On 02/01/12 16:34, Alexander Graf wrote: if (ret == -EAGAIN || (ret = 0 ret buf_size)) { virtio_serial_throttle_port(port, true); Ah; I see what's

Re: [Qemu-devel] [PULL] virtio-serial: Fix console failure on unconnected pty

2012-01-03 Thread Amit Shah
On (Tue) 03 Jan 2012 [21:18:20], Amit Shah wrote: Hi, This patch fixes a frozen guest on virtio-console output before a pty is connected. Please pull. The following changes since commit 8d3bc5178fbc06cdd89c064ae8f44e77c503e91e: Fix qapi code generation wrt parallel build (2011-12-27

[Qemu-devel] [PULL v2] virtio-serial: Fix console failure on unconnected pty

2012-01-03 Thread Amit Shah
Hi, Turns out I used the wrong repo dir which caused problems. Corrected link below. This patch fixes a frozen guest on virtio-console output before a pty is connected. Please pull. The following changes since commit f3c6a169a39d188e98c17a0a0ebfa7f85e5aafdd: Merge remote-tracking branch

[Qemu-devel] [PATCH 1/2] qdev: Add a 'free' method to disassociate chardev from qdev device

2012-01-13 Thread Amit Shah
When a device is removed, remove the association with a chardev, if any, so that the chardev can be re-used later for other devices. Reported-by: Qunfang Zhang qzh...@redhat.com Fix-suggested-by: Markus Armbruster arm...@redhat.com Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/qdev

[Qemu-devel] [PATCH 0/2] qdev: disassociate chardev from device on device exit

2012-01-13 Thread Amit Shah
When the device is going away (e.g., hot-unplug), an associated chardev should be freed and made available for use for other devices. An earlier hack did this for virtio serial ports, do it in a generic way and remove the virtio-serial specific hack. Amit Shah (2): qdev: Add a 'free' method

[Qemu-devel] [PATCH 2/2] virtio-console: no need to remove char handlers explicitly

2012-01-13 Thread Amit Shah
qdev is now equipped (thanks to the last commit) to disassociate chardevs from the qdev devices on the devices going away. So doing it in the virtio-console driver is not necessary. Since that was the only thing being done in the qdev exit method, drop it entirely. Signed-off-by: Amit Shah

Re: [Qemu-devel] [PATCH 2/2] virtio-console: no need to remove char handlers explicitly

2012-01-13 Thread Amit Shah
On (Fri) 13 Jan 2012 [15:24:59], Amit Shah wrote: qdev is now equipped (thanks to the last commit) to disassociate chardevs from the qdev devices on the devices going away. So doing it in the virtio-console driver is not necessary. Since that was the only thing being done in the qdev exit

[Qemu-devel] [PATCH v2 0/2] qdev: disassociate chardev from device on device exit

2012-01-13 Thread Amit Shah
() Amit Shah (2): qdev: Add a 'free' method to disassociate chardev from qdev device virtio-console: no need to remove char handlers explicitly hw/qdev-properties.c | 11 +++ hw/virtio-console.c | 17 - 2 files changed, 11 insertions(+), 17 deletions(-) -- 1.7.7.5

[Qemu-devel] [PATCH v2 1/2] qdev: Add a 'free' method to disassociate chardev from qdev device

2012-01-13 Thread Amit Shah
When a device is removed, remove the association with a chardev, if any, so that the chardev can be re-used later for other devices. Reported-by: Qunfang Zhang qzh...@redhat.com Fix-suggested-by: Markus Armbruster arm...@redhat.com Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/qdev

[Qemu-devel] [PATCH v2 2/2] virtio-console: no need to remove char handlers explicitly

2012-01-13 Thread Amit Shah
qdev is now equipped (thanks to the last commit) to disassociate chardevs from the qdev devices on the devices going away. So doing it in the virtio-console driver is not necessary. Since that was the only thing being done in the qdev exit method, drop it entirely. Signed-off-by: Amit Shah

Re: [Qemu-devel] [RFC] qemu-ga: Introduce guest-hibernate command

2011-12-08 Thread Amit Shah
On (Thu) 08 Dec 2011 [16:52:58], Luiz Capitulino wrote: This is basically suspend to disk on a Linux guest. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- This is an RFC because I did it as simple as possible and I'm open to suggestions... Now, while testing this or even

[Qemu-devel] [PATCH 0/3] balloon: error if guest driver is not initialised

2011-12-09 Thread Amit Shah
change it to something else. Please review and apply. Amit Shah (3): balloon: Make functions return 0 on OK, -1 on error. balloon: report error if ballooning operation fails virtio-balloon: report error if balloon driver in guest not available balloon.c | 19

[Qemu-devel] [PATCH 1/3] balloon: Make functions return 0 on OK, -1 on error.

2011-12-09 Thread Amit Shah
Current semantics of 1 on OK and 0 on error are slightly weird. qemu_balloon() and qemu_balloon_stats() do this. Other functions in the file use the standard 0 and -1 return values. This commit makes the file consistent in returning such values. Signed-off-by: Amit Shah amit.s...@redhat.com

[Qemu-devel] [PATCH 3/3] virtio-balloon: report error if balloon driver in guest not available

2011-12-09 Thread Amit Shah
was still updated, resulting in the ballooning value being applied to the guest after the guest loads the balloon module. This may not be the desirable thing to do at this later stage. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-balloon.c |3 +++ 1 files changed, 3 insertions

[Qemu-devel] [PATCH 2/3] balloon: report error if ballooning operation fails

2011-12-09 Thread Amit Shah
Ballooning operations can fail (e.g. driver in guest not available). Let the user know of such an error condition instead of silently ignoring errors. Signed-off-by: Amit Shah amit.s...@redhat.com --- balloon.c |7 +-- balloon.h |2 +- hw/virtio-balloon.c |3

Re: [Qemu-devel] [PATCH 0/3] balloon: error if guest driver is not initialised

2011-12-09 Thread Amit Shah
On (Fri) 09 Dec 2011 [11:55:21], Daniel P. Berrange wrote: On Fri, Dec 09, 2011 at 05:19:35PM +0530, Amit Shah wrote: Hello, These patches make qemu generate an error on failure in setting a balloon value: (qemu) balloon 400 Device 'balloon' has not been activated This can

Re: [Qemu-devel] [RFC] qemu-ga: Introduce guest-hibernate command

2011-12-09 Thread Amit Shah
On (Fri) 09 Dec 2011 [10:22:25], Luiz Capitulino wrote: On Thu, 08 Dec 2011 21:18:00 -0600 Michael Roth mdr...@linux.vnet.ibm.com wrote: On 12/08/2011 12:52 PM, Luiz Capitulino wrote: This is basically suspend to disk on a Linux guest. Signed-off-by: Luiz

Re: [Qemu-devel] [RFC] virtio-console fails on unconnected pty

2011-12-16 Thread Amit Shah
Hi Christian, On (Thu) 15 Dec 2011 [13:44:41], Christian Borntraeger wrote: Amit, when I tried qemu with -virtio-console pty the guest hangs and attaching on /dev/pts/x does not return anything if the attachement is too late. Unfortunately we don't yet have chardevs to signal to frontends

Re: [Qemu-devel] [PATCH] virtio-serial: Allow one MSI-X vector per virtqueue

2011-12-16 Thread Amit Shah
On (Fri) 16 Dec 2011 [09:14:26], zanghongy...@huawei.com wrote: From: Hongyong Zang zanghongy...@huawei.com In pci_enable_msix(), the guest's virtio-serial driver tries to set msi-x with one vector per queue. But it fails and eventually all virtio-serial ports share one MSI-X vector. Because

Re: [Qemu-devel] [PATCH] virtio-serial: Allow one MSI-X vector per virtqueue

2011-12-18 Thread Amit Shah
On (Mon) 19 Dec 2011 [14:09:43], Zang Hongyong wrote: 于 2011/12/16,星期五 17:39, Amit Shah 写道: On (Fri) 16 Dec 2011 [09:14:26], zanghongy...@huawei.com wrote: From: Hongyong Zangzanghongy...@huawei.com In pci_enable_msix(), the guest's virtio-serial driver tries to set msi-x with one vector

[Qemu-devel] [PULL] virtio-serial: use bh for unthrottling

2011-05-12 Thread Amit Shah
The following changes since commit 0225e254ae81c5638463cda8f5730f31619113b6: usb-linux: Add missing break statement (2011-05-09 16:18:32 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/virt/qemu/amit/virtio-serial.git for-anthony Alon Levy (1):

[Qemu-devel] [PATCH 1/1] virtio-serial-bus: use bh for unthrottling

2011-05-12 Thread Amit Shah
. Signed-off-by: Alon Levy al...@redhat.com Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-serial-bus.c | 12 ++-- hw/virtio-serial.h |5 + 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index f10d48f

Re: [Qemu-devel] [PATCH 2/4] virtio-serial: Clean up virtser_bus_dev_print() output

2011-05-19 Thread Amit Shah
On (Thu) 19 May 2011 [13:37:15], Markus Armbruster wrote: Old version looks like this in info qtree (last four lines): dev: virtconsole, id dev-prop: is_console = 1 dev-prop: nr = 0 dev-prop: chardev = null dev-prop: name = null

Re: [Qemu-devel] [PATCH 3/4] virtio-serial: Turn props any virtio-serial-bus device must have into bus props

2011-05-19 Thread Amit Shah
On (Thu) 19 May 2011 [13:37:16], Markus Armbruster wrote: diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index bd3121e..a7d6b2b 100644 --- a/hw/virtio-serial-bus.c +++ b/hw/virtio-serial-bus.c @@ -642,6 +642,11 @@ static struct BusInfo virtser_bus_info = { .name =

Re: [Qemu-devel] [PATCH 3/4] virtio-serial: Turn props any virtio-serial-bus device must have into bus props

2011-05-19 Thread Amit Shah
On (Thu) 19 May 2011 [16:05:39], Markus Armbruster wrote: Amit Shah amit.s...@redhat.com writes: On (Thu) 19 May 2011 [13:37:16], Markus Armbruster wrote: diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index bd3121e..a7d6b2b 100644 --- a/hw/virtio-serial-bus.c +++ b/hw

Re: [Qemu-devel] [PATCH 2/4] virtio-serial: Clean up virtser_bus_dev_print() output

2011-05-19 Thread Amit Shah
On (Thu) 19 May 2011 [16:18:29], Markus Armbruster wrote: Amit Shah amit.s...@redhat.com writes: On (Thu) 19 May 2011 [13:37:15], Markus Armbruster wrote: Old version looks like this in info qtree (last four lines): dev: virtconsole, id dev-prop: is_console = 1

Re: [Qemu-devel] [PATCH 0/5] virtio-serial: Fixes and cleanups

2011-05-25 Thread Amit Shah
On (Wed) 25 May 2011 [14:21:09], Markus Armbruster wrote: Feel free to drop PATCH 3/3 if you believe we need to keep the useless property is_console for backward compatibility. I don't think anyone uses it; it's better gone. Thanks for the patches, applied to my tree. Will send a pull request

[Qemu-devel] [PULL] virtio-serial updates

2011-05-27 Thread Amit Shah
Hello, Please pull to get virtio-serial cleanups from Markus and a move to bh for flushing out throttled data from Alon. (git mirror might take some time to sync). The following changes since commit aa29141d84d58171c2d219f0a4b599bd76fb2e37: Merge remote-tracking branch 'kraxel/CVE-2011-1751'

Re: [Qemu-devel] [PATCH] Fix a number of unused-but-set-variable warnings (new with gcc-4.6)

2011-05-27 Thread Amit Shah
call_type = (flags TCG_CALL_TYPE_MASK); #endif if (ret != TCG_CALL_DUMMY_ARG) { Both these lines have a trailing space. Care to resubmit with Anthony in CC? You can add: Acked-by: Amit Shah amit.s...@redhat.com Amit

Re: [Qemu-devel] block bug: tray status is not updated (and/or guest ignores it)

2011-05-27 Thread Amit Shah
On (Thu) 26 May 2011 [15:29:29], Luiz Capitulino wrote: I'm testing with qemu.git (HEAD aa29141d84d), procedure: 1. Start a VM with: # qemu -hda disks/test.img -enable-kvm -m 1G -cdrom Fedora-14-x86_64-DVD.iso 2. Then inside the guest run: # eject /dev/sr0 mount /dev/sr0 /mnt

Re: [Qemu-devel] block bug: tray status is not updated (and/or guest ignores it)

2011-05-27 Thread Amit Shah
On (Fri) 27 May 2011 [17:01:35], Amit Shah wrote: On (Thu) 26 May 2011 [15:29:29], Luiz Capitulino wrote: I'm testing with qemu.git (HEAD aa29141d84d), procedure: 1. Start a VM with: # qemu -hda disks/test.img -enable-kvm -m 1G -cdrom Fedora-14-x86_64-DVD.iso 2

Re: [Qemu-devel] block bug: tray status is not updated (and/or guest ignores it)

2011-05-27 Thread Amit Shah
On (Fri) 27 May 2011 [17:04:30], Amit Shah wrote: On (Fri) 27 May 2011 [17:01:35], Amit Shah wrote: On (Thu) 26 May 2011 [15:29:29], Luiz Capitulino wrote: I'm testing with qemu.git (HEAD aa29141d84d), procedure: 1. Start a VM with: # qemu -hda disks/test.img -enable-kvm

Re: [Qemu-devel] Booting custom kernel in qemu

2011-05-27 Thread Amit Shah
On (Thu) 26 May 2011 [21:59:01], Apelete Seketeli wrote: Hello, I'm trying to boot a custom linux kernel in qemu, and I plan to contribute the necessary work to make it work (this is the first step I'm taking to add OS support in qemu). I'm totally new to qemu, and I haven't found enough

Re: [Qemu-devel] [PATCH 0/2] Fix unused-but-set-variable warnings

2011-05-30 Thread Amit Shah
On (Mon) 30 May 2011 [12:28:01], Christophe Fergeau wrote: Hi, Here are Hans's patches split and with the various issues that were pointed out fixed. I'm not sure how I'm supposed to handle acks, original author, ... when reworking patches this way, let me know if I should proceed

Re: [Qemu-devel] [PATCH 0/2] Fix unused-but-set-variable warnings

2011-05-30 Thread Amit Shah
On (Mon) 30 May 2011 [15:56:28], Christophe Fergeau wrote: On Mon, May 30, 2011 at 04:23:43PM +0530, Amit Shah wrote: You should keep From: as the same person, keep his Signed-off-by, add your Signed-off-by and mention what you have changed in the series. Hans's patches didn't have a S-o-b

Re: [Qemu-devel] [PATCH 2/3] QMP: Add BLOCK_MEDIA_EJECT event documentation

2011-05-31 Thread Amit Shah
On (Mon) 30 May 2011 [16:54:22], Markus Armbruster wrote: Luiz Capitulino lcapitul...@redhat.com writes: ... The monitor command 'eject' already caused a lot of confusion, please don't make the same mistake in this event name. Even though I know more or less what eject can mean in qemu,

Re: [Qemu-devel] [RFC 05/10] QMP: Introduce the blockdev-tray-open command

2011-06-06 Thread Amit Shah
On (Fri) 03 Jun 2011 [16:03:57], Luiz Capitulino wrote: +static int tray_open(const char *device, int remove, int force) +{ +BlockDriverState *bs; + +bs = bdrv_removable_find(device); +if (!bs) { +return -1; +} + +if (bdrv_eject(bs, 1, force) 0) { +

Re: [Qemu-devel] [RFC 07/10] QMP: Introduce the blockdev-media-insert command

2011-06-06 Thread Amit Shah
On (Fri) 03 Jun 2011 [16:03:59], Luiz Capitulino wrote: +static int media_insert(const char *device, const char *mediafile, +const char *format) +{ +BlockDriver *drv = NULL; +BlockDriverState *bs; +int bdrv_flags; + +bs =

Re: [Qemu-devel] [RFC 10/10] QMP/HMP: change: Use QMP tray commands

2011-06-06 Thread Amit Shah
On (Fri) 03 Jun 2011 [16:04:02], Luiz Capitulino wrote: This commit rewrites change in terms of blockdev-tray-open, blockdev-media-insert and blockdev-tray-close. There should be no visible changes in HMP or QMP, except that the use of this command causes the BLOCK_TRAY_OPEN *and*

Re: [Qemu-devel] [RFC 05/10] QMP: Introduce the blockdev-tray-open command

2011-06-07 Thread Amit Shah
On (Mon) 06 Jun 2011 [11:38:03], Luiz Capitulino wrote: On Mon, 6 Jun 2011 17:10:32 +0530 Amit Shah amit.s...@redhat.com wrote: On (Fri) 03 Jun 2011 [16:03:57], Luiz Capitulino wrote: +static int tray_open(const char *device, int remove, int force) +{ +BlockDriverState *bs

Re: [Qemu-devel] [RFC 10/10] QMP/HMP: change: Use QMP tray commands

2011-06-07 Thread Amit Shah
On (Mon) 06 Jun 2011 [11:45:06], Luiz Capitulino wrote: On Mon, 6 Jun 2011 17:18:31 +0530 Amit Shah amit.s...@redhat.com wrote: On (Fri) 03 Jun 2011 [16:04:02], Luiz Capitulino wrote: This commit rewrites change in terms of blockdev-tray-open, blockdev-media-insert and blockdev-tray

Re: [Qemu-devel] [PATCH] virtio-serial: Fix segfault on guest boot

2011-06-17 Thread Amit Shah
On (Thu) 16 Jun 2011 [13:38:49], Luiz Capitulino wrote: If I start qemu with: # qemu -hda disks/test.img -enable-kvm -m 1G -snapshot \ -device virtio-serial \ -chardev socket,host=localhost,port=1234,server,nowait,id=foo \ -device

Re: [Qemu-devel] [PATCH] virtio-serial: Fix segfault on guest boot

2011-06-17 Thread Amit Shah
On (Fri) 17 Jun 2011 [09:47:31], Markus Armbruster wrote: Amit Shah amit.s...@redhat.com writes: On (Thu) 16 Jun 2011 [13:38:49], Luiz Capitulino wrote: If I start qemu with: # qemu -hda disks/test.img -enable-kvm -m 1G -snapshot \ -device virtio-serial \ -chardev

Re: [Qemu-devel] [PATCH] virtio-serial: Fix segfault on guest boot

2011-06-17 Thread Amit Shah
On (Fri) 17 Jun 2011 [10:16:44], Luiz Capitulino wrote: On Fri, 17 Jun 2011 12:17:36 +0530 Amit Shah amit.s...@redhat.com wrote: On (Thu) 16 Jun 2011 [13:38:49], Luiz Capitulino wrote: If I start qemu with: # qemu -hda disks/test.img -enable-kvm -m 1G -snapshot

Re: [Qemu-devel] [PATCH] virtio-serial: Fix segfault on guest boot

2011-06-17 Thread Amit Shah
On (Fri) 17 Jun 2011 [15:08:11], Luiz Capitulino wrote: if (!cpkt.value) { -error_report(virtio-serial-bus: Guest failure in adding device %s\n, - vser-bus.qbus.name); -break; +error_report(virtio-serial-bus:

Re: [Qemu-devel] unix domain socket communication with guests

2011-06-21 Thread Amit Shah
On (Mon) 20 Jun 2011 [18:24:38], Joel Uckelman wrote: I'm trying to set up a unix domain socket with a guest on one end and the host on the other, where the server is running on and bound to the socket on the guest. I've been able to get the reverse, where the server is running on the host,

Re: [Qemu-devel] [PATCH v2] virtio-serial: Fix segfault on guest boot

2011-06-21 Thread Amit Shah
On (Fri) 17 Jun 2011 [15:58:08], Luiz Capitulino wrote: If I start qemu with: # qemu -hda disks/test.img -enable-kvm -m 1G -snapshot \ -device virtio-serial \ -chardev socket,host=localhost,port=1234,server,nowait,id=foo \ -device

Re: [Qemu-devel] [PATCH] virtio-serial: Fix segfault on guest boot

2011-06-21 Thread Amit Shah
On (Sun) 19 Jun 2011 [00:43:20], Blue Swirl wrote: On Sat, Jun 18, 2011 at 6:42 AM, Amit Shah amit.s...@redhat.com wrote: On (Fri) 17 Jun 2011 [15:08:11], Luiz Capitulino wrote:          if (!cpkt.value) { -            error_report(virtio-serial-bus: Guest failure in adding

Re: [Qemu-devel] unix domain socket communication with guests

2011-06-23 Thread Amit Shah
On (Thu) 23 Jun 2011 [17:37:50], Joel Uckelman wrote: On Tue, Jun 21, 2011 at 10:47 AM, Amit Shah amit.s...@redhat.com wrote: On (Mon) 20 Jun 2011 [18:24:38], Joel Uckelman wrote: I'm trying to set up a unix domain socket with a guest on one end and the host on the other, where the server

[Qemu-devel] [PULL] virtio-serial: Fix segfault on start

2011-06-27 Thread Amit Shah
Hello, This fixes a segfault at startup regression debugged and fixed by Luiz. Please pull. The following changes since commit f26e428da505709ec03b2ed2c9eb3db82b30bd7b: Fix MinGW compilation when --enable-vnc-jpeg is specified (2011-06-26 20:19:38 +) are available in the git

Re: [Qemu-devel] serial input with -serial stdio

2011-06-27 Thread Amit Shah
Hello, On (Fri) 24 Jun 2011 [02:22:44], Edgar E. Iglesias wrote: Hi, Tried to stream 2K of data into a guest via an emulated serial port backed by -serial stdio but it failed. Looks like data flows for a while, then suddenly even though the last call to can_rceive returns +, nothing comes.

Re: [Qemu-devel] unix domain socket communication with guests

2011-06-27 Thread Amit Shah
On (Fri) 24 Jun 2011 [12:54:07], Joel Uckelman wrote: On Fri, Jun 24, 2011 at 4:54 AM, Amit Shah amit.s...@redhat.com wrote: I guess this means I need to get networking running on the guest so that it has a port visible to the host on which my server can listen. Is there a guide somewhere

Re: [Qemu-devel] 80-column rule and breaking output statements

2011-06-27 Thread Amit Shah
On (Sun) 26 Jun 2011 [20:43:16], Blue Swirl wrote: On Wed, Jun 22, 2011 at 7:53 AM, Amit Shah amit.s...@redhat.com wrote: [snip] From dec93d9eccd639f7bfd1343dca65fa112eb19e3e Mon Sep 17 00:00:00 2001 Message-Id: dec93d9eccd639f7bfd1343dca65fa112eb19e3e.1308718380.git.amit.s...@redhat.com

Re: [Qemu-devel] [PATCH 0/4] A few cleanups of qdev users

2011-06-27 Thread Amit Shah
On (Fri) 24 Jun 2011 [13:57:28], Markus Armbruster wrote: Ping? There were a couple of things: port 0, guest on, host off, throttle off guest on/off, host on/off doesn't convey much -- what's on/off? Also, 'throttle' could be 'thottled'? Amit

Re: [Qemu-devel] [PATCH v2] virtio-serial: Fix segfault on guest boot

2011-06-28 Thread Amit Shah
On (Wed) 22 Jun 2011 [09:53:35], Luiz Capitulino wrote: On Wed, 22 Jun 2011 09:49:22 +0530 Amit Shah amit.s...@redhat.com wrote: -port = find_port_by_id(vser, ldl_p(gcpkt-id)); -if (!port cpkt.event != VIRTIO_CONSOLE_DEVICE_READY) -return; - -info

Re: [Qemu-devel] [PATCH 0/4] A few cleanups of qdev users

2011-06-28 Thread Amit Shah
On (Mon) 27 Jun 2011 [14:36:11], Markus Armbruster wrote: Amit Shah amit.s...@redhat.com writes: On (Fri) 24 Jun 2011 [13:57:28], Markus Armbruster wrote: Ping? There were a couple of things: port 0, guest on, host off, throttle off guest on/off, host on/off doesn't

Re: [Qemu-devel] [PATCH 0/4] A few cleanups of qdev users

2011-06-28 Thread Amit Shah
On (Tue) 28 Jun 2011 [14:24:32], Markus Armbruster wrote: Amit Shah amit.s...@redhat.com writes: On (Mon) 27 Jun 2011 [14:36:11], Markus Armbruster wrote: Amit Shah amit.s...@redhat.com writes: On (Fri) 24 Jun 2011 [13:57:28], Markus Armbruster wrote: Ping? There were

Re: [Qemu-devel] Query on the License of qemu

2011-06-29 Thread Amit Shah
On (Tue) 28 Jun 2011 [10:49:03], 박재민 wrote: Dear All, This is Jaemin Park, who delves into qemu. I have 2 questions about the license of qemu. Legal questions should go to lawyers, not developers. Amit

<    2   3   4   5   6   7   8   9   10   11   >