On (Tue) 28 Feb 2012 [15:31:07], Orit Wasserman wrote:
Otherwise we crash on error.
A description on how to reproduce the crash would be nice.
Signed-off-by: Orit Wasserman owass...@redhat.com
Signed-off-by: Ulrich Obergfell uober...@redhat.com
Acked-by: Amit Shah amit.s...@redhat.com
...
3) migrate from 1 to 2.
Thanks.
Acked-by: Amit Shah amit.s...@redhat.com
Amit
On (Sun) 11 Mar 2012 [17:52:59], Michael Tokarev wrote:
In case of more than one control message, the code will use
size of the largest message so far for all subsequent messages,
instead of using size of current one. Fix it.
Makes sense. How did you detect this? Any reproducible test-case?
On (Mon) 12 Mar 2012 [13:22:22], Michael Tokarev wrote:
On 12.03.2012 12:59, Amit Shah wrote:
On (Sun) 11 Mar 2012 [17:52:59], Michael Tokarev wrote:
In case of more than one control message, the code will use
size of the largest message so far for all subsequent messages,
instead
On (Mon) 12 Mar 2012 [15:44:07], Michael Tokarev wrote:
On 12.03.2012 15:06, Amit Shah wrote:
On (Mon) 12 Mar 2012 [13:22:22], Michael Tokarev wrote:
On 12.03.2012 12:59, Amit Shah wrote:
On (Sun) 11 Mar 2012 [17:52:59], Michael Tokarev wrote:
In case of more than one control message
On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote:
At 03/13/2012 06:47 PM, Avi Kivity Wrote:
On 03/13/2012 11:18 AM, Daniel P. Berrange wrote:
On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity wrote:
On 03/12/2012 11:04 AM, Wen Congyang wrote:
Do you have any other comments about
On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote:
At 03/14/2012 05:24 PM, Avi Kivity Wrote:
On 03/14/2012 10:29 AM, Wen Congyang wrote:
At 03/13/2012 06:47 PM, Avi Kivity Wrote:
On 03/13/2012 11:18 AM, Daniel P. Berrange wrote:
On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi Kivity
On (Wed) 14 Mar 2012 [18:04:40], Wen Congyang wrote:
At 03/14/2012 05:51 PM, Amit Shah Wrote:
On (Wed) 14 Mar 2012 [16:29:50], Wen Congyang wrote:
At 03/13/2012 06:47 PM, Avi Kivity Wrote:
On 03/13/2012 11:18 AM, Daniel P. Berrange wrote:
On Mon, Mar 12, 2012 at 12:33:33PM +0200, Avi
On (Wed) 14 Mar 2012 [18:52:07], Wen Congyang wrote:
At 03/14/2012 06:37 PM, Amit Shah Wrote:
On (Wed) 14 Mar 2012 [17:53:00], Wen Congyang wrote:
At 03/14/2012 05:24 PM, Avi Kivity Wrote:
On 03/14/2012 10:29 AM, Wen Congyang wrote:
At 03/13/2012 06:47 PM, Avi Kivity Wrote:
On 03/13
virtio
There are ways to extend the device to be more generic and collect
entropy from other sources, but this is simple enough and works for now.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
Makefile.objs |1 +
hw/pci.h|1 +
hw/virtio-pci.c | 50 +
hw
On (Wed) 16 May 2012 [13:38:06], Paolo Bonzini wrote:
Il 16/05/2012 13:30, Amit Shah ha scritto:
hw-obj-$(CONFIG_VIRTIO) += virtio-console.o
+hw-obj-$(CONFIG_VIRTIO) += virtio-rng.o
This needs to be conditional on CONFIG_LINUX too.
Right.
Thanks,
Amit
On (Wed) 16 May 2012 [14:45:34], Daniel P. Berrange wrote:
On Wed, May 16, 2012 at 08:24:22AM -0500, Anthony Liguori wrote:
On 05/16/2012 06:30 AM, Amit Shah wrote:
The Linux kernel already has a virtio-rng driver, this is the device
implementation.
When Linux needs more entropy
/16/2012 06:30 AM, Amit Shah wrote:
The Linux kernel already has a virtio-rng driver, this is the device
implementation.
When Linux needs more entropy, it puts a buffer in the vq. We then put
entropy into that buffer, and push it back to the guest.
Feeding randomness from host's /dev/urandom
On (Wed) 16 May 2012 [08:24:22], Anthony Liguori wrote:
On 05/16/2012 06:30 AM, Amit Shah wrote:
The Linux kernel already has a virtio-rng driver, this is the device
implementation.
When Linux needs more entropy, it puts a buffer in the vq. We then put
entropy into that buffer, and push
On (Thu) 17 May 2012 [08:49:44], Daniel P. Berrange wrote:
On Wed, May 16, 2012 at 01:58:34PM -0500, Anthony Liguori wrote:
On 05/16/2012 01:42 PM, Luiz Capitulino wrote:
On Wed, 16 May 2012 11:10:47 +0100
Daniel P. Berrangeberra...@redhat.com wrote:
From: Daniel P.
On (Mon) 21 May 2012 [12:29:52], Daniel P. Berrange wrote:
On Mon, May 21, 2012 at 04:44:38PM +0530, Amit Shah wrote:
On (Thu) 17 May 2012 [08:49:44], Daniel P. Berrange wrote:
On Wed, May 16, 2012 at 01:58:34PM -0500, Anthony Liguori wrote:
On 05/16/2012 01:42 PM, Luiz Capitulino wrote
On (Wed) 16 May 2012 [08:48:20], Anthony Liguori wrote:
On 05/16/2012 08:45 AM, Daniel P. Berrange wrote:
On Wed, May 16, 2012 at 08:24:22AM -0500, Anthony Liguori wrote:
On 05/16/2012 06:30 AM, Amit Shah wrote:
The Linux kernel already has a virtio-rng driver, this is the device
On (Wed) 16 May 2012 [13:24:10], Anthony Liguori wrote:
On 05/16/2012 12:26 PM, Amit Shah wrote:
On (Wed) 16 May 2012 [14:45:34], Daniel P. Berrange wrote:
On Wed, May 16, 2012 at 08:24:22AM -0500, Anthony Liguori wrote:
On 05/16/2012 06:30 AM, Amit Shah wrote:
The Linux kernel already has
On (Wed) 16 May 2012 [13:23:11], Anthony Liguori wrote:
On 05/16/2012 12:21 PM, Amit Shah wrote:
On (Wed) 16 May 2012 [08:24:22], Anthony Liguori wrote:
On 05/16/2012 06:30 AM, Amit Shah wrote:
The Linux kernel already has a virtio-rng driver, this is the device
implementation.
When Linux
On (Mon) 21 May 2012 [17:59:52], Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
After setting a balloon target value, applications have to
continually poll 'query-balloon' to determine whether the
guest has reacted to this request. The virtio-balloon backend
knows
On (Mon) 21 May 2012 [20:50:55], Daniel P. Berrange wrote:
On Tue, May 22, 2012 at 01:14:59AM +0530, Amit Shah wrote:
On (Mon) 21 May 2012 [17:59:52], Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
After setting a balloon target value, applications have
On (Mon) 21 May 2012 [15:34:59], Anthony Liguori wrote:
On 05/21/2012 02:39 PM, Amit Shah wrote:
On (Wed) 16 May 2012 [13:23:11], Anthony Liguori wrote:
On 05/16/2012 12:21 PM, Amit Shah wrote:
On (Wed) 16 May 2012 [08:24:22], Anthony Liguori wrote:
On 05/16/2012 06:30 AM, Amit Shah wrote
for notifying listeners about entropy needed and
the bytes asked for by the guest.
* Add s390 code
Please review, and apply if appropriate.
Amit Shah (1):
virtio-rng: hardware random number generator device
Makefile.objs|1 +
hw/pci.h |1 +
hw/s390-virtio-bus.c
asked by the guest:
{timestamp: {seconds: 1337966878, microseconds: 517009}, \
event: ENTROPY_NEEDED, data: {bytes: 64}}
Signed-off-by: Amit Shah amit.s...@redhat.com
---
Makefile.objs|1 +
hw/pci.h |1 +
hw/s390-virtio-bus.c | 35 +
hw/s390-virtio-bus.h
On (Fri) 25 May 2012 [15:00:53], Anthony Liguori wrote:
On 05/25/2012 02:32 PM, Amit Shah wrote:
The Linux kernel already has a virtio-rng driver, this is the device
implementation.
When the guest asks for entropy from the virtio hwrng, it puts a buffer
in the vq. We then put entropy
On (Mon) 28 May 2012 [09:33:57], Daniel P. Berrange wrote:
On Sat, May 26, 2012 at 01:02:49AM +0530, Amit Shah wrote:
The Linux kernel already has a virtio-rng driver, this is the device
implementation.
When the guest asks for entropy from the virtio hwrng, it puts a buffer
in the vq
Hello,
The Call for Proposals for the Linux Plumbers Conf 2012 is out. We're
looking for speakers to talk at the Virtualization microconference as
well as the main conference. The deadline for proposal submissions is
1st May. This year's edition of LPC is co-located with LinuxCon NA
and will
On (Mon) 23 Apr 2012 [14:26:23], Alon Levy wrote:
We could drop the features parameter but that's a little more work and
it's not really needed.
Signed-off-by: Alon Levy al...@redhat.com
Michael, can you ack this? I'm running these through the test suite
and will send them both once
with
VIRTIO_CONFIG_S_DRIVER_OK by even older non multiport drivers.
[Amit: Add comment, tweak summary]
Signed-off-by: Alon Levy al...@redhat.com
Acked-by: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c | 29
Hi,
Please pull for a virtio-serial fix.
The following changes since commit 3c30dd5a68e9fee6af67cfd0d14ed7520820f36a:
target-arm: Move reset handling to arm_cpu_reset (2012-04-21 18:13:22 +)
are available in the git repository at:
On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote:
On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote:
From: Alon Levy al...@redhat.com
guest_connected should be false before guest driver initialization, and
true after, both for multiport aware and non multiport aware
On (Tue) 24 Apr 2012 [13:49:53], Michael S. Tsirkin wrote:
On Tue, Apr 24, 2012 at 03:56:44PM +0530, Amit Shah wrote:
On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote:
On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote:
From: Alon Levy al...@redhat.com
On (Tue) 24 Apr 2012 [14:21:36], Michael S. Tsirkin wrote:
On Tue, Apr 24, 2012 at 04:44:10PM +0530, Amit Shah wrote:
On (Tue) 24 Apr 2012 [13:49:53], Michael S. Tsirkin wrote:
On Tue, Apr 24, 2012 at 03:56:44PM +0530, Amit Shah wrote:
On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin
When a guest driver resets the virtio status to not ready, or when qemu
is reset, reset the guest_connected bit and let ports know if they have
the guest_close() callback registered.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c | 28
1
When a guest driver resets the virtio status to not ready, or when qemu
is reset, reset all ports' guest_connected bit and let port users know
of this event if they have the guest_close() callback registered.
Reviewed-by: Alon Levy al...@redhat.com
Signed-off-by: Amit Shah amit.s...@redhat.com
guest_connected init before driver init
Amit Shah (1):
virtio-serial-bus: Unset guest_connected at reset and driver reset
hw/virtio-serial-bus.c | 57 +--
1 files changed, 49 insertions(+), 8 deletions(-)
--
1.7.7.6
with
VIRTIO_CONFIG_S_DRIVER_OK by even older non multiport drivers.
[Amit: Add comment, tweak summary, only set guest_connected and not
reset it as a side-effect.]
Signed-off-by: Alon Levy al...@redhat.com
Acked-by: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Amit Shah amit.s
When a guest driver resets the virtio status to not ready, or when qemu
is reset, reset all ports' guest_connected bit and let port users know
of this event if they have the guest_close() callback registered.
Reviewed-by: Alon Levy al...@redhat.com
Signed-off-by: Amit Shah amit.s...@redhat.com
On (Tue) 21 Aug 2012 [11:47:16], Rusty Russell wrote:
On Thu, 9 Aug 2012 15:46:20 +0530, Amit Shah amit.s...@redhat.com wrote:
Hi,
On (Tue) 24 Jul 2012 [11:36:57], Yoshihiro YUNOMAE wrote:
Hi All,
The following patch set provides a low-overhead system for collecting
kernel
On (Thu) 09 Aug 2012 [21:30:29], Yoshihiro YUNOMAE wrote:
Hi All,
The following patch set provides a low-overhead system for collecting kernel
tracing data of guests by a host in a virtualization environment.
ACK this series.
I ran it through the virtio-serial test suite, and there's no
On (Sun) 30 Sep 2012 [20:05:16], Marcelo Tosatti wrote:
On Thu, Sep 20, 2012 at 09:46:41AM -0300, Marcelo Tosatti wrote:
On Thu, Sep 20, 2012 at 01:55:20PM +0530, Amit Shah wrote:
Commit f349c12c0434e29c79ecde89029320c4002f7253 added the guest stop
notification, but it did it in a way
On (Sun) 30 Sep 2012 [21:50:07], Amos Kong wrote:
- Original Message -
On Thu, Sep 20, 2012 at 09:46:41AM -0300, Marcelo Tosatti wrote:
On Thu, Sep 20, 2012 at 01:55:20PM +0530, Amit Shah wrote:
Commit f349c12c0434e29c79ecde89029320c4002f7253 added the guest
stop
On (Wed) 17 Oct 2012 [17:14:14], Eduardo Habkost wrote:
On Wed, Jul 15, 2009 at 01:43:31PM +0200, Gerd Hoffmann wrote:
[...]
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
new file mode 100644
index 000..8b0d0ff
--- /dev/null
+++ b/hw/qdev-properties.c
@@ -0,0 +1,246 @@
out, and the result is:
0d8d7690850eb0cf2b2b60933cf47669a6b6f18f is the first bad commit
commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f
Author: Amit Shah amit.s...@redhat.com
Date: Tue Sep 25 00:05:15 2012 +0530
virtio: Introduce virtqueue_get_avail_bytes
On (Tue) 02 Apr 2013 [07:52:19], Anthony Liguori wrote:
Amit Shah amit.s...@redhat.com writes:
On (Mon) 01 Apr 2013 [09:02:46], Anthony Liguori wrote:
Amit Shah amit.s...@redhat.com writes:
Opening backends in non-blocking mode isn't necessary, we don't do
anything while waiting
On (Fri) 29 Mar 2013 [10:02:39], fred.kon...@greensocs.com wrote:
From: KONRAD Frederic fred.kon...@greensocs.com
Here the virtio-serial-pci is modified for the new API. The device
virtio-serial-pci extends virtio-pci. It creates and connects a
virtio-serial during the init. The properties
On (Fri) 29 Mar 2013 [10:02:37], fred.kon...@greensocs.com wrote:
From: KONRAD Frederic fred.kon...@greensocs.com
This is the next part of virtio-refactoring.
Basically it creates virtio-serial device which extends virtio-device.
Then a virtio-serial can be connected on a virtio-bus.
On (Fri) 05 Apr 2013 [17:59:33], Paolo Bonzini wrote:
The character backend refactoring introduced an undesirable busy wait.
The busy wait happens if can_read returns zero and there is data available
on the character device's file descriptor. Then, the I/O watch will
fire continuously and,
On (Wed) 03 Apr 2013 [15:08:40], Anthony Liguori wrote:
Amit Shah amit.s...@redhat.com writes:
On (Tue) 02 Apr 2013 [07:52:19], Anthony Liguori wrote:
Amit Shah amit.s...@redhat.com writes:
backends/rng-random.c:44:entropy_available: assertion failed: (len !=
-1)
without
are you ok with that?
Thanks, this looks good.
Acked-by: Amit Shah amit.s...@redhat.com
Amit
On (Wed) 10 Apr 2013 [15:23:27], Paolo Bonzini wrote:
After attaching the source, we have to remove the reference we hold
to it, because we do not hold anymore a pointer to the source.
If we do not do this, removing the source will not finalize it and
will not drop the real I/O watch source.
On (Thu) 11 Apr 2013 [10:58:30], Paolo Bonzini wrote:
Il 10/04/2013 19:59, Amit Shah ha scritto:
On (Wed) 10 Apr 2013 [15:23:27], Paolo Bonzini wrote:
After attaching the source, we have to remove the reference we hold
to it, because we do not hold anymore a pointer to the source.
If we
made basic tests (with linux guests) on:
* qemu-system-i386
Looks OK.
Acked-by: Amit Shah amit.s...@redhat.com
Thanks,
Amit
.
Reported-by: yunpingzheng yunzh...@redhat.com
Signed-off-by: Amit Shah amit.s...@redhat.com
---
backends/rng-random.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/backends/rng-random.c b/backends/rng-random.c
index d5761f2..830360c 100644
--- a/backends/rng-random.c
+++ b/backends/rng
On (Tue) 16 Apr 2013 [15:51:30], Andreas Färber wrote:
Am 16.04.2013 12:28, schrieb Amit Shah:
Not handling EAGAIN triggers the assert
qemu/backends/rng-random.c:44:entropy_available: assertion failed: (len !=
-1)
Aborted (core dumped)
This happens when starting a guest
- Bugfix: rng_backend_request_entropy() in chr_read() should pass len,
not size
- Do not request for more entropy in chr_read() once the current
request is served; there are other ways this notification will go
out.
Amit Shah (1):
virtio-rng: hardware random number generator device
From: Anthony Liguori aligu...@us.ibm.com
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
include/qemu/object.h | 16 ++
qom/object.c | 56 +
2 files changed, 72 insertions(+), 0 deletions(-)
diff --git
From: Anthony Liguori aligu...@us.ibm.com
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
hw/qdev.c | 36 +++-
1 files changed, 35 insertions(+), 1 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index 9b9aba3..5e34c22 100644
--- a/hw/qdev.c
+++
From: Anthony Liguori aligu...@us.ibm.com
This will create a new QOM object in the '/objects' path. Note that properties
are set in order which allows for simple objects to be initialized entirely
with this option and then realized.
This option is roughly equivalent to -device but for things
From: Anthony Liguori aligu...@us.ibm.com
This backend talks EGD to a CharDriverState. A typical way to invoke this would
be:
qemu -chardev socket,host=localhost,port=1024,id=chr0 \
-object rng-egd,chardev=chr0,id=egd0 \
-device virtio-rng-pci,rng=egd0
Signed-off-by: Anthony Liguori
From: Anthony Liguori aligu...@us.ibm.com
In order to create qdev objects via -late-object, we almost always have to
specify the parent_bus which is usually created during machine init. Until we
properly support two stage init, introduce a -late-object option that allows for
creation of objects
From: Anthony Liguori aligu...@us.ibm.com
The filename can be overridden but it expects a non-blocking source of entropy.
A typical invocation would be:
qemu -object rng-urandom,id=rng0 -device virtio-rng-pci,rng=rng0
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
The Linux kernel already has a virtio-rng driver, this is the device
implementation.
When the guest asks for entropy from the virtio hwrng, it puts a buffer
in the vq. We then put entropy into that buffer, and push it back to
the guest.
Signed-off-by: Amit Shah amit.s...@redhat.com
Signed-off
From: Anthony Liguori aligu...@us.ibm.com
This is the backend used by devices that need to request entropy.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
Makefile.objs |2 +
backends/Makefile.objs |1 +
backends/rng.c | 93
On (Fri) 26 Oct 2012 [13:24:06], Anthony Liguori wrote:
H. Peter Anvin h...@zytor.com writes:
On 10/26/2012 08:42 AM, Anthony Liguori wrote:
Is /dev/random even appropriate to feed rngd?
rngd needs _a lot_ of entropy to even start working. Its randomness
test works in groups of
On (Fri) 26 Oct 2012 [09:43:34], Anthony Liguori wrote:
Hi,
This series implements the backend and frontend infrastructure for virtio-rng.
This is similar to previous series sent out by both Amit and myself although
it
has been trimmed down considerably.
In terms of backends, a file and
On (Tue) 23 Oct 2012 [14:55:03], Stefan Hajnoczi wrote:
On Mon, Oct 22, 2012 at 06:50:00AM -0700, Edivaldo de Araujo Pereira wrote:
I didn't take enough time to uderstand the code, so unfortunately I fear
there is not much I could do to solve the problem, apart from trying your
On (Thu) 01 Nov 2012 [14:04:11], Michael S. Tsirkin wrote:
On Thu, Nov 01, 2012 at 02:49:18PM +0530, Amit Shah wrote:
On (Tue) 23 Oct 2012 [14:55:03], Stefan Hajnoczi wrote:
On Mon, Oct 22, 2012 at 06:50:00AM -0700, Edivaldo de Araujo Pereira
wrote:
I didn't take enough time
limiting lookahead, and
use in virtqueue_avail_bytes.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Reported-by: Edivaldo de Araujo Pereira edivaldoapere...@yahoo.com.br
Acked-by: Amit Shah amit.s...@redhat.com
Amit
Fix typos and update comments to match current implementation.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-rng.c|1 -
include/qemu/rng.h |6 +++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/hw/virtio-rng.c b/hw/virtio-rng.c
index bb19cfa..290b2b6
Hey Anthony,
Here are the fixes for the virtio-rng code -- ideally these should be
folded in the series before you merge, but if the original series is
ready to apply, these can go in as follow-on patches.
Amit Shah (3):
virtio-rng: use virtqueue_get_avail_bytes, fix migration
virtio-rng
Popping an elem from the vq just to find out its length causes problems
with save/load later on. Use the new virtqueue_get_avail_bytes()
function instead, saves us the complexity in the migration code.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-rng.c | 69
If we just got a few bytes from the backends, but the guest is ready to
accept more, don't poke the backends once more for more bytes; it
already knows (from the request in handle_input()).
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-rng.c | 10 --
1 files changed, 0
On (Wed) 14 Nov 2012 [15:09:07], Alon Levy wrote:
Add a new timer based on vm_clock for 1 ns in the future from post_load
to do the event send in case host_connected differs between migration
source and target.
RHBZ: 867366
Signed-off-by: Alon Levy al...@redhat.com
---
as well, but that's for later.
Please review and apply.
Amit Shah (4):
virtio-rng: use virtqueue_get_avail_bytes, fix migration
virtio-rng: remove extra request for entropy
virtio-rng: disable timer on device removal
virtio-rng: fix typos, comments
hw/virtio-rng.c| 92
If we got fewer bytes from the backend than requested, don't poke the
backend for more bytes; the guest will ask for more (or if the guest has
already asked for more, the backend knows about it via handle_input()).
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-rng.c | 7 ---
1
Disable the rate-limit timer on device remove (e.g. hot-unplug).
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-rng.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/virtio-rng.c b/hw/virtio-rng.c
index cf5a8ff..c8a6da7 100644
--- a/hw/virtio-rng.c
+++ b/hw/virtio-rng.c
Popping an elem from the vq just to find out its length causes problems
with save/load later on. Use the new virtqueue_get_avail_bytes()
function instead, saves us the complexity in the migration code, as well
as makes the migration endian-safe.
Signed-off-by: Amit Shah amit.s...@redhat.com
Fix typos, whitespace and update comments to match current
implementation.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-rng.c| 7 +++
include/qemu/rng.h | 6 +++---
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/hw/virtio-rng.c b/hw/virtio-rng.c
index
as well, but that's for later.
v2:
* fix typo in patch 4
* travel back to present, fix cover letter subject line
* add Anthony's reviewed-by tags to patches.
Please apply.
Amit Shah (4):
virtio-rng: use virtqueue_get_avail_bytes, fix migration
virtio-rng: remove extra request for entropy
Popping an elem from the vq just to find out its length causes problems
with save/load later on. Use the new virtqueue_get_avail_bytes()
function instead, saves us the complexity in the migration code, as well
as makes the migration endian-safe.
Signed-off-by: Amit Shah amit.s...@redhat.com
On (Tue) 20 Nov 2012 [19:43:16], Anthony Liguori wrote:
* The backend does not need to pass the full amount of data to
@receive_entropy
- * but will pass at a value greater than 0.
+ * but will pass a a value greater than 0.
Your typo fix has a typo.
Woops, series re-sent.
On (Tue) 20 Nov 2012 [19:44:55], Anthony Liguori wrote:
Amit Shah amit.s...@redhat.com writes:
Popping an elem from the vq just to find out its length causes problems
with save/load later on. Use the new virtqueue_get_avail_bytes()
function instead, saves us the complexity
If we got fewer bytes from the backend than requested, don't poke the
backend for more bytes; the guest will ask for more (or if the guest has
already asked for more, the backend knows about it via handle_input()).
Signed-off-by: Amit Shah amit.s...@redhat.com
Reviewed-by: Anthony Liguori aligu
Disable the rate-limit timer on device remove (e.g. hot-unplug).
Signed-off-by: Amit Shah amit.s...@redhat.com
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
---
hw/virtio-rng.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/virtio-rng.c b/hw/virtio-rng.c
index cf5a8ff..c8a6da7
Fix typos, whitespace and update comments to match current
implementation.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-rng.c| 7 +++
include/qemu/rng.h | 6 +++---
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/hw/virtio-rng.c b/hw/virtio-rng.c
index
On (Wed) 30 Jan 2013 [08:38:50], Anthony Liguori wrote:
Amit Shah amit.s...@redhat.com writes:
Hi Anthony,
I did some basic testing of the char flow control patches from your
char-flow.2 branch. With the following patch applied, things seem to
be working fine. I tested the isa
On (Mon) 11 Feb 2013 [12:37:34], Amit Shah wrote:
On (Wed) 30 Jan 2013 [08:38:50], Anthony Liguori wrote:
Amit Shah amit.s...@redhat.com writes:
Hi Anthony,
I did some basic testing of the char flow control patches from your
char-flow.2 branch. With the following patch applied
.
This is based on a rebased version of an old series of mine plus a
number of improvements from Amit Shah.
This series works fine, resolves the client sockets issue.
Acked-by: Amit Shah amit.s...@redhat.com
Amit
On (Mon) 18 Feb 2013 [15:48:07], Anthony Liguori wrote:
From: Amit Shah amit.s...@redhat.com
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-char.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/qemu-char.c b/qemu-char.c
index e59e580..160bcea 100644
--- a/qemu
On (Tue) 19 Feb 2013 [07:55:36], Anthony Liguori wrote:
Amit Shah amit.s...@redhat.com writes:
On (Mon) 18 Feb 2013 [15:48:07], Anthony Liguori wrote:
From: Amit Shah amit.s...@redhat.com
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-char.c | 7 +++
1 file changed
On (Sun) 23 Dec 2012 [23:35:29], Alon Levy wrote:
The target has not seen the guest_connected event via
spice_chr_guest_open or spice_chr_write, and so spice server wrongly
assumes there is no agent active, while the client continues to send
motion events only by the agent channel, which the
Hi Luiz,
On (Tue) 18 Dec 2012 [18:16:55], Luiz Capitulino wrote:
The auto-ballooning feature automatically performs balloon inflate
or deflate based on host and guest memory pressure. This can help to
avoid swapping or worse in both, host and guest.
Auto-ballooning has a host and a guest
On (Mon) 14 Jan 2013 [09:58:30], Luiz Capitulino wrote:
On Sat, 12 Jan 2013 02:02:32 +0530
Amit Shah amit.s...@redhat.com wrote:
Hi Luiz,
On (Tue) 18 Dec 2012 [18:16:55], Luiz Capitulino wrote:
The auto-ballooning feature automatically performs balloon inflate
or deflate based
Hi Anthony,
I did some basic testing of the char flow control patches from your
char-flow.2 branch. With the following patch applied, things seem to
be working fine. I tested the isa-serial and virtio-serial devices.
I haven't yet tested with virtio-serial flow control, but at least no
On (Wed) 30 Jan 2013 [08:38:50], Anthony Liguori wrote:
Amit Shah amit.s...@redhat.com writes:
Hi Anthony,
I did some basic testing of the char flow control patches from your
char-flow.2 branch. With the following patch applied, things seem to
be working fine. I tested the isa
.
Patch 4 adds flow control to virtio-serial ports.
With these applied, I tested flow control with virtio-serial ports
with a unix socket backend, and things are working fine.
Amit Shah (4):
char: poll a frontend only if it's writable
char: fix return value of can_read functions on no input
char
If the frontend reports it's not writable, don't start polling it for
data yet.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-char.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-char.c b/qemu-char.c
index 2b714cf..5731d02 100644
--- a/qemu-char.c
+++ b/qemu
When the can_read functions report the frontend isn't ready to accept
data yet, return 'FALSE' instead of 'TRUE'.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-char.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 5731d02
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-char.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/qemu-char.c b/qemu-char.c
index 7fa9372..01b0190 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2484,6 +2484,12 @@ static ssize_t tcp_chr_recv(CharDriverState *chr, char
*buf
901 - 1000 of 1938 matches
Mail list logo
