[Qemu-devel] [PATCH v3 0/9] target-arm: enable qmp-dump-guest-memory

2015-12-15 Thread Andrew Jones
the physical page bitmap is all zeros? Needs qemu and crash debugging. Additional notes: 1) QEMU also has scripts/dump-guest-memory.py, which can and should be updated to support multiple architectures, pagesizes, and physbases. This is currently left as future work. Andrew Jones (9

[Qemu-devel] [PATCH v3 7/9] target-arm: dump-guest-memory: add prfpreg notes for aarch64

2015-12-15 Thread Andrew Jones
Signed-off-by: Andrew Jones <drjo...@redhat.com> --- target-arm/arch_dump.c | 79 +- 1 file changed, 71 insertions(+), 8 deletions(-) diff --git a/target-arm/arch_dump.c b/target-arm/arch_dump.c index dc32d98101004..6cbba92f3d014

[Qemu-devel] [PATCH v3 3/9] dump: allow target to set the page size

2015-12-15 Thread Andrew Jones
This is necessary for targets that don't have TARGET_PAGE_SIZE == real-target-page-size. The target should set the page size to the correct one, if known, or, if not known, to the maximum page size it supports. (No functional change.) Signed-off-by: Andrew Jones <drjo...@redhat.com> ---

[Qemu-devel] [PATCH v3 4/9] dump: allow target to set the physical base

2015-12-15 Thread Andrew Jones
crash assumes the physical base in the kdump subheader of makedumpfile formatted dumps is correct. Zero is not correct for all architectures, so allow it to be changed. (No functional change.) Signed-off-by: Andrew Jones <drjo...@redhat.com> Reviewed-by: Peter Maydell <peter.mayd...@l

[Qemu-devel] [PATCH v3 9/9] target-arm: dump-guest-memory: add vfp notes for arm

2015-12-15 Thread Andrew Jones
gdb won't actually dump these with 'info all-registers' since it first tries to confirm that it should by checking the VFP hwcap in the .auxv note. Well, we don't generate an .auxv note. Signed-off-by: Andrew Jones <drjo...@redhat.com> --- target-arm/arch_dump.

[Qemu-devel] [PATCH v3 5/9] target-arm: introduce aarch64_compat_sp

2015-12-15 Thread Andrew Jones
Signed-off-by: Andrew Jones <drjo...@redhat.com> --- target-arm/cpu.h | 45 + 1 file changed, 45 insertions(+) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 815fef8a30663..9231a9ff3b9c2 100644 --- a/target-arm/cpu.h +++ b/target-arm

[Qemu-devel] [PATCH v3 6/9] target-arm: support QMP dump-guest-memory

2015-12-15 Thread Andrew Jones
Add the support needed for creating prstatus elf notes. This allows us to use QMP dump-guest-memory. Signed-off-by: Andrew Jones <drjo...@redhat.com> --- target-arm/Makefile.objs | 3 +- target-arm/arch_dump.c | 230 +++ target-arm/cpu

[Qemu-devel] [PATCH v3 2/9] dump: qemunotes aren't commonly needed

2015-12-15 Thread Andrew Jones
Only one of three architectures implementing qmp-dump-guest-memory write qemu notes. And, another architecture (arm/aarch64) is coming, which won't use them either. Make the common implementation truly common. (No functional change.) Signed-off-by: Andrew Jones <drjo...@redhat.com> Re

[Qemu-devel] [PATCH v2] trace-events: fix broken format strings

2016-01-05 Thread Andrew Jones
Fixes compiling with --enable-trace-backends Signed-off-by: Andrew Jones <drjo...@redhat.com> --- v2: also remove trailing null strings [Laurent] trace-events | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/trace-events b/trace-events index 6f03638

Re: [Qemu-devel] [PATCH] hw/dma/xilinx_axidma: debug printf fixups

2016-01-05 Thread Andrew Jones
On Tue, Jan 05, 2016 at 07:07:22AM -0700, Eric Blake wrote: > On 01/05/2016 06:22 AM, Andrew Jones wrote: > > (Found by grepping for broken PRI users.) > > > > Signed-off-by: Andrew Jones <drjo...@redhat.com> > > --- > > hw/dma/xilinx_axidma.c | 8

Re: [Qemu-devel] [PATCH] hw/dma/xilinx_axidma: debug printf fixups

2016-01-06 Thread Andrew Jones
On Tue, Jan 05, 2016 at 05:45:57PM -0800, Alistair Francis wrote: > On Tue, Jan 5, 2016 at 7:32 AM, Andrew Jones <drjo...@redhat.com> wrote: > > On Tue, Jan 05, 2016 at 07:07:22AM -0700, Eric Blake wrote: > >> On 01/05/2016 06:22 AM, Andrew Jones wrote: > >> &g

[Qemu-devel] [PATCH] hw/dma/xilinx_axidma: remove dead code

2016-01-06 Thread Andrew Jones
stream_desc_show() (and DEBUG_ENET) appear to be unused, as the function isn't compilable (there are broken PRI format strings). Signed-off-by: Andrew Jones <drjo...@redhat.com> --- hw/dma/xilinx_axidma.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/hw/dma/xilinx_axidma.

Re: [Qemu-devel] [PATCH] trace-events: fix broken format strings

2016-01-05 Thread Andrew Jones
On Tue, Jan 05, 2016 at 03:54:48PM +0100, Laurent Vivier wrote: > > > On 05/01/2016 14:20, Andrew Jones wrote: > > Fixes compiling with --enable-trace-backends > > > > Signed-off-by: Andrew Jones <drjo...@redhat.com> > > --- > > trace-events | 10

[Qemu-devel] [PATCH] trace-events: fix broken format strings

2016-01-05 Thread Andrew Jones
Fixes compiling with --enable-trace-backends Signed-off-by: Andrew Jones <drjo...@redhat.com> --- trace-events | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/trace-events b/trace-events index 6f036384a84f8..e42898d5659d5 100644 --- a/trace-events +++ b

[Qemu-devel] [PATCH] hw/dma/xilinx_axidma: debug printf fixups

2016-01-05 Thread Andrew Jones
(Found by grepping for broken PRI users.) Signed-off-by: Andrew Jones <drjo...@redhat.com> --- hw/dma/xilinx_axidma.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c index b1cfa11356a26..2ab0772cd19ae 100644 --- a/

Re: [Qemu-devel] [PATCH v3 6/9] target-arm: support QMP dump-guest-memory

2015-12-18 Thread Andrew Jones
On Fri, Dec 18, 2015 at 11:59:39AM +, Peter Maydell wrote: > On 15 December 2015 at 22:51, Andrew Jones <drjo...@redhat.com> wrote: > > Add the support needed for creating prstatus elf notes. This > > allows us to use QMP dump-guest-memory. > > > >

Re: [Qemu-devel] [PATCH v3 6/9] target-arm: support QMP dump-guest-memory

2015-12-18 Thread Andrew Jones
On Fri, Dec 18, 2015 at 04:31:13PM +, Peter Maydell wrote: > On 18 December 2015 at 16:05, Andrew Jones <drjo...@redhat.com> wrote: > > On Fri, Dec 18, 2015 at 11:59:39AM +, Peter Maydell wrote: > >> On 15 December 2015 at 22:51, Andrew Jones <drjo...@re

Re: [Qemu-devel] [PATCH v3 6/9] target-arm: support QMP dump-guest-memory

2015-12-18 Thread Andrew Jones
On Fri, Dec 18, 2015 at 06:46:14PM +, Peter Maydell wrote: > On 18 December 2015 at 18:05, Andrew Jones <drjo...@redhat.com> wrote: > > On Fri, Dec 18, 2015 at 04:31:13PM +, Peter Maydell wrote: > >> On 18 December 2015 at 16:05, Andrew Jones <drjo...@redhat.com

[Qemu-devel] [PATCH v2 1/6] qapi-schema: dump-guest-memory: Improve text

2015-11-24 Thread Andrew Jones
dump-guest-memory is supported by more than just x86, however the paging option is not. (No functional change.) Signed-off-by: Andrew Jones <drjo...@redhat.com> Reviewed-by: Eric Blake <ebl...@redhat.com> --- qapi-schema.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH v2 0/6] target-arm: enable qmp-dump-guest-memory

2015-11-24 Thread Andrew Jones
. Andrew Jones (6): qapi-schema: dump-guest-memory: Improve text dump: qemunotes aren't commonly needed dump: allow target to set the page size dump: allow target to set the physical base target-arm: support QMP dump-guest-memory target-arm: dump-guest-memory: add fpregset notes dump.c

[Qemu-devel] [PATCH v2 2/6] dump: qemunotes aren't commonly needed

2015-11-24 Thread Andrew Jones
Only one of three architectures implementing qmp-dump-guest-memory write qemu notes. And, another architecture (arm/aarch64) is coming, which won't use them either. Make the common implementation truly common. (No functional change.) Signed-off-by: Andrew Jones <drjo...@redhat.com> Re

[Qemu-devel] [PATCH v2 4/6] dump: allow target to set the physical base

2015-11-24 Thread Andrew Jones
crash assumes the physical base in the kdump subheader of makedumpfile formatted dumps is correct. Zero is not correct for all architectures, so allow it to be changed. (No functional change.) Signed-off-by: Andrew Jones <drjo...@redhat.com> --- dump.c | 4 ++-- i

[Qemu-devel] [PATCH v2 5/6] target-arm: support QMP dump-guest-memory

2015-11-24 Thread Andrew Jones
Add the support needed for creating prstatus elf notes. This allows us to use QMP dump-guest-memory. Signed-off-by: Andrew Jones <drjo...@redhat.com> --- target-arm/Makefile.objs | 3 +- target-arm/arch_dump.c | 230 +++ target-arm/cpu

[Qemu-devel] [PATCH v2 3/6] dump: allow target to set the page size

2015-11-24 Thread Andrew Jones
This is necessary for targets that don't have TARGET_PAGE_SIZE == real-target-page-size. The target should set the page size to the correct one, if known, or, if not known, to the maximum page size it supports. (No functional change.) Signed-off-by: Andrew Jones <drjo...@redhat.com> ---

[Qemu-devel] [PATCH v2 6/6] target-arm: dump-guest-memory: add fpregset notes

2015-11-24 Thread Andrew Jones
Also refactors note init code to avoid code duplication. Signed-off-by: Andrew Jones <drjo...@redhat.com> --- target-arm/arch_dump.c | 161 ++--- 1 file changed, 139 insertions(+), 22 deletions(-) diff --git a/target-arm/arch_dump.c b/targ

Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory

2015-11-24 Thread Andrew Jones
On Sat, Nov 21, 2015 at 10:05:37AM -0500, Andrew Jones wrote: > On Fri, Nov 20, 2015 at 04:41:21PM -0500, Andrew Jones wrote: > > On Fri, Nov 20, 2015 at 06:19:14PM +, Peter Maydell wrote: > > > On 19 November 2015 at 14:53, Andrew Jones <drjo

Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory

2015-11-24 Thread Andrew Jones
On Tue, Nov 24, 2015 at 09:08:29PM +, Peter Maydell wrote: > On 24 November 2015 at 20:52, Andrew Jones <drjo...@redhat.com> wrote: > > > > I've pulled a v2 together that I'll be testing and posting soon. Here's > > what I decided to do > > > > 1) Th

Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory

2015-11-20 Thread Andrew Jones
On Fri, Nov 20, 2015 at 06:19:14PM +, Peter Maydell wrote: > On 19 November 2015 at 14:53, Andrew Jones <drjo...@redhat.com> wrote: > > Add the support needed for creating prstatus elf notes. This > > allows us to use QMP dump-guest-memory. > > > >

Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory

2015-11-21 Thread Andrew Jones
On Fri, Nov 20, 2015 at 04:41:21PM -0500, Andrew Jones wrote: > On Fri, Nov 20, 2015 at 06:19:14PM +, Peter Maydell wrote: > > On 19 November 2015 at 14:53, Andrew Jones <drjo...@redhat.com> wrote: > > > + > > > +if (is_a64(env)) { > > > > Are

Re: [Qemu-devel] [PATCH REPOST 1/2] dump-guest-memory: add "detach" flag for QMP/HMP interfaces

2015-11-23 Thread Andrew Jones
On Mon, Nov 23, 2015 at 06:07:41PM +0800, Peter Xu wrote: > This patch only add the interfaces, but not implementing them. > > Signed-off-by: Peter Xu > --- > dump.c | 3 ++- > hmp-commands.hx | 5 +++-- > hmp.c| 3 ++- > qapi-schema.json | 3 ++- >

Re: [Qemu-devel] [PATCH REPOST 0/2] Add basic "detach" support for dump-guest-memory

2015-11-23 Thread Andrew Jones
On Mon, Nov 23, 2015 at 05:22:29PM +0100, Laszlo Ersek wrote: > On 11/23/15 11:07, Peter Xu wrote: > > Currently, dump-guest-memory supports synchronous operation only. This patch > > sets are adding "detach" support for it (just like "migrate -d" for > > migration). When "-d" is provided,

Re: [Qemu-devel] [PATCH REPOST 2/2] dump-guest-memory: add basic "detach" support.

2015-11-23 Thread Andrew Jones
On Mon, Nov 23, 2015 at 06:07:42PM +0800, Peter Xu wrote: > This will allow the user specify "-d" (just like command > "migrate") when using "dump-guest-memory" command. When > specified, one background thread is created to do the dump work. > One flag is added to show whether there is a

[Qemu-devel] [PATCH 0/5] target-arm: enable qmp-dump-guest-memory

2015-11-19 Thread Andrew Jones
debugging. Additional notes: 1) QEMU also has scripts/dump-guest-memory.py, which can and should be updated to support multiple architectures, pagesizes, and physbases. This is currently left as future work. [*] https://www.redhat.com/archives/crash-utility/2015-November/msg00031.html Andrew

[Qemu-devel] [PATCH 3/5] dump: allow target to set the page size

2015-11-19 Thread Andrew Jones
This is necessary for targets that don't have TARGET_PAGE_SIZE == real-target-page-size. The target should set the page size to the correct one, if known, or, if not known, to the maximum page size it supports. (No functional change.) Signed-off-by: Andrew Jones <drjo...@redhat.com> ---

[Qemu-devel] [PATCH 2/5] dump: qemunotes aren't commonly needed

2015-11-19 Thread Andrew Jones
Only one of three architectures implementing qmp-dump-guest-memory write qemu notes. And, another architecture (arm/aarch64) is coming, which won't use them either. Make the common implementation truly common. (No functional change.) Signed-off-by: Andrew Jones <drjo...@redhat.com> --

[Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory

2015-11-19 Thread Andrew Jones
Add the support needed for creating prstatus elf notes. This allows us to use QMP dump-guest-memory. Signed-off-by: Andrew Jones <drjo...@redhat.com> --- target-arm/Makefile.objs | 3 +- target-arm/arch_dump.c | 222 +++ target-arm/cpu

[Qemu-devel] [PATCH 1/5] qapi-schema: dump-guest-memory: Improve text

2015-11-19 Thread Andrew Jones
dump-guest-memory is supported by more than just x86, however the paging option is not. (No functional change.) Signed-off-by: Andrew Jones <drjo...@redhat.com> --- qapi-schema.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json

[Qemu-devel] [PATCH 4/5] dump: allow target to set the physical base

2015-11-19 Thread Andrew Jones
crash assumes the physical base in the kdump subheader of makedumpfile formatted dumps is correct. Zero is not correct for all architectures, so allow it to be changed. (No functional change.) Signed-off-by: Andrew Jones <drjo...@redhat.com> --- dump.c | 4 ++-- i

[Qemu-devel] [kvm-unit-tests PATCH v2 08/10] arm/arm64: gicv2: add an IPI test

2016-06-04 Thread Andrew Jones
Signed-off-by: Andrew Jones <drjo...@redhat.com> --- v2: add more details in the output if a test fails, report spurious interrupts if we get them --- arm/Makefile.common | 6 +- arm/gic.c | 194 arm/unittests.cfg | 7

[Qemu-devel] [kvm-unit-tests PATCH v2 00/10] arm/arm64: add gic framework

2016-06-04 Thread Andrew Jones
unit test), currently just IPI Available here: https://github.com/rhdrjones/kvm-unit-tests/commits/arm/gic Andrew Jones (10): lib: xstr: allow multiple args arm64: fix get_"sysreg32" and make MPIDR 64bit arm/arm64: smp: support more than 8 cpus arm/arm64: add some delay routin

[Qemu-devel] [kvm-unit-tests PATCH v2 05/10] arm/arm64: irq enable/disable

2016-06-04 Thread Andrew Jones
Signed-off-by: Andrew Jones <drjo...@redhat.com> --- lib/arm/asm/processor.h | 10 ++ lib/arm64/asm/processor.h | 10 ++ 2 files changed, 20 insertions(+) diff --git a/lib/arm/asm/processor.h b/lib/arm/asm/processor.h index afc903ca7d4ab..75a8d08b89330 100644 --- a/lib/a

[Qemu-devel] [kvm-unit-tests PATCH v2 06/10] arm/arm64: add initial gicv2 support

2016-06-04 Thread Andrew Jones
Add some gicv2 support. This just adds init and enable functions, allowing unit tests to start messing with it. Signed-off-by: Andrew Jones <drjo...@redhat.com> --- arm/Makefile.common| 1 + lib/arm/asm/gic-v2.h | 74 ++ lib/arm/asm

[Qemu-devel] [kvm-unit-tests PATCH v2 04/10] arm/arm64: add some delay routines

2016-06-04 Thread Andrew Jones
Allow a thread to wait some specified amount of time. Can specify in cycles, usecs, and msecs. Signed-off-by: Andrew Jones <drjo...@redhat.com> --- lib/arm/asm/processor.h | 19 +++ lib/arm/processor.c | 15 +++ lib/arm64/asm/processor.

[Qemu-devel] [kvm-unit-tests PATCH v2 01/10] lib: xstr: allow multiple args

2016-06-04 Thread Andrew Jones
Signed-off-by: Andrew Jones <drjo...@redhat.com> --- lib/libcflat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/libcflat.h b/lib/libcflat.h index 582e3fc60e287..e5e588c742763 100644 --- a/lib/libcflat.h +++ b/lib/libcflat.h @@ -27,8 +27,8 @@ #define __

[Qemu-devel] [kvm-unit-tests PATCH v2 07/10] arm/arm64: add initial gicv3 support

2016-06-04 Thread Andrew Jones
Signed-off-by: Andrew Jones <drjo...@redhat.com> --- v2: configure irqs as NS GRP1 --- lib/arm/asm/arch_gicv3.h | 184 ++ lib/arm/asm/gic-v3.h | 321 + lib/arm/asm/gic.h | 1 + lib/arm/gic.c

[Qemu-devel] [kvm-unit-tests PATCH v2 09/10] arm/arm64: gicv3: add an IPI test

2016-06-04 Thread Andrew Jones
Signed-off-by: Andrew Jones <drjo...@redhat.com> --- v2: use IRM for gicv3 broadcast --- arm/gic.c | 157 ++ arm/unittests.cfg | 6 +++ 2 files changed, 154 insertions(+), 9 deletions(-) diff --git a/arm/gic.c b/arm/gic.c

[Qemu-devel] [kvm-unit-tests PATCH v2 02/10] arm64: fix get_"sysreg32" and make MPIDR 64bit

2016-06-04 Thread Andrew Jones
mrs is always 64bit, so we should always use a 64bit register. Sometimes we'll only want to return the lower 32, but not for MPIDR, as that does define fields in the upper 32. Signed-off-by: Andrew Jones <drjo...@redhat.com> --- lib/arm64/asm/processor.h | 15 +-- 1 file chan

[Qemu-devel] [kvm-unit-tests PATCH v2 03/10] arm/arm64: smp: support more than 8 cpus

2016-06-04 Thread Andrew Jones
Signed-off-by: Andrew Jones <drjo...@redhat.com> --- arm/run | 19 --- arm/selftest.c| 5 - lib/arm/asm/processor.h | 9 +++-- lib/arm/asm/setup.h | 4 ++-- lib/arm/setup.c | 12 +++- lib/arm64/asm/processor.

[Qemu-devel] [kvm-unit-tests PATCH v2 10/10] arm/arm64: gic: don't just use zero

2016-06-04 Thread Andrew Jones
Allow user to select who sends ipis and with which irq, rather than just always sending irq=0 from cpu0. Signed-off-by: Andrew Jones <drjo...@redhat.com> --- v2: actually check that the irq received was the irq sent, and (for gicv2) that the sender is the expected one. --- arm/gic.

[Qemu-devel] [PATCH 5/5] hw/arm/virt: create the 2.7 machine type

2016-06-08 Thread Andrew Jones
Signed-off-by: Andrew Jones <drjo...@redhat.com> --- hw/arm/virt.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 017c244a46f41..323ffd4689641 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -42,6 +42,7 @@ #i

[Qemu-devel] [PATCH 2/5] hw/arm/virt: set is_default

2016-06-08 Thread Andrew Jones
Make the latest machine type (currently only one) the default. Signed-off-by: Andrew Jones <drjo...@redhat.com> --- hw/arm/virt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index a0d35d0826590..09afbafde025d 100644 --- a/hw/arm/virt.c +++ b/hw/arm/

[Qemu-devel] [PATCH 3/5] hw/arm/virt: introduce DEFINE_VIRT_MACHINE

2016-06-08 Thread Andrew Jones
Use DEFINE_VIRT_MACHINE to generate versioned machine type info. Signed-off-by: Andrew Jones <drjo...@redhat.com> --- hw/arm/virt.c | 40 +++- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 09afbaf

[Qemu-devel] [PATCH 4/5] hw/arm/virt: introduce DEFINE_VIRT_MACHINE_AS_LATEST

2016-06-08 Thread Andrew Jones
Create two variants of DEFINE_VIRT_MACHINE. One, just called DEFINE_VIRT_MACHINE, that does not set properties that only the latest machine type should have, and another that does. This will hopefully reduce potential for errors when adding new versions. Signed-off-by: Andrew Jones <d

[Qemu-devel] [PATCH 1/5] hw/arm/virt: separate versioned type-init code

2016-06-08 Thread Andrew Jones
Rename machvirt_info (which is specifically for 2.6 TypeInfo) to machvirt_2_6_info, and separate the type registration of the abstract machine type from the versioned type. Signed-off-by: Andrew Jones <drjo...@redhat.com> --- hw/arm/virt.c | 16 ++-- 1 file changed, 10 inse

[Qemu-devel] [PATCH 0/5] create the mach-virt 2.7 machine type

2016-06-08 Thread Andrew Jones
This is the first new machine type mach-virt has received (2.6 being the first versioned machine type), so we need to do a bit more than the average "new machine type" patch. The first four patches prepare for easy-adding of machine types. The last patch adds the 2.7 type. Andrew Jones

Re: [Qemu-devel] [kvm-unit-tests PATCH v2 00/10] arm/arm64: add gic framework

2016-06-08 Thread Andrew Jones
On Tue, Jun 07, 2016 at 06:13:53PM +0100, Alex Bennée wrote: > > Alex Bennée <alex.ben...@linaro.org> writes: > > > Andrew Jones <drjo...@redhat.com> writes: > > > >> v2: > >> Rebased on on latest master + my "populate argv[0]" se

Re: [Qemu-devel] [kvm-unit-tests PATCH v2 01/10] lib: xstr: allow multiple args

2016-06-06 Thread Andrew Jones
On Mon, Jun 06, 2016 at 11:49:09AM +0100, Alex Bennée wrote: > > Andrew Jones <drjo...@redhat.com> writes: > > > Signed-off-by: Andrew Jones <drjo...@redhat.com> > > --- > > lib/libcflat.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions

Re: [Qemu-devel] [kvm-unit-tests PATCH v2 03/10] arm/arm64: smp: support more than 8 cpus

2016-06-06 Thread Andrew Jones
On Mon, Jun 06, 2016 at 05:22:49PM +0100, Alex Bennée wrote: > > Andrew Jones <drjo...@redhat.com> writes: > > > Signed-off-by: Andrew Jones <drjo...@redhat.com> > > --- > > arm/run | 19 --- > > arm/selftest.c

Re: [Qemu-devel] [PATCH V1 0/2] Versioning ARM virt machine types

2016-06-07 Thread Andrew Jones
On Tue, Jun 07, 2016 at 04:17:09PM +0100, Peter Maydell wrote: > On 11 March 2016 at 17:36, Wei Huang wrote: > > We start to see more features been added to ARM virtual machine models. > > For the purpose of backward compatibility (e.g. migration), it is time > > to consider

Re: [Qemu-devel] [kvm-unit-tests PATCH v2 04/10] arm/arm64: add some delay routines

2016-06-06 Thread Andrew Jones
On Mon, Jun 06, 2016 at 06:39:50PM +0100, Alex Bennée wrote: > > Andrew Jones <drjo...@redhat.com> writes: > > > Allow a thread to wait some specified amount of time. Can > > specify in cycles, usecs, and msecs. > > I wonder if delay() and mdelay() can be in

Re: [Qemu-devel] [PATCH RFC 07/16] qom/cpu: make nr-cores, nr-threads real properties

2016-06-12 Thread Andrew Jones
On Sat, Jun 11, 2016 at 08:54:35AM +0200, Thomas Huth wrote: > On 10.06.2016 19:40, Andrew Jones wrote: > > Signed-off-by: Andrew Jones <drjo...@redhat.com> > > --- > > qom/cpu.c | 8 > > 1 file changed, 8 insertions(+) > > > > diff --git a/

Re: [Qemu-devel] [PATCH RFC 00/16] Rework SMP parameters

2016-06-12 Thread Andrew Jones
On Fri, Jun 10, 2016 at 07:40:11PM +0200, Andrew Jones wrote: > This series is a first step in eliminating smp_* global > variables (the last patch gets rid of two of them!) And, it's > a first step in deprecating '-smp' in favor of using machine > properties, e.g. > qemu -machi

[Qemu-devel] [PATCH v2 4/4] hw/arm/virt: create the 2.7 machine type

2016-06-12 Thread Andrew Jones
Signed-off-by: Andrew Jones <drjo...@redhat.com> --- hw/arm/virt.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index df88eeb4d2ca0..d266ad7b943e3 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -42,6 +42,7 @@ #i

[Qemu-devel] [PATCH v2 2/4] hw/arm/virt: introduce DEFINE_VIRT_MACHINE

2016-06-12 Thread Andrew Jones
Use DEFINE_VIRT_MACHINE to generate versioned machine type info. Signed-off-by: Andrew Jones <drjo...@redhat.com> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> --- hw/arm/virt.c | 41 - 1 file changed, 24 insertions(+), 17 deletions(-)

Re: [Qemu-devel] [PATCH RFC 00/16] Rework SMP parameters

2016-06-12 Thread Andrew Jones
On Sat, Jun 11, 2016 at 08:42:14AM +0200, Thomas Huth wrote: > On 10.06.2016 19:40, Andrew Jones wrote: > > This series is a first step in eliminating smp_* global > > variables (the last patch gets rid of two of them!) And, it's > > a first step in deprecating '-smp' in f

[Qemu-devel] [PATCH v2 1/4] hw/arm/virt: separate versioned type-init code

2016-06-12 Thread Andrew Jones
Rename machvirt_info (which is specifically for 2.6 TypeInfo) to machvirt_2_6_info, and separate the type registration of the abstract machine type from the versioned type. Signed-off-by: Andrew Jones <drjo...@redhat.com> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> --- h

[Qemu-devel] [PATCH v2 0/4] create the mach-virt 2.7 machine type

2016-06-12 Thread Andrew Jones
ur patches prepare for easy-adding of machine types. The last patch adds the 2.7 type. Andrew Jones (4): hw/arm/virt: separate versioned type-init code hw/arm/virt: introduce DEFINE_VIRT_MACHINE hw/arm/virt: introduce DEFINE_VIRT_MACHINE_AS_LATEST hw/arm/virt: create the 2.7 machine typ

[Qemu-devel] [PATCH v2 3/4] hw/arm/virt: introduce DEFINE_VIRT_MACHINE_AS_LATEST

2016-06-12 Thread Andrew Jones
Create two variants of DEFINE_VIRT_MACHINE. One, just called DEFINE_VIRT_MACHINE, that does not set properties that only the latest machine type should have, and another that does. This will hopefully reduce potential for errors when adding new versions. Signed-off-by: Andrew Jones <d

[Qemu-devel] [PATCH RFC 12/16] hw/arm/virt: rename *.smp_cpus to *.cpus

2016-06-10 Thread Andrew Jones
Use the name 'cpus' instead of 'smp_cpus' to be consistent with MachineState.cpus. This also makes grepping for the global smp_cpus easier. Signed-off-by: Andrew Jones <drjo...@redhat.com> --- hw/arm/virt-acpi-build.c | 14 +++--- hw/arm/virt.c

[Qemu-devel] [PATCH RFC 14/16] hw/arm/virt: stash cpu topo info in VirtGuestInfo

2016-06-10 Thread Andrew Jones
This is a first step to preparing mach-virt for configurable cpu topology, and is necessary now to prepare to move smbios code away from using cpu topology globals smp_cores,smp_threads. Signed-off-by: Andrew Jones <drjo...@redhat.com> --- hw/arm/virt.c| 6 +- incl

[Qemu-devel] [PATCH RFC 00/16] Rework SMP parameters

2016-06-10 Thread Andrew Jones
. Tested with kvm-unit-tests on all five arches supported there, x86_64 both with KVM and TCG, and booting an x86_64 guest (KVM) to check SMBIOS before and after in order to make sure it was the same. Also compile tested all targets. Thanks, drew Andrew Jones (15): vl: smp_parse: cleanups vl

[Qemu-devel] [PATCH RFC 15/16] smbios: don't use smp_cores, smp_threads

2016-06-10 Thread Andrew Jones
(directly in the case of x86, indirectly through VirtGuestInfo in the case of arm). Signed-off-by: Andrew Jones <drjo...@redhat.com> --- hw/arm/virt.c | 9 - hw/i386/pc.c | 13 ++--- hw/smbios/smbios.c | 20 +++- include/hw/

[Qemu-devel] [PATCH RFC 05/16] hw/core/machine: add smp properites

2016-06-10 Thread Andrew Jones
Signed-off-by: Andrew Jones <drjo...@redhat.com> --- hw/core/machine.c | 81 + include/hw/boards.h | 6 2 files changed, 87 insertions(+) diff --git a/hw/core/machine.c b/hw/core/machine.c index 3dce9020e510a..2625044002e57

[Qemu-devel] [PATCH RFC 10/16] hw/ppc/spapr: don't use smp_cores, smp_threads

2016-06-10 Thread Andrew Jones
Use CPUState nr_cores,nr_threads and MachineState cores,threads instead. Signed-off-by: Andrew Jones <drjo...@redhat.com> --- hw/ppc/spapr.c | 9 + hw/ppc/spapr_rtas.c | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c

[Qemu-devel] [PATCH RFC 04/16] hw/core/machine: Introduce pre_init

2016-06-10 Thread Andrew Jones
From: Igor Mammedov <imamm...@redhat.com> Signed-off-by: Igor Mammedov <imamm...@redhat.com> Signed-off-by: Andrew Jones <drjo...@redhat.com> --- hw/core/machine.c | 6 ++ include/hw/boards.h | 1 + vl.c| 1 + 3 files changed, 8 insertions(+) diff --git a

[Qemu-devel] [PATCH RFC 06/16] vl: move smp parsing to machine pre_init

2016-06-10 Thread Andrew Jones
-by: Andrew Jones <drjo...@redhat.com> --- hw/core/machine.c | 113 -- vl.c | 111 - 2 files changed, 142 insertions(+), 82 deletions(-) diff --git a/hw/core/machine.c b/h

[Qemu-devel] [PATCH RFC 11/16] target-ppc: don't use smp_threads

2016-06-10 Thread Andrew Jones
Use CPUState nr_threads instead. Signed-off-by: Andrew Jones <drjo...@redhat.com> --- target-ppc/translate_init.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index a1db5009c4a83..f442b2f

[Qemu-devel] [PATCH RFC 08/16] hw/core/machine: set cpu global nr_cores, nr_threads in pre_init

2016-06-10 Thread Andrew Jones
globals smp_cores,smp_threads from cpus.c. Signed-off-by: Andrew Jones <drjo...@redhat.com> --- cpus.c| 2 -- hw/core/machine.c | 18 ++ 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index 326742f445eef..36d8faa0091c8

[Qemu-devel] [PATCH RFC 01/16] vl: smp_parse: cleanups

2016-06-10 Thread Andrew Jones
No functional changes; only some code movement and removal of dead code (impossible conditions). Also, max_cpus can be initialized to 1, like smp_cpus, because it's either set by the user or set to smp_cpus, when smp_cpus is set by the user, or set to 1, when nothing is set. Signed-off-by: Andrew

[Qemu-devel] [PATCH RFC 13/16] hw/arm/virt: don't use smp_cpus, max_cpus

2016-06-10 Thread Andrew Jones
Use MachineState.cpus or own copy from VirtBoardInfo.cpus instead. (Congratulations mach-virt, you're the first machine type to be cpu topology globals free!) Signed-off-by: Andrew Jones <drjo...@redhat.com> --- hw/arm/virt.c | 18 +- 1 file changed, 9 insertions

[Qemu-devel] [PATCH RFC 07/16] qom/cpu: make nr-cores, nr-threads real properties

2016-06-10 Thread Andrew Jones
Signed-off-by: Andrew Jones <drjo...@redhat.com> --- qom/cpu.c | 8 1 file changed, 8 insertions(+) diff --git a/qom/cpu.c b/qom/cpu.c index 751e992de8823..024cda3eb98c8 100644 --- a/qom/cpu.c +++ b/qom/cpu.c @@ -28,6 +28,7 @@ #include "exec/log.h" #include &quo

[Qemu-devel] [PATCH RFC 02/16] vl: smp: add checks for maxcpus based topologies

2016-06-10 Thread Andrew Jones
topology information recalculate it. If they choose to (correctly) calculate it based on maxcpus, then we need to guard them against building topologies which provide more cpu slots than are the maximum allowed cpus. Signed-off-by: Andrew Jones <drjo...@redhat.com> --- vl.c | 19

[Qemu-devel] [PATCH RFC 09/16] hw/i386/pc: don't use smp_cores, smp_threads

2016-06-10 Thread Andrew Jones
Use CPUState nr_cores,nr_threads and MachineState cores,threads instead. Signed-off-by: Andrew Jones <drjo...@redhat.com> --- hw/i386/pc.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 7198ed5

[Qemu-devel] [PATCH RFC 16/16] sysemu/cpus: bye, bye smp_cores, smp_threads

2016-06-10 Thread Andrew Jones
The smp_cores and smp_threads globals are no longer used. Vanish them. Signed-off-by: Andrew Jones <drjo...@redhat.com> --- hw/core/machine.c | 2 -- include/sysemu/cpus.h | 10 -- vl.c | 2 -- 3 files changed, 14 deletions(-) diff --git a/hw/core/machine.

[Qemu-devel] [PATCH RFC 03/16] hw/smbios/smbios: fix number of sockets calculation

2016-06-10 Thread Andrew Jones
rting more cpus than max_cpus. Signed-off-by: Andrew Jones <drjo...@redhat.com> --- hw/smbios/smbios.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c index cb8a029cf..cf18ecfd8599c 100644 --- a/hw/smbios/smbios.c +++ b/hw/smbios

Re: [Qemu-devel] [PATCH 5/5] hw/arm/virt: create the 2.7 machine type

2016-06-09 Thread Andrew Jones
On Thu, Jun 09, 2016 at 05:06:43PM +0100, Alex Bennée wrote: > > Andrew Jones <drjo...@redhat.com> writes: > > > Signed-off-by: Andrew Jones <drjo...@redhat.com> > > > I'm confused. These steps have introduced a bunch of boiler plate to set > the defaul

Re: [Qemu-devel] [PATCH RFC 10/16] hw/ppc/spapr: don't use smp_cores, smp_threads

2016-06-14 Thread Andrew Jones
On Tue, Jun 14, 2016 at 01:03:41PM +1000, David Gibson wrote: > On Fri, Jun 10, 2016 at 07:40:21PM +0200, Andrew Jones wrote: > > Use CPUState nr_cores,nr_threads and MachineState > > cores,threads instead. > > > > Signed-off-by: Andrew Jones <drjo...@redhat.co

Re: [Qemu-devel] [PATCH RFC 02/16] vl: smp: add checks for maxcpus based topologies

2016-06-14 Thread Andrew Jones
On Tue, Jun 14, 2016 at 11:28:52AM +1000, David Gibson wrote: > On Fri, Jun 10, 2016 at 07:40:13PM +0200, Andrew Jones wrote: > > smp_parse computes missing smp options. Unfortunately cores and > > threads are computed by dividing smp_cpus, instead of max_cpus. > > This

Re: [Qemu-devel] [PATCH RFC 07/16] qom/cpu: make nr-cores, nr-threads real properties

2016-06-14 Thread Andrew Jones
On Tue, Jun 14, 2016 at 12:12:16PM +1000, David Gibson wrote: > On Sun, Jun 12, 2016 at 03:48:10PM +0200, Andrew Jones wrote: > > On Sat, Jun 11, 2016 at 08:54:35AM +0200, Thomas Huth wrote: > > > On 10.06.2016 19:40, Andrew Jones wrote: > > > > Signed-off-by: An

Re: [Qemu-devel] [PATCH RFC 06/16] vl: move smp parsing to machine pre_init

2016-06-14 Thread Andrew Jones
On Tue, Jun 14, 2016 at 10:17:49AM +0200, Paolo Bonzini wrote: > > > On 13/06/2016 22:35, Andrew Jones wrote: > > On Mon, Jun 13, 2016 at 07:04:01PM +0200, Paolo Bonzini wrote: > >> On 10/06/2016 19:40, Andrew Jones wrote: > >>> +if (sockets =

Re: [Qemu-devel] [PATCH RFC 06/16] vl: move smp parsing to machine pre_init

2016-06-14 Thread Andrew Jones
On Tue, Jun 14, 2016 at 01:53:05PM +0200, Paolo Bonzini wrote: > > > On 14/06/2016 13:39, Andrew Jones wrote: > > On Tue, Jun 14, 2016 at 10:17:49AM +0200, Paolo Bonzini wrote: > >> On 13/06/2016 22:35, Andrew Jones wrote: > >>> On Mon, Jun 13, 2016 at 0

Re: [Qemu-devel] [PATCH RFC 04/16] hw/core/machine: Introduce pre_init

2016-06-14 Thread Andrew Jones
On Tue, Jun 14, 2016 at 11:30:37AM +1000, David Gibson wrote: > On Fri, Jun 10, 2016 at 07:40:15PM +0200, Andrew Jones wrote: > > From: Igor Mammedov <imamm...@redhat.com> > > > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > > Signed-off-by: Andrew

Re: [Qemu-devel] [PATCH RFC 05/16] hw/core/machine: add smp properites

2016-06-14 Thread Andrew Jones
On Tue, Jun 14, 2016 at 12:00:26PM +1000, David Gibson wrote: > On Fri, Jun 10, 2016 at 07:40:16PM +0200, Andrew Jones wrote: > > Signed-off-by: Andrew Jones <drjo...@redhat.com> > > --- > > hw/core/machine.c | 81 > >

Re: [Qemu-devel] [PATCH] ACPI: ARM: Present GIC version in MADT table

2016-06-15 Thread Andrew Jones
enericDistributor AcpiMadtGenericDistributor; > -- > 2.0.4 AFAICT, Linux is actually fine with version=0 (as before this patch). One way or another it has already determined that the gic is either v3 or v4, and then just proceeds. That said, it does seem like the right thing to do to set it Reviewed-by: Andrew Jones <drjo...@redhat.com>

Re: [Qemu-devel] [PATCH v3 00/20] GICv3 emulation

2016-06-15 Thread Andrew Jones
On Wed, Jun 15, 2016 at 04:53:35PM +0800, Shannon Zhao wrote: > > > On 2016/6/14 22:38, Peter Maydell wrote: > > This series implements emulation of the GICv3 interrupt controller. > > It is based to some extent on previous patches from Shlomo and > > Pavel, but the bulk of it has turned out to

Re: [Qemu-devel] git master build failure

2016-06-15 Thread Andrew Jones
On Wed, Jun 15, 2016 at 08:14:18AM +0100, Mark Cave-Ayland wrote: > Hi Peter, > > Just to let you know that after pulling git master > (49237b856ae58ee7955be0b959c504c51b014f20) I see the following build > failure here: Just pulled and successfully compiled, configure

Re: [Qemu-devel] git master build failure

2016-06-15 Thread Andrew Jones
On Wed, Jun 15, 2016 at 11:08:26AM +0100, Mark Cave-Ayland wrote: > On 15/06/16 10:48, Andrew Jones wrote: > > > On Wed, Jun 15, 2016 at 08:14:18AM +0100, Mark Cave-Ayland wrote: > >> Hi Peter, > >> > >> Just to let

Re: [Qemu-devel] [PATCH RFC 05/16] hw/core/machine: add smp properites

2016-06-15 Thread Andrew Jones
On Wed, Jun 15, 2016 at 10:37:59AM +1000, David Gibson wrote: > On Tue, Jun 14, 2016 at 08:08:07AM +0200, Andrew Jones wrote: > > On Tue, Jun 14, 2016 at 12:00:26PM +1000, David Gibson wrote: > > > On Fri, Jun 10, 2016 at 07:40:16PM +0200, Andrew Jones wrote: > > > &g

Re: [Qemu-devel] [PATCH RFC 06/16] vl: move smp parsing to machine pre_init

2016-06-15 Thread Andrew Jones
On Wed, Jun 15, 2016 at 10:51:08AM +1000, David Gibson wrote: > On Tue, Jun 14, 2016 at 04:03:29PM +0200, Andrew Jones wrote: > > On Tue, Jun 14, 2016 at 01:53:05PM +0200, Paolo Bonzini wrote: > > > > > > > > > On 14/06/2016 13:39, Andrew Jones wrote: > &

Re: [Qemu-devel] [PATCH RFC 10/16] hw/ppc/spapr: don't use smp_cores, smp_threads

2016-06-15 Thread Andrew Jones
On Wed, Jun 15, 2016 at 10:59:01AM +1000, David Gibson wrote: > On Tue, Jun 14, 2016 at 08:23:08AM +0200, Andrew Jones wrote: > > On Tue, Jun 14, 2016 at 01:03:41PM +1000, David Gibson wrote: > > > On Fri, Jun 10, 2016 at 07:40:21PM +0200, Andrew Jones wrote: > > &

<    1   2   3   4   5   6   7   8   9   10   >