On Thu, Jul 04, 2013 at 05:53:17PM +0800, Wanlong Gao wrote:
Show host memory policy of nodes in the info numa monitor command.
After this patch, the monitor command info numa will show the
information like following if the host numa support is enabled:
(qemu) info numa
2 nodes
...@cn.fujitsu.com
Reviewed-by: Eduardo Habkost ehabk...@redhat.com
---
cpus.c | 2 +-
hw/i386/pc.c| 4 ++--
hw/net/eepro100.c | 1 -
include/sysemu/sysemu.h | 8 ++--
monitor.c | 2 +-
vl.c| 24
On Mon, Jul 08, 2013 at 01:02:41PM -0600, Eric Blake wrote:
On 07/05/2013 12:41 PM, Eduardo Habkost wrote:
On Thu, Jul 04, 2013 at 05:53:08PM +0800, Wanlong Gao wrote:
From: Bandan Das b...@redhat.com
This allows us to use the cpus property multiple times
to specify multiple cpu (ranges
with resetting twice on startup, so drop
the #ifdef.
Suggested-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber afaer...@suse.de
Cc: Eduardo Habkost ehabk...@redhat.com
---
This had been discussed as a possible cleanup for the #ifdef.
I am uncertain whether we should do
On Wed, Jul 10, 2013 at 07:51:32PM +0100, Peter Maydell wrote:
On 10 July 2013 19:43, Eduardo Habkost ehabk...@redhat.com wrote:
On Wed, Jul 10, 2013 at 06:30:38PM +0200, Andreas Färber wrote:
Some CPUs reset as part of cpu_init(), some others were reset
afterwards, some not at all. While
/gmane.comp.emulators.kvm.devel/112380
(Minutes of last call where this was discussed)
Eduardo Habkost (3):
tests: unit tests for qdev global-properties handling
qom: introduce post_init() function
qdev: set globals on post_init() function
hw/core/qdev.c | 10 ++-
include/qom/object.h
This will allow classes to specify a function to be called after all
instance_init() functions were called.
This will be used by DeviceState to call qdev_prop_set_globals() at the
right moment.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
include/qom/object.h | 3 +++
qom/object.c
This tests the qdev global-properties handling code.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
tests/.gitignore | 1 +
tests/Makefile | 7 +++
tests/test-qdev-global-props.c | 109 +
3 files changed, 117
This way, properties registered in the instance_init() function of
children classes will be handled properly by qdev_prop_set_globals(),
too.
Includes a new unit test for the new functionality.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
hw/core/qdev.c | 10
On Thu, Jul 11, 2013 at 06:32:48PM +0800, Peter Huang(Peng) wrote:
Hi,Wanlong
From the patch discription below, seems that qemu numa only support
cpu/memory node binding.
As we know, binding is not the common usage due to VM migration may happen or
the load balance
would be disabled.
On Thu, Jul 11, 2013 at 08:29:15AM +0200, Igor Mammedov wrote:
On Wed, 10 Jul 2013 17:08:41 -0300
Eduardo Habkost ehabk...@redhat.com wrote:
This will allow classes to specify a function to be called after all
instance_init() functions were called.
This will be used by DeviceState
On Thu, Jul 11, 2013 at 08:48:44AM +0200, Igor Mammedov wrote:
[...]
#define TYPE_STATIC_PROPS static_prop_type
@@ -80,7 +82,7 @@ static void test_static_prop(void)
static void test_static_globalprop(void)
{
MyType *mt;
-GlobalProperty props[] = {
+static
On Tue, Jul 16, 2013 at 07:22:01PM +0200, Andrea Arcangeli wrote:
Without this patch the guest physical bits are advertised as 40, not
44 or more depending on the hardware capability of the host.
That leads to guest kernel crashes with injection of page faults 9
(see oops: 0009) as bits
On Tue, Jul 16, 2013 at 07:46:14PM +0200, Paolo Bonzini wrote:
Il 16/07/2013 19:38, Eduardo Habkost ha scritto:
On Tue, Jul 16, 2013 at 07:22:01PM +0200, Andrea Arcangeli wrote:
Without this patch the guest physical bits are advertised as 40, not
44 or more depending on the hardware
On Tue, Jul 16, 2013 at 09:24:30PM +0200, Paolo Bonzini wrote:
Il 16/07/2013 20:11, Eduardo Habkost ha scritto:
For physical bit size, what about extending it in a backwards-compatible
way? Something like this:
*eax = 0x0003000; /* 48 bits virtual */
if (ram_size 1TB
On Wed, Jul 17, 2013 at 10:09:01AM +0200, Paolo Bonzini wrote:
Il 16/07/2013 21:42, Eduardo Habkost ha scritto:
On Tue, Jul 16, 2013 at 09:24:30PM +0200, Paolo Bonzini wrote:
Il 16/07/2013 20:11, Eduardo Habkost ha scritto:
For physical bit size, what about extending it in a backwards
On Wed, Jul 17, 2013 at 06:19:28PM +0300, Gleb Natapov wrote:
On Tue, Jul 16, 2013 at 04:42:38PM -0300, Eduardo Habkost wrote:
On Tue, Jul 16, 2013 at 09:24:30PM +0200, Paolo Bonzini wrote:
Il 16/07/2013 20:11, Eduardo Habkost ha scritto:
For physical bit size, what about extending
On Tue, Jul 16, 2013 at 03:01:58PM +0300, Gleb Natapov wrote:
On Tue, Jul 16, 2013 at 07:56:25PM +0800, Arthur Chunqi Li wrote:
On Tue, Jul 16, 2013 at 7:42 PM, Gleb Natapov g...@redhat.com wrote:
On Sun, Jul 07, 2013 at 11:13:37PM +0800, Arthur Chunqi Li wrote:
The recent KVM patch adds
On Mon, Jul 22, 2013 at 12:14:25PM +0200, Paolo Bonzini wrote:
Il 22/07/2013 12:10, Orit Wasserman ha scritto:
As discussed offlist, I would prefer to have this in the kernel since
that's where the bug is. Gleb disagrees.
As this is a migration bug I prefer to fix it in the migration
On Mon, Jul 22, 2013 at 07:24:24PM +0800, Peter Huang(Peng) wrote:
Hi, Everyone
I have been encountered a problem recently.
My box uses Nehalem E5520 CPU, and this model doesn't support x2apic feature.
I created a VM on KVM, and uses cpu mode=pass-through, I can get the right cpu
model from
On Thu, Jun 13, 2013 at 09:40:14AM +0800, Wanlong Gao wrote:
On 06/11/2013 09:40 PM, Eduardo Habkost wrote:
On Tue, Jun 11, 2013 at 03:22:13PM +0800, Wanlong Gao wrote:
On 06/05/2013 09:46 PM, Eduardo Habkost wrote:
On Wed, Jun 05, 2013 at 11:58:25AM +0800, Wanlong Gao wrote:
Add monitor
On Thu, Jun 13, 2013 at 08:04:00PM -0500, Anthony Liguori wrote:
Eduardo Habkost ehabk...@redhat.com writes:
On Wed, Jun 05, 2013 at 07:57:42AM -0500, Anthony Liguori wrote:
Wanlong Gao gaowanl...@cn.fujitsu.com writes:
Add monitor command mem-nodes to show the huge mapped
memory
On Tue, Jun 18, 2013 at 11:20:37AM +0200, Paolo Bonzini wrote:
[...]
Also, please use QemuOpts instead of yet another homegrown parser.
Eduardo, I think you had the most recent attempt to convert -numa to
QemuOpts?
I had one, but I believe it is more complex than it should have been. I
was
On Wed, Jun 19, 2013 at 01:42:52PM +0200, Igor Mammedov wrote:
On Tue, 18 Jun 2013 16:09:49 -0400
Bandan Das b...@redhat.com wrote:
This allows us to use the cpu property multiple times
to specify multiple cpu (ranges) to the -numa option :
-numa node,cpu=1,cpu=2,cpu=4
or
-numa
On Thu, Jun 20, 2013 at 11:52:42AM +0200, Paolo Bonzini wrote:
Il 20/06/2013 11:30, Igor Mammedov ha scritto:
So, basically the format seemed easier to work with if we are
thinking
of using QemuOpts for -numa. Using -cpu rather than cpus probably
makes it less ambiguous as
On Sat, Jun 22, 2013 at 04:50:34PM +0800, Hu Tao wrote:
Introduce type constant and avoid DO_UPCAST().
Cc: qemu-devel@nongnu.org
Cc: Andreas Färber afaer...@suse.de
Cc: Paolo Bonzini pbonz...@redhat.com
Cc: Eduardo Habkost ehabk...@redhat.com
Cc: Igor Mammedov imamm...@redhat.com
Cc
On Sat, Jun 22, 2013 at 04:50:13PM +0800, Hu Tao wrote:
Cc: Gerd Hoffmann kra...@redhat.com
Signed-off-by: Hu Tao hu...@cn.fujitsu.com
---
hw/usb/hcd-ohci.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
index
On Sat, Jun 22, 2013 at 04:50:33PM +0800, Hu Tao wrote:
Cc: qemu-devel@nongnu.org
Cc: Andreas Färber afaer...@suse.de
Cc: Paolo Bonzini pbonz...@redhat.com
Cc: Anthony Liguori aligu...@us.ibm.com
Cc: Igor Mammedov imamm...@redhat.com
Cc: Eduardo Habkost ehabk...@redhat.com
Signed-off-by: Hu
On Wed, Jun 05, 2013 at 03:18:34PM +0200, Igor Mammedov wrote:
Signed-off-by: Igor Mammedov imamm...@redhat.com
Reviewed-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/target-i386/cpu.c b
On Wed, Jun 05, 2013 at 03:18:32PM +0200, Igor Mammedov wrote:
Signed-off-by: Igor Mammedov imamm...@redhat.com
Reviewed-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 17 ++---
1 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/target-i386
On Wed, Jun 05, 2013 at 03:18:36PM +0200, Igor Mammedov wrote:
Signed-off-by: Igor Mammedov imamm...@redhat.com
Reviewed-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 20 +---
1 files changed, 1 insertions(+), 19 deletions(-)
diff --git a/target-i386
On Wed, Jun 05, 2013 at 03:18:33PM +0200, Igor Mammedov wrote:
Signed-off-by: Igor Mammedov imamm...@redhat.com
Reviewed-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/target-i386/cpu.c b
of keeping it signed? We already
reject negative values.
As this patch just converts the current code/semantics to use static
properties, and the change to uint64 could be done in a separate patch:
Reviewed-by: Eduardo Habkost ehabk...@redhat.com
+.get = x86_cpuid_get_tsc_freq,
+.set
On Wed, Jun 05, 2013 at 03:18:37PM +0200, Igor Mammedov wrote:
Signed-off-by: Igor Mammedov imamm...@redhat.com
Reviewed-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 31 ---
1 files changed, 24 insertions(+), 7 deletions(-)
diff --git
-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 31 ++-
1 files changed, 22 insertions(+), 9 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 21e7334..9f6fe06 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1344,7
On Wed, Jun 05, 2013 at 03:18:35PM +0200, Igor Mammedov wrote:
Signed-off-by: Igor Mammedov imamm...@redhat.com
Reviewed-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 20 +---
1 files changed, 1 insertions(+), 19 deletions(-)
diff --git a/target-i386
-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu-qom.h | 4 +++-
target-i386/cpu.c | 23 ---
2 files changed, 19 insertions(+), 8 deletions(-)
diff --git a/target-i386/cpu-qom.h b/target-i386/cpu-qom.h
index 37c61e7..c619f3b 100644
--- a/target-i386/cpu-qom.h
On Tue, Jun 25, 2013 at 10:20:08AM +0800, Hu Tao wrote:
[...]
Is TYPE_SYS_BUS_DEVICE guaranteed to never override -realize() itself?
From DeviceClass documentation:
* If a type derived directly from TYPE_DEVICE implements @realize, it does
* not need to implement @init and
On Wed, Jun 05, 2013 at 03:18:40PM +0200, Igor Mammedov wrote:
- since hyperv_* helper functions are used only in target-i386/kvm.c
move them there as static helpers
Signed-off-by: Igor Mammedov imamm...@redhat.com
Requestd-By: Eduardo Habkost ehabk...@redhat.com
Reviewed-by: Eduardo
On Wed, Jun 05, 2013 at 03:18:41PM +0200, Igor Mammedov wrote:
Signed-off-by: Igor Mammedov imamm...@redhat.com
---
[...]
@@ -1632,6 +1677,7 @@ static void cpu_x86_parse_featurestr(X86CPU *cpu, char
*features, Error **errp)
} else if (!strcmp(featurestr, hv-spinlocks)) {
On Tue, Jun 25, 2013 at 05:30:50PM -0300, Eduardo Habkost wrote:
On Wed, Jun 05, 2013 at 03:18:41PM +0200, Igor Mammedov wrote:
Signed-off-by: Igor Mammedov imamm...@redhat.com
---
[...]
@@ -1632,6 +1677,7 @@ static void cpu_x86_parse_featurestr(X86CPU *cpu,
char *features, Error **errp
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Changes v1 - v2:
* Fix typo: qemu-file.c - qemu-timer.c
---
savevm.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/savevm.c b/savevm.c
index 8eeb5ef..a7dbe18 100644
--- a/savevm.c
+++ b/savevm.c
@@ -166,7 +166,9
On Thu, Nov 28, 2013 at 07:09:13PM +0100, Laszlo Ersek wrote:
The current two GTest cases, /i440fx/defaults and /i440fx/pam can share a
qemu process, but the next two cases will need dedicated instances. It is
messy (and order-dependent) to dynamically configure GTest cases one by
one to
On Tue, Dec 03, 2013 at 11:44:19AM +0100, Igor Mammedov wrote:
On Mon, 02 Dec 2013 23:09:55 +0100
Andreas Färber afaer...@suse.de wrote:
Am 02.12.2013 18:06, schrieb Michael Tokarev:
25.11.2013 07:39, Alexey Kardashevskiy wrote:
Since modern POWER7/POWER8 chips can have more that 256
On Tue, Dec 03, 2013 at 02:30:48PM +0100, Andreas Färber wrote:
Am 03.12.2013 00:03, schrieb Alexey Kardashevskiy:
On 12/03/2013 09:09 AM, Andreas Färber wrote:
Am 02.12.2013 18:06, schrieb Michael Tokarev:
25.11.2013 07:39, Alexey Kardashevskiy wrote:
Since modern POWER7/POWER8 chips can
On Wed, Dec 04, 2013 at 04:50:59PM +1100, Alexey Kardashevskiy wrote:
On 12/04/2013 01:47 AM, Eduardo Habkost wrote:
On Tue, Dec 03, 2013 at 02:30:48PM +0100, Andreas Färber wrote:
Am 03.12.2013 00:03, schrieb Alexey Kardashevskiy:
On 12/03/2013 09:09 AM, Andreas Färber wrote:
Am
Bugzilla: 972773
Brew scratch build: http://brewweb.devel.redhat.com/brew/taskinfo?taskID=6676272
Add support statement to -help output, reporting direct qemu-kvm usage
as unsupported by Red Hat, and advising users to use libvirt instead.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
On Wed, Dec 04, 2013 at 11:51:17AM -0700, Eric Blake wrote:
On 12/04/2013 11:42 AM, Eduardo Habkost wrote:
Bugzilla: 972773
Add support statement to -help output, reporting direct qemu-kvm usage
as unsupported by Red Hat, and advising users to use libvirt instead.
Signed-off
Ping? No comments, even about the first few patches (that are fairly
simple)?
On Wed, Nov 27, 2013 at 05:34:02PM -0200, Eduardo Habkost wrote:
I want to try to get this in 1.8, because I have found one additional use-case
for the new subclasses:
libvirt needs to be able to query details
On Fri, Dec 06, 2013 at 10:48:04AM +0100, Paolo Bonzini wrote:
Il 06/12/2013 10:31, Wanlong Gao ha scritto:
I think patches 1-4 and 7 are fine. For the rest, I'd rather wait for
Igor's patches and try to integrate with Igor's memory hotplug patches.
So, how about apply them first and
The default machine-type (pc-i440fx-2.0) now requires bios-256k.bin, but
make install isn't installing it, so qemu-system-x86_64 won't run out
of the box. Add it to BLOBS so it gets installed.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Makefile | 2 +-
1 file changed, 1 insertion
On Wed, Dec 04, 2013 at 03:58:49PM +0800, Wanlong Gao wrote:
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
Reviewed-by: Eduardo Habkost ehabk...@redhat.com
--
Eduardo
CCing libvir-list.
On Wed, Dec 04, 2013 at 03:58:50PM +0800, Wanlong Gao wrote:
If the total number of the assigned numa nodes memory is not
equal to the assigned ram size, it will write the wrong data
to ACPI talb, then the guest will ignore the wrong ACPI table
and recognize all memory to
The compiler is capable of eliminating the KVM-specific function calls
as long as the calling function has an assert(kvm_enabled()) line, so we
don't need to wrap all KVM-specific code inside #ifdefs.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Changes v2:
* Check for __i386__
On Tue, Dec 10, 2013 at 07:03:50PM +0100, Paolo Bonzini wrote:
Il 10/12/2013 14:15, Eduardo Habkost ha scritto:
If the total number of the assigned numa nodes memory is not
equal to the assigned ram size, it will write the wrong data
to ACPI talb, then the guest will ignore the wrong
Ping? Any comments?
On Sun, Nov 24, 2013 at 05:55:32PM -0200, Eduardo Habkost wrote:
This series simplifies kvm_cpu_fill_host() and
kvm_check_features_against_host() to simply use FeatureWord
feature_word_info
loops to fill/check feature words.
The initial motivation
On Tue, Dec 10, 2013 at 05:36:10PM -0800, Richard Henderson wrote:
On 12/10/2013 10:55 AM, Eduardo Habkost wrote:
The compiler is capable of eliminating the KVM-specific function calls
as long as the calling function has an assert(kvm_enabled()) line, so we
don't need to wrap all KVM
.
Tested to build successfully with CONFIG_KVM disabled, using the
following CFLAGS combinations: -DNDEBUG, -DNDEBUG -O', -DNDEBUG
-O0, -DNDEBUG -O1, -DNDEBUG -O2.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Changes v2:
* Check for __i386__ on host_cpuid() so the code compiles properly
On Mon, Dec 16, 2013 at 03:54:57PM +0800, jun muzi wrote:
Type error, change smp_cores to nr_cores and change smp_threads to
nr_threads. But using smp_cores can work well. As it is not the same with
explanatory note, so change it.
Signed-off-by: Jun Li junm...@gmail.com
---
On Fri, Dec 13, 2013 at 02:10:20AM +0800, lijun wrote:
Hi all,
when set -smp more than 160, qemu will give the following warning:
Warning: Number of SMP cpus requested (161) exceeds the recommended
cpus supported by KVM (160)
As the above warning, when set -smp
On Mon, Dec 16, 2013 at 04:01:05PM +0100, Igor Mammedov wrote:
On Sun, 15 Dec 2013 23:50:47 +0100
Andreas Färber afaer...@suse.de wrote:
Am 27.11.2013 23:28, schrieb Igor Mammedov:
Igor Mammedov (16):
target-i386: cleanup 'foo' feature handling'
target-i386: cleanup 'foo=val'
On Tue, Dec 17, 2013 at 11:16:30PM +0800, lijun wrote:
As Eric and Eduardo's suggestions, use is_power_of_2 to check
whether nr_cores
and nr_threads is the power of 2 in function x86_apicid_from_cpu_idx in file
target-i386/topology.h. This check is very simple, I prefer add it in a
function
Errors when closing the file we just created should not be ignored. I/O errors
may happen and qemu-img create should fail in those cases.
If we are already exiting due to an error, we will still return the original
error number, though.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
From: Eduardo Habkost ehabk...@raisama.net
Hi,
Here are two small fixes on qcow2_create() error handling.
Eduardo Habkost (2):
fix fd leak on a qcow2_create2() error path
check for close() errors on qcow2_create()
block/qcow2.c | 11 ---
1 files changed, 8 insertions(+), 3
When getting an invalid cluster size, the open fd must be closed before
qcow2_create() returns an error.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
block/qcow2.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index ee3481b
On Fri, Oct 08, 2010 at 10:28:37AM +0100, Stefan Hajnoczi wrote:
exit_close:
- close(fd);
+ cret = close(fd);
+ if (ret == 0 cret 0)
if (close(fd) 0 ret == 0) {
Does the same without variable cret.
Yes. I used the variable just for readability. I personally don't like
On Fri, Oct 08, 2010 at 12:14:07PM +0200, Kevin Wolf wrote:
Am 07.10.2010 22:25, schrieb Eduardo Habkost:
Errors when closing the file we just created should not be ignored. I/O
errors
may happen and qemu-img create should fail in those cases.
If we are already exiting due to an error
This allows vmport to be easily enabled or disabled at build time.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Makefile.target|3 ++-
default-configs/i386-softmmu.mak |2 ++
default-configs/x86_64-softmmu.mak |2 ++
hw/pc_piix.c
Hi,
This series makes CONFIG_VMWARE_VGA actually work (today we can't disable the
option without getting a build error).
It also add two new options: CONFIG_VMMOUSE and CONFIG_VMPORT, for vmmouse.o
and vmport.o.
Eduardo Habkost (4):
Add config-devices.h again
skip pci_vmsvga_init() calls
This will allow vmmouse to be disabled at build time if necessary.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Makefile.target|5 -
default-configs/i386-softmmu.mak |1 +
default-configs/x86_64-softmmu.mak |1 +
hw/pc.c
work and can't be disabled. I
don't see a good way to implement it that wouldn't involve heavily
refactoring completely the '-vga' option parsing code.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
hw/mips_malta.c |4
hw/pc.c |4
2 files changed, 8 insertions(+), 0
-timestamp
make: *** [subdir-x86_64-softmmu] Error 2
config-devices.h will allow us to add an #ifdef to fix the above error, and
other similar cases.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Makefile|7 +--
Makefile.target |2 +-
config.h| 11
On Wed, Feb 02, 2011 at 05:16:23PM +, Blue Swirl wrote:
On Wed, Feb 2, 2011 at 7:55 AM, Paolo Bonzini pbonz...@redhat.com wrote:
On 02/01/2011 07:10 PM, Blue Swirl wrote:
One way to solve this which would preserve the device model would be
to add stub devices. For example,
On Tue, Feb 01, 2011 at 07:14:00PM +0100, Stefan Weil wrote:
+
#include config-host.h
#include config-target.h
+
+/* We want to include different config files for specific targets
+ And for the common library. They need a different name because
+ we don't want to rely in paths */
On Wed, Sep 08, 2010 at 09:21:16AM -0500, Adam Litke wrote:
The addition of memory stats reporting to the virtio balloon causes
the 'info balloon' command to become asynchronous. This is a regression
because in some cases it can hang the user monitor.
Disable this feature until a better
On Tue, Sep 14, 2010 at 09:24:11AM -0500, Adam Litke wrote:
On Tue, 2010-09-14 at 11:09 -0300, Eduardo Habkost wrote:
On Wed, Sep 08, 2010 at 09:21:16AM -0500, Adam Litke wrote:
[...]
static uint32_t virtio_balloon_get_features(VirtIODevice *vdev, uint32_t
f)
{
-f |= (1
On Tue, Sep 14, 2010 at 11:41:55AM -0300, Eduardo Habkost wrote:
On Tue, Sep 14, 2010 at 09:24:11AM -0500, Adam Litke wrote:
On Tue, 2010-09-14 at 11:09 -0300, Eduardo Habkost wrote:
On Wed, Sep 08, 2010 at 09:21:16AM -0500, Adam Litke wrote:
[...]
static uint32_t
) virtio feature bit, causing issues for migration.
Original discussion is available at:
http://marc.info/?l=qemu-develm=128448124328314w=2
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
Acked-by: Adam Litke a...@us.ibm.com
---
diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c
index 1e4dfdd
) virtio feature bit, causing issues for migration.
Original discussion is available at:
http://marc.info/?l=qemu-develm=128448124328314w=2
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
Acked-by: Adam Litke a...@us.ibm.com
---
diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c
index 1e4dfdd
Patch from Oleg L. Sadov.
Removes broken 'slash' and 'bar' definitions (that were duplicated) from
the 'ru' keymap.
I can't test it myself, but the the fix was reported to be working, at:
https://bugzilla.redhat.com/show_bug.cgi?id=580637
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
, Eduardo Habkost wrote:
Patch from Oleg L. Sadov.
Removes broken 'slash' and 'bar' definitions (that were duplicated) from
the 'ru' keymap.
I can't test it myself, but the the fix was reported to be working, at:
https://bugzilla.redhat.com/show_bug.cgi?id=580637
Signed-off-by: Eduardo
, as do_change() calls eject_device() before
re-opening the block device, but bdrv_close() is never called.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
monitor.c | 22 ++
1 files changed, 10 insertions(+), 12 deletions(-)
diff --git a/monitor.c b/monitor.c
index
On Mon, Jun 07, 2010 at 02:19:28PM +0200, Markus Armbruster wrote:
Kevin Wolf kw...@redhat.com writes:
Am 02.06.2010 00:12, schrieb Eduardo Habkost:
The first eject command didn't work because the is_inserted() check
failed.
But does it really make a difference? The guest should not see
7:
ftp://ftp.seagate.com/sff/INF-8090.PDF
[ehabkost: solved conficts on monitor.c eject_device()]
Signed-off-by: Naphtali Sprei nsp...@redhat.com
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
This patch needs to be rebaed to the new monitor printing code.
Naphtali, do you plan to do
re-opening the block device, but bdrv_close() is never called.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
monitor.c | 22 ++
1 files changed, 10 insertions(+), 12 deletions(-)
diff --git a/monitor.c b/monitor.c
index 96f7876..97fbe25 100644
--- a/monitor.c
+++ b
On Fri, Dec 18, 2009 at 06:15:27PM -0200, Luiz Capitulino wrote:
On Fri, 18 Dec 2009 17:07:43 -0200
Eduardo Habkost ehabk...@redhat.com wrote:
When using a file, eject works as expected. But when using a host cdrom
device:
(qemu) change ide1-cd0 /dev/cdrom
(qemu) info block
Excerpts from Anthony Liguori's message of Mon Nov 23 00:17:46 -0200 2009:
Paolo Bonzini wrote:
I don't see how this fixes anything. If you used feature bits, how do
you migrate from a version that has a feature bit that an older version
doesn't know about? Do you just ignore it?
I'd
On Mon, Nov 23, 2009 at 03:21:24PM +0100, Paolo Bonzini wrote:
On 11/23/2009 02:51 PM, Eduardo Habkost wrote:
Right, but I wouldn't be surprised if a user complains that I know that
my guest don't use that VM feature, so I want to be able to migrate to
an older version anyway.
That's a bit
Excerpts from Anthony Liguori's message of Mon Nov 23 12:49:23 -0200 2009:
Juan Quintela wrote:
But if you know substitute qemu-0.11 and qemu-0.12 for RHEL5.4 and
RHEL5.4.1, you will see that the code bases are going to be really,
really similar. And if any savevm format is changed, it is
On Mon, Nov 23, 2009 at 09:00:05AM -0600, Anthony Liguori wrote:
snip
I think the problem is that you shouldn't be changing the guest visible
state in a stable update of qemu. If you change the guest visible state
in a stable update, then you won't be able to support live migration
Excerpts from Anthony Liguori's message of Mon Nov 23 14:16:39 -0200 2009:
Eduardo Habkost wrote:
Excerpts from Anthony Liguori's message of Mon Nov 23 12:49:23 -0200 2009:
snip
In our own stable branch, we do not introduce any savevm changes. I
would recommend the same policy
On Mon, Nov 23, 2009 at 12:28:16PM -0600, Anthony Liguori wrote:
Eduardo Habkost wrote:
That may be good enough for upstream Qemu, but IMO for RHEL it is not a
realistic policy. If the definition of guest visible state is buggy on
the current implementation, we can't drop entirely
Excerpts from Anthony Liguori's message of Mon Nov 23 14:44:04 -0200 2009:
I don't want to transparently migrate from 5.4.1 to 5.4.0 and have my
guest's time start drifting. I specifically want that to fail.
If you migrate from 5.4.0 to 5.4.0 or from 5.4.0 to 5.4.1, the guest
will also
On Mon, Nov 23, 2009 at 01:49:09PM -0600, Anthony Liguori wrote:
Eduardo Habkost wrote:
On Mon, Nov 23, 2009 at 12:28:16PM -0600, Anthony Liguori wrote:
snip
After mulling over it a bit, here's what I'd suggest:
1) Integrate VMstate with qdev
2) Introduce a bitmap blacklist
, as
do_change() calls eject_device() before re-opening the block device, but
bdrv_close() is never called.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
monitor.c | 20 +---
1 files changed, 9 insertions(+), 11 deletions(-)
diff --git a/monitor.c b/monitor.c
index 3286ba2
than 200 uses of qemu_mallocz(),
qemu_malloc() and qemu_realloc() that don't have an argument of the form
sizeof(...) or similar:
Acked-by: Eduardo Habkost ehabk...@redhat.com
This also makes qemu_realloc(NULL, size) completely equivalent to
qemu_malloc(size), and that's a good thing.
--
Eduardo
wants the virtual
device to be disconnected from the host device.
The is_inserted() has another side effect: a memory leak if the change
command is used multiple times, as do_change() calls eject_device() before
re-opening the block device, but bdrv_close() is never called.
Signed-off-by: Eduardo
eject_device()]
Signed-off-by: Naphtali Sprei nsp...@redhat.com
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
block.c | 24
block.h |1 +
block_int.h |1 +
hw/ide/core.c | 35 +--
monitor.c |1 +
5
is missing on eject_device()).
Naphtali's patch should have included the bdrv_forget_fname() call inside the
bdrv_is_inserted() if block. But instead of fixing it, it can be simply applied
after my patch.
Eduardo Habkost (1):
monitor: allow device to be ejected if no disk is inserted
Naphtali Sprei
It is just set by net_set_boot_mask() and never used. The logic for rom loading
changed a lot since this field was introduced. It is not needed anymore.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
net.c |1 -
net.h |1 -
2 files changed, 0 insertions(+), 2 deletions(-)
diff
101 - 200 of 11343 matches
Mail list logo
