In addition to removing the variable, this also renames the parse_bootdevices()
function to validate_bootdevices(), as we don't need its return value anymore.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
vl.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git
. Checking if the requested boot device is
valid is now a task for the BIOS or the machine-type code.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
net.c | 19 ---
net.h |1 -
vl.c |5 +
3 files changed, 1 insertions(+), 24 deletions(-)
diff --git a/net.c b/net.c
.
Eduardo Habkost (3):
Kill NICInfo.bootable field
kill broken net_set_boot_mask() boot device validation
kill unused boot_devices_bitmap variable
net.c | 20
net.h |2 --
vl.c | 13 -
3 files changed, 4 insertions(+), 31 deletions(-)
On Tue, Jan 10, 2012 at 01:10:51PM -0600, Anthony Liguori wrote:
[...]
@@ -733,10 +732,6 @@ for opt do
;;
--enable-fdt) fdt=yes
;;
- --disable-check-utests) check_utests=no
- ;;
- --enable-check-utests) check_utests=yes
- ;;
--disable-nptl) nptl=no
;;
Subject line shorter]
Signed-off-by: john cooper john.coo...@redhat.com
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
cpus.c |8
kvm-all.c| 36 +---
kvm.h|1 +
qemu-common.h|2
submission is
at Message-ID: 4ddad5e7.2020...@redhat.com,
http://marc.info/?l=qemu-develm=130618871926030.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
sysconfigs/target/target-x86_64.conf |6 +++---
target-i386/cpuid.c |4 ++--
2 files changed, 5 insertions(+), 5
://marc.info/?l=qemu-develm=130618871926030.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
sysconfigs/target/target-x86_64.conf |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sysconfigs/target/target-x86_64.conf
b/sysconfigs/target/target-x86_64.conf
index 09b30a4
of the existing user interface, a solution which minimally
impacts the user is ultimately required.
[ehabkost: edited commit message to have better Subject line]
Signed-off-by: john cooper john.coo...@redhat.com
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
qemu-config.c | 30
-by: Eduardo Habkost ehabk...@redhat.com
---
sysconfigs/target/target-x86_64.conf | 32
1 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/sysconfigs/target/target-x86_64.conf
b/sysconfigs/target/target-x86_64.conf
index ea310bb..d368b6c 100644
cooper john.coo...@redhat.com
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
sysconfigs/target/target-x86_64.conf |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sysconfigs/target/target-x86_64.conf
b/sysconfigs/target/target-x86_64.conf
index fd4e421..09b30a4
Subject lines and split
one large patch changing CPU flags into small steps, so the changes can be more
easily reviewed/discussed. The proof can be checked by looking at the
'cpudefs-v1-john' and 'cpudefs-v2-ehabkost' branches at
git://github.com/ehabkost/qemu-hacks.git.
Eduardo Habkost (5):
cpu defs
recommendations were
received which more accurately represent shipped silicon.
[ehabkost: made Subject line shorter]
Signed-off-by: john cooper john.coo...@redhat.com
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
sysconfigs/target/target-x86_64.conf |6 +++---
1 files changed, 3 insertions
Subject line shorter]
[ehabkost: v2: cosmetic: add x2apic kvm emulated comments to conf file]
Signed-off-by: john cooper john.coo...@redhat.com
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
hw/pc.c |2 +-
sysconfigs/target/target-x86_64.conf | 12
] -- Intel host
[Opteron_G1, Opteron_G2, Opteron_G3] x [F12-64, win64, win32] -- AMD
host
Yielding successful boots in all cases.
Signed-off-by: john cooper john.coo...@redhat.com
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
sysconfigs/target/target-x86_64.conf |6
address
such quirks.
[ehabkost: edited commit message to have a better Subject line]
Signed-off-by: john cooper john.coo...@redhat.com
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
sysconfigs/target/target-x86_64.conf | 14 ++
1 files changed, 14 insertions(+), 0 deletions
Ouch, the subject prefix is completely wrong because of broken
git-send-email config on my side, sorry.
Please ignore the 'RHEL6 qemu-kvm' prefix, it is actually supposed to go
to the main Qemu tree.
--
Eduardo
]
Signed-off-by: john cooper john.coo...@redhat.com
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
hw/pc.c | 39 +++
target-i386/helper.c |1 +
2 files changed, 36 insertions(+), 4 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index 5b94e53
(CCing Marcelo, Avi, and kvm mailing list, so they can help answering
the uq/master patch flow question)
On Fri, Jun 03, 2011 at 12:51:42AM +0200, Jan Kiszka wrote:
On 2011-06-02 21:34, Eduardo Habkost wrote:
Ouch, the subject prefix is completely wrong because of broken
git-send-email
On Wed, Jun 08, 2011 at 04:11:05PM +0200, Jan Kiszka wrote:
kvm_arch_get_supported_cpuid checks for global cpuid restrictions, it
does not require any CPUState reference. Changing its interface allows
to call it before any VCPU is initialized.
I'm wondering if it wouldn't be simpler to keep
On Thu, Jun 09, 2011 at 07:41:03PM +0200, Jan Kiszka wrote:
snip
I'm wondering if it wouldn't be simpler to keep the existing interface
but just initialize CPUState-kvm_state earlier (today it is initialized
only on kvm_init_vcpu(), although the kvm_state global is initialized
much
On Wed, Jun 08, 2011 at 04:11:03PM +0200, Jan Kiszka wrote:
snip
@@ -217,7 +209,6 @@ int kvm_arch_get_registers(CPUState *env)
return ret;
}
-#ifdef KVM_CAP_PPC_BOOKE_SREGS
if (sregs.u.e.features KVM_SREGS_E_BASE) {
env-spr[SPR_BOOKE_CSRR0] =
Hi,
While checking the cpu model code, I don't think I understand fully what
is supposed to be the right semantics for '-cpu host' on qemu-kvm, and
what exactly we are aiming to.
Maybe this was already discussed before, but I failed to find any
additional information except for the original
enables the unit tests by default, so
you don't have to re-run configure with a special switch.
Reviewed-by: Markus Armbruster arm...@redhat.com
One test fails, but Luiz has a fix in his tree.
Reviewed-by: Eduardo Habkost ehabk...@redhat.com
Now all tests are passing. Why
On Tue, Oct 25, 2011 at 03:27:35PM +0200, Gerd Hoffmann wrote:
[...]
A while ago I played with some simple IDE tests. It basically was a
small x86 kernel with an empty image that sends IDE commands and prints
some results, and a script that invokes the guest and checks whether the
test has
clearing 's-file'. In both cases the fix below could just be hiding
the real issue, but let's get started...
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
Acked-by: Eduardo Habkost ehabk...@redhat.com
However, it looks like the error-check interface of QEMUFile is really
easy to misuse
value
- migrate_fd_cancel(): doesn't check the migrate_fd_cleanup() return
value
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
migration.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/migration.c b/migration.c
index 3b4abbd..a98897c 100644
--- a/migration.c
In case close() fails, we want to report the error back.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
migration-fd.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/migration-fd.c b/migration-fd.c
index d0aec89..4d86d43 100644
--- a/migration-fd.c
+++ b
This is what qemu_fclose() expects.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
savevm.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/savevm.c b/savevm.c
index 63dd719..7fbc4ca 100644
--- a/savevm.c
+++ b/savevm.c
@@ -243,9 +243,11 @@ static int
Some code uses qemu_file_set_error() already, so use it everywhere
when setting last_error, for consistency.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
savevm.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/savevm.c b/savevm.c
index f01838f..dc3311b
All qemu_fclose() callers were already changed to accept any negative
value as error, so we now can change it to return -errno.
When the process exits with a non-zero exit code, we return -EIO to as a
fake errno value.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
migration-exec.c
In case close() fails, we want to report the error back.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
migration-tcp.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/migration-tcp.c b/migration-tcp.c
index 5aa742c..fd5fd56 100644
--- a/migration-tcp.c
Note that we don't return the unchanged return value back yet, because
we need to change all qemu_fclose() callers to accept any positive value
as success.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
migration-exec.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
qemu_fclose() and QEMUFile-close will return -errno on error, and any
positive value on success.
We need the positive non-zero success values because
migration-exec.c:exec_close() relies on non-zero return values to get
the process exit code.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
check (yet)
- do_savevm(): no return value check (yet)
- load_vmstate(): no return value check (yet)
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
savevm.c | 46 +++---
1 files changed, 43 insertions(+), 3 deletions(-)
diff --git a/savevm.c b
In case close() fails, we want to report the error back.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
migration-unix.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/migration-unix.c b/migration-unix.c
index 8596353..197285c 100644
--- a/migration-unix.c
This is what qemu_fclose() expects.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
savevm.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/savevm.c b/savevm.c
index 3c746a6..63dd719 100644
--- a/savevm.c
+++ b/savevm.c
@@ -233,8 +233,9 @@ static int
)
- socket_close
- No system call is made, returns always 0.
- bdrv_fclose
- No system call is made, returns always 0.
Eduardo Habkost (11):
savevm: use qemu_file_set_error() instead of setting last_error
directly
QEMUFileCloseFunc: add return value documentation
exec_close(): accept any
On Wed, Nov 02, 2011 at 08:33:05AM +0100, Paolo Bonzini wrote:
On 11/01/2011 08:20 PM, Eduardo Habkost wrote:
+/** Calls close function and set last_error if needed
+ *
+ * Internal function. qemu_fflush() must be called before this.
+ *
+ * Returns f-close() return value, or 0 if close
On Wed, Nov 02, 2011 at 01:15:46PM +0100, Paolo Bonzini wrote:
On 11/02/2011 12:56 PM, Eduardo Habkost wrote:
No, if it's positive it won't be set on last_error, so we have to save
it somewhere other than last_error (that's what the qemu_close() return
value is used for).
Ok, I was confused
On Tue, Nov 01, 2011 at 05:20:25PM -0200, Eduardo Habkost wrote:
This is what qemu_fclose() expects.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
savevm.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/savevm.c b/savevm.c
index 3c746a6..63dd719
On Tue, Nov 08, 2011 at 11:24:30AM -0600, Anthony Liguori wrote:
On 11/03/2011 09:45 PM, Wen Congyang wrote:
We disable vm_clock when pausing all vcpus, but we forget to
reenable it when resuming all vcpus. It will cause that the
guest can not be rebooted.
Signed-off-by: Wen
check (yet)
- do_savevm(): no return value check (yet)
- load_vmstate(): no return value check (yet)
Changes v1 - v2:
- Add small comment about the need to return previously-spotted errors
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
savevm.c | 49
This is what qemu_fclose() expects.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
savevm.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/savevm.c b/savevm.c
index 5112d66..ee49288 100644
--- a/savevm.c
+++ b/savevm.c
@@ -244,9 +244,11 @@ static int
value
- migrate_fd_cancel(): doesn't check the migrate_fd_cleanup() return
value
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
migration.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/migration.c b/migration.c
index 4b17566..5a33003 100644
--- a/migration.c
Some code uses qemu_file_set_error() already, so use it everywhere
when setting last_error, for consistency.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
savevm.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/savevm.c b/savevm.c
index bee16c0..2dab5dc
Note that we don't return the unchanged return value back yet, because
we need to change all qemu_fclose() callers to accept any positive value
as success.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
migration-exec.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
In case close() fails, we want to report the error back.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
migration-unix.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/migration-unix.c b/migration-unix.c
index 8596353..197285c 100644
--- a/migration-unix.c
In case close() fails, we want to report the error back.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
migration-tcp.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/migration-tcp.c b/migration-tcp.c
index 5aa742c..fd5fd56 100644
--- a/migration-tcp.c
- Fixed to return -errno on close() errors. (patch 11)
- socket_close
- No system call is made, returns always 0.
- bdrv_fclose
- No system call is made, returns always 0.
Eduardo Habkost (10):
savevm: use qemu_file_set_error() instead of setting last_error
directly
All qemu_fclose() callers were already changed to accept any negative
value as error, so we now can change it to return -errno.
When the process exits with a non-zero exit code, we return -EIO to as a
fake errno value.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
migration-exec.c
on comment text
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
hw/hw.h |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/hw/hw.h b/hw/hw.h
index ed20f5a..efa04d1 100644
--- a/hw/hw.h
+++ b/hw/hw.h
@@ -27,7 +27,13 @@ typedef int (QEMUFilePutBufferFunc)(void *opaque
This is what qemu_fclose() expects.
Changes v1 - v2:
- On success, keep returning pclose() return value, instead of always 0.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
savevm.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/savevm.c b/savevm.c
index
On Wed, Nov 09, 2011 at 07:57:35PM -0600, Anthony Liguori wrote:
On 11/09/2011 04:03 PM, Eduardo Habkost wrote:
I am not sure if this is appropriate post-freeze, I will let the maintainers
decide this. Personally I think the code is more reliable with these changes,
but on the other hand
On Thu, Nov 10, 2011 at 04:21:46PM +0800, Dong Xu Wang wrote:
if (s-fd != -1) {
- close(s-fd);
+ if (close(s-fd) 0)
+ r = -errno;
Braces {} are necessary, or checkpatch.pl will give warnings, also in
other patches in your series.
No mistake, just
I will send v3 of this series with changes to comply with coding style,
fixing warnings detected by checkpatch.pl.
--
Eduardo
value
- migrate_fd_cancel(): doesn't check the migrate_fd_cleanup() return
value
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
migration.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/migration.c b/migration.c
index 4b17566..5a33003 100644
--- a/migration.c
In case close() fails, we want to report the error back.
Changes v1 - v2:
- Use braces on if statement to match coding style
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
migration-tcp.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/migration-tcp.c b
This is what qemu_fclose() expects.
Changes v1 - v2:
- Add braces to if statement to match coding style
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
savevm.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/savevm.c b/savevm.c
index a870b3f..4ccbc1c
Note that we don't return the unchanged return value back yet, because
we need to change all qemu_fclose() callers to accept any positive value
as success.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
migration-exec.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
Some code uses qemu_file_set_error() already, so use it everywhere
when setting last_error, for consistency.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
savevm.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/savevm.c b/savevm.c
index bee16c0..2dab5dc
on comment text
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
hw/hw.h |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/hw/hw.h b/hw/hw.h
index ed20f5a..efa04d1 100644
--- a/hw/hw.h
+++ b/hw/hw.h
@@ -27,7 +27,13 @@ typedef int (QEMUFilePutBufferFunc)(void *opaque
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
migration-exec.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/migration-exec.c b/migration-exec.c
index 626b648..e14552e 100644
--- a/migration-exec.c
+++ b/migration-exec.c
@@ -50,12 +50,9 @@ static int
check (yet)
- do_savevm(): no return value check (yet)
- load_vmstate(): no return value check (yet)
Changes v1 - v2:
- Add small comment about the need to return previously-spotted errors
Changes v2 - v3:
- Add braces to if statements to match coding style
Signed-off-by: Eduardo Habkost ehabk
In case close() fails, we want to report the error back.
Changes v1 - v2:
- Use braces on if statement to match coding style
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
migration-unix.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/migration-unix.c b
-errno on close() errors. (patch 11)
- socket_close
- No system call is made, returns always 0.
- bdrv_fclose
- No system call is made, returns always 0.
Eduardo Habkost (10):
savevm: use qemu_file_set_error() instead of setting last_error
directly
QEMUFileCloseFunc: add return
This is what qemu_fclose() expects.
Changes v1 - v2:
- On success, keep returning pclose() return value, instead of always 0.
Changes v2 - v3:
- Add braces on if statements to match coding style
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
savevm.c |3 +++
1 files changed, 3
On Wed, Jul 25, 2012 at 05:47:36PM +0300, Gleb Natapov wrote:
On Fri, Jul 20, 2012 at 05:00:25PM -0300, Eduardo Habkost wrote:
Hi,
While working at the CPU index vs APIC ID changes, I stumbled upon
another not-very-well-defined interface between SeaBIOS and QEMU, and I
would like
), but by coincidence every single
one was changed on QEMU-1.1.
- Conroe, Penryn, Nehalem, Opteron_G1, Opteron_G2, Opteron_G3:
added on 0.13, changed on 1.1
- Westmere, SandyBridge, Opteron_G4: added on 1.1
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
hw/pc_piix.c | 56
Other code directly related to the board init function may be moved
there.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
hw/boards.h |7 +++
vl.c| 14 +-
2 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/hw/boards.h b/hw/boards.h
index 59c01d0
could use.
Eduardo Habkost (3):
vl.c: extract qemu_machine_init() function
per-machine-type CPU model alias system
x86: pc: versioned CPU model names compatibility aliases
hw/boards.h| 13 +
hw/pc_piix.c | 56
This allow QEMUMachine structs to contain a list of CPU model aliases,
used to keep command-line compatibility with older machine types, while
making CPU model fixes available on newer machine types.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
hw/boards.h |6 ++
vl.c
On Mon, Jul 23, 2012 at 03:20:14PM +0300, Gleb Natapov wrote:
On Fri, Jul 20, 2012 at 02:04:50PM -0300, Eduardo Habkost wrote:
Extract Local APIC IDs directly from the CPUs, and instead of check for
i CountCPUs, check if the APIC ID was present on boot, when building
ACPI tables and the MP
Changes v2 - v3:
- Report I/O APIC ID = 0 on MP-table, too
Changes v1 - v2:
- Patch 1/2: cosmetic whitespace change
- Patch 2/2: use size suffixes on asm instructions on smp.c
- New patch descriptions
Eduardo Habkost (2):
report real I/O APIC ID (0) on MADT and MP-table (v3)
allow CPUs
reality.
Changes v2 - v3:
- Fix MP-table too, not just ACPI MADT table
Changes v1 - v2:
- Cosmetic: whitespace change (removed extra newline)
- New patch description
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
src/acpi.c|2 +-
src/config.h |1 +
src/mptable.c |2 +-
3
be exactly the
same. This patch will simply allow QEMU to start setting non-contiguous
APIC IDs (that is a requirement for some sockets/cores/threads topology
settings).
Changes v1 - v2:
- Use size suffixes on all asm instructions on smp.c
- New patch description
Signed-off-by: Eduardo Habkost ehabk
On Wed, Jul 25, 2012 at 06:43:25PM -0500, Anthony Liguori wrote:
Eduardo Habkost ehabk...@redhat.com writes:
Hi,
This is the first try at a simple system to make the CPU model definitions
versioned (to allow them to get bug fixes while allowing migration from
older
versions
On Thu, Jul 26, 2012 at 09:08:40AM +0300, Gleb Natapov wrote:
On Wed, Jul 25, 2012 at 03:42:21PM -0300, Eduardo Habkost wrote:
On Mon, Jul 23, 2012 at 03:20:14PM +0300, Gleb Natapov wrote:
On Fri, Jul 20, 2012 at 02:04:50PM -0300, Eduardo Habkost wrote:
Extract Local APIC IDs directly
On Thu, Jul 26, 2012 at 12:52:33AM +0200, Andreas Färber wrote:
Am 25.07.2012 20:18, schrieb Eduardo Habkost:
This adds version number to CPU model names on the pc-version
machine-types, so we can create new models with bug fixes while keeping
compatibility when using older machine-types
On Thu, Jul 26, 2012 at 04:06:03PM +0200, Andreas Färber wrote:
Am 26.07.2012 15:53, schrieb Eduardo Habkost:
On Wed, Jul 25, 2012 at 06:43:25PM -0500, Anthony Liguori wrote:
Eduardo Habkost ehabk...@redhat.com writes:
Hi,
This is the first try at a simple system to make the CPU model
On Thu, Jul 26, 2012 at 04:31:45PM +0200, Andreas Färber wrote:
Am 26.07.2012 16:24, schrieb Eduardo Habkost:
On Thu, Jul 26, 2012 at 12:52:33AM +0200, Andreas Färber wrote:
Am 25.07.2012 20:18, schrieb Eduardo Habkost:
This adds version number to CPU model names on the pc-version
machine
On Thu, Jul 26, 2012 at 04:33:36PM +0200, Jiri Denemark wrote:
On Wed, Jul 25, 2012 at 15:18:43 -0300, Eduardo Habkost wrote:
This adds version number to CPU model names on the pc-version
machine-types, so we can create new models with bug fixes while keeping
compatibility when using older
On Thu, Jul 26, 2012 at 05:55:09PM +0300, Avi Kivity wrote:
On 07/26/2012 05:16 PM, Eduardo Habkost wrote:
It's possible to replace the atomic read of CountCPUs with the bitmap
weight
calculation on the loop, but: is it really worth it?
Why not? This eliminates one more global
On Thu, Jul 26, 2012 at 07:08:19PM +0300, Avi Kivity wrote:
On 07/26/2012 06:07 PM, Eduardo Habkost wrote:
On Thu, Jul 26, 2012 at 05:55:09PM +0300, Avi Kivity wrote:
On 07/26/2012 05:16 PM, Eduardo Habkost wrote:
It's possible to replace the atomic read of CountCPUs with the bitmap
On Wed, Jul 25, 2012 at 04:18:01PM -0600, Eric Blake wrote:
On 07/25/2012 12:18 PM, Eduardo Habkost wrote:
Other code directly related to the board init function may be moved
there.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
hw/boards.h |7 +++
vl.c
On Mon, Jul 30, 2012 at 09:34:05AM +0200, Juan Quintela wrote:
Hi
Please send in any agenda items you are interested in covering.
- 1.2 plans for CPU model versioning/compatibility
(global properties vs QOM vs qdev)
--
Eduardo
(or)
suggest who I should talk to get these changes in ?
Thanks!
Vinod
-Original Message-
From: Eduardo Habkost [mailto:ehabk...@redhat.com]
Sent: Wednesday, July 18, 2012 10:15 AM
To: Vinod, Chegu
Cc: qemu-devel@nongnu.org; aligu...@us.ibm.com; k...@vger.kernel.org
Subject: Re: [Qemu
On Tue, Jul 31, 2012 at 03:22:59PM +0200, Igor Mammedov wrote:
On Thu, Jul 26, 2012 at 10:48:45AM -0400, Eduardo Habkost wrote:
...
[1] There are multiple changes I want to make the cpudef config format:
- Make it based on boolean per-feature flags, not low-level
feature_register
On Tue, Jul 31, 2012 at 04:32:05PM +0200, Juan Quintela wrote:
- 1.2 plans for CPU model versioning/compatibility (eduardo)
(global properties vs QOM vs qdev)
how to do it ? configuration file? moving back to the code?
different external interface from internal one
(CCing libvir-list)
On Tue, Jul 31, 2012 at 04:32:05PM +0200, Juan Quintela wrote:
- 1.2 plans for CPU model versioning/compatibility (eduardo)
(global properties vs QOM vs qdev)
how to do it ? configuration file? moving back to the code?
different external interface from internal one
Another question:
On Fri, Jul 27, 2012 at 08:37:18AM -0500, Anthony Liguori wrote:
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
target-i386/cpu.c | 22 ++
1 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index
(indicating they
are built-in models), the output of -cpu ?dump is exactly the same before and
after applying this series.
[1] http://article.gmane.org/gmane.comp.emulators.kvm.devel/95328
Eduardo Habkost (3):
i386: add missing CPUID_* constants
move CPU models from cpus-x86_64.conf to C
This file is not needed anymore, as QEMU won't ship any config-based
cpudefs out of the box, relying only on the builtin CPU models.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Makefile | 1 -
arch_init.c| 1 -
sysconfigs/target/cpus
Those models are maintained by QEMU and may require compatibility code
to be added when making some changes. Keeping the data in the C source
code should make it simpler to handle those details.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
sysconfigs/target/cpus-x86_64.conf | 129
Those constants will be used by new CPU model definitions.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.h | 22 ++
1 file changed, 22 insertions(+)
diff --git a/target-i386/cpu.h b/target-i386/cpu.h
index 2a61c81..c81f7bf 100644
--- a/target-i386
On Wed, Aug 01, 2012 at 10:37:04PM +0300, Lluís Vilanova wrote:
Eduardo Habkost writes:
This file is not needed anymore, as QEMU won't ship any config-based
cpudefs out of the box, relying only on the builtin CPU models.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
On Wed, Aug 01, 2012 at 10:04:50PM +0200, Andreas Färber wrote:
Am 01.08.2012 20:45, schrieb Eduardo Habkost:
This makes the change we discussed on the latest KVM conf call[1], moving
the
existing cpudefs from cpus-x86_64.conf to the C code.
The config file data was converted to C
On Wed, Aug 01, 2012 at 03:41:56PM -0500, Anthony Liguori wrote:
Eduardo Habkost ehabk...@redhat.com writes:
On Wed, Aug 01, 2012 at 10:04:50PM +0200, Andreas Färber wrote:
Am 01.08.2012 20:45, schrieb Eduardo Habkost:
This makes the change we discussed on the latest KVM conf call[1
On Wed, Aug 01, 2012 at 11:53:51PM +0200, Andreas Färber wrote:
Am 01.08.2012 22:27, schrieb Eduardo Habkost:
On Wed, Aug 01, 2012 at 10:04:50PM +0200, Andreas Färber wrote:
Am 01.08.2012 20:45, schrieb Eduardo Habkost:
This makes the change we discussed on the latest KVM conf call[1
Changes to make checkpatch.pl happy:
- Use sizeof(...) instead of sizeof (...);
- Spaces around :;
- Use spaces instead of tabs;
- Braces on if statements.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 66 ++-
1
Make source code lines shorter.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 9414d75..d546534 100644
--- a/target-i386/cpu.c
+++ b/target
201 - 300 of 11343 matches
Mail list logo
