[Qemu-devel] [PATCH v9 03/22] virtio: introduce device specific migration calls

2014-06-24 Thread Greg Kurz
-off-by: Greg Kurz gk...@linux.vnet.ibm.com Reviewed-by: Alexander Graf ag...@suse.de --- hw/block/virtio-blk.c |2 +- hw/char/virtio-serial-bus.c |2 +- hw/net/virtio-net.c |2 +- hw/scsi/virtio-scsi.c |2 +- hw/virtio/virtio-balloon.c |2 +- hw/virtio

[Qemu-devel] [PATCH v9 04/22] virtio-net: implement per-device migration calls

2014-06-24 Thread Greg Kurz
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com Reviewed-by: Alexander Graf ag...@suse.de --- hw/net/virtio-net.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 151d220..699201f 100644 --- a/hw/net

[Qemu-devel] [PATCH v9 05/22] virtio-blk: implement per-device migration calls

2014-06-24 Thread Greg Kurz
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com Reviewed-by: Alexander Graf ag...@suse.de --- hw/block/virtio-blk.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 3b34ce9..fd32a6a 100644

[Qemu-devel] [PATCH v9 06/22] virtio-serial: implement per-device migration calls

2014-06-24 Thread Greg Kurz
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com Reviewed-by: Alexander Graf ag...@suse.de --- hw/char/virtio-serial-bus.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c index

[Qemu-devel] [PATCH v9 07/22] virtio-balloon: implement per-device migration calls

2014-06-24 Thread Greg Kurz
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com Reviewed-by: Alexander Graf ag...@suse.de --- hw/virtio/virtio-balloon.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index 165592e

[Qemu-devel] [PATCH v9 08/22] virtio-rng: implement per-device migration calls

2014-06-24 Thread Greg Kurz
While we are here, we also check virtio_load() return value. Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com Reviewed-by: Alexander Graf ag...@suse.de --- hw/virtio/virtio-rng.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/virtio/virtio-rng.c b/hw

[Qemu-devel] [PATCH v9 09/22] virtio: add subsections to the migration stream

2014-06-24 Thread Greg Kurz
and the start of the next sections. This allows an older QEMU to complain and exit when fed with subsections: Unknown savevm section type 5 load of migration failed Suggested-by: Alexander Graf ag...@suse.de Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com Reviewed-by: Alexander Graf ag...@suse.de

[Qemu-devel] [PATCH v9 10/22] exec: introduce target_words_bigendian() helper

2014-06-24 Thread Greg Kurz
the TARGET_WORDS_BIGENDIAN bits out to a new helper and have virtio_is_big_endian() implemented on top of it. This patch doesn't change any functionality. Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- Changes since v8: - target_words_bigendian() removed from include/exec/cpu-common.h exec.c

[Qemu-devel] [PATCH v9 11/22] cpu: introduce CPUClass::virtio_is_big_endian()

2014-06-24 Thread Greg Kurz
behaviour is to return the compile-time default target endianness. Suggested-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- Changes since v8: - removed the globally visible cpu_virtio_is_big_endian() helper (code is now called directly from virtio

[Qemu-devel] [PATCH v9 12/22] virtio: add endian-ambivalent support to VirtIODevice

2014-06-24 Thread Greg Kurz
. As a consequence, the vring sanity checks had to be moved after the call to vmstate_load_state(). We enforce paranoia by poisoning the property at the begining of virtio_load(). Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- Changes since v8: - introduced a new virtio_current_cpu_endian() helper

[Qemu-devel] [PATCH v9 13/22] virtio: memory accessors for endian-ambivalent targets

2014-06-24 Thread Greg Kurz
-off-by: Rusty Russell ru...@rustcorp.com.au [ relicensed virtio-access.h to GPLv2+ on Rusty's request, pass address_space_memory to physical memory accessors, per-device endianness, virtio tswap16 and tswap64 helpers, faspath for fixed endian targets, Greg Kurz gk...@linux.vnet.ibm.com ] Cc

[Qemu-devel] [PATCH v9 14/22] virtio: allow byte swapping for vring

2014-06-24 Thread Greg Kurz
From: Rusty Russell ru...@rustcorp.com.au Quoting original text from Rusty: This is based on a simpler patch by Anthony Liguouri. Signed-off-by: Rusty Russell ru...@rustcorp.com.au [ add VirtIODevice * argument to most helpers, Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Greg Kurz gk

[Qemu-devel] [PATCH v9 16/22] virtio-balloon: use virtio wrappers to access page frame numbers

2014-06-24 Thread Greg Kurz
From: Rusty Russell ru...@rustcorp.com.au Signed-off-by: Rusty Russell ru...@rustcorp.com.au Reviewed-by: Anthony Liguori aligu...@us.ibm.com [ pass VirtIODevice * to memory accessors, Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com Reviewed-by: Alexander

[Qemu-devel] [PATCH v9 15/22] virtio-net: use virtio wrappers to access headers

2014-06-24 Thread Greg Kurz
From: Rusty Russell ru...@rustcorp.com.au Signed-off-by: Rusty Russell ru...@rustcorp.com.au Reviewed-by: Anthony Liguori aligu...@us.ibm.com [ pass VirtIODevice * to memory accessors, converted new tswap locations to virtio_tswap, Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Greg Kurz

[Qemu-devel] [PATCH v9 18/22] virtio-scsi: use virtio wrappers to access headers

2014-06-24 Thread Greg Kurz
to virtio_tswap, Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com Reviewed-by: Alexander Graf ag...@suse.de --- Changes since v8: - removed some lines that should be sent in a follow-up patch (missing tswaps for ppc64le guests under PowerKVM) - rebased

[Qemu-devel] [PATCH v9 19/22] virtio-serial-bus: use virtio wrappers to access headers

2014-06-24 Thread Greg Kurz
time, Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com Reviewed-by: Alexander Graf ag...@suse.de --- hw/char/virtio-serial-bus.c | 46 +-- 1 file changed, 31 insertions(+), 15 deletions(-) diff --git a/hw/char/virtio

[Qemu-devel] [PATCH v9 20/22] virtio-9p: use virtio wrappers to access headers

2014-06-24 Thread Greg Kurz
Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p. Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com Reviewed-by: Alexander Graf ag...@suse.de --- hw/9pfs/virtio-9p-device.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/9pfs/virtio-9p

[Qemu-devel] [PATCH v9 21/22] target-ppc: enable virtio endian ambivalent support

2014-06-24 Thread Greg Kurz
The device endianness is the cpu endianness at device reset time. Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com Reviewed-by: Alexander Graf ag...@suse.de --- Changes since v8: - added missing register sync target-ppc/cpu.h|2 ++ target-ppc/translate_init.c | 15

[Qemu-devel] [PATCH v9 22/22] vhost-net: disable when cross-endian

2014-06-24 Thread Greg Kurz
-endian qemu-system-ppc64: unable to start vhost net: 38: falling back on userspace virtio This way users can continue to run VMs without changing their setup and have a chance to know that performance will impacted. Suggested-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Greg Kurz gk

Re: [Qemu-devel] [PATCH v9 00/22] legacy virtio support for cross-endian targets

2014-06-24 Thread Greg Kurz
On Tue, 24 Jun 2014 20:25:41 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Jun 24, 2014 at 07:06:58PM +0200, Greg Kurz wrote: The current legacy virtio devices have a fundamental flaw: they all share data between host and guest with guest endianness ordering. This is ok

Re: [Qemu-devel] [PATCH v3 04/25] tcg-ppc64: Relax register restrictions in tcg_out_mem_long

2014-06-26 Thread Greg Kurz
On Fri, 20 Jun 2014 07:13:20 -0700 Richard Henderson r...@twiddle.net wrote: In order to be able to use tcg_out_ld/st sensibly with scratch registers, assert only when we'd incorrectly clobber a scratch. Signed-off-by: Richard Henderson r...@twiddle.net --- Hi, While testing various

Re: [Qemu-devel] [PATCH] tcg/ppc: Fix failure in tcg_out_mem_long

2014-06-27 Thread Greg Kurz
On Thu, 26 Jun 2014 21:26:00 -0700 Richard Henderson r...@twiddle.net wrote: With rt != r0 on loads, we use rt for scratch. If we need an index register different from base, we can't use rt, but r0 is usable. Signed-off-by: Richard Henderson r...@twiddle.net --- This ought to fix the

Re: [Qemu-devel] [PATCH] target-ppc: KVMPPC_H_CAS fix cpu-version endianess

2014-06-27 Thread Greg Kurz
results. If needed, the value is now converted. Fixes: 6d9412ea8132 (target-ppc: Implement compat CPU option) Signed-off-by: Laurent Dufour lduf...@linux.vnet.ibm.com --- Reviewed-by: Greg Kurz gk...@linux.vnet.ibm.com hw/ppc/spapr.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions

Re: [Qemu-devel] [PATCH v9 00/22] legacy virtio support for cross-endian targets

2014-06-30 Thread Greg Kurz
On Sun, 29 Jun 2014 18:13:53 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Jun 24, 2014 at 07:06:58PM +0200, Greg Kurz wrote: The current legacy virtio devices have a fundamental flaw: they all share data between host and guest with guest endianness ordering. This is ok for nearly

[Qemu-devel] [PATCH] virtio-scsi: virtio_scsi_push_event() lacks VirtIOSCSIReq parsing

2014-06-30 Thread Greg Kurz
a call to virtio_scsi_parse_req(). It also drops the in size sanity check since it is already done by virtio_scsi_parse_req(). This is enough to have hotplug working again. Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- I guess the following check could also be handled

[Qemu-devel] [PATCH] virtio-scsi: scsi events must be converted to target endianness

2014-06-30 Thread Greg Kurz
virtio scsi event 100 This issue got uncovered while testing disk hotplug with a PowerKVM ppc64le guest. I have checked that this issue also affects a x86_64 guest run on a ppc64 host. Signed-off-by: Cédric Le Goater c...@fr.ibm.com [ Ported from PowerKVM, Greg Kurz gk...@linux.vnet.ibm.com

[Qemu-devel] [PATCH v2] virtio-scsi: virtio_scsi_push_event() lacks VirtIOSCSIReq parsing

2014-06-30 Thread Greg Kurz
a call to virtio_scsi_parse_req(). It also drops some sanity checks that are already performed by virtio_scsi_parse_req(). Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- Changes in v2: - dropped now useless req-elem.out_num sanity check hw/scsi/virtio-scsi.c |8 +--- 1 file changed

[Qemu-devel] [PATCH RFC 0/8] virtio: migrate new properties

2014-05-14 Thread Greg Kurz
a suggestion from Alex: - patches 1 to 7 adds optional subsections in the virtio migration stream - patch 8 belongs to the virtio endianness serie, it is sent as an example Thanks for your comments. --- Greg Kurz (8): virtio: add subsections to the migration stream virtio-net: migrate

[Qemu-devel] [PATCH RFC 2/8] virtio-net: migrate subsections

2014-05-14 Thread Greg Kurz
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/net/virtio-net.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index fd23c46..4004d02 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -1300,6 +1300,8 @@ static void

[Qemu-devel] [PATCH RFC 6/8] virtio-balloon: migrate subsections

2014-05-14 Thread Greg Kurz
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/virtio/virtio-balloon.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index a470a0b..41f7ae1 100644 --- a/hw/virtio/virtio-balloon.c +++ b/hw/virtio/virtio

[Qemu-devel] [PATCH RFC 7/8] virtio-rng: migrate subsections

2014-05-14 Thread Greg Kurz
While we are here, we also check virtio_load() return value. Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/virtio/virtio-rng.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c index b6ab361..0371103

[Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-14 Thread Greg Kurz
...@suse.de Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/virtio/virtio.c | 65 include/hw/virtio/virtio.h |4 +++ 2 files changed, 69 insertions(+) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index aeabf3a..f4eaa3f

[Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-05-14 Thread Greg Kurz
is restored (virtio_load_device_endian) We enforce some paranoia by making the endianness a 3-value enum so that we can poison it when it should not be used. Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- exec.c |8 +- hw/virtio/virtio-pci.c | 11 +++- hw/virtio

[Qemu-devel] [PATCH RFC 3/8] virtio-blk: migrate subsections

2014-05-14 Thread Greg Kurz
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/block/virtio-blk.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 8a568e5..5a0d224 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio-blk.c @@ -600,6

[Qemu-devel] [PATCH RFC 4/8] virtio-scsi: migrate subsections

2014-05-14 Thread Greg Kurz
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/scsi/virtio-scsi.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index b0d7517..989e4ed 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -471,6 +471,7

[Qemu-devel] [PATCH RFC 5/8] virtio-serial: migrate subsections

2014-05-14 Thread Greg Kurz
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/char/virtio-serial-bus.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c index 2b647b6..98f32fd 100644 --- a/hw/char/virtio-serial-bus.c +++ b/hw

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Greg Kurz
On Thu, 15 May 2014 11:34:25 +0530 Amit Shah amit.s...@redhat.com wrote: On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: There is a need to add some more fields to VirtIODevice that should be migrated (broken status, endianness). The problem is that we do not want to break compatibility

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Greg Kurz
On Thu, 15 May 2014 12:16:35 +0530 Amit Shah amit.s...@redhat.com wrote: On (Thu) 15 May 2014 [09:23:51], Michael S. Tsirkin wrote: On Thu, May 15, 2014 at 11:34:25AM +0530, Amit Shah wrote: On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: There is a need to add some more fields

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Greg Kurz
On Thu, 15 May 2014 11:20:18 +0200 Andreas Färber afaer...@suse.de wrote: Am 15.05.2014 09:04, schrieb Greg Kurz: On Thu, 15 May 2014 12:16:35 +0530 Amit Shah amit.s...@redhat.com wrote: On (Thu) 15 May 2014 [09:23:51], Michael S. Tsirkin wrote: On Thu, May 15, 2014 at 11:34:25AM +0530

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Greg Kurz
On Thu, 15 May 2014 12:08:26 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote: On Thu, 15 May 2014 11:20:18 +0200 Andreas Färber afaer...@suse.de wrote: Am 15.05.2014 09:04, schrieb Greg Kurz: On Thu, 15 May 2014 12:16:35 +0530 Amit Shah amit.s...@redhat.com wrote: On (Thu) 15 May 2014

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Greg Kurz
On Thu, 15 May 2014 13:12:12 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, May 15, 2014 at 12:08:26PM +0200, Greg Kurz wrote: On Thu, 15 May 2014 11:20:18 +0200 Andreas Färber afaer...@suse.de wrote: Am 15.05.2014 09:04, schrieb Greg Kurz: On Thu, 15 May 2014 12:16:35 +0530

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Greg Kurz
Kurz: On Thu, 15 May 2014 12:16:35 +0530 Amit Shah amit.s...@redhat.com wrote: On (Thu) 15 May 2014 [09:23:51], Michael S. Tsirkin wrote: On Thu, May 15, 2014 at 11:34:25AM +0530, Amit Shah wrote: On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: Since each virtio device

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Greg Kurz
Färber wrote: Am 15.05.2014 11:52, schrieb Michael S. Tsirkin: On Thu, May 15, 2014 at 11:20:18AM +0200, Andreas Färber wrote: Am 15.05.2014 09:04, schrieb Greg Kurz: On Thu, 15 May 2014 12:16:35 +0530 Amit Shah amit.s...@redhat.com wrote: On (Thu) 15 May 2014 [09:23:51], Michael S. Tsirkin

Re: [Qemu-devel] dump-guest-memory command?

2014-05-16 Thread Greg Kurz
On Fri, 16 May 2014 14:24:16 +0800 Jun Koi junkoi2...@gmail.com wrote: Hi, Anybody please help me on this dump-guest-memory command? How does the virtual memory map to the dumped file? For example, if x86 register RIP points to 0x12345, how does that map to the dump file? Meaning how can

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-16 Thread Greg Kurz
On Fri, 16 May 2014 17:40:00 +0800 Fam Zheng f...@redhat.com wrote: On Fri, 05/16 11:22, Andreas Färber wrote: Am 16.05.2014 11:14, schrieb Fam Zheng: On Thu, 05/15 12:08, Greg Kurz wrote: The main problem I see is that virtio sucks: as you see in patch 8, we have to be careful

Re: [Qemu-devel] dump-guest-memory command?

2014-05-16 Thread Greg Kurz
On Fri, 16 May 2014 16:40:23 +0800 Jun Koi junkoi2...@gmail.com wrote: On Fri, May 16, 2014 at 3:03 PM, Greg Kurz gk...@linux.vnet.ibm.com wrote: On Fri, 16 May 2014 14:24:16 +0800 Jun Koi junkoi2...@gmail.com wrote: Hi, Anybody please help me on this dump-guest-memory command? How

Re: [Qemu-devel] dump-guest-memory command?

2014-05-16 Thread Greg Kurz
On Fri, 16 May 2014 16:51:36 +0800 Jun Koi junkoi2...@gmail.com wrote: On Fri, May 16, 2014 at 4:45 PM, Andreas Färber afaer...@suse.de wrote: Am 16.05.2014 10:40, schrieb Jun Koi: What I want to know is how to map 0x12345 (virtual address) back to the dump file. For example, if

Re: [Qemu-devel] dump-guest-memory command?

2014-05-16 Thread Greg Kurz
On Fri, 16 May 2014 17:59:25 +0800 Jun Koi junkoi2...@gmail.com wrote: On Fri, May 16, 2014 at 5:51 PM, Greg Kurz gk...@linux.vnet.ibm.com wrote: On Fri, 16 May 2014 16:40:23 +0800 Jun Koi junkoi2...@gmail.com wrote: On Fri, May 16, 2014 at 3:03 PM, Greg Kurz gk...@linux.vnet.ibm.com

[Qemu-devel] [PATCH RFC V2 0/8] virtio: migrate new properties

2014-05-19 Thread Greg Kurz
/save methods to VirtioDeviceClass. - virtio subsections now implement a needed concept with the same semantics as in the VMState code. I haven't looked at compat mode issues yet, but it is on my TODO list. Cheers. --- Greg Kurz (8): virtio: introduce device specific migration calls

[Qemu-devel] [PATCH RFC 2/8] virtio-net: implement per-device migration calls

2014-05-19 Thread Greg Kurz
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/net/virtio-net.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index e0dc544..d319ac2 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c

[Qemu-devel] [PATCH RFC 3/8] virtio-blk: implement per-device migration calls

2014-05-19 Thread Greg Kurz
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/block/virtio-blk.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 63d4ccd..a50be54 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio

[Qemu-devel] [PATCH RFC 4/8] virtio-serial: implement per-device migration calls

2014-05-19 Thread Greg Kurz
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/char/virtio-serial-bus.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c index b0f322a..ce336a0 100644 --- a/hw/char/virtio

[Qemu-devel] [PATCH RFC 1/8] virtio: introduce device specific migration calls

2014-05-19 Thread Greg Kurz
In order to migrate virtio subsections, we need the device specific code to be called from the common migration code. This patch introduces load and save methods for this purpose. Suggested-by: Andreas Färber afaer...@suse.de Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/block/virtio

[Qemu-devel] [PATCH RFC 5/8] virtio-balloon: implement per-device migration calls

2014-05-19 Thread Greg Kurz
Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/virtio/virtio-balloon.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index 6d8ec72..a3a9ac1 100644 --- a/hw/virtio/virtio-balloon.c

[Qemu-devel] [PATCH RFC 6/8] virtio-rng: implement per-device migration calls

2014-05-19 Thread Greg Kurz
While we are here, we also check virtio_load() return value. Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/virtio/virtio-rng.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c index 025de81..1356aca

[Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-05-19 Thread Greg Kurz
to be moved from virtio_load() to virtio_load_subsections() because of that. We enforce some paranoia by making the endianness a 3-value enum so that we can temporarily poison it while loading state. Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- exec.c |8 +--- hw/virtio

[Qemu-devel] [PATCH RFC 7/8] virtio: add subsections to the migration stream

2014-05-19 Thread Greg Kurz
Graf ag...@suse.de Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/virtio/virtio.c | 78 +++- 1 file changed, 77 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index cf87b44..7fbad29 100644 --- a/hw/virtio

Re: [Qemu-devel] [PATCH RFC V2 0/8] virtio: migrate new properties

2014-05-19 Thread Greg Kurz
On Mon, 19 May 2014 14:02:39 +0200 Alexander Graf ag...@suse.de wrote: On 19.05.14 10:38, Greg Kurz wrote: Hi, This patch set tries to address comments from the initial review. For this round, I have focused on two changes: - as suggested by Andreas, we now call the device specific

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-05-19 Thread Greg Kurz
On Mon, 19 May 2014 10:39:09 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote: Some CPU families can dynamically change their endianness. This means we can have little endian ppc or big endian arm guests for example. This has an impact on legacy virtio data structures since they are target

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-05-19 Thread Greg Kurz
On Mon, 19 May 2014 19:06:39 +0200 Andreas Färber afaer...@suse.de wrote: Am 19.05.2014 15:06, schrieb Greg Kurz: On Mon, 19 May 2014 10:39:09 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote: diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 7fbad29..6578854 100644 --- a/hw

[Qemu-devel] [PATCH v4 1/4] dump: Make DumpState and endian conversion routines available for arch-specific dump code

2014-05-19 Thread Greg Kurz
helpers, Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- No change dump.c | 228 +--- include/sysemu/dump-arch.h | 28 + include/sysemu/dump.h | 48 +++-- stubs/dump.c

[Qemu-devel] [PATCH v4 0/4] little-endian dump for ppc64

2014-05-19 Thread Greg Kurz
like applying it right away :P Thanks. --- Bharata B Rao (3): dump: Make DumpState and endian conversion routines available for arch-specific dump code target-ppc: Support dump for little endian ppc64 target-ppc: Set the correct endianness in ELF dump header Greg Kurz (1

[Qemu-devel] [PATCH v4 2/4] target-ppc: Support dump for little endian ppc64

2014-05-19 Thread Greg Kurz
, introduced NoteFuncArg, use new cpu_to_dump{16,32,64} endian helpers, fix altivec support, Greg Kurz gk...@linux.vnet.ibm.com ] Reviewed-by: Alexander Graf ag...@suse.de Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- Changes since v3: Fixed AltiVec. target-ppc/arch_dump.c | 95

[Qemu-devel] [PATCH v4 4/4] target-ppc: Set the correct endianness in ELF dump header

2014-05-19 Thread Greg Kurz
From: Bharata B Rao bhar...@linux.vnet.ibm.com Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com Reviewed-by: Alexander Graf ag...@suse.de Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- No change. target-ppc/arch_dump.c | 12 1 file changed, 8 insertions(+), 4

[Qemu-devel] [PATCH v4 3/4] target-ppc: ppc can be either endian

2014-05-19 Thread Greg Kurz
is needed to write ELF headers using the kernel endianness. Suggested-by: Benjamin Herrenschmidt b...@kernel.crashing.org Reviewed-by: Alexander Graf ag...@suse.de Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- Changes since v3: updated description target-ppc/cpu-qom.h|1

Re: [Qemu-devel] [Qemu-ppc] [PATCH 9/9] spapr_hcall: Add address-translation-mode-on-interrupt resource in H_SET_MODE

2014-05-21 Thread Greg Kurz
On Wed, 21 May 2014 16:20:28 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: This adds handling of the RESOURCE_ADDR_TRANS_MODE resource from the H_SET_MODE, for POWER8 (PowerISA 2.07) only. This defines AIL flags for LPCR special register. This changes @excp_prefix according to the

Re: [Qemu-devel] [Qemu-ppc] [PATCH V9 2/5] target-ppc: Fix htab_mask calculation

2014-02-12 Thread Greg Kurz
On Wed, 12 Feb 2014 00:16:25 +0530 Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: Hi Greg, can you try the below patch and see if it fix the TCG mode failure ? -aneesh Hi Aneesh, The patche fixes the issue indeed. Maybe a helper could be factored out since we have 4 times the

[Qemu-devel] [PATCH] target-ppc: fix 32 bit build break in the page table lookup code

2014-02-12 Thread Greg Kurz
page table lookup code. Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/ppc/spapr_hcall.c|6 +++--- target-ppc/kvm.c| 10 +- target-ppc/kvm_ppc.h| 10 +- target-ppc/mmu-hash64.c | 28 +++- target-ppc/mmu-hash64.h | 25

[Qemu-devel] [PATCH] target-ppc: fix warn_unused_result build break with in-kernel HTAB support

2014-02-12 Thread Greg Kurz
)); ^ Even though nothing is done for the moment if kvm_htab_write() fails, we obviously need to be explicit. Let's add an *empty* return path to please gcc. Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- target-ppc/kvm.c | 10 -- 1 file changed, 8 insertions(+), 2

Re: [Qemu-devel] [Qemu-ppc] [PATCH V10] target-ppc: Fix htab_mask calculation

2014-02-13 Thread Greg Kurz
for external htab and if found true, we don't need to update sdr1 Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Reviewed-by: Greg Kurz gk...@linux.vnet.ibm.com --- Changes from V9: * Fix TCG breakage Alex, This patch is a complete replacement for commit 1df2d6d900a9

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: fix 32 bit build break in the page table lookup code

2014-02-13 Thread Greg Kurz
On Thu, 13 Feb 2014 15:53:16 +0100 Alexander Graf ag...@suse.de wrote: On 13.02.2014, at 04:00, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: Greg Kurz gk...@linux.vnet.ibm.com writes: The 396bb9874 commit reworked page table lookup to support kvm. Unfortunately

Re: [Qemu-devel] [PATCH 0/7] virtio endian-ambivalent target fixes.

2014-02-14 Thread Greg Kurz
On Thu, 17 Oct 2013 14:23:35 +1030 Rusty Russell ru...@rustcorp.com.au wrote: This is a re-transmit of the core of the virtio endian code. Since there seems to be some interest in ARM BE virtio, I've separated this from the direct problem I was solving: PowerPC LE. Please apply! Rusty.

Re: [Qemu-devel] [Qemu-ppc] [PATCH V10] target-ppc: Fix htab_mask calculation

2014-02-15 Thread Greg Kurz
On Fri, 14 Feb 2014 15:42:49 +0100 Alexander Graf ag...@suse.de wrote: [...] -M mac99 also fails miserably. It almost looks as if the mask cuts off some bits, but please investigate this yourself. I'll remove the patch from the queue meanwhile. Sigh, this whole series is just way too

[Qemu-devel] [PATCH 0/4] target-ppc: htab fixes

2014-02-17 Thread Greg Kurz
Hi, This is a new tentative for the patches 2/5 to 5/5 from the target-ppc: Add support for dumping guest memory using qemu gdb server patchset: https://lists.nongnu.org/archive/html/qemu-ppc/2014-01/msg00380.html All patches have been rebased on the current ppc-next head (72c798d7dccc). To

[Qemu-devel] [PATCH 1/4] target-ppc: Fix htab_mask calculation

2014-02-17 Thread Greg Kurz
computation in ppc_hash64_htab_lookup() that caused TCG to fail, Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com Signed-off-by: Alexander Graf ag...@suse.de --- hw/ppc/spapr.c |8

[Qemu-devel] [PATCH 4/4] target-ppc: Update ppc_hash64_store_hpte to support updating in-kernel htab

2014-02-17 Thread Greg Kurz
in qemu for HV kvm. [ folded fix for the warn_unused_result build break in kvmppc_hash64_write_pte(), Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com Signed-off-by: Alexander Graf ag...@suse.de

[Qemu-devel] [PATCH 2/4] target-ppc: Fix page table lookup with kvm enabled

2014-02-17 Thread Greg Kurz
: Cannot access memory at address 0xc0098660 (gdb) [ folded fixes for 32 bit build (casts!), ldq_phys() API change, Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com Signed-off

[Qemu-devel] [PATCH 3/4] target-ppc: Change the hpte store API

2014-02-17 Thread Greg Kurz
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com For updating in kernel htab we need to provide both pte0 and pte1, hence update the interface to take pte0 and pte1 together [ ldq_phys() API change, Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Aneesh Kumar K.V aneesh.ku

[Qemu-devel] [PATCH 0/8] virtio endian-ambivalent target fixes (rebased)

2014-02-18 Thread Greg Kurz
:) had to be updated actually. FWIW, this the very same patchset I use, along with some ppc64 specific enablement code, to have functionnal ppc64 LE guests. --- Greg Kurz (1): hw/9pfs/virtio_9p_device: use virtio wrappers to access headers. Rusty Russell (7): virtio_get_byteswap

[Qemu-devel] [PATCH 3/8] hw/net/virtio-net: use virtio wrappers to access headers.

2014-02-18 Thread Greg Kurz
From: Rusty Russell ru...@rustcorp.com.au Signed-off-by: Rusty Russell ru...@rustcorp.com.au Reviewed-by: Anthony Liguori aligu...@us.ibm.com --- hw/net/virtio-net.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c

[Qemu-devel] [PATCH 6/8] hw/scsi/virtio-scsi: use virtio wrappers to access headers.

2014-02-18 Thread Greg Kurz
From: Rusty Russell ru...@rustcorp.com.au Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p. Signed-off-by: Rusty Russell ru...@rustcorp.com.au Reviewed-by: Anthony Liguori aligu...@us.ibm.com --- hw/scsi/virtio-scsi.c | 33 + 1 file

[Qemu-devel] [PATCH 5/8] hw/block/virtio-blk: use virtio wrappers to access headers.

2014-02-18 Thread Greg Kurz
From: Rusty Russell ru...@rustcorp.com.au Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p. Signed-off-by: Rusty Russell ru...@rustcorp.com.au Reviewed-by: Anthony Liguori aligu...@us.ibm.com --- hw/block/virtio-blk.c | 35 ++- 1 file

[Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

2014-02-18 Thread Greg Kurz
). This is called at device reset time (which is done before any driver is loaded) since it may involve a system call to get the status when running under kvm. [ fixed checkpatch.pl error with the virtio_byteswap initialisation, ldq_phys() API change, Greg Kurz gk...@linux.vnet.ibm.com ] Signed

[Qemu-devel] [PATCH 2/8] virtio: allow byte swapping for vring and config access

2014-02-18 Thread Greg Kurz
From: Rusty Russell ru...@rustcorp.com.au This is based on a simpler patch by Anthony Liguouri, which only handled the vring accesses. We also need some drivers to access these helpers, eg. for data which contains headers. [ ldq_phys() API change, Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off

[Qemu-devel] [PATCH 4/8] hw/net/virtio-balloon: use virtio wrappers to access page frame numbers.

2014-02-18 Thread Greg Kurz
From: Rusty Russell ru...@rustcorp.com.au Signed-off-by: Rusty Russell ru...@rustcorp.com.au Reviewed-by: Anthony Liguori aligu...@us.ibm.com --- hw/virtio/virtio-balloon.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-balloon.c

[Qemu-devel] [PATCH 7/8] hw/char/virtio-serial-bus: use virtio wrappers to access headers.

2014-02-18 Thread Greg Kurz
From: Rusty Russell ru...@rustcorp.com.au Signed-off-by: Rusty Russell ru...@rustcorp.com.au Reviewed-by: Anthony Liguori aligu...@us.ibm.com --- hw/char/virtio-serial-bus.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git

[Qemu-devel] [PATCH 8/8] hw/9pfs/virtio_9p_device: use virtio wrappers to access headers.

2014-02-18 Thread Greg Kurz
Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p. Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/9pfs/virtio-9p-device.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c index

Re: [Qemu-devel] [PATCH 2/8] virtio: allow byte swapping for vring and config access

2014-02-18 Thread Greg Kurz
On Tue, 18 Feb 2014 14:08:35 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: On Tue, 18 Feb 2014 13:38:54 +0100 Greg Kurz gk...@linux.vnet.ibm.com wrote: From: Rusty Russell ru...@rustcorp.com.au This is based on a simpler patch by Anthony Liguouri, which only handled the vring

Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

2014-02-19 Thread Greg Kurz
On Tue, 18 Feb 2014 20:25:15 +0100 Andreas Färber afaer...@suse.de wrote: Am 18.02.2014 13:38, schrieb Greg Kurz: diff --git a/include/hw/virtio/virtio-access.h b/include/hw/virtio/virtio-access.h new file mode 100644 index 000..2e22a47 --- /dev/null +++ b/include/hw/virtio/virtio

[Qemu-devel] [PATCH 0/4] target-ppc: htab fixes (V2)

2014-02-20 Thread Greg Kurz
On Mon, 17 Feb 2014 14:22:14 +0100 Greg Kurz gk...@linux.vnet.ibm.com wrote: Hi, This is a new tentative for the patches 2/5 to 5/5 from the target-ppc: Add support for dumping guest memory using qemu gdb server patchset: https://lists.nongnu.org/archive/html/qemu-ppc/2014-01/msg00380.html

[Qemu-devel] [PATCH 3/4] target-ppc: Change the hpte store API

2014-02-20 Thread Greg Kurz
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com For updating in kernel htab we need to provide both pte0 and pte1, hence update the interface to take pte0 and pte1 together Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com [ ldq_phys() API change, Greg Kurz gk

[Qemu-devel] [PATCH 2/4] target-ppc: Fix page table lookup with kvm enabled

2014-02-20 Thread Greg Kurz
: Cannot access memory at address 0xc0098660 (gdb) Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com [ fixes for 32 bit build (casts!), ldq_phys() API change, Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/ppc/spapr.c

[Qemu-devel] [PATCH 4/4] target-ppc: Update ppc_hash64_store_hpte to support updating in-kernel htab

2014-02-20 Thread Greg Kurz
in qemu for HV kvm. Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com [ folded fix for the warn_unused_result build break in kvmppc_hash64_write_pte(), Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- target-ppc/kvm.c| 36

[Qemu-devel] [PATCH 1/4] target-ppc: Fix htab_mask calculation

2014-02-20 Thread Greg Kurz
aneesh.ku...@linux.vnet.ibm.com [ fixed pte group offset computation in ppc_hash64_htab_lookup() that caused TCG to fail, Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/ppc/spapr.c |8 +++- hw/ppc/spapr_hcall.c | 19

[Qemu-devel] [PATCH v5 0/8] virtio endian-ambivalent target fixes

2014-02-21 Thread Greg Kurz
virtio_ in patch 2/8, spotted by Cornelia - relicensed virtio-access.h to GPLv2+ in patch 1/8, as requested by Rusty Thanks for your comments. Best Regards. -- Greg --- Greg Kurz (1): virtio-9p: use virtio wrappers to access headers Rusty Russell (7): virtio_get_byteswap: function

[Qemu-devel] [PATCH v5 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio

2014-02-21 Thread Greg Kurz
change, relicensed virtio-access.h to GPLv2+ on Rusty's request, Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/virtio/virtio.c|6 ++ include/hw/virtio/virtio-access.h | 134 + include/hw/virtio

[Qemu-devel] [PATCH v5 2/8] virtio: allow byte swapping for vring and config access

2014-02-21 Thread Greg Kurz
change, fixed missing virtio_ in vring_used_flags_unset_bit(), Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/virtio/virtio.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/hw/virtio/virtio.c b

[Qemu-devel] [PATCH v5 3/8] virtio-net: use virtio wrappers to access headers

2014-02-21 Thread Greg Kurz
From: Rusty Russell ru...@rustcorp.com.au Signed-off-by: Rusty Russell ru...@rustcorp.com.au Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/net/virtio-net.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff

[Qemu-devel] [PATCH v5 6/8] virtio-scsi: use virtio wrappers to access headers

2014-02-21 Thread Greg Kurz
From: Rusty Russell ru...@rustcorp.com.au Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p. Signed-off-by: Rusty Russell ru...@rustcorp.com.au Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/scsi/virtio-scsi.c

[Qemu-devel] [PATCH v5 5/8] virtio-blk: use virtio wrappers to access headers

2014-02-21 Thread Greg Kurz
From: Rusty Russell ru...@rustcorp.com.au Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p. Signed-off-by: Rusty Russell ru...@rustcorp.com.au Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/block/virtio-blk.c

<    1   2   3   4   5   6   7   8   9   10   >